[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #12 from Tapani Pälli --- Created attachment 135537 --> https://bugs.freedesktop.org/attachment.cgi?id=135537&action=edit workaround This patch (that simply rearranges visuals) fixes the issue. -- You are receiving this mail bec

[Mesa-dev] [PATCH] llvmpipe: fix snorm blending

From: Roland Scheidegger The blend math gets a bit funky due to inverse blend factors being in range [0,2] rather than [-1,1], our normalized math can't really cover this. src_alpha_saturate blend factor has a similar problem too. (Note that piglit fbo-blending-formats test is mostly useless for

Re: [Mesa-dev] [PATCH 01/28] vulkan/wsi: use function ptr definitions from the spec.

On November 16, 2017 21:40:42 Michael Schellenberger Costa wrote: Hi Jason, -Ursprüngliche Nachricht- Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Auftrag von Jason Ekstrand Gesendet: Donnerstag, 16. November 2017 22:29 An: mesa-dev@lists.freedesktop.org Cc: Dave

Re: [Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

On Wed, Nov 15, 2017 at 12:13 AM, Rogovin, Kevin wrote: > I have just seen that I have had an epic brain lapse on this. > > The code is pretty clear, the correct value of count should be ann_count - i. > This is because: > a. The value of ann_count is the value of the array size BEFORE the inse

[Mesa-dev] [PATCH 2/4] i965: Simplify annotation_insert_error()

--- src/intel/compiler/intel_asm_annotation.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/intel/compiler/intel_asm_annotation.c b/src/intel/compiler/intel_asm_annotation.c index b07a545a12..26ab4b9818 100644 --- a/src/intel/compiler/intel_asm_annotation

[Mesa-dev] [PATCH 3/4] i965: Rewrite disassembly annotation code

The old code used an array to store each "instruction group" (the new, better name than the old overloaded "annotation"), and required a memmove() to shift elements over in the array when we needed to split a group so that we could add an error message. This was confusing and difficult to get right

[Mesa-dev] [PATCH 4/4] i965: Rename intel_asm_annotation -> brw_disasm_info

It was the only file named intel_* in the compiler. --- src/intel/Makefile.sources | 6 +++--- src/intel/compiler/{intel_asm_annotation.c => brw_disasm_info.c} | 2 +- src/intel/compiler/{intel_asm_annotation.h => brw_disasm_info.h} | 0 src/intel/compiler/brw

[Mesa-dev] [PATCH 1/4] i965: Move common code out of #ifdef

I'm going to change the call in a later patch and with the difference in indentation level it wasn't immediately obvious that the calls were identical. --- src/intel/compiler/brw_fs_generator.cpp | 7 ++- src/intel/compiler/brw_vec4_generator.cpp | 6 ++ 2 files changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH] egl: refactor color_buffers structure for deduplicating (v2)

Hi Gwan-gyeong, Thanks for the patch! On Wed, Nov 15, 2017 at 11:27 PM, Gwan-gyeong Mun wrote: > This is added for preventing adding of new color buffers structure and back* > when new platform backend is added. > This refactoring separates out the common and platform specific bits. > This makes

[Mesa-dev] [PATCH] r600: add ARB_shader_storage_buffer_object support (v2)

From: Dave Airlie This just builds on the image support. Evergreen only has ssbo for fragment and compute no other stages. v2: handle images and ssbo in the same shader properly (Ilia) --- docs/features.txt| 4 +- src/gallium/drivers/r600/evergreen_state.c | 131

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

I just force-pushed my branch with some changes as per Dave to more explicitly enable implicit sync when allocating memory objects. On Thu, Nov 16, 2017 at 1:28 PM, Jason Ekstrand wrote: > This patch series is the combined brain-child of Dave and myself. The > objective is to rewrite Vulkan WSI

[Mesa-dev] [PATCH 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

--- src/gallium/auxiliary/util/u_transfer.c | 118 src/gallium/auxiliary/util/u_transfer.h | 18 + 2 files changed, 136 insertions(+) diff --git a/src/gallium/auxiliary/util/u_transfer.c b/src/gallium/auxiliary/util/u_transfer.c index 3d3c5eb42cd4..f941e648b

[Mesa-dev] [PATCH 1/5] gallium: Add helpers for MSAA resolves in pipe_transfer_map()/unmap().

I had replicated this code from vc4 to vc5, but it's something that most drivers will need to do in a similar way. --- src/gallium/auxiliary/util/u_transfer.c | 119 src/gallium/auxiliary/util/u_transfer.h | 10 +++ 2 files changed, 129 insertions(+) diff --git a

[Mesa-dev] [PATCH 5/5] broadcom/vc5: Start adding support for rendering to Z32F_S8X24_UINT.

There may be some more RCL work to be done (I think I need to split my Z/S stores when doing separate stencil), but this gets piglit's "texwrap GL_ARB_depth_buffer_float." working. --- src/gallium/drivers/vc5/vc5_rcl.c | 22 + src/gallium/drivers/vc5/vc5_resource.c | 85 ++

[Mesa-dev] [PATCH 2/5] broadcom/vc4: Switch to using the u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc4/vc4_resource.c | 104 - src/gallium/drivers/vc4/vc4_resource.h | 3 - 2 files changed, 10 insertions(+), 97 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c index cdcbcc917e0d..

[Mesa-dev] [PATCH 3/5] broadcom/vc5: Switch to using u_transfer_map_msaa_helper().

--- src/gallium/drivers/vc5/vc5_resource.c | 103 - src/gallium/drivers/vc5/vc5_resource.h | 3 - 2 files changed, 10 insertions(+), 96 deletions(-) diff --git a/src/gallium/drivers/vc5/vc5_resource.c b/src/gallium/drivers/vc5/vc5_resource.c index dad238f89fba..

[Mesa-dev] [PATCH 0/5] gallium transfer_map() helpers (MSAA, Z32F_S8X24).

Having been frustrated with duplicating this code into yet another driver, I made some little helpers for u_transfer so others don't have to go through this. I'm not pleased with needing the callback for Z32F, and the recursion feels dangerous if you're doing both of them, but it does seem to work

Re: [Mesa-dev] [PATCH 1/2] st/mesa: don't move ssbo after atomic buffers if we support hw atomics

Reviewed-by: Ilia Mirkin On Thu, Nov 16, 2017 at 9:05 PM, Dave Airlie wrote: > From: Dave Airlie > > There is no need to have these overlap if we support hw atomics. > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_atom_storagebuf.c | 8 +--- > src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH 1/2] st/mesa: don't move ssbo after atomic buffers if we support hw atomics

From: Dave Airlie There is no need to have these overlap if we support hw atomics. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_storagebuf.c | 8 +--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 -- 2 files changed, 13 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH 2/2] r600: add ARB_shader_storage_buffer_object support

From: Dave Airlie This just builds on the image support. Evergreen only has ssbo for fragment and compute no other stages. --- docs/features.txt| 4 +- src/gallium/drivers/r600/evergreen_state.c | 131 ++- src/gallium/drivers/r600/r600_pipe

[Mesa-dev] [PATCH] radv: Implement VK_KHR_get_surface_capabilities2

The WSI core code does all the hard work. Just add the wrappers and turn it on. --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: don't generate nir twice for gs

With the typo fixed: Reviewed-by: Marek Olšák Marek On Thu, Nov 16, 2017 at 1:16 AM, Timothy Arceri wrote: > This was left out of c980a3aa3133 > --- > src/mesa/state_tracker/st_program.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH] i965: Upload invariant state once at the start of the batch on Gen4-5.

Sounds like a plan. Reviewed-by: Jason Ekstrand On Thu, Nov 16, 2017 at 12:37 AM, Kenneth Graunke wrote: > We want to emit invariant state at the start of a render batch. In the > past, this more or less happened: a new batch flagged BRW_NEW_CONTEXT > (because we don't have hardware contexts)

[Mesa-dev] [PATCH v3] meson: Enable SSE4.1 optimizations

This patch checks for an and then enables sse4.1 optimizations if the host machine will be x86/x86_64. v2: - Don't compile code, it's unnecessary since we require a compiler which always has SSE4.1 (Matt) v3: - x64 -> x86_64 (Matt) Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom (v

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

What is the staging area? Note that radeonsi creates all textures in VRAM. The driver allocates its own staging copy (in RAM) for each texture upload and deallocates it after the upload is done. The driver also doesn't release memory immediately; it keeps it and recycles it for future allocations,

[Mesa-dev] [PATCH v4 07/13] meson: extend install_megadrivers script to handle symmlinking

Which is required for the gallium media state trackers. v4: - Make the full version the hard link and the partial so versiions the symlinks Signed-off-by: Dylan Baker --- bin/install_megadrivers.py | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/bin

[Mesa-dev] [PATCH v4 08/13] meson: drop gallium-media argument

This argument is the wrong approach for handling gallium media state trackers, since it doesn't allow for an auto option. Instead we'll use tristates, which do allow for auto. This option has never been wired to anything anyway. Signed-off-by: Dylan Baker --- meson.build | 17

[Mesa-dev] [PATCH v4 13/13] meson: build gallium xa state tracker

v2: - set with_gallium_xa when -Dgallium-xa=true - install pkg config file Signed-off-by: Dylan Baker --- meson.build | 22 meson_options.txt | 7 +++ src/gallium/meson.build | 7 ++- src/gallium/state_tracker

[Mesa-dev] [PATCH v4 05/13] meson: build svga driver on linux

Build tested only. Signed-off-by: Dylan Baker --- meson.build | 6 ++- src/gallium/drivers/svga/meson.build| 88 + src/gallium/meson.build | 5 +- src/gallium/targets/dri/meson.build | 5 ++ src/gallium/winsys

[Mesa-dev] [PATCH v4 02/13] meson: build i915g driver

Build tested only. Signed-off-by: Dylan Baker --- meson.build | 7 +++- src/gallium/drivers/i915/meson.build| 70 + src/gallium/meson.build | 7 ++-- src/gallium/targets/dri/meson.build | 5 +++ src/gallium/wi

[Mesa-dev] [PATCH v4 10/13] meson: build gallium xvmc state tracker

v2: - set with_gallium_xvmc when -Dgallium-xvmc=true - Install megadrivers properly - only use cflags from pkg-config, don't add linker flags. v4: - make use of the install_megadrivers.py changes Signed-off-by: Dylan Baker --- meson.build | 40

[Mesa-dev] [PATCH v4 09/13] meson: build gallium vdpau state tracker

v2: - set with_gallium_vdpau when -Dgallium-vdpau=true - Install megadriver hard links and symlinks - only use cflags from pkg-config, don't add linker flags. v4: - make use of the install_megadrivers.py changes Signed-off-by: Dylan Baker --- meson.build

[Mesa-dev] [PATCH v4 12/13] meson: build gallium va state tracker

v2: - set with_gallium_va when -Dgallium-va=true - Fix megadrivers install - only use cflags from pkg-config, don't add linker flags. - Don't get version from pkg-config, it's not tracking the same version information. v4: - Fix variable double-assignment Signed-off-by: Dylan Bak

[Mesa-dev] [PATCH v4 11/13] meson: build gallium omx state tracker

v2: - set with_gallium_omx when -Dgallium-omx=true - Fix detection of omx plugins dir - only use cflags from pkg-config, don't add linker flags. Signed-off-by: Dylan Baker --- meson.build| 60 - meson_options.txt

[Mesa-dev] [PATCH v4 01/13] meson: add proper LLVM modules to check for RadeonSI as well

Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 383ebb36662..87d435fcb71 100644 --- a/meson.build +++ b/meson.build @@ -702,7 +702,7 @@ if with_gallium_freedreno endif llvm_modules = ['bitwriter', '

[Mesa-dev] [PATCH v4 06/13] meson: build virgl driver

Build tested only. Signed-off-by: Dylan Baker --- meson.build| 16 src/gallium/drivers/virgl/meson.build | 39 ++ src/gallium/meson.build| 7 +- src/gallium/targets/dri/meson.build| 5

[Mesa-dev] [PATCH v4 04/13] meson: build r600 driver

v4: - Ensure inc_amd_common defined when radeonsi is disabled (needed by r600) Signed-off-by: Dylan Baker Tested-by: Aaron Watry --- meson.build | 22 -- src/amd/common/meson.build | 2 - src/gallium/drivers/r600/meson.build | 128

[Mesa-dev] [PATCH v4 03/13] meson: build r300 driver

This is build tested only Signed-off-by: Dylan Baker --- meson.build | 6 +- src/gallium/drivers/r300/meson.build | 156 +++ src/gallium/meson.build | 9 +- src/gallium/targets/dri/meson.build | 12 ++- 4 files changed,

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

Reviewed-by: Marek Olšák Marek On Wed, Nov 15, 2017 at 12:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/amd/M

Re: [Mesa-dev] [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases

On 17 November 2017 at 09:41, Charmaine Lee wrote: > > Reviewed-by: Charmaine Lee > Oops, Acked-by: Dave Airlie > > From: Brian Paul > Sent: Thursday, November 16, 2017 3:36:15 PM > To: mesa-dev@lists.freedesktop.org > Cc: Charmaine Lee; Neha Bhende >

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

On Wed, Nov 15, 2017 at 3:55 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/amd/Makefile.addrlib.am | 2 +- > 1 file

Re: [Mesa-dev] [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 16, 2017 3:36:15 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases --- src/gallium/d

[Mesa-dev] [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases

--- src/gallium/drivers/svga/svga_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 8621640..ab604b9 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_screen.c

Re: [Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

On 17 November 2017 at 08:00, Gert Wollny wrote: > Am Mittwoch, den 15.11.2017, 11:28 +1000 schrieb Dave Airlie: >> On 15 November 2017 at 04:50, Gert Wollny >> wrote: >> > Although the EOP bit is documented for the vertex fetch clause, it >> > is not >> > properly interpreted. As a result the pi

Re: [Mesa-dev] [PATCH v2] meson: Enable SSE4.1 optimizations

On Thu, Nov 16, 2017 at 2:46 PM, Dylan Baker wrote: > This patch checks for an and then enables sse4.1 optimizations if the > host machine will be x86/x86_64. > > v2: - Don't compile code, it's unnecessary since we require a compiler > which always has SSE4.1 (Matt) > > Signed-off-by: Dylan

[Mesa-dev] [PATCH v2] meson: Enable SSE4.1 optimizations

This patch checks for an and then enables sse4.1 optimizations if the host machine will be x86/x86_64. v2: - Don't compile code, it's unnecessary since we require a compiler which always has SSE4.1 (Matt) Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom (v1) --- meson.build

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

On Thu, Nov 16, 2017 at 2:19 PM, Dylan Baker wrote: > Quoting Matt Turner (2017-11-15 21:57:37) >> On Wed, Nov 15, 2017 at 5:10 PM, Dylan Baker wrote: >> > This patch checks for an and then enables sse4.1 optimizations if the >> > host machine will be x86/x86_64. >> >> There's some stack realignm

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

Quoting Emil Velikov (2017-11-16 03:35:17) > Hi Dylan, > > On 16 November 2017 at 01:10, Dylan Baker wrote: > > This patch checks for an and then enables sse4.1 optimizations if the > > host machine will be x86/x86_64. > > > Hell yeah, SSE is coming to town :-) > > Will this work if the user dis

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

Quoting Matt Turner (2017-11-15 21:57:37) > On Wed, Nov 15, 2017 at 5:10 PM, Dylan Baker wrote: > > This patch checks for an and then enables sse4.1 optimizations if the > > host machine will be x86/x86_64. > > There's some stack realignment stuff that probably needs to stay, but > depending on w

Re: [Mesa-dev] [PATCH 3/4] meson: Fix TODO for missing dl_iterate_phdr function

Quoting Emil Velikov (2017-11-16 05:21:50) > On 16 November 2017 at 01:11, Dylan Baker wrote: > > This function is required for both the Intel "Anvil" vulkan driver and > > the i965 GL driver. Error out if either of those is enabled but this > > function isn't found. > > > > Signed-off-by: Dylan B

Re: [Mesa-dev] [PATCH 2/4] meson: disable x86 asm in fewer cases.

Quoting Eric Engestrom (2017-11-16 03:46:04) > On Wednesday, 2017-11-15 17:11:00 -0800, Dylan Baker wrote: > > This patch allows building asm for x86 on x86_64 platforms, when the > > operating system is the same. Previously cross compile always turned off > > assembly. This allows using a cross fi

Re: [Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

Am Mittwoch, den 15.11.2017, 11:28 +1000 schrieb Dave Airlie: > On 15 November 2017 at 04:50, Gert Wollny > wrote: > > Although the EOP bit is documented for the vertex fetch clause, it > > is not > > properly interpreted. As a result the piglit > >   spec/arb_tessellation_shader/execution/trivial

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

Am Donnerstag, den 16.11.2017, 17:13 + schrieb Emil Velikov: > On 16 November 2017 at 15:09, Gert Wollny > wrote: > > Explicitely convert on value to the target type. > > > > Signed-off-by: Gert Wollny > > Reviewed-by: Brian Paul > > --- > >  src/mesa/main/framebuffer.h | 2 +- > >  1 file c

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

On 11/16/2017 11:57 AM, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: >> On 11/14/2017 02:54 PM, Scott D Phillips wrote: >>> This extension provides a new texture and sampler parameter >>> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce >>> a filtered

[Mesa-dev] [PATCH 24/28] vulkan/wsi: Move wsi_swapchain to wsi_common_private.h

The drivers no longer poke at this directly. --- src/vulkan/wsi/wsi_common.h | 46 + src/vulkan/wsi/wsi_common_private.h | 46 + 2 files changed, 47 insertions(+), 45 deletions(-) diff --git a/src/vulkan/wsi/wsi_commo

[Mesa-dev] [PATCH 25/28] vulkan/wsi: Drop the can_handle_different_gpu parameter from get_support

Both anv and radv can handle prime now. --- src/amd/vulkan/radv_wsi.c | 2 +- src/intel/vulkan/anv_wsi.c | 2 +- src/vulkan/wsi/wsi_common.h | 1 - src/vulkan/wsi/wsi_common_wayland.c | 1 - src/vulkan/wsi/wsi_common_x11.c | 5 - 5 files changed, 2 insertions(+),

[Mesa-dev] [PATCH 26/28] vulkan/wsi: Add wrappers for all of the surface queries

This lets us move wsi_interface to wsi_common_private.h --- src/amd/vulkan/radv_wsi.c | 41 ++-- src/intel/vulkan/anv_wsi.c | 51 +++- src/vulkan/wsi/wsi_common.c | 77 + src/vulkan/wsi/wsi_common.h

[Mesa-dev] [PATCH 18/28] anv/wsi: Use the common QueuePresent code

--- src/intel/vulkan/anv_wsi.c | 63 +- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index b654db9..4d9f7df 100644 --- a/src/intel/vulkan/anv_wsi.c +++ b/src/intel/vulkan/anv_wsi.c

[Mesa-dev] [PATCH 28/28] vulkan/wsi: Initialize individual WSI interfaces in wsi_device_init

Now that we have anv_device_init/finish functions, there's no reason to have the individual driver do any more work than that. --- src/amd/vulkan/radv_wsi.c | 36 ++-- src/intel/vulkan/anv_wsi.c | 36 ++-- src/vulka

[Mesa-dev] [PATCH 21/28] vulkan/wsi: Move prime blitting into queue_present

This lets us save a QueueSubmit and it also makes prime a lot less X11-specific. Also, it means we can only wait on the semaphores once instead of on every blit. --- src/vulkan/wsi/wsi_common.c | 41 + src/vulkan/wsi/wsi_common.h | 5 ++--- src

[Mesa-dev] [PATCH 22/28] vulkan/wsi: move swapchain create/destroy to common code

From: Dave Airlie v2 (Jason Ekstrand): - Rebase - Alter the names of the helpers to better match the vulkan entrypoints - Use the helpers in anv --- src/amd/vulkan/radv_wsi.c | 42 -- src/intel/vulkan/anv_wsi.c | 35 +-

[Mesa-dev] [PATCH 27/28] vulkan/wsi: Drop some unneeded cruft from the API

This drops the unneeded callbacks struct as well as the queue_get_family callback we were using before we'd pulled QueuePresent inside. --- src/amd/vulkan/radv_wsi.c | 18 +- src/intel/vulkan/anv_wsi.c | 19 +-- src/vulkan/wsi/wsi_common.c

[Mesa-dev] [PATCH 23/28] vulkan/wsi: Add a helper for AcquireNextImage

Unfortunately, due to the fact that AcquireNextImage does not take a queue, the ANV trick for triggering the fence won't work in general. We leave dealing with the fence up to the caller for now. --- src/amd/vulkan/radv_wsi.c | 15 ++- src/intel/vulkan/anv_wsi.c | 19 +++---

[Mesa-dev] [PATCH 16/28] vulkan/wsi: Only wait on semaphores on the first swapchain

--- src/vulkan/wsi/wsi_common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index 322f19b..4f92427 100644 --- a/src/vulkan/wsi/wsi_common.c +++ b/src/vulkan/wsi/wsi_common.c @@ -532,9 +532,14 @@ wsi_common_q

[Mesa-dev] [PATCH 17/28] vulkan/wsi: Set a proper pWaitDstStageMask on the dummy submit

Neither mesa driver really cares, but we should set it none the less for the sake of correctness. --- src/vulkan/wsi/wsi_common.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index 4f92427..09528d7 100644 --- a/src

[Mesa-dev] [PATCH 08/28] vulkan/wsi: Add a mock image creation extension

--- src/vulkan/wsi/wsi_common.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 9c1899c..0e1604a 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -30,6 +30,16 @@ #include #include +/*

[Mesa-dev] [PATCH 15/28] vulkan/wsi: Refactor result handling in queue_present

--- src/vulkan/wsi/wsi_common.c | 54 +++-- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index 5cb062e..322f19b 100644 --- a/src/vulkan/wsi/wsi_common.c +++ b/src/vulkan/wsi/wsi_com

[Mesa-dev] [PATCH 19/28] anv/wsi: Enable prime support

Now that we're using the same common code as radv, we get prime support for free. Just enable it. --- src/intel/vulkan/anv_wsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index 4d9f7df..975ad18 100644 --- a/src/inte

[Mesa-dev] [PATCH 20/28] vulkan/wsi: Move get_images into common code

This moves bits out of all four corners (anv, radv, x11, wayland) and into the wsi common code. We also switch to using an outarray to ensure we get our return code right. --- src/amd/vulkan/radv_wsi.c | 7 +++ src/intel/vulkan/anv_wsi.c | 7 +++ src/vulkan/wsi/wsi_co

[Mesa-dev] [PATCH 09/28] anv/image: Implement the wsi "extension"

--- src/intel/vulkan/anv_image.c | 43 +++--- src/intel/vulkan/anv_private.h | 2 ++ 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 41fe3d8..3e94a76 100644 --- a/src/intel/vulk

[Mesa-dev] [PATCH 13/28] vulkan/wsi: Add a WSI_FROM_HANDLE macro

--- src/vulkan/wsi/wsi_common.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 6741157..be45042 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -169,6 +169,9 @@ struct wsi_callbacks { retur

[Mesa-dev] [PATCH 14/28] radv/wsi: Move the guts of QueuePresent to wsi common

From: Dave Airlie v2 (Jason Ekstrand): - Better comit message - Rebase - Re-indent to follow wsi_common style - Drop the unneeded _swapchain from the newly added helper - Make the clone more true to the original (as per the rebase) --- src/amd/vulkan/radv_wsi.c | 92 +++---

[Mesa-dev] [PATCH 12/28] vulkan/wsi: Do image creation in common code

This uses the mock extension created in a previous commit to tell the driver that the image it's just been asked to create is, in fact, a window system image with whatever assumptions that implies. There was a lot of redundant code between the two drivers to do basically exactly the same thing. --

[Mesa-dev] [PATCH 11/28] radv/wsi: drop allocate memory special case

From: Dave Airlie Just check if image has scanout flag set v2 (Jason Ekstrand): - Rebase - Also drop the now unused radv_mem_flag_bits enum --- src/amd/vulkan/radv_device.c | 16 ++-- src/amd/vulkan/radv_private.h | 10 -- 2 files changed, 6 insertions(+), 20 deletions(-)

[Mesa-dev] [PATCH 10/28] radv/image: Implement the wsi "extension"

--- src/amd/vulkan/radv_device.c | 2 ++ src/amd/vulkan/radv_image.c | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 722c768..58a4604 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vu

[Mesa-dev] [PATCH 06/28] vulkan/wsi: Implement prime in a completely generic way

--- src/amd/vulkan/radv_wsi.c | 137 +++ src/intel/vulkan/anv_wsi.c | 14 +- src/vulkan/wsi/wsi_common.c | 338 +++- src/vulkan/wsi/wsi_common.h | 54 +- src/vulkan/wsi/wsi_common_private.h | 16 ++ src/vulkan/ws

[Mesa-dev] [PATCH 07/28] anv/image: Add a return value to bind_memory_plane

--- src/intel/vulkan/anv_image.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index ba932ba..41fe3d8 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -599

[Mesa-dev] [PATCH 05/28] vulkan/wsi: Add wsi_swapchain_init/finish functions

--- src/vulkan/Makefile.sources | 1 + src/vulkan/wsi/meson.build | 1 + src/vulkan/wsi/wsi_common.c | 23 ++- src/vulkan/wsi/wsi_common.h | 1 + src/vulkan/wsi/wsi_common_private.h | 37 + src/vulkan/wsi/w

[Mesa-dev] [PATCH 04/28] vulkan/wsi: Add a wsi_device_init function

This gives the opportunity to collect some function pointers if we'd like which will be very useful in future. --- src/amd/vulkan/radv_wsi.c | 10 +- src/intel/vulkan/anv_wsi.c | 11 ++- src/vulkan/Makefile.sources | 1 + src/vulkan/wsi/meson.build | 1 + src/vulkan/wsi/wsi_c

[Mesa-dev] [PATCH 03/28] vulkan/wsi/x11: Handle the geometry check earlier in create_swapchain

This fixes a potential leak if allocating the swapchain fails. Since geometry checking and bit-depth fetching is self-contained, it makes sense to just do it first so we can delete the geometry reply. --- src/vulkan/wsi/wsi_common_x11.c | 19 ++- 1 file changed, 10 insertions(+),

[Mesa-dev] [PATCH 01/28] vulkan/wsi: use function ptr definitions from the spec.

From: Dave Airlie This just seems cleaner, and we may expand this in future. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 3 ++- src/intel/vulkan/anv_wsi.c | 3 ++- src/vulkan/wsi/wsi_common.h | 6 +++--- src/vulkan/wsi/wsi_common_wayland.c | 2 +- 4 fi

[Mesa-dev] [PATCH 02/28] vulkan/wsi: Add a wsi_image structure

From: Daniel Stone This is used to hold information about the allocated image, rather than an ever-growing function argument list. v2 (Jason Ekstrand): - Rename wsi_image_base to wsi_image Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/amd/vulkan/radv_wsi.c | 31 +

[Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

This patch series is the combined brain-child of Dave and myself. The objective is to rewrite Vulkan WSI to look as much like a layer as possible and to reduce the driver <-> WSI interface. We try very hard to have as many of the WSI details as possible in common code and to use standard Vulkan i

Re: [Mesa-dev] [PATCH v2 29/29] gallium/aux/util/u_tests.c: Fix warnigns triggered -Wmissing-field-initializers

Am Donnerstag, den 16.11.2017, 16:34 + schrieb Emil Velikov: > On 16 November 2017 at 15:10, Gert Wollny > wrote: > > * Use a designated initializer to silence the warning. > > * fix one intention that was using tabs instead of spaces > > > > Sigh, -Wmissing-field-initalizers warnings - it's

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

On Thu, Nov 16, 2017 at 2:57 PM, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: >> On 11/14/2017 02:54 PM, Scott D Phillips wrote: >>> This extension provides a new texture and sampler parameter >>> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce >>> a

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: > On 11/14/2017 02:54 PM, Scott D Phillips wrote: >> This extension provides a new texture and sampler parameter >> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce >> a filtered texel value by computing a component-wise minimum

Re: [Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v3)

I like this. Reviewed-by: Ian Romanick On 11/16/2017 10:17 AM, Brian Paul wrote: > For checking that bitfields are large enough to hold the largest > expected value. > > v2: move into existing util/macros.h header where STATIC_ASSERT() lives. > v3: add MAYBE_UNUSED to variable declaration > ---

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_texture_filter_minmax

On 11/14/2017 02:54 PM, Scott D Phillips wrote: > On gen >= 9, minmax reduction modes are available as a flag in > SAMPLER_STATE. > --- > docs/features.txt | 2 +- > src/mesa/drivers/dri/i965/brw_formatquery.c | 4 > src/mesa/drivers/dri/i965/genX_state_upload.

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

On 11/14/2017 02:54 PM, Scott D Phillips wrote: > This extension provides a new texture and sampler parameter > (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce > a filtered texel value by computing a component-wise minimum (MIN) > or maximum (MAX) of the texels that would normally

Re: [Mesa-dev] [PATCH 3/4] meson: Fix TODO for missing dl_iterate_phdr function

Quoting Emil Velikov (2017-11-16 05:21:50) > On 16 November 2017 at 01:11, Dylan Baker wrote: > > This function is required for both the Intel "Anvil" vulkan driver and > > the i965 GL driver. Error out if either of those is enabled but this > > function isn't found. > > > > Signed-off-by: Dylan B

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 Dylan Baker changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] egl: pass the dri2_dpy to the $plat_teardown functions

Tested-by: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103784 Quoting Emil Velikov (2017-11-16 10:36:01) > From: Emil Velikov > > Cc: Mark Janes > Fixes: 40a01c9a0ef ("egl/drm: move teardown code to the platform file") > Fixes: 8d745abc009 ("egl/wayland: move teardown co

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 --- Comment #2 from Emil Velikov --- I've posted a fix was on the list at the same moment you opened the bug. https://patchwork.freedesktop.org/patch/188753/ -- You are receiving this mail because: You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 1:20 PM, Wladimir J. van der Laan wrote: > On Thu, Nov 16, 2017 at 12:26:05PM -0500, Ilia Mirkin wrote: >> On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote: > >> The point of the texcoord semantics is precisely point sprite >> replacement. NVIDIA hardware (Fermi+) can only

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 --- Comment #1 from Dylan Baker --- You can easily verify this via: wflinfo --platform gbm -a gl -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list m

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 Dylan Baker changed: What|Removed |Added CC||baker.dyla...@gmail.com,

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all of EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 Dylan Baker changed: What|Removed |Added Summary|[bisected] Egl changes |[bisected] Egl changes

[Mesa-dev] [PATCH] egl: pass the dri2_dpy to the $plat_teardown functions

From: Emil Velikov Cc: Mark Janes Fixes: 40a01c9a0ef ("egl/drm: move teardown code to the platform file") Fixes: 8d745abc009 ("egl/wayland: move teardown code to the platform file") Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[Mesa-dev] [Bug 103784] [bisected] Egl changes breaks all all EGL

https://bugs.freedesktop.org/show_bug.cgi?id=103784 Bug ID: 103784 Summary: [bisected] Egl changes breaks all all EGL Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: critical

  1   2   3   >