[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #36 from Dave Airlie --- Created attachment 133276 --> https://bugs.freedesktop.org/attachment.cgi?id=133276&action=edit fix MSAA rendering. I've sent this to the list, it at least fixes bad rendering in talos for me. I've also j

Re: [Mesa-dev] [PATCH 11/11] radeonsi: use optimal packet order when doing a pipeline sync

On 07.08.2017 00:20, Marek Olšák wrote: From: Marek Olšák Process most new SET packets in parallel with previous draw calls, then flush caches and wait, start the draw, and do L2 prefetches last. This decreases the [CP busy / SPI busy] ratio (verified with GRBM perf counters). In other words,

Re: [Mesa-dev] [PATCH 06/11] radeonsi: add a separate dirty mask for prefetches

On 07.08.2017 00:20, Marek Olšák wrote: From: Marek Olšák so that we don't rely on si_pm4_state_enabled_and_changed, allowing us to move prefetches after draw calls. --- src/gallium/drivers/radeonsi/si_cp_dma.c| 16 src/gallium/drivers/radeonsi/si_descriptors.c |

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

> -Original Message- > > Tomasz, > > > -Original Message- > > From: Tomasz Figa [mailto:tf...@chromium.org] > > Sent: Saturday, August 5, 2017 8:47 AM > > > > Hi Yogesh, > > > > On Sat, Aug 5, 2017 at 1:22 AM, Marathe, Yogesh > > > > wrote: > > >> -Original Message- > > >

[Mesa-dev] [PATCH] radv: fix MSAA on SI gpus.

From: Dave Airlie This ports the workaround from radeonsi, that was missing in radv. This fixes Talos rendering when MSAA is enabled on my Tahiti card. Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 10 +

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

> -Original Message- > From: Wu, Zhongmin > Sent: Monday, August 7, 2017 11:27 AM > To: Marathe, Yogesh ; Tomasz Figa > > Cc: Gao, Shuo ; Antognolli, Rafael > ; Emil Velikov ; > Kenneth Graunke ; ML mesa-dev d...@lists.freedesktop.org>; Kondapally, Kalyan > ; Timothy Arceri > Subject: RE

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Hi Yogesh: http://oorja.iind.intel.com/mediawiki/index.php/Flatland can you also try the flatland on this page. For AOSP flatland, yes, the EGL patch may solve the issue. However, I met one case that the batch buffer is empty just at the swapbuffer (glfush is just called before that), then yo

Re: [Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

Reviewed-by: Tapani Pälli On 08/03/2017 07:52 PM, Jason Ekstrand wrote: The make_shareable function deletes the aux buffer and then whacks aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear. Since we only look at supports_fast_clear to decide whether or not to do fast clears,

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

This can be dropped. I'm running with egl patch alone and things seem fine. Zhongmin, please comment if you don’t think so. > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Marathe, Yogesh > Sent: Friday, August 4, 2017 9:18 PM > > Toma

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

Tomasz, > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Saturday, August 5, 2017 8:47 AM > > Hi Yogesh, > > On Sat, Aug 5, 2017 at 1:22 AM, Marathe, Yogesh > wrote: > >> -Original Message- > >> From: Tomasz Figa [mailto:tf...@chromium.org] > >> Sent:

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #35 from John --- Created attachment 133274 --> https://bugs.freedesktop.org/attachment.cgi?id=133274&action=edit radv trace after 2nd patch I've just tested with the hacky patch and the one from #28 and it seemed about the same.

[Mesa-dev] [PATCH 2/2] TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture

Previous behavior was inconsistent with other texture targets so this has been fixed in OpenGL 4.6. Fixes: KHR-GL45.direct_state_access.textures_storage_errors --- src/mesa/main/texstorage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/

[Mesa-dev] [PATCH 1/2] Update TextureParameter* error for incompatible texture targets

The OpenGL 4.6 specs have been updated so that GetTextureParameter* with a texture object with an incompatible TEXTURE_TARGET should now report INVALID_OPERATION instead of INVALID_ENUM. Fixes: KHR-GL45.direct_state_access.textures_parameter_errors --- src/mesa/main/texparam.c | 2 +- 1 file chan

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #34 from Dave Airlie --- Created attachment 133273 --> https://bugs.freedesktop.org/attachment.cgi?id=133273&action=edit hacky patch? does this patch make any difference? (on top of the one from the list). -- You are receiving t

Re: [Mesa-dev] [PATCH 00/11] RadeonSI misc patches v2

For the series: Tested-by: Dieter Nützel on RX580 09/11 didn't apply clean (fixed by hand) Dieter Am 07.08.2017 00:20, schrieb Marek Olšák: The last series didn't get any attention, so this is a full re-send. These are tiny adjustements and cleanups, and the last one is an interesting micr

[Mesa-dev] [PATCH 8/8] glsl: use ralloc_str_append() rather than ralloc_asprintf_rewrite_tail()

The Deus Ex: Mankind Divided shaders go from spending ~20 seconds in the GLSL IR compilers front-end down to ~18.5 seconds on a Ryzen 1800X. Tested by compiling once with shader-db then deleting the index file from the shader cache and compiling again. --- src/compiler/glsl/glcpp/glcpp-parse.y |

[Mesa-dev] [PATCH 5/8] glsl: clone builtin function constants

f81ede469910d fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we referenced it lead to a significant reduction in the GLSL IR compiler performance. Everything was already cloned when inlining the function, as far as

[Mesa-dev] [PATCH 7/8] util/ralloc: add ralloc_str_append() helper

This function differs from ralloc_strcat() and ralloc_strncat() in that it does not do any strlen() calls which can become costly on large strings. --- src/util/ralloc.c | 17 + src/util/ralloc.h | 18 ++ 2 files changed, 35 insertions(+) diff --git a/src/util/ral

[Mesa-dev] [PATCH 6/8] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

The cloning was introduced in f81ede469910d to fixed a problem with shaders including IR that was owned by builtins. However the approach of cloning the whole function each time we reference a builtin lead to a significant reduction in the GLSL IR compilers performance. The previous patch fixes t

[Mesa-dev] GLSL compile time improvements

I've sent all but the last 2 already but they haven't received much feedback yet. This series reduces compile times of the Deus Ex shaders on my Ryzen 1800X from 2m27s -> 2m8s with a cold cache on radeonsi. Note: The above times are from compiling the shaders with shader-db on a single thread, st

[Mesa-dev] [PATCH 2/8] glsl: tidy up get_num_operands()

Also add a comment that this should only be used by the ir_reader interface for testing purposes. --- src/compiler/glsl/ir.cpp | 8 ++-- src/compiler/glsl/ir.h | 14 +++--- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/i

[Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. --- src/compiler/glsl/glsl_to_nir.cpp | 4 +-- src/compiler/glsl/ir.

[Mesa-dev] [PATCH 4/8] glsl: remove unused field from ir_call

Reviewed-by: Thomas Helland Tested-by: Dieter Nützel --- src/compiler/glsl/ir.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 40f3338470..d425b97aca 100644 --- a/src/compiler/glsl/ir.h +++ b/src/compiler/glsl/ir.h @@ -1595,32 +1595,

[Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

We are currently copying the name for each member dereference but we can just share a single instance of the string provided by the type. This change also stops us recalculating the field index repeatedly. --- src/compiler/glsl/ast_array_index.cpp | 14 - src/compiler/glsl/gl

[Mesa-dev] About the VDPAU state tracker project

hello, I am currently pursuing my undergraduate degree in Theoretical computer science.I came to know about The X.Org Endless Vacation of Code(EVoC) while searching for the GSoc, since it is already became too late to apply for GSoc , I found an interesting opportunity while reading the pr

Re: [Mesa-dev] [PATCH v2] mesa: Fix swizzling for luminance/intensity in _mesa_readpixels

On Mon, 2017-07-31 at 23:15 +0100, Chris Wilson wrote: > Quoting Chris Wilson (2017-07-31 22:51:25) > > Luminance/Intensity when converted to RGB should be replicated to > > fill > > the RGB channels, but they differ on how the alpha channel is > > filled, as > > luminance is set to 1 (unless alpha

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

This patch is still missing a review. Any takers? Iago On Fri, 2017-07-21 at 10:26 +0200, Iago Toral Quiroga wrote: > Mesa will map user defined vertex input attributes to slots > starting at VERT_ATTRIB_GENERIC0 which gives us room for only 16 > slots (up to GL_VERT_ATTRIB_MAX). This sufficient

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

Hi, Yeah, I have quite a few patches that have been stuck for a while, and many of them are also reviewed. Just need to get around to get commit-access, so that I don't have to bother everyone else. I was hoping to get that done one of the coming days. It's basically hanging on me at the moment D

[Mesa-dev] [PATCH 07/11] radeonsi: prefetch VBO descriptors after the first VGT shader

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 80 +--- 1 file changed, 63 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c index 21202b3..91a6aff 100644 --- a/src/galli

[Mesa-dev] [PATCH 11/11] radeonsi: use optimal packet order when doing a pipeline sync

From: Marek Olšák Process most new SET packets in parallel with previous draw calls, then flush caches and wait, start the draw, and do L2 prefetches last. This decreases the [CP busy / SPI busy] ratio (verified with GRBM perf counters). In other words, the time window when shaders are idle (bet

[Mesa-dev] [PATCH 09/11] gallium/radeon: rename GPU-dma-busy -> GPU-cp-dma-busy

From: Marek Olšák --- src/gallium/drivers/radeon/r600_gpu_load.c| 6 +++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_query.c | 6 +++--- src/gallium/drivers/radeon/r600_query.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-)

[Mesa-dev] [PATCH 08/11] radeonsi: rename shader_userdata -> shader_pointers where appropriate

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 24 src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_state.h | 6 +++--- src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 10/11] radeonsi: expose the number of decompress calls to the HUD

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_query.c | 7 +++ src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 18 +++--- 4 files changed, 20 insertions(+),

[Mesa-dev] [PATCH 05/11] radeonsi: add and use si_pm4_state_enabled_and_changed

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c| 20 +--- src/gallium/drivers/radeonsi/si_state.h | 3 +++ src/gallium/drivers/radeonsi/si_state_shaders.c | 12 ++-- 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 02/11] radeonsi: remove a tautology sctx->framebuffer.nr_samples >= 1

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index c9bb108..11dee49 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b

[Mesa-dev] [PATCH 01/11] gallium/radeon: print all members of radeon_info with R600_DEBUG=info

From: Marek Olšák also set max_alignment on amdgpu. --- src/gallium/drivers/radeon/r600_pipe_common.c | 16 ++-- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src

[Mesa-dev] [PATCH 06/11] radeonsi: add a separate dirty mask for prefetches

From: Marek Olšák so that we don't rely on si_pm4_state_enabled_and_changed, allowing us to move prefetches after draw calls. --- src/gallium/drivers/radeonsi/si_cp_dma.c| 16 src/gallium/drivers/radeonsi/si_descriptors.c | 3 +-- src/gallium/drivers/radeonsi/si_hw_co

[Mesa-dev] [PATCH 03/11] radeonsi: align all CE dumps to L2 cache line size

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 02f921e..ea5b89e 100644 --- a/sr

[Mesa-dev] [PATCH 04/11] radeonsi: de-atomize L2 prefetch

From: Marek Olšák I'd like to be able to move the prefetch call site around. --- src/gallium/drivers/radeonsi/si_cp_dma.c| 7 +++ src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- src/gallium/drivers/radeonsi/si_hw_context.c| 2 +- src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH 00/11] RadeonSI misc patches v2

The last series didn't get any attention, so this is a full re-send. These are tiny adjustements and cleanups, and the last one is an interesting micro-optimization. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] radv: add separate fmask tile swizzle counter.

Reviewed-by: Bas Nieuwenhuizen On Fri, Aug 4, 2017 at 7:55 AM, Dave Airlie wrote: > From: Dave Airlie > > This mirrors what Marek has done for radeonsi, and uses > a separate counter to handle the fmask surface for MSAA > MRTs. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device

Re: [Mesa-dev] [PATCH] radv: fix tile swizzle regression on mipmaps.

Reviewed-by: Bas Nieuwenhuizen On Fri, Aug 4, 2017 at 7:46 AM, Dave Airlie wrote: > From: Dave Airlie > > When Marek enabled mipmapped swizzle, radv didn't > have the code in place to handle it. This fixes the > regression. > > I'll look more into GFX9 once I have a vega card (soon). > Fixes: 2

Re: [Mesa-dev] [PATCH 1/3] glsl: remove unused field from ir_call

For the series: Tested-by: Dieter Nützel on RX580 Dieter Am 04.08.2017 09:25, schrieb Timothy Arceri: --- src/compiler/glsl/ir.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 40f3338470..d425b97aca 100644 --- a/src/compiler/gls

Re: [Mesa-dev] [PATCH] etnaviv: Add support for R8_UNORM textures

2017-07-28 16:05 GMT+02:00 Wladimir J. van der Laan : > R8_UNORM textures can be emulated by means of L8 and a swizzle. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

Great, then I only can point to the 'prehash work' from Thomas Helland '[Mesa-dev] [PATCH 0/6] Prehash all the things' https://lists.freedesktop.org/archives/mesa-dev/2017-May/156564.html with which I'm running during the last weeks. No one commented other then me... It has my 'Tested-by:' (H

Re: [Mesa-dev] [PATCH] i965/miptree: Set supports_fast_clear = false in make_shareable

On Thursday, August 3, 2017 9:52:37 AM PDT Jason Ekstrand wrote: > The make_shareable function deletes the aux buffer and then whacks > aux_usage to ISL_AUX_USAGE_NONE but not unsetting supports_fast_clear. > Since we only look at supports_fast_clear to decide whether or not to do > fast clears, th

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

Hi Dieter, Yes, all of my GLSL compilation speedup work landed. I'm glad glibc got a better allocator. Marek On Sun, Aug 6, 2017 at 7:48 PM, Dieter Nützel wrote: > Hello Marek, > > with latest glibc-2.26 results on Phoronix, I remember your GREAT GLSL > compilation speedup work. Did anything o

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

Hello Marek, with latest glibc-2.26 results on Phoronix, I remember your GREAT GLSL compilation speedup work. Did anything of this landed? --- I think not? (Can't find related commits.) Some other ralloc related optimizations landed during October 2016... ralloc: don't memset ralloc_header, cl

[Mesa-dev] [PATCH 2/2] glapi: per the extension spec, the EXT-suffixed function should be used

We already expose glMultiDrawElementsBaseVertexEXT as part of the EXT_draw_elements_base_vertex chunk, so this one can just be removed. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/es_EXT.xml | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/

[Mesa-dev] [PATCH 1/2] include: update GLES gl2ext header to no longer reference bad function

There was a previous error in the gl.xml and generated files that referenced glMultiDrawElementsBaseVertexOES. This function should not exist, only the EXT-suffixed version should. Leaving the other headers alone to avoid conflicts with GL 4.6 work. Signed-off-by: Ilia Mirkin --- include/GLES2/

[Mesa-dev] [Bug 102057] Enabling DSA in COMPATIBILITY PROFILE

https://bugs.freedesktop.org/show_bug.cgi?id=102057 Bug ID: 102057 Summary: Enabling DSA in COMPATIBILITY PROFILE Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: enhancement