Re: [Mesa-dev] [PATCH 1/3] radv: fix release build unused variable warnings

2016-12-10 Thread Bas Nieuwenhuizen
This series has been reviewed and pushed, thanks. - Bas On Sat, Dec 10, 2016 at 8:10 PM, Grazvydas Ignotas wrote: > Just mark with MAYBE_UNUSED. > > Signed-off-by: Grazvydas Ignotas > --- > no commit access, somebody please push > > src/amd/vulkan/radv_cmd_buffer.c | 34 ++-

Re: [Mesa-dev] [PATCH] glsl: Make copy propagation not panic when it sees an intrinsic.

2016-12-10 Thread Matt Turner
On Fri, Dec 9, 2016 at 8:28 PM, Kenneth Graunke wrote: > A number of games have large arrays of constants, which we promote to > uniforms. This introduces copies from the uniform array to the original > temporary array. Normally, copy propagation eliminates those copies, > making everything refe

Re: [Mesa-dev] [PATCH] softpipe: fix release build unused variable warning

2016-12-10 Thread Marek Olšák
Pushed, thanks. Marek On Sat, Dec 10, 2016 at 8:10 PM, Grazvydas Ignotas wrote: > Signed-off-by: Grazvydas Ignotas > --- > no commit access, somebody please push > > src/gallium/drivers/softpipe/sp_state_shader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gall

Re: [Mesa-dev] [PATCH] radeonsi: fix release build unused variable warnings

2016-12-10 Thread Marek Olšák
Pushed, thanks. Marek On Sat, Dec 10, 2016 at 8:10 PM, Grazvydas Ignotas wrote: > Signed-off-by: Grazvydas Ignotas > --- > no commit access, somebody please push > > src/gallium/drivers/radeonsi/si_blit.c | 2 +- > src/gallium/drivers/radeonsi/si_state.c | 2 +- > 2 files changed, 2 insertion

[Mesa-dev] [PATCH] i965: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c1d858..8b5750c 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp

[Mesa-dev] [PATCH] softpipe: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/softpipe/sp_state_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_state_shader.c b/src/gallium/drivers/softpipe/sp_state_shader.c index a7

[Mesa-dev] [PATCH] intel/aubinator: fix 32bit shift overflow warning

2016-12-10 Thread Grazvydas Ignotas
Doesn't look like this can work on 32bit, just rids of annoying warning. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubi

[Mesa-dev] [PATCH] anv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/vulkan/anv_blorp.c | 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 159e

[Mesa-dev] [PATCH 3/3] radv/ac: some fix maybe-uninitialized warnings

2016-12-10 Thread Grazvydas Ignotas
Mark some paths unreachable so that compiler knows variables are initialized in all valid paths. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_

[Mesa-dev] [PATCH] radeonsi: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/radeonsi/si_blit.c | 2 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers

[Mesa-dev] [PATCH 1/3] radv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Just mark with MAYBE_UNUSED. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_cmd_buffer.c | 34 ++ src/amd/vulkan/radv_query.c | 6 +++--- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/a

[Mesa-dev] [PATCH 2/3] radv/meta: use VK_NULL_HANDLE for handles

2016-12-10 Thread Grazvydas Ignotas
Otherwise we get 32bit warnings because handle is plain uint64_t there and NULL is not suited to initialize that. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufimage.c | 2 +- src/amd/vulka

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Kai Wasserbäch
Nicolai Hähnle wrote on 10.12.2016 19:12: > On 10.12.2016 18:19, Kai Wasserbäch wrote: >> Nicolai Hähnle wrote on 10.12.2016 14:54: >>> From: Nicolai Hähnle >>> >>> Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 >>> (Compatibility Profile) spec says: >>> >>> "If a

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Nicolai Hähnle
On 10.12.2016 18:19, Kai Wasserbäch wrote: Nicolai Hähnle wrote on 10.12.2016 14:54: From: Nicolai Hähnle Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 (Compatibility Profile) spec says: "If a value is so large in magnitude that it cannot be represented by th

Re: [Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Kai Wasserbäch
Nicolai Hähnle wrote on 10.12.2016 14:54: > From: Nicolai Hähnle > > Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 > (Compatibility Profile) spec says: > > "If a value is so large in magnitude that it cannot be represented by the > returned data type, then

Re: [Mesa-dev] [PATCH 25/27] i965: Use partial resolves for CCS buffers being scanned out

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:10:06PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > On Gen9 hardware, the display engine is able to scanout a compressed > framebuffer by providing an offset to auxiliary compression information. > Unfortunately, the hardware is incapable of doing the same thing

Re: [Mesa-dev] [PATCH 22/27] i965: Change resolve flags to enum

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:10:03PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > In the foreseeable future it doesn't seem to make sense to have multiple > resolve flags. What does make sense is to have the caller give an > indication to the lower layers what it things should be done for >

Re: [Mesa-dev] [PATCH 21/27] i965: Make CCS stride match kernel's expectations

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:10:02PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Cc: Ville Syrjälä > Cc: Jason Ekstrand > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/intel_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drive

Re: [Mesa-dev] [PATCH 20/27] i965: Pretend that CCS modified images are two planes

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:10:01PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/intel_screen.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_scr

[Mesa-dev] [PATCH] mesa: Clamp negative values in glGetUniformuiv

2016-12-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 (Compatibility Profile) spec says: "If a value is so large in magnitude that it cannot be represented by the returned data type, then the nearest value representable using the requested

Re: [Mesa-dev] [PATCH 18/27] i965/miptree: Add a return for updating of winsys

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:09:59PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > There is nothing particularly useful to do currently if the update > fails, but there is no point carrying on either. As a result, this has a > behavior change. > > Signed-off-by: Ben Widawsky > --- > src/me

Re: [Mesa-dev] [PATCH 17/27] i965: Create correctly sized mcs for an image

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:09:58PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/intel_screen.c | 37 > > 1 file changed, 33 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 16/27] i965/miptree: Allocate mcs_buf for an image's CCS_E

2016-12-10 Thread Pohjolainen, Topi
On Thu, Dec 01, 2016 at 02:09:57PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in > later if preferred. > >

Re: [Mesa-dev] [PATCH 04/10] nir: Add a LCSAA-pass

2016-12-10 Thread Pohjolainen, Topi
On Tue, Dec 06, 2016 at 12:12:22PM +1100, Timothy Arceri wrote: > From: Thomas Helland > > V2: Do a "depth first search" to convert to LCSSA > > V3: Small comment fixup > > V4: Rebase, adapt to removal of function overloads > > V5: Rebase, adapt to relocation of nir to compiler/nir > Still

Re: [Mesa-dev] [PATCH 05/10] nir: don't count removal of lcssa_phi as progress

2016-12-10 Thread Pohjolainen, Topi
On Tue, Dec 06, 2016 at 12:12:23PM +1100, Timothy Arceri wrote: > --- > src/compiler/nir/nir_opt_remove_phis.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_opt_remove_phis.c > b/src/compiler/nir/nir_opt_remove_phis.c > index acaa6e1..d4344b0 10

Re: [Mesa-dev] [PATCH] run: stop leaking SSO programs

2016-12-10 Thread Nicolai Hähnle
On 10.12.2016 01:45, Timothy Arceri wrote: This was causing my poor 8GB laptop to run out on memory. Reviewed-by: Nicolai Hähnle --- run.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/run.c b/run.c index 08fd543..6d635c1 100644 --- a/run.c +++ b/run.c @@ -670,7 +67

Re: [Mesa-dev] [PATCH 2/2] spirv: Use a simpler and more correct implementaiton of tanh()

2016-12-10 Thread Erik Faye-Lund
On Fri, Dec 9, 2016 at 6:41 PM, Jason Ekstrand wrote: > The new implementation is more correct because it clamps the incoming value > to 10 to avoid floating-point overflow. It also uses a much reduced > version of the formula which only requires 1 exp() rather than 2. This > fixes all of the dE

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.render_multiple_contexts.gles2_renderbuffer_depth16_depth_buffer

2016-12-10 Thread Pohjolainen, Topi
On Fri, Dec 09, 2016 at 04:44:23PM -0800, Kenneth Graunke wrote: > On Friday, December 9, 2016 4:32:53 PM PST Chad Versace wrote: > > The inescapable vortex of HiZ finds me wherever I go... > > > > This series brings us one step closer to passing the Android N CTS. > > > > See https://bugs.freede