Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

On 06/09/16 03:14 PM, Michel Dänzer wrote: > On 06/09/16 01:59 PM, Jason Ekstrand wrote: >> On Sep 5, 2016 8:43 PM, "Michel Dänzer" > > wrote: >>> >>> On 06/09/16 12:08 PM, Jason Ekstrand wrote: On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer >

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

On 06/09/16 01:59 PM, Jason Ekstrand wrote: > On Sep 5, 2016 8:43 PM, "Michel Dänzer" > wrote: >> >> On 06/09/16 12:08 PM, Jason Ekstrand wrote: >> > On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer >> >

Re: [Mesa-dev] [PATCH 1/6] intel/isl: Add a format_supports_multisampling helper

On Fri, Sep 02, 2016 at 03:50:42PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h| 2 ++ > src/intel/isl/isl_format.c | 30 ++ > src/intel/isl/isl_gen6.c | 19 +-- > src/intel/isl/isl_gen7.c | 16 +--- > src/intel/isl/i

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

On Sep 5, 2016 8:43 PM, "Michel Dänzer" wrote: > > On 06/09/16 12:08 PM, Jason Ekstrand wrote: > > On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer > > wrote: > > > > From: Michel Dänzer > > > > > > This can make a significant di

Re: [Mesa-dev] [PATCH] anv/pipeline: Lower indirect outputs when EmitNoIndirectOutput is set

On Monday, September 5, 2016 8:10:48 PM PDT Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Reported-by: Timothy Arceri > --- > src/intel/vulkan/anv_pipeline.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c >

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

On 06/09/16 12:08 PM, Jason Ekstrand wrote: > On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer > wrote: > > From: Michel Dänzer > > > This can make a significant difference for performance with some extreme > test cases such

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

On 02/09/16 11:46 PM, Axel Davy wrote: > Le 02/09/2016 à 16:41, Axel Davy a écrit : >> Le 02/09/2016 à 03:06, Michel Dänzer a écrit : >>> On 02/09/16 12:37 AM, Alex Deucher wrote: On Thu, Sep 1, 2016 at 11:28 AM, Jason Ekstrand wrote: > On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrot

[Mesa-dev] [PATCH] anv/pipeline: Lower indirect outputs when EmitNoIndirectOutput is set

Signed-off-by: Jason Ekstrand Reported-by: Timothy Arceri --- src/intel/vulkan/anv_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 35acc4a..9780201 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/inte

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer wrote: > From: Michel Dänzer > > This can make a significant difference for performance with some extreme > test cases such as vblank_mode=0 glxgears. > > Fixes: 1e3218bc5ba2 ("loader/dri3: Overhaul dri3_update_num_back") > Cc: "12.0 11.2" > Bugzill

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

Got it. Thanks for your patient explanation! 2016-09-06 1:14 GMT+08:00 Emil Velikov : > On 5 September 2016 at 17:21, Weng Chuanbo wrote: > > > [Chuanbo] Could you explain " we want these NULL checks split out > > and ported to older loader " more detailed? > > > > And what's older loade

[Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

From: Michel Dänzer This can make a significant difference for performance with some extreme test cases such as vblank_mode=0 glxgears. Fixes: 1e3218bc5ba2 ("loader/dri3: Overhaul dri3_update_num_back") Cc: "12.0 11.2" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97549 Signed-off-by:

[Mesa-dev] (no subject)

https://www.facebook.com/messages/13832670320 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] (no subject)

https://www.facebook.com/beatrix.beres.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On Mon, Sep 5, 2016 at 9:54 PM, Michel Dänzer wrote: > On 06/09/16 07:46 AM, Marek Olšák wrote: >> From: Marek Olšák > > Did you measure any significant performance boost with this change? > Otherwise, using (un)likely can be bad because it can defeat the CPU's > branch prediction, which tends to

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

On 06/09/16 07:46 AM, Marek Olšák wrote: > From: Marek Olšák Did you measure any significant performance boost with this change? Otherwise, using (un)likely can be bad because it can defeat the CPU's branch prediction, which tends to be pretty good these days. > - if (!sctx->vs_shader.cso)

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On 6 September 2016 at 03:41, Marek Olšák wrote: > On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: >> So currently out-of-tree radv, reuses addrlib (by copying the all >> the files), and at least wants to share the register and family >> header files. >> >> This is a set of patches to just mov

Re: [Mesa-dev] [PATCH] i965: release GLSL IR in LinkShader after it's not needed

Assuming there are no regressions. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On 05/09/16 23:49, Marek Olšák wrote: > On Mon, Sep 5, 2016 at 11:32 PM, Luke A. Guest wrote: >> >> On 05/09/16 18:41, Marek Olšák wrote: >>> On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: So currently out-of-tree radv, reuses addrlib (by copying the all the files), and at least w

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On Mon, Sep 5, 2016 at 11:32 PM, Luke A. Guest wrote: > > > On 05/09/16 18:41, Marek Olšák wrote: >> On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: >>> So currently out-of-tree radv, reuses addrlib (by copying the all >>> the files), and at least wants to share the register and family >>> hea

[Mesa-dev] [PATCH 4/4] radeonsi: skip redundant INDEX_TYPE writes

From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_hw_context.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 50 +--- 3 files changed, 32 insertions(+), 20 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 9469bb4..d4447a9 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH 2/4] radeonsi: skip draws with instance_count == 0

From: Marek Olšák loosely ported from Vulkan --- src/gallium/drivers/radeonsi/si_state_draw.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 0a91291..9469bb4

[Mesa-dev] [PATCH 1/4] gallium/radeon/winsyses: fix counting mapped memory

From: Marek Olšák Not all buffers are unmapped explicitly. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 8 src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 8 2 files changed, 16 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/a

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On 05/09/16 18:41, Marek Olšák wrote: > On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: >> So currently out-of-tree radv, reuses addrlib (by copying the all >> the files), and at least wants to share the register and family >> header files. >> >> This is a set of patches to just move those in

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

https://bugs.freedesktop.org/show_bug.cgi?id=97542 Daniel Exner changed: What|Removed |Added CC||dex+fdobugzilla@dragonslave

Re: [Mesa-dev] FPE Invalid Operation

On Mon, Sep 5, 2016 at 2:32 PM, Bram Stolk wrote: > >>If you're able to, make a local build, adding -O0 to cflags, and don't >>strip the debug info. That should show you exactly where the issue >>lies. > > I built mesa 12.0.2 using: > ~/src/mesa-12.0.2$ CFLAGS=-O0 ./configure --prefix=$HOME --disa

Re: [Mesa-dev] FPE Invalid Operation

>If you're able to, make a local build, adding -O0 to cflags, and don't >strip the debug info. That should show you exactly where the issue >lies. I built mesa 12.0.2 using: ~/src/mesa-12.0.2$ CFLAGS=-O0 ./configure --prefix=$HOME --disable-dri3 If I LD_PRELOAD the resulting libGL.so then the cra

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

Am 05.09.2016 um 18:37 schrieb Ilia Mirkin: > On Mon, Sep 5, 2016 at 12:32 PM, Rob Clark wrote: + single plane (interleaved) YUV formats? And seems like android wants YV12 (which is I420 with the 2nd and 3rd planes swapped). In general I don't want to go too crazy and add ev

Re: [Mesa-dev] [PATCH 4/4] amd/addrlib: move addrlib from amdgpu winsys to common code

With my comment at patch 3 addressed, the series is: Acked-by: Marek Olšák Marek On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: > From: Dave Airlie > > --- > src/amd/Makefile.addrlib.am| 35 > ++ > src/amd/Makefile.am

Re: [Mesa-dev] [PATCH 3/4] gallium/util: move endian detect into a separate file

On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: > From: Dave Airlie > > This just ports the simpler endian detection bits, addrlib > sharing wants this outside gallium. > --- > src/gallium/include/pipe/p_config.h | 40 ++- > src/util/Makefile.sources | 3 +- > s

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On Mon, Sep 5, 2016 at 3:03 AM, Dave Airlie wrote: > So currently out-of-tree radv, reuses addrlib (by copying the all > the files), and at least wants to share the register and family > header files. > > This is a set of patches to just move those into a shared directory, > in advance of proposin

Re: [Mesa-dev] FPE Invalid Operation

On Mon, Sep 5, 2016 at 12:55 PM, Bram Stolk wrote: > Hey, > > Do you guys test with Floating-Point-Exceptions enabled? I think most people just test with whatever is the default. > Because on Intel-Haswell, I can trigger a FPE with a simple glClearColor and > glClear. > I think glClear is doing

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

On 5 September 2016 at 17:21, Weng Chuanbo wrote: > [Chuanbo] Could you explain " we want these NULL checks split out > and ported to older loader " more detailed? > > And what's older loaders? What's newer dri modules? > > From my understanding, the only path in mesa code invokes mapImag

[Mesa-dev] FPE Invalid Operation

Hey, Do you guys test with Floating-Point-Exceptions enabled? Because on Intel-Haswell, I can trigger a FPE with a simple glClearColor and glClear. I think glClear is doing bad FP math on Haswell. https://software.intel.com/en-us/forums/graphics-driver-bug- reporting/topic/681580 I recommend doi

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #41 from Dieter Nützel --- With Marek's latest Mesa commits (0d7ec8b) it helps even more. The regression with 'glxgears' and 'objview/bobcat.obj' is much bigger and FIXED with your patch from bug 97549. -- You are receiving this mai

Re: [Mesa-dev] [RFC 2/2] mesa/st: support lowering multi-planar YUV

On Fri, Sep 2, 2016 at 9:45 PM, Rob Clark wrote: > Support multi-planar YUV for external EGLImage's (currently just in the > dma-buf import path) by lowering to multiple texture fetch's for each > plane and CSC in shader. > > Currently lots of TODO's, only NV12 implemented so far, only wired up in

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

On Mon, Sep 5, 2016 at 12:37 PM, Ilia Mirkin wrote: > On Mon, Sep 5, 2016 at 12:32 PM, Rob Clark wrote: + single plane (interleaved) YUV formats? And seems like android wants YV12 (which is I420 with the 2nd and 3rd planes swapped). In general I don't want to go too crazy a

[Mesa-dev] [PATCH] gallium/winsys/kms: Close drm device filedescriptor on kms_dri_sw_winsys release

This closes filedescriptor owned by kms_dri_sw_winsys struct. It fixes issue where removal of udl or evdi module used by DisplayLink devices was impossible due to not closed filedescriptors. When this file descriptor was not closed then command rmmod udl was returning error "Module udl is in use".

[Mesa-dev] [PATCH] gallium/winsys/kms: Close drm device filedescriptor on kms_dri_sw_winsys release

Hi, This patch fixes issue where unloading kernel modules udl or evdi was impossible due to not closed file descriptor. As this library is loaded by Xorg after unpluging device the process is still keeping file open making unload impossible. Steps to reproduce: - Install latest xorg-server:

Re: [Mesa-dev] [PATCH 00/33] anv: Use blorp for most blits and clears

Everything is now reviewed. I've also sent two additional patches blorp which, when placed prior to the anv patches, make the series regression-free and they've been reviewed by Topi. Nanley, if you don't mind, I would still like your review on the "use blorp to implement vkFoo" patches. They're

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

On Mon, Sep 5, 2016 at 12:32 PM, Rob Clark wrote: >>> + single plane (interleaved) YUV formats? And seems like android >>>wants YV12 (which is I420 with the 2nd and 3rd planes swapped). >>>In general I don't want to go too crazy and add every YUV format >>>under the sun, but try and

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

On Mon, Sep 5, 2016 at 6:32 PM, Rob Clark wrote: > On Mon, Sep 5, 2016 at 12:12 PM, Marek Olšák wrote: >> On Fri, Sep 2, 2016 at 9:45 PM, Rob Clark wrote: >>> So, android and blob GLES drivers were left unchecked for too long, and >>> now we are stuck with this annoying OES_EGL_image_external ex

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

On Mon, Sep 5, 2016 at 12:12 PM, Marek Olšák wrote: > On Fri, Sep 2, 2016 at 9:45 PM, Rob Clark wrote: >> So, android and blob GLES drivers were left unchecked for too long, and >> now we are stuck with this annoying OES_EGL_image_external extension and >> the expectation that the driver can impo

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

Hi Emil, (Seems something wrong with my company's email, so I use this one) I understand your meaning except the NULL check part. Please see my questions below. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org ] On Behalf O

Re: [Mesa-dev] [RFC 0/2] mesa/st: support for YUV EGLImages

On Fri, Sep 2, 2016 at 9:45 PM, Rob Clark wrote: > So, android and blob GLES drivers were left unchecked for too long, and > now we are stuck with this annoying OES_EGL_image_external extension and > the expectation that the driver can import multi-planar YUV buffers (via, > for example, EGL_EXT_i

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #40 from Dieter Nützel --- (In reply to Michel Dänzer from comment #39) > It would have been better to file new reports instead of adding comments > here. Sorry for that Michel. I've appended it here because it overlap with attachmen

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #8 from Eero Tamminen --- Created attachment 126222 --> https://bugs.freedesktop.org/attachment.cgi?id=126222&action=edit backtrace after change -- You are receiving this mail because: You are the QA Contact for the bug. You are t

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #7 from Eero Tamminen --- Created attachment 126221 --> https://bugs.freedesktop.org/attachment.cgi?id=126221&action=edit backtrace before change -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #6 from Eero Tamminen --- With modesetting: * BXT: similar to new X DDX, perf OK (somewhat below X DDX) * SNB: perf still bad, but better than with Intel DDX -> on SNB the attached patch is needed to get performance on previous leve

[Mesa-dev] [ANNOUNCE] mesa 12.0.2

Hi all, Mesa 12.0.2 is now available. The current release fixes crashes in GLX, EGL and Wayland-EGL, resolves a number of memory leaks in the video decoding drivers, makes the Intel Vulkan driver more robust by exporting only the required symbols (previously we would get symbol collisions leading

Re: [Mesa-dev] [PATCH] gbm: add missing R8 and GR88 formats

On Mon, Sep 5, 2016 at 6:50 AM, Eric Engestrom wrote: > On Sat, Sep 03, 2016 at 08:52:07AM -0400, Rob Clark wrote: >> Signed-off-by: Rob Clark > > Reviewed-by: Eric Engestrom > >> --- >> I would have added RG88 except we seem to have no corresponding >> __DRI_IMAGE_FORMAT_RG88 >> >> src/gbm/bac

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #5 from Eero Tamminen --- (In reply to Michel Dänzer from comment #4) > Created attachment 126214 [details] [review] > Always use at least two buffers > > Does this patch fix the problem? Yes, but that's not all... BXT performance

Re: [Mesa-dev] [PATCH] glvnd: Fix dynamic GLX entrypoint lookup

On 5 September 2016 at 11:23, Eric Engestrom wrote: > On Fri, Sep 02, 2016 at 04:12:24PM -0400, Adam Jackson wrote: >> The dynamic dispatch table needs to be sorted properly, the entrypoints >> shouldn't duplicate the 'glX' prefix, and please just use bsearch() >> instead of open-coding it. >> >>

Re: [Mesa-dev] [PATCH] gbm: add missing R8 and GR88 formats

On Sat, Sep 03, 2016 at 08:52:07AM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark Reviewed-by: Eric Engestrom > --- > I would have added RG88 except we seem to have no corresponding > __DRI_IMAGE_FORMAT_RG88 > > src/gbm/backends/dri/gbm_dri.c | 6 ++ > src/gbm/main/gbm.h |

Re: [Mesa-dev] [PATCH] glvnd: Fix dynamic GLX entrypoint lookup

On Fri, Sep 02, 2016 at 04:12:24PM -0400, Adam Jackson wrote: > The dynamic dispatch table needs to be sorted properly, the entrypoints > shouldn't duplicate the 'glX' prefix, and please just use bsearch() > instead of open-coding it. > > Signed-off-by: Adam Jackson > --- > src/glx/g_glxglvnddis

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 Artem changed: What|Removed |Added CC||turbono...@gmail.com -- You are receiving this

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On 09/05/2016 04:41 PM, Nicolai Hähnle wrote: > On 05.09.2016 03:03, Dave Airlie wrote: >> So currently out-of-tree radv, reuses addrlib (by copying the all >> the files), and at least wants to share the register and family >> header files. >> >> This is a set of patches to just move those into a

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #39 from Michel Dänzer --- It would have been better to file new reports instead of adding comments here. Anyway, please test the patch I attached to bug 97549. --- Comment #38 from Dieter Nützel --- I got regression wtih 1e3218b..

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #4 from Michel Dänzer --- Created attachment 126214 --> https://bugs.freedesktop.org/attachment.cgi?id=126214&action=edit Always use at least two buffers Does this patch fix the problem? -- You are receiving this mail because: Yo

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

Hi Leo, I have tested your patch with my mplayer and it gives error when I try to increase the size of the window. It gives the following error:- X11 error: BadAlloc (insufficient resources for operation) X11 error: BadDrawable (invalid Pixmap or Window parameter) X11 error: BadPixmap (invalid Pi

Re: [Mesa-dev] [RFC] precursor patches to trying to merge radv

On 5 September 2016 at 16:41, Nicolai Hähnle wrote: > On 05.09.2016 03:03, Dave Airlie wrote: >> >> So currently out-of-tree radv, reuses addrlib (by copying the all >> the files), and at least wants to share the register and family >> header files. >> >> This is a set of patches to just move thos