Re: [Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

2016-08-14 Thread Kenneth Graunke
On Thursday, August 11, 2016 2:14:57 PM PDT Jason Ekstrand wrote: > This patch series is the next on the way towards generalizing blorp for > usin in Vulkan. At this point, I'd say the project is about 80% complete. > This series only applies on top of the last two blorp isl series which are > sti

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: fix depth clamping wrt reversed near/far values

2016-08-14 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Aug 14, 2016 at 11:41 PM, wrote: > From: Roland Scheidegger > > This wasn't handled before (the result was that no matter what value got > clamped, it always ended up as the near value in this case) (if clamping > actually happened). > Fix this by using the uti

Re: [Mesa-dev] [PATCH 0/5] Move check for mapped buffers into api_validate.

2016-08-14 Thread Mathias Fröhlich
Hi, On Sunday, 14 August 2016 12:50:58 CEST Eric Anholt wrote: > Very nice! I've always been bothered by this validation being in vbo. > > Reviewed-by: Eric Anholt > Thanks! Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://li

[Mesa-dev] [Bug 97307] glsl/glcpp/tests/glcpp-test regression

2016-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97307 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |glsl-compiler Assignee|mesa-

[Mesa-dev] [PATCH] glcpp: Update tests for new #undef of built-in macro rules.

2016-08-14 Thread Kenneth Graunke
Ian recently changed the preprocessor to allow this in most GLSL versions, but not GLSL ES 3.00+. This patch converts the existing test that expects a failure to a #version 300 es shader, and adds a #version 110 shader to make sure that it's allowed. Fixes 'make check'. Cc: i...@freedesktop.org

[Mesa-dev] [PATCH] freedreno: fix depth clamping on a3xx/a4xx

2016-08-14 Thread Ilia Mirkin
We were previously ... not clamping. I guess this meant that everything got clamped to 1/0, which was enough to pass the existing tests. Or perhaps the clamping would only happen to the rasterized depth value and not the frag shader's output depth value. Either way, this broke dolphin's new depth i

[Mesa-dev] [PATCH] llvmpipe: fix issues with depth clamp

2016-08-14 Thread sroland
From: Roland Scheidegger We only did depth clamp when the value was written from the fs. This is very wrong both for d3d10 and GL, and only passed the corresponding piglit test due to pure luck (it no longer does with the enhanced test). Also, interpolation clamped values to 1.0 always, which can

[Mesa-dev] [PATCH 1/2] llvmpipe: fix depth clamping wrt reversed near/far values

2016-08-14 Thread sroland
From: Roland Scheidegger This wasn't handled before (the result was that no matter what value got clamped, it always ended up as the near value in this case) (if clamping actually happened). Fix this by using the util helper for that (the math is otherwise "mostly" the same, mostly because there

Re: [Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Release previous context's display

2016-08-14 Thread Александр
On 11.08.2016 11:43, Nicolas Boichat wrote: eglMakeCurrent can also be used to change the active display. In that case, we need to decrement ref_count of the previous display (possibly destroying it), and increment it on the next display. Also, old_dsurf/old_rsurf cannot be non-NULL if old_ctx

Re: [Mesa-dev] [PATCH 1/3] gallium: change pipe_sampler_view::first_element/last_element -> offset/size

2016-08-14 Thread Marek Olšák
On Aug 12, 2016 8:49 PM, "Roland Scheidegger" wrote: > > I can't say I'm a big fan of this. > From an "api cleanness" point of view, defining things in elements makes > more sense imho. > This is due to the GL api though which uses generic buffer api to turn > buffers into textures which can be sa

[Mesa-dev] [PATCH] anv/x11: Add support for Xlib platform

2016-08-14 Thread Kevin Strasser
Some applications continue to use the Xlib client library and expect that VK_KHR_xlib_surface will be available in the driver. Service these applications by converting the Display pointer to xcb_connection_t and use the existing xcb code in the driver. Signed-off-by: Kevin Strasser Cc: Jason Ekst

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

2016-08-14 Thread Александр
On 10.08.2016 10:44, Michel Dänzer wrote: On 10/08/16 03:00 PM, Nicolas Boichat wrote: eglMakeCurrent can also be used to change the active display. In that case, we need to decrement ref_count of the previous display (possibly destroying it), and increment it on the next display. Also, old_d

Re: [Mesa-dev] [PATCH 5/5] mesa: Remove duplicate include.

2016-08-14 Thread Brian Paul
Series LGTM. Reviewed-by: Brian Paul On Sun, Aug 14, 2016 at 12:12 PM, wrote: > From: Mathias Fröhlich > > In api_validate.c stdbool.h was included twice. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/main/api_validate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/me

Re: [Mesa-dev] [PATCH v2 1/2] gallium/util: add helper to compute zmin/zmax for a viewport state

2016-08-14 Thread Brian Paul
On Sun, Aug 14, 2016 at 11:09 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: "11.2 12.0" > --- > src/gallium/auxiliary/Makefile.sources | 3 +- > src/gallium/auxiliary/util/u_viewport.h | 59 > + > 2 files changed, 61 insertions(+), 1 deletion(-) >

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #22 from Ilia Mirkin --- Like Roland said, if multiple drivers are affected, it's by independent bugs. However for nv50 and nvc0, this is fixed by: commit 5c1ccd8053412b6a42098481d2fde3d483208c33 Author: Ilia Mirkin Date: Fri Aug

Re: [Mesa-dev] [PATCH v2 1/2] gallium/util: add helper to compute zmin/zmax for a viewport state

2016-08-14 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 14.08.2016 um 19:09 schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > Cc: "11.2 12.0" > --- > src/gallium/auxiliary/Makefile.sources | 3 +- > src/gallium/auxiliary/util/u_viewport.h | 59 > + > 2 files changed, 61 inserti

Re: [Mesa-dev] [PATCH 0/5] Move check for mapped buffers into api_validate.

2016-08-14 Thread Eric Anholt
mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich > > Hi all, > > This series moves the call to check for mapped vertex > buffer objects on draw from the vbo code into api_validate.c. > There we already check for various conditions to validate the > current draw call. Some cleanups in th

[Mesa-dev] [PATCH 5/5] mesa: Remove duplicate include.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich In api_validate.c stdbool.h was included twice. Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_validate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index ae3e118..384a8858 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 2/5] mesa: Move _mesa_all_buffers_are_unmapped to arrayobj.c.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Move the function to check if all vao buffers are unmapped into the vao implementation file. Rename the function to _mesa_all_buffers_are_unmapped. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 28 src/mesa/main/arrayobj

[Mesa-dev] [PATCH 4/5] vbo: Remove allways true return from vbo_bind_arrays.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo.h| 2 +- src/mesa/vbo/vbo_exec_array.c | 36 +++- 2 files changed, 12 insertions(+), 26 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 939a3a6..7347

[Mesa-dev] [PATCH 3/5] mesa: Move check for vbo mapping into api_validate.c.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of checking for mapped buffers in vbo_bind_arrays do this check in api_validate.c. This additionally enables printing the draw calls name into the error string. Signed-off-by: Mathias Fröhlich --- src/mesa/main/api_validate.c | 7 +++ src/mesa/vbo/vbo_exec_a

[Mesa-dev] [PATCH 1/5] vbo: Array draw must not care about glBegin/glEnd vbo mapping.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich In array draw do not check if the vertex buffer object that is used to implement immediate mode glBegin/glEnd is mapped. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH 0/5] Move check for mapped buffers into api_validate.

2016-08-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, This series moves the call to check for mapped vertex buffer objects on draw from the vbo code into api_validate.c. There we already check for various conditions to validate the current draw call. Some cleanups in that area are included. Please review! Thanks Mat

[Mesa-dev] [PATCH v2 1/2] gallium/util: add helper to compute zmin/zmax for a viewport state

2016-08-14 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Cc: "11.2 12.0" --- src/gallium/auxiliary/Makefile.sources | 3 +- src/gallium/auxiliary/util/u_viewport.h | 59 + 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 src/gallium/auxiliary/util/u_viewport.h diff --git

[Mesa-dev] [PATCH v2 2/2] nv50, nvc0: fix depth range when halfz is enabled

2016-08-14 Thread Ilia Mirkin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97231 Signed-off-by: Ilia Mirkin Cc: "11.2 12.0" --- v1 -> v2: make use of the new helper to compute min/max src/gallium/drivers/nouveau/nv50/nv50_state_validate.c | 9 +++-- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 9 +

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Estimate maximum sampler message execution size more accurately.

2016-08-14 Thread Kenneth Graunke
On Friday, August 12, 2016 10:06:29 PM PDT Francisco Jerez wrote: > The current logic used to determine the execution size of sampler > messages was based on special-casing several argument and opcode > combinations, which unsurprisingly missed the possibility that some > messages could exceed the

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 LoneVVolf changed: What|Removed |Added CC||lonew...@xs4all.nl -- You are receiving thi

Re: [Mesa-dev] [PATCH] vbo: allow DrawElementsBaseVertex in display lists

2016-08-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Aug 14, 2016 at 8:30 AM, Ilia Mirkin wrote: > Looks like it was missed originally. The multi version is there somehow. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97331 > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop.org >