[Mesa-dev] [PATCH 3/3] glsl: be more strict on block qualifiers

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96528 --- src/compiler/glsl/ast_to_hir.cpp | 61 1 file changed, 50 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 683c144..f2ed82

[Mesa-dev] [PATCH 2/3] glsl: add name param to validate_flags()

--- src/compiler/glsl/ast.h | 4 ++-- src/compiler/glsl/ast_to_hir.cpp | 7 +++ src/compiler/glsl/ast_type.cpp | 8 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h index aa8c422..157895d 100644 --- a/src/comp

[Mesa-dev] [PATCH V2 1/3] glsl: add component to ast_type_qualifier::validate_flags

This was added with ARB_enhanced_layouts. V2: Add an extra format specifier for the new qualifier. --- src/compiler/glsl/ast_type.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index d34d641..1f8fb9c 100644

[Mesa-dev] [PATCH] freedreno/ir3: init ir3_shader_key with memset()

To silence missing initializers warning Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/ir3/ir3_shader.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c b/src/gallium/drivers/freedreno/ir3/ir3_shader.c i

Re: [Mesa-dev] [PATCH] glsl: emit a specific error when ast_*_assign changes type

On Fri, 2016-07-08 at 23:30 -0400, Ilia Mirkin wrote: > For regular ast_add, we can implicitly change either a or b's type. > However in an assignment situation, the type of the lvalue is fixed. > So > if the implicit conversion logic decides to change it, it means that > the > rhs's type could not

[Mesa-dev] [PATCH] glsl: add component to ast_type_qualifier::validate_flags

This was added with ARB_enhanced_layouts. --- src/compiler/glsl/ast_type.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index d34d641..f3ca535 100644 --- a/src/compiler/glsl/ast_type.cpp +++ b/src/compiler/glsl/ast_type.cpp @

[Mesa-dev] [Bug 33220] Use of talloc_autofree_context causes segfault when dynamically loaded

https://bugs.freedesktop.org/show_bug.cgi?id=33220 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [Mesa-dev] [PATCH] loader: fix memory leak in loader_dri3_open

2016-07-30 8:31 GMT+08:00 Jan Ziak <0xe2.0x9a.0...@gmail.com>: > Found via "valgrind --leak-check=full glxgears". > > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > src/loader/loader_dri3_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/loa

Re: [Mesa-dev] [PATCH mesa] gallium/freedreno: move cast to avoid integer overflow

On Fri, Jul 29, 2016 at 8:33 PM, Eric Engestrom wrote: > Previously, the bitshift would be performed on a simple int (32 bits on > most systems), overflow, and then be cast to 64 bits. and actually 32b on 100% of systems that had a2xx ;-) I've picked this up locally and will push soon.. thanks

Re: [Mesa-dev] [PATCH mesa] freedreno/a2xx: add missing `break` after error message

hmm, these were actually intended to fall-thru to the 'x' case, just to give the hw something sensible. (Not that it is a case that should ever happen.) Maybe better to use unreachable()? BR, -R On Fri, Jul 29, 2016 at 8:27 PM, Eric Engestrom wrote: > CovID: 1362455, 1362456, 1362457 > Signed-

Re: [Mesa-dev] [PATCH mesa] freedreno/a2xx: remove duplicate assignment

thanks, applied locally and will push in next day or two.. BR, -R On Fri, Jul 29, 2016 at 8:23 PM, Eric Engestrom wrote: > CovID: 1362445, 1362446 > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke wrote: > Papers over GPU hangs on Ivybridge and Baytrail caused by the > recent NIR FS input rework by restoring the old behavior. > (I'm not honestly sure why they hang with PLN not at the top.) I think this is because of the unlit centroid workar

[Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

CovID: 401540 Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c index 8c4f215..1ed4336 100644 --- a/src/gallium/auxiliary/util/

[Mesa-dev] [PATCH mesa] gallium/freedreno: move cast to avoid integer overflow

Previously, the bitshift would be performed on a simple int (32 bits on most systems), overflow, and then be cast to 64 bits. CovID: 1362461 Signed-off-by: Eric Engestrom --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Mesa-dev] [PATCH mesa] freedreno/a2xx: add missing `break` after error message

CovID: 1362455, 1362456, 1362457 Signed-off-by: Eric Engestrom --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c index 2b62b3a..e2fea5d 100644 --- a/s

[Mesa-dev] [PATCH] loader: fix memory leak in loader_dri3_open

Found via "valgrind --leak-check=full glxgears". Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/loader/loader_dri3_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 896f225..b86

[Mesa-dev] [PATCH] docs: Add GL4.4 and ARB_enhanced_layouts to the release notes

--- Not sure is we need to be more careful about mentioning we support 4.4 thoughts? docs/relnotes/12.1.0.html | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/relnotes/12.1.0.html b/docs/relnotes/12.1.0.html index e7c3a52..3935bb0 100644 --- a/docs/relnotes/12.1.

[Mesa-dev] [PATCH mesa] freedreno/a2xx: remove duplicate assignment

CovID: 1362445, 1362446 Signed-off-by: Eric Engestrom --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.h b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.h index 822e5ec..36ed204 100644

Re: [Mesa-dev] [PATCH 19/87] glsl: cache more uniform storage values

On Thu, 2016-07-28 at 13:35 +0300, Tapani Pälli wrote: > > On 07/13/2016 05:47 AM, Timothy Arceri wrote: > > --- > >  src/compiler/glsl/shader_cache.cpp | 16 ++-- > >  1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/src/compiler/glsl/shader_cache.cpp > > b/src/co

[Mesa-dev] Debug GLSL shader in Mesa

Hi, I am wondering if it is possible to debug GLSL shader in Mesa. I am interested in software based implementation, such as llvmpipe or swr. Is there an option so Mesa will put debug information into GLSL shader? Thanks Sheng ___ mesa-dev mailing l

[Mesa-dev] [Bug 97140] dd_draw.c:949:11: error: implicit declaration of function 'fmemopen' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

https://bugs.freedesktop.org/show_bug.cgi?id=97140 Bug ID: 97140 Summary: dd_draw.c:949:11: error: implicit declaration of function 'fmemopen' is invalid in C99 [-Werror,-Wimplicit-function-declaration] Product: Mesa

Re: [Mesa-dev] [PATCH] gbm: Removed unused function.

On Fri, Jul 29, 2016 at 1:42 PM, Ben Widawsky wrote: > AFAICT, it's never been used. > > It was briefly nudged in the right direction here: > commit 10e5ffd4961055ebba5be4d85a93cc66cdd5a635 > Author: Emil Velikov > Date: Sat Jan 25 17:19:10 2014 + > > gbm: do not export _gbm_mesa_get_de

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke wrote: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fall through to "default" and hit a "continue", making it > not actually move any

[Mesa-dev] [PATCH 10/12] gallium/radeon: inline radeon_winsys::query_memory_usage

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeon/radeon_winsys.h| 2 -- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 6 -- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 6 -- 4 files changed, 1 insertion(+), 15 deletions(-)

[Mesa-dev] [PATCH 06/12] radeonsi: flush if sampler views and images use too much memory

From: Marek Olšák --- src/gallium/drivers/radeon/r600_cs.h | 34 +++ src/gallium/drivers/radeonsi/si_descriptors.c | 48 --- 2 files changed, 63 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_cs.h b/src/gallium/drive

[Mesa-dev] [PATCH 09/12] gallium/radeon/winsyses: expose per-IB used_vram and used_gart to drivers

From: Marek Olšák The following patches will use this. --- src/gallium/drivers/radeon/radeon_winsys.h| 5 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 17 - src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 2 -- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 22 +++

[Mesa-dev] [PATCH 04/12] radeonsi: take compute shader and dispatch indirect memory usage into account

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index e75f6bd..c3e8a35 100644 --- a/src/gallium/drivers/radeonsi/si_compute.c +++ b/src

[Mesa-dev] [PATCH 08/12] gallium/radeon/winsyses: print CS submission error number

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index fb517b9..3

[Mesa-dev] [PATCH 11/12] gallium/radeon: move radeon_winsys::cs_memory_below_limit to drivers

From: Marek Olšák --- src/gallium/drivers/r600/r600_hw_context.c| 3 ++- src/gallium/drivers/radeon/r600_cs.h | 29 --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeon/radeon_winsys.h| 11 -- src/gallium/drivers/

[Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

From: Marek Olšák This is controversial, but I don't see a better way out of this. Tonga has 2 GB of VRAM and 2 GB of GTT. amdgpu is not capable of submitting an IB referencing 1 GB of VRAM and 1 GB of GTT. The CS ioctl never succeeds even though it's far below the limits. Without this, "dEQP-G

[Mesa-dev] [PATCH 05/12] radeonsi: deal with high vertex buffer memory usage correctly

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 ++--- src/gallium/drivers/radeonsi/si_state.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 7 +++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descripto

[Mesa-dev] [PATCH 02/12] radeonsi: check IB memory usage of CP DMA operations

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c index 882458c..7d4edc0 100644 --- a/src/gallium/drivers/radeonsi/si_cp_dma.c +++ b/src/gall

[Mesa-dev] [PATCH 07/12] radeonsi: flush if constant, shader, and streamout buffers use too much memory

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 33 +++ 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index ea58584..224cf35 100644 --- a

[Mesa-dev] [PATCH 00/12] RadeonSI: Prevent IB submissions with illegal memory usage

Hi, This series ensures that memory usage of gfx IBs is below the kernel- exposed memory limits in most cases. It's not possible to prevent CS ioctl failures completely because it depends on whether continuous free space for all buffers is available, i.e. it depends on where some system buffers a

[Mesa-dev] [PATCH 03/12] radeonsi: take scratch buffer and draw indirect memory usage into account

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 24fa682..6f87721 100644 --- a/src/gallium/drivers/radeonsi/si_state_draw

[Mesa-dev] [PATCH 01/12] gallium/radeon: add r600_resource::vram_usage and gart_usage

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 10 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 18 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/gallium/d

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Fri, Jul 29, 2016 at 12:32 PM, Anuj Phogat wrote: > > > On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand > wrote: > >> On Jul 28, 2016 7:37 PM, "Anuj Phogat" wrote: >> > >> > Fixes the vulkan cts regression in test >> dEQP-VK.api.info.device.properties >> > >> > Cc: Mark Janes >> > Cc: Jason

Re: [Mesa-dev] [PATCH] gallium/util: fix align64

Ouch, good one! Reviewed-by: Ilia Mirkin On Fri, Jul 29, 2016 at 5:22 PM, Marek Olšák wrote: > From: Marek Olšák > > it cut off the upper 32 bits > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/auxiliary/util/u_math.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

[Mesa-dev] [PATCH] gallium/util: fix align64

From: Marek Olšák it cut off the upper 32 bits Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/util/u_math.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index c94967e..1661e63 1006

Re: [Mesa-dev] [PATCH 10/17] glsl: Define a gl_LastFragData built-in for GLSL versions that have gl_FragData.

Francisco Jerez writes: > Kenneth Graunke writes: > >> On Wednesday, July 27, 2016 5:05:39 PM PDT Francisco Jerez wrote: >>> Kenneth Graunke writes: >>> >>> > On Wednesday, July 20, 2016 9:49:40 PM PDT Francisco Jerez wrote: >>> >> The EXT_shader_framebuffer_fetch extension defines alternative

[Mesa-dev] [PATCH] gbm: Removed unused function.

AFAICT, it's never been used. It was briefly nudged in the right direction here: commit 10e5ffd4961055ebba5be4d85a93cc66cdd5a635 Author: Emil Velikov Date: Sat Jan 25 17:19:10 2014 + gbm: do not export _gbm_mesa_get_device Cc: Kristian Høgsberg Cc: Emil Velikov Signed-off-by: Ben Wi

[Mesa-dev] [Bug 97136] [softpipe] piglit egl-create-context-verify-gl-flavor regression

https://bugs.freedesktop.org/show_bug.cgi?id=97136 Bug ID: 97136 Summary: [softpipe] piglit egl-create-context-verify-gl-flavor regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 5/7] draw: Avoid aliasing violations.

Reviewed-by: Marek Olšák Marek On Fri, Jul 29, 2016 at 12:35 AM, Matt Turner wrote: > --- > src/gallium/auxiliary/draw/draw_cliptest_tmp.h | 6 -- > src/gallium/auxiliary/draw/draw_pipe_clip.c| 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxil

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

Reviewed-by: Marek Olšák Marek On Fri, Jul 29, 2016 at 12:35 AM, Matt Turner wrote: > --- > src/gallium/auxiliary/Makefile.sources | 1 + > src/gallium/auxiliary/util/u_bitcast.h | 57 > ++ > 2 files changed, 58 insertions(+) > create mode 100644 src/gallium/

Re: [Mesa-dev] [PATCH 4/7] r600g: Avoid aliasing violations.

Reviewed-by: Marek Olšák Marek On Fri, Jul 29, 2016 at 12:35 AM, Matt Turner wrote: > --- > src/gallium/drivers/r600/r600_asm.c| 3 ++- > src/gallium/drivers/r600/r600_shader.c | 19 +++ > 2 files changed, 9 insertions(+), 13 deletions(-) > > diff --git a/src/gallium/drive

Re: [Mesa-dev] [PATCH 3/7] r300g: Avoid aliasing violation.

Reviewed-by: Marek Olšák Marek On Fri, Jul 29, 2016 at 12:35 AM, Matt Turner wrote: > --- > src/gallium/drivers/r300/compiler/radeon_inline_literals.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/r300/compiler/radeon_inline_literals.c > b/src/

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

Iago Toral Quiroga writes: > From: "Juan A. Suarez Romero" > > Our current data flow analysis does not take into account that channels > on 64-bit operands are 64-bit. This is a problem when the same register > is accessed using both 64-bit and 32-bit channels. This is very common > in operation

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand wrote: > On Jul 28, 2016 7:37 PM, "Anuj Phogat" wrote: > > > > Fixes the vulkan cts regression in test > dEQP-VK.api.info.device.properties > > > > Cc: Mark Janes > > Cc: Jason Ekstrand > > Signed-off-by: Anuj Phogat > > --- > > src/intel/vulka

Re: [Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

On Fri, Jul 29, 2016 at 8:01 PM, Rob Herring wrote: > On Fri, Jul 29, 2016 at 12:51 PM, Marek Olšák wrote: >> The fd table and reference counting in the winsys is required by the >> GL-VDPAU interop. >> >> radeon_drm_winsys_create and amdgpu_winsys_create are publicly >> exported by both *_dri.so

Re: [Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

thanks, pushed On Fri, Jul 29, 2016 at 7:56 AM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Valgrind detected that variable ir_copy_propagation_visitor::killed_all > is uninitialized. > > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > src/compiler/glsl/opt_co

Re: [Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

On Fri, Jul 29, 2016 at 12:51 PM, Marek Olšák wrote: > The fd table and reference counting in the winsys is required by the > GL-VDPAU interop. > > radeon_drm_winsys_create and amdgpu_winsys_create are publicly > exported by both *_dri.so and libvdpau_*.so, and whichever is loaded > first will eff

Re: [Mesa-dev] [PATCH v4 07/11] amdgpu: use common screen ref counting

The fd table and reference counting in the winsys is required by the GL-VDPAU interop. radeon_drm_winsys_create and amdgpu_winsys_create are publicly exported by both *_dri.so and libvdpau_*.so, and whichever is loaded first will effectively provide the gallium driver implementation for both of th

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Jul 29, 2016 9:09 AM, "Jason Ekstrand" wrote: > > On Jul 29, 2016 1:47 AM, "Pohjolainen, Topi" wrote: > > > > On Thu, Jul 28, 2016 at 11:41:01AM -0700, Jason Ekstrand wrote: > > >On Jul 28, 2016 12:05 PM, "Pohjolainen, Topi" > > ><[1]topi.pohjolai...@intel.com> wrote: > > >> > > >

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

On 28 July 2016 at 14:58, Stefan Dirsch wrote: > On Thu, Jul 14, 2016 at 05:20:55PM +0100, Emil Velikov wrote: >> On 14 July 2016 at 15:23, Eric Engestrom wrote: >> > On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: >> >> This 'last' variable used in FindGLXFunction(...) may become

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

Ah you're right it is guaranteed by c99 and newer (who cares about c++ :-)). I was probably remembering some discussion for older c standards, where it might not have been guaranteed by the standard but all compilers would have honored the union aliasing anyway. But in any case I'm still fine wit

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Jul 29, 2016 1:47 AM, "Pohjolainen, Topi" wrote: > > On Thu, Jul 28, 2016 at 11:41:01AM -0700, Jason Ekstrand wrote: > >On Jul 28, 2016 12:05 PM, "Pohjolainen, Topi" > ><[1]topi.pohjolai...@intel.com> wrote: > >> > >> On Tue, Jul 26, 2016 at 03:11:12PM -0700, Jason Ekstrand wrot

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

yes please BR, -R On Fri, Jul 29, 2016 at 1:37 AM, Francesco Ansanelli wrote: > I did a test with: > > static struct ir3_shader_key key; > memset(&key, 0, sizeof(key)); > > both gcc and clang seems happy with it. > Let me know if you want me to send a patch. > > > 2016-07-29 1:53 GMT+02:00 Rob C

Re: [Mesa-dev] [PATCH v2 09/27] i964/blorp: Set up most aux surfaces up-front

On Jul 29, 2016 2:18 AM, "Pohjolainen, Topi" wrote: > > On Fri, Jul 29, 2016 at 09:58:36AM +0300, Pohjolainen, Topi wrote: > > On Tue, Jul 26, 2016 at 03:11:13PM -0700, Jason Ekstrand wrote: > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp.c | 43 --- > > > src/

Re: [Mesa-dev] [PATCH v2 10/27] i965/blorp: Set up HiZ surfaces up-front

On Jul 29, 2016 2:26 AM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:11:14PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 59 +- > > src/mesa/drivers/dri/i965/brw_blorp.h | 2 -- > > src/mesa/drivers/dri/i965/gen

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

Is that really the case? I always thought that using union is one of the best ways to play it safe while not disabling strict aliasing rules. Here is an answer on stack overflow that uses this reasoning: http://stackoverflow.com/a/99010 Here is another site with an extract from C11 standard: http

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

Am 29.07.2016 um 06:55 schrieb Connor Abbott: > On Thu, Jul 28, 2016 at 7:58 PM, Roland Scheidegger > wrote: >> Am 29.07.2016 um 00:35 schrieb Matt Turner: >>> --- >>> src/gallium/auxiliary/Makefile.sources | 1 + >>> src/gallium/auxiliary/util/u_bitcast.h | 57 >>>

Re: [Mesa-dev] [PATCH 4/4] nir: Make nir_opt_remove_phis see through moves.

Sounds like you're doing something similar to nouveau's GlobalCSE pass. On the off chance it's useful, you can have a look at how we do it here: https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp#n3118 On Fri, Jul 29, 2016 at 4:29 AM, Kenneth Grau

[Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

Valgrind detected that variable ir_copy_propagation_visitor::killed_all is uninitialized. Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/compiler/glsl/opt_copy_propagation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/opt_copy_propa

Re: [Mesa-dev] [PATCH 1/3] loader/dri3: Destroy Present event context when destroying drawable

On 28.07.2016 18:41, Chris Wilson wrote: > On Thu, Jul 28, 2016 at 06:34:44PM +0900, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Without this, the X server may accumulate stale Present event contexts >> if a client ends up creating and destroying DRI drawables for the same >> window. >> >> S

[Mesa-dev] [PATCH 2/3] vl/dri3: Destroy Present event context when destroying drawable v2

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client performs several video decoding sessions using the same window. v2: Based on Chris Wilson's review: * Use xcb_discard_reply() instead of free(xcb_request_check()) Signed-off-by: Michel Dänzer

[Mesa-dev] [PATCH 3/3] anv/x11: Destroy Present event context when destroying swapchain v2

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client creates and destroys multiple swapchains using the same window. v2: Based on Chris Wilson's review: * Use xcb_present_select_input_checked so that protocol errors generated by old X servers c

[Mesa-dev] [PATCH 1/3] loader/dri3: Destroy Present event context when destroying drawable v2

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client ends up creating and destroying DRI drawables for the same window. v2: Based on Chris Wilson's review: * Use xcb_present_select_input_checked so that protocol errors generated by old X server

Re: [Mesa-dev] [PATCH 1/4] i965: Use a separate register for every access to an SSA undef.

I made a couple of small comments to patches 1 and 4, but either way all 4 patches are: Reviewed-by: Iago Toral Quiroga On Fri, 2016-07-29 at 01:29 -0700, Kenneth Graunke wrote: > Previously, we allocated a new VGRF for every undefined definition. > Instead, this patch makes us allocate a new V

Re: [Mesa-dev] [PATCH 1/4] i965: Use a separate register for every access to an SSA undef.

On Fri, 2016-07-29 at 01:29 -0700, Kenneth Graunke wrote: > Previously, we allocated a new VGRF for every undefined definition. > Instead, this patch makes us allocate a new VGRF for every use of an > undefined definition.  This makes sure that undefined values are > fully independent of one anothe

Re: [Mesa-dev] [PATCH 4/4] nir: Make nir_opt_remove_phis see through moves.

On Fri, 2016-07-29 at 01:29 -0700, Kenneth Graunke wrote: > I found a shader in Tales of Maj'Eyal that contains: > > if ssa_21 { > block block_1: > /* preds: block_0 */ > ...instructions that prevent the select peephole... > v

[Mesa-dev] [PATCH 4/4] nir: Make nir_opt_remove_phis see through moves.

I found a shader in Tales of Maj'Eyal that contains: if ssa_21 { block block_1: /* preds: block_0 */ ...instructions that prevent the select peephole... vec1 32 ssa_23 = imov ssa_4 vec1 32 ssa_24 = imov ssa_4.y

[Mesa-dev] [PATCH 3/4] nir: Make nir_alu_srcs_equal non-static.

Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir.h | 3 +++ src/compiler/nir/nir_instr_set.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 65ecd33..9ce5be2 100644 --- a/src/compiler/nir/nir.h +++ b/src/

[Mesa-dev] [PATCH 2/4] nir: Turn imov/fmov of undef into undef.

On Broadwell: total instructions in shared programs: 11640214 -> 11639872 (-0.00%) instructions in affected programs: 17744 -> 17402 (-1.93%) helped: 78 HURT: 0 total spills in shared programs: 2924 -> 2922 (-0.07%) spills in affected programs: 104 -> 102 (-1.92%) helped: 1 HURT: 0 total fills i

[Mesa-dev] [PATCH 1/4] i965: Use a separate register for every access to an SSA undef.

Previously, we allocated a new VGRF for every undefined definition. Instead, this patch makes us allocate a new VGRF for every use of an undefined definition. This makes sure that undefined values are fully independent of one another, and have live ranges limited to their single use. This allows

Re: [Mesa-dev] [PATCH 1/9] i965/eu: Take into account the target cache argument in brw_set_dp_read_message.

Reviewed-by: Iago Toral Quiroga On Thu, 2016-07-28 at 14:50 -0700, Francisco Jerez wrote: > brw_set_dp_read_message() was setting the data cache as send message > SFID on Gen7+ hardware, ignoring the target cache specified by the > caller.  Some of the callers were passing a bogus target cache va

Re: [Mesa-dev] [PATCH v2 12/27] i965/blorp: Use the isl_surf for more params setup

On Tue, Jul 26, 2016 at 03:11:16PM -0700, Jason Ekstrand wrote: > The isl_surf munging doesn't happen until fairly late in the blorp_blit > function. We can use the isl_surf for the vast majority if not all of our > params setup. Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH v2 11/27] i965/blorp: Do gen6 stencil offsets up-front

On Tue, Jul 26, 2016 at 03:11:15PM -0700, Jason Ekstrand wrote: > This keeps all of the nastyness of gen6 stencil on the i965 side of the API > line and lets us delete that nasty hand-rolled ISL-based offset path that > we were using for ALL_SLICES_AT_EACH_LOD. Reviewed-by: Topi Pohjolainen > --

Re: [Mesa-dev] [PATCH] configure: add support for LLVM 4.0.0svn static libs

On 27.07.2016 20:36, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 5c196a9..58c2db4 100644 > --- a/configure.ac > +++

Re: [Mesa-dev] [PATCH v2 10/27] i965/blorp: Set up HiZ surfaces up-front

On Tue, Jul 26, 2016 at 03:11:14PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 59 > +- > src/mesa/drivers/dri/i965/brw_blorp.h | 2 -- > src/mesa/drivers/dri/i965/gen6_blorp.c | 19 +++ > src/mesa/drivers/dri/i965/gen7_b

Re: [Mesa-dev] [PATCH v2 09/27] i964/blorp: Set up most aux surfaces up-front

On Fri, Jul 29, 2016 at 09:58:36AM +0300, Pohjolainen, Topi wrote: > On Tue, Jul 26, 2016 at 03:11:13PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 43 > > --- > > src/mesa/drivers/dri/i965/brw_blorp.h | 4 > > 2 files cha