Re: [Mesa-dev] [PATCH 1/2] gallium/u_queue: guard fence->signalled checks with fence->mutex

This series is, Reviewed-by: Edward O'Callaghan On 07/10/2016 03:44 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > I have seen a hang during application shutdown that could be explained by the > following race condition which this patch fixes: > > 1. Worker thread enters util_queue_fenc

Re: [Mesa-dev] [PATCH 3/4] st/mesa: refactor duplicated etc fallback checks

On Fri, Jul 8, 2016 at 3:51 PM, Ilia Mirkin wrote: > On Fri, Jul 8, 2016 at 6:22 AM, Eric Engestrom > wrote: >> On Fri, Jul 08, 2016 at 02:48:04AM -0400, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/mesa/state_tracker/st_cb_texture.c | 15 +-- >>> 1 file changed

Re: [Mesa-dev] [PATCH 2/4] st/mesa: return appropriate mesa format for ETC texture formats

Reviewed-by: Marek Olšák Marek On Fri, Jul 8, 2016 at 8:48 AM, Ilia Mirkin wrote: > Even when the backend driver does not support ETC formats, we handle the > decoding into an uncompressed backing texture. However as far as core > mesa is concerned, it's an ETC texture and we should return the

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Sat, Jul 9, 2016 at 11:02 PM, Grazvydas Ignotas wrote: > On Sat, Jul 9, 2016 at 6:49 PM, Marek Olšák wrote: >> On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri >> wrote: >>> On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: Hi, This series implements basic multithreaded LLVM

Re: [Mesa-dev] [PATCH] mesa: set _NEW_BUFFERS when updating texture bound to current buffers

On Fri, Jul 08, 2016 at 02:24:38PM -0400, Ilia Mirkin wrote: > When a glTexImage call updates the parameters of a currently bound > framebuffer, we might miss out on revalidating whether it is complete. > Make sure to set _NEW_BUFFERS which will trigger the revalidation in > that case. > > Also wh

Re: [Mesa-dev] [PATCH 20/47] clover/llvm: Clean up codestyle of get_kernel_args().

Jan Vesely writes: > On Mon, 2016-07-04 at 12:31 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: >> > > Reviewed-by: Serge Martin >> > > --- >> > >  .../state_trackers/clover/llvm/invocation.cpp  | 223 >> > > ++-

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Sat, Jul 9, 2016 at 6:49 PM, Marek Olšák wrote: > On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri > wrote: >> On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: >>> Hi, >>> >>> This series implements basic multithreaded LLVM shader compilation >>> in a minimally invasive way. (+51 lines of c

Re: [Mesa-dev] [PATCH] mesa: set _NEW_BUFFERS when updating texture bound to current buffers

Reviewed-by: Marek Olšák Marek On Fri, Jul 8, 2016 at 8:24 PM, Ilia Mirkin wrote: > When a glTexImage call updates the parameters of a currently bound > framebuffer, we might miss out on revalidating whether it is complete. > Make sure to set _NEW_BUFFERS which will trigger the revalidation in

Re: [Mesa-dev] [PATCH] radeonsi: fix bad assertion in si_emit_sample_mask

Reviewed-by: Marek Olšák Marek On Fri, Jul 8, 2016 at 7:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The blitter sets mask == 1, which is fine since it doesn't use smoothing. > Fixes a regression introduced in commit 5bcfbf91. > --- > src/gallium/drivers/radeonsi/si_state.c | 3 ++-

Re: [Mesa-dev] [PATCH 2/2] gallium/u_queue: assert that users must wait on fences before destroying them

The series is: Reviewed-by: Marek Olšák Marek On Sat, Jul 9, 2016 at 7:44 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/util/u_queue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/auxiliary/util/u_queue.c > b/src/gallium/auxiliary/u

[Mesa-dev] [PATCH v2 12/14] isl: Add support for color control surfaces

--- src/intel/isl/isl.c | 32 src/intel/isl/isl.h | 14 ++ src/intel/isl/isl_format_layout.csv | 9 + src/intel/isl/isl_gen7.c| 7 +++ src/intel/isl/isl_gen8.c| 13 + src/

[Mesa-dev] [PATCH 08/14] isl: Make take bpb rather than bs in get_format_layout

--- src/intel/isl/isl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 796b4cc..e0e67e2 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -107,10 +107,10 @@ isl_device_get_sample_counts(struct isl_device *d

[Mesa-dev] [PATCH 04/14] isl: Rework the way we define tile sizes.

This is based on a very long set of discussions between Chad and myself about how we should properly represent HiZ and CCS buffers. The end result of that discussion was that a tiling actually has two different sizes, a logical size in elements, and a physical size in bytes and rows. This commit

[Mesa-dev] [PATCH 12/14] isl: Add support for color control surfaces

--- src/intel/isl/isl.c | 10 ++ src/intel/isl/isl.h | 14 ++ src/intel/isl/isl_format_layout.csv | 9 + src/intel/isl/isl_gen7.c| 7 +++ src/intel/isl/isl_gen8.c| 13 + src/intel/isl/isl_gen9.c

[Mesa-dev] [PATCH 02/14] isl: Stop multiplying height by block size

The row pitch already specifies the size of a row of elements. Multiplying by the block height simply causes us to allocate as muc as 12 times more memory than needed for compressed textures. --- src/intel/isl/isl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH 11/14] isl: Add support for multisample compression surfaces

--- src/intel/isl/isl.h | 7 +++ src/intel/isl/isl_format_layout.csv | 4 src/intel/isl/isl_gen7.c| 4 3 files changed, 15 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 9a60bbd..598ed2c 100644 --- a/src/intel/isl/isl.h +++ b/s

[Mesa-dev] [PATCH 13/14] isl: Add an auxiliary surface usage enum

--- src/intel/isl/isl.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 0ea19d1..dfc00d5 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -511,6 +511,32 @@ enum isl_dim_layout { ISL_DIM_LAYOUT_GEN9_1D,

[Mesa-dev] [PATCH 06/14] isl: Bring back isl_format_layout::bpb

A while ago we got rid of the bits-per-block because we thought we didn't need it. We're about to introduce some very useful 1 and 2-bit formats so we really should be able to handle them again. --- src/intel/isl/gen_format_layout.py | 5 +++-- src/intel/isl/isl.h| 2 ++ 2 files c

[Mesa-dev] [PATCH 00/14] isl: Add support for auxiliary surfaces

This set of patches adds support in isl for the various types of auxiliary surfaces. Chad and I have been fiercely arguing back and forth for about the last two weeks on how we want to handle all of the different aspects of auxiliary surfaces. This little series is the result of that discussion.

[Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

--- src/intel/isl/isl.c | 11 +++ src/intel/isl/isl.h | 17 + src/intel/isl/isl_format_layout.csv | 1 + src/intel/isl/isl_gen6.c| 8 src/intel/isl/isl_gen7.c| 10 +- src/intel/isl/isl_gen8.c

[Mesa-dev] [PATCH 08/14] isl: Take bpb rather than bs in get_format_layout

--- src/intel/isl/isl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 796b4cc..e0e67e2 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -107,10 +107,10 @@ isl_device_get_sample_counts(struct isl_device *d

[Mesa-dev] [PATCH 14/14] isl/state: Add support for handling color control surfaces

Reviewed-by: Topi Pohjolainen --- src/intel/isl/isl.h | 7 +++ src/intel/isl/isl_surface_state.c | 43 +-- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index dfc00d5..8716cbd 100644

[Mesa-dev] [PATCH 09/14] isl: Kill off isl_format_layout::bs

--- src/intel/isl/gen_format_layout.py | 1 - src/intel/isl/isl.c| 11 ++- src/intel/isl/isl.h| 5 ++--- src/intel/isl/isl_gen9.c | 14 +++--- src/intel/isl/isl_storage_image.c | 4 ++-- src/intel/vulkan/anv_image.c | 4 ++-- src

[Mesa-dev] [PATCH 01/14] isl: Get rid of tiling_get_extent

It was unused --- src/intel/isl/isl.c | 11 --- src/intel/isl/isl.h | 6 -- 2 files changed, 17 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 77b570d..72b681e 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -166,17 +166,6 @@ isl_tiling_get_in

[Mesa-dev] [PATCH 03/14] isl: Rework the way we handle surface padding

--- src/intel/isl/isl.c | 52 +--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index decba3d..6f57ac2 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -933,21 +933,21 @@ isl_c

[Mesa-dev] [PATCH 05/14] isl: Change the physical size of a W-tile to 128x32

--- src/intel/isl/isl.c| 14 -- src/intel/isl/isl_surface_state.c | 11 +-- src/intel/vulkan/anv_meta_blit2d.c | 2 +- src/intel/vulkan/genX_cmd_buffer.c | 7 +-- 4 files changed, 15 insertions(+), 19 deletions(-) diff --git a/src/intel/isl/isl.c b/src/i

[Mesa-dev] [PATCH 07/14] isl: Use bpb in a few places where it's more natural than bs

--- src/intel/isl/isl.c | 2 +- src/intel/isl/isl_gen6.c | 2 +- src/intel/isl/isl_gen7.c | 2 +- src/intel/isl/isl_storage_image.c| 4 ++-- src/intel/vulkan/anv_formats.c

[Mesa-dev] [Bug 96872] glReadPixels returns black pixels on first display in software mode

https://bugs.freedesktop.org/show_bug.cgi?id=96872 --- Comment #1 from Ruslan Kabatsayev --- I can also reproduce this with FBDEV driver being in use and default renderer. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

https://bugs.freedesktop.org/show_bug.cgi?id=86837 Christian König changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #33 from Christian

[Mesa-dev] [PATCH 1/2] gallium/u_queue: guard fence->signalled checks with fence->mutex

From: Nicolai Hähnle I have seen a hang during application shutdown that could be explained by the following race condition which this patch fixes: 1. Worker thread enters util_queue_fence_signal, sets fence->signalled = true. 2. Main thread calls util_queue_job_wait, which returns immediately.

[Mesa-dev] [PATCH 2/2] gallium/u_queue: assert that users must wait on fences before destroying them

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxiliary/util/u_queue.c index 2429336..ac3afa1 100644 --- a/src/gallium/auxiliary/util/u_queue.c +++ b/src/gallium/auxiliary/util

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Sat, Jul 9, 2016 at 10:02 AM, Timothy Arceri wrote: > On Fri, 2016-07-01 at 14:12 +1000, Timothy Arceri wrote: >> On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: >> > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri >> > wrote: >> > > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ign

[Mesa-dev] [Bug 96872] glReadPixels returns black pixels on first display in software mode

https://bugs.freedesktop.org/show_bug.cgi?id=96872 Bug ID: 96872 Summary: glReadPixels returns black pixels on first display in software mode Product: Mesa Version: 10.5 Hardware: Other OS: All S

Re: [Mesa-dev] [PATCH 3/4] radeonsi: use multi-threaded compilation in debug contexts

On Fri, Jul 8, 2016 at 10:58 AM, Nicolai Hähnle wrote: > On 07.07.2016 23:49, Marek Olšák wrote: >> >> On Thu, Jul 7, 2016 at 9:39 AM, Nicolai Hähnle wrote: >>> >>> From: Nicolai Hähnle >>> >>> We only have to stay single-threaded when debug output must be >>> synchronous. >>> This yields better

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri wrote: > On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: >> Hi, >> >> This series implements basic multithreaded LLVM shader compilation >> in a minimally invasive way. (+51 lines of code in the main patch) >> >> It doesn't help on-demand shader

Re: [Mesa-dev] [PATCH 08/13] todo! egl/dri2: Questions about sync fd ownership

On Fri, Jul 08, 2016 at 05:00:58PM -0700, Chad Versace wrote: > See the comments. > --- > src/egl/drivers/dri2/egl_dri2.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c > index c7b81ce..03ed4b9 100644 > ---

[Mesa-dev] [PATCH] i965: fix ignored qualifiers warning

--- src/mesa/drivers/dri/i965/gen6_queryobj.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src/mesa/drivers/dri/i965/gen6_queryobj.c index 96db5e9..95a5c56 100644 --- a/src/mesa/drivers/dri/i965/gen6_queryobj.c +++ b/src/mesa/d

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Fri, 2016-07-01 at 14:12 +1000, Timothy Arceri wrote: > On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: > > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri > > wrote: > > > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ignotas wrote: > > > > On Tue, Jun 28, 2016 at 10:53 AM, Timothy