[Mesa-dev] [Bug 94274] [swrast] piglit arb_occlusion_query2-render regression

2016-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94274 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH V4 24/26] glsl: lower tessellation varyings packed with component layout qualifier

2016-03-05 Thread Timothy Arceri
For tessellation shaders we cannot just copy everything to the packed varyings like we do in other stages as tessellation uses shared memory for varyings, therefore it is only safe to copy array elements that the shader actually uses. This class searches the IR for uses of varyings and then create

Re: [Mesa-dev] [PATCH] i965/hsw: Initialize SLM index in state register

2016-03-05 Thread Matt Turner
On Sat, Mar 5, 2016 at 4:02 PM, Jordan Justen wrote: > On 2016-03-04 16:07:08, Matt Turner wrote: >> Alternatively, if overwriting FFTID is bad, instead of emitting >> >>shr(1) sr0.1:UD g0.0:UD 16UD >> >> you could write only the low word: >> >>mov(1) sr0.2:UW g0.1:UW >> >> or maybe u

Re: [Mesa-dev] [PATCH] st/mesa: 78-column wrapping in st_extensions.c

2016-03-05 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 4, 2016 5:17 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: 78-column wrapping in st_extensions.c --- src/mesa/state_tracker/st_extensions.c | 175

Re: [Mesa-dev] [PATCH 3/3] svga: add new surface-write-flushes HUD query

2016-03-05 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 4, 2016 5:17 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 3/3] svga: add new surface-write-flushes HUD query To know when we're flushing the comman

Re: [Mesa-dev] [PATCH] i965/hsw: Initialize SLM index in state register

2016-03-05 Thread Jordan Justen
On 2016-03-04 16:07:08, Matt Turner wrote: > Alternatively, if overwriting FFTID is bad, instead of emitting > >shr(1) sr0.1:UD g0.0:UD 16UD > > you could write only the low word: > >mov(1) sr0.2:UW g0.1:UW > > or maybe use an AND to ensure you're writing zeros to the MBZ bits of >

[Mesa-dev] [Bug 93667] Crash in eglCreateImageKHR with huge texture size

2016-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93667 --- Comment #1 from Emil Velikov --- Hi Fabian, just send out the a patch for this case. Can you please test it ? The only other case that I've spot has already been addressed with commit 5d87a7c894d "egl_dri2: NULL check for xcb_dri2_get_buffer

[Mesa-dev] [PATCH] egl/x11: check the return value of xcb_dri2_get_buffers_reply()

2016-03-05 Thread Emil Velikov
... before using it. The function can return NULL, which we should check prior to refererencing it in the next function(s). Cc: Fabian Vogt Cc: "11.1 11.2" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93667 Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 3 +++

Re: [Mesa-dev] [PATCH] program: add no-op add_uniform_to_shader::set_buffer_offset() method

2016-03-05 Thread Jose Fonseca
On 05/03/16 17:40, Brian Paul wrote: Fixes VMware MSVC, MinGW builds: build/windows-x86-debug/mesa/libmesa.a(ir_to_mesa.o): ir_to_mesa.cpp:(.rdata+0xf9c): undefined reference to `program_resource_visitor::set_buffer_offset(unsigned int)' This doesn't seem to be needed for the libgl-gdi target,

Re: [Mesa-dev] [PATCH] i965/hsw: Initialize SLM index in state register

2016-03-05 Thread Kenneth Graunke
On Friday, March 4, 2016 4:07:08 PM PST Matt Turner wrote: > On Mon, Feb 22, 2016 at 11:35 AM, Jordan Justen > wrote: > > For Haswell, we need to initialize the SLM index in the state > > register. This can be copied out of the CS header dword 0. > > > > Fixes piglit: arb_compute_shader/execution/

[Mesa-dev] [PATCH] program: add no-op add_uniform_to_shader::set_buffer_offset() method

2016-03-05 Thread Brian Paul
Fixes VMware MSVC, MinGW builds: build/windows-x86-debug/mesa/libmesa.a(ir_to_mesa.o): ir_to_mesa.cpp:(.rdata+0xf9c): undefined reference to `program_resource_visitor::set_buffer_offset(unsigned int)' This doesn't seem to be needed for the libgl-gdi target, however. --- src/mesa/program/ir_to_me

Re: [Mesa-dev] [PATCH 3/3] glsl: remove out of date comments from file header

2016-03-05 Thread Matt Turner
On Wed, Feb 10, 2016 at 8:45 PM, Timothy Arceri wrote: > The bison/flex generated code hasn't been keeped in version control s/keeped/kept/ > for a long time, and I doubt anyone is going to argue for putting > all this validation in the parser. > --- > src/compiler/glsl/ast_to_hir.cpp | 18 +---

Re: [Mesa-dev] [PATCH 02/16] mesa: Add support to query block depth using _mesa_get_format_block_size()

2016-03-05 Thread Brian Paul
On 03/04/2016 06:29 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i915/intel_mipmap_tree.c| 8 src/mesa/drivers/dri/i915/intel_tex_layout.c | 4 ++-- src/mesa/drivers/dri/i965/brw_tex_layout.c | 21 +++-- src/mesa/drivers

Re: [Mesa-dev] [PATCH] st/va: avoid dereference after free

2016-03-05 Thread Emil Velikov
Hi Thomas, On 5 March 2016 at 12:07, Thomas Hindoe Paaboel Andersen wrote: > --- > src/gallium/state_trackers/va/image.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/va/image.c > b/src/gallium/state_trackers/va/image.c > index 2c42a98..9

Re: [Mesa-dev] [PATCH] opencl: fix .gitignore for .install-gallium-links

2016-03-05 Thread Emil Velikov
I new I forgot something. Can you please move this to the top level .gitignore and add the following tag to the commit message. Fixes: 0b6157e9713 "install-gallium-links: port changes from install-lib-links" Thanks Emil ___ mesa-dev mailing list mesa-d

[Mesa-dev] [PATCH] st/va: avoid dereference after free

2016-03-05 Thread Thomas Hindoe Paaboel Andersen
--- src/gallium/state_trackers/va/image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index 2c42a98..92d014c 100644 --- a/src/gallium/state_trackers/va/image.c +++ b/src/gallium/state_trackers

Re: [Mesa-dev] [PATCH 3/4] gallium/util: update comments and URL in u_debug_refcnt.c

2016-03-05 Thread Eduardo Lima Mitev
On 03/05/2016 02:16 AM, Brian Paul wrote: --- src/gallium/auxiliary/util/u_debug_refcnt.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug_refcnt.c b/src/gallium/auxiliary/util/u_debug_refcnt.c index f486492..c17c65f 100644

Re: [Mesa-dev] [PATCH] opencl: fix .gitignore for .install-gallium-links

2016-03-05 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev On 03/05/2016 04:14 AM, Dieter Nützel wrote: Signed-off-by: Dieter Nützel --- src/gallium/targets/opencl/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/opencl/.gitignore b/src/gallium/targets/opencl/.gitignore index dad573

Re: [Mesa-dev] [PATCH] st/mesa: 78-column wrapping in st_extensions.c

2016-03-05 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev On 03/05/2016 02:17 AM, Brian Paul wrote: --- src/mesa/state_tracker/st_extensions.c | 175 - 1 file changed, 107 insertions(+), 68 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_e

Re: [Mesa-dev] [PATCH] gallium/tests: silence warning in compute.c

2016-03-05 Thread Samuel Pitoiset
On 05/03/2016 02:20, Brian Paul wrote: compute.c: In function ‘launch_grid’: compute.c:435:20: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default] info.input = input; ^ Maybe the pipe_grid_info::input field should be cons

[Mesa-dev] [PATCH v2] i965/vec4: pass the correct src_sz to emit_send at emit_untyped_atomic

2016-03-05 Thread Alejandro Piñeiro
If the src is invalid, so src size is zero, the src_sz passed to emit send should be zero too, instead of a default 1 if we are in a simd4x2 case. This can happens if using emit_untyped_atomic for an atomic dec/inc. v2: use the proper src_sz when calling emit_send, instead of just avoid loadin

Re: [Mesa-dev] [PATCH 5/5] st/dri: implement the GL interop DRI extension

2016-03-05 Thread Michel Dänzer
On 04.03.2016 04:46, Marek Olšák wrote: > > @@ -1417,6 +1422,254 @@ static const __DRIrobustnessExtension dri2Robustness > = { > .base = { __DRI2_ROBUSTNESS, 1 } > }; > > +#define offset_after(type, ptr, member) \ > + offsetof(type, member) + sizeof(ptr->member) > + > +static int > +dri2

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-05 Thread Michel Dänzer
On 04.03.2016 04:46, Marek Olšák wrote: > > +/** > + * Device information returned by Mesa. > + */ > +typedef struct _mesa_glinterop_device_info { > + uint32_t size; /* size of this structure */ Callees determine how much data they can write by looking at these size members of the *out paramete

Re: [Mesa-dev] [PATCH] mesa: Add GL_RED and GL_RG to ES3 effective internal format mapping.

2016-03-05 Thread Alejandro Piñeiro
On 05/03/16 07:49, Kenneth Graunke wrote: > The dEQP-GLES3.functional.fbo.completeness.renderable.texture. > {color0,depth,stencil}.{red,rg}_unsigned_byte tests appear to expect > GL_RED/GL_RG and GL_UNSIGNED_BYTE to map to GL_R8/GL_RG8, rather than > returning an INVALID_OPERATION error. > > This