On 03/05/2016 02:16 AM, Brian Paul wrote:
---
src/gallium/auxiliary/util/u_debug_refcnt.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug_refcnt.c
b/src/gallium/auxiliary/util/u_debug_refcnt.c
index f486492..c17c65f 100644
--- a/src/gallium/auxiliary/util/u_debug_refcnt.c
+++ b/src/gallium/auxiliary/util/u_debug_refcnt.c
@@ -26,9 +26,14 @@
#if defined(DEBUG)
-/* see http://www.mozilla.org/performance/refcnt-balancer.html for what do
with the output
- * on Linux, use tools/addr2line.sh to postprocess it before anything else
- **/
+/**
+ * If the GALLIUM_REFCNT_LOG env var is defined as a filename, gallium
+ * reference counting will be logged to the file.
+ *
+ * See http://www-archive.mozilla.org/performance/refcnt-balancer.html
+ * for what do with the output on Linux, use tools/addr2line.sh to
+ * postprocess it before anything else.
+ */
I suppose the comment above wanted to say "for what *to* do with..."
instead. If it does not, it still seems like wrong English to me. With
that fixed, all 4 patches are :
Reviewed-by: Eduardo Lima Mitev <el...@igalia.com>
#include <stdio.h>
@@ -201,4 +206,5 @@ debug_reference_slowpath(const struct pipe_reference *p,
fflush(stream);
}
}
-#endif
+
+#endif /* DEBUG */
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
