Re: [Mesa-dev] [PATCH] glsl: track total amount of uniform locations used

2016-01-10 Thread Tapani Pälli
On 01/08/2016 11:32 AM, Tapani Pälli wrote: On 01/08/2016 11:17 AM, Timothy Arceri wrote: On Fri, 2016-01-08 at 08:20 +0200, Tapani Pälli wrote: Linker missed a check for situation where we exceed max amount of uniform locations with explicit + implicit locations. Patch adds this check to a

[Mesa-dev] [PATCH 6/7] glsl: use explicit offset when lowering buffer access

2016-01-10 Thread Timothy Arceri
--- src/glsl/lower_buffer_access.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/lower_buffer_access.cpp b/src/glsl/lower_buffer_access.cpp index f8c8d14..ef1b1c5 100644 --- a/src/glsl/lower_buffer_access.cpp +++ b/src/glsl/lower_buffer_access.cpp @@ -439,6 +439,10 @@ lower_bu

[Mesa-dev] [PATCH 5/7] glsl: copy explicit offset to uniform storage

2016-01-10 Thread Timothy Arceri
--- src/glsl/link_uniform_blocks.cpp | 5 + src/glsl/link_uniforms.cpp | 13 + src/glsl/linker.h| 2 ++ 3 files changed, 20 insertions(+) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index 7d75576..c8fa181 100644 --- a/sr

[Mesa-dev] [PATCH 7/7] docs: mark explicit byte offsets as DONE

2016-01-10 Thread Timothy Arceri
--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index d8668d7..c64784c 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -180,7 +180,7 @@ GL 4.4, GLSL 4.40: GL_ARB_clear_texture DONE (i965, nv50, nvc0

[Mesa-dev] [PATCH 3/7] glsl: add offset to glsl interface type

2016-01-10 Thread Timothy Arceri
In this patch we also copy the offset value from the ast and implement offset linking rules by adding it to the record_compare() function. From Section 4.4.5 (Uniform and Shader Storage Block Layout Qualifiers) of the GLSL 4.50 spec: "Two blocks linked together in the same program with the sam

[Mesa-dev] [PATCH 1/7] glsl: enable offset layout qualifier for ARB_enhanced_layouts

2016-01-10 Thread Timothy Arceri
--- src/glsl/glsl_parser.yy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 6b634f2..b2b94f4 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1505,7 +1505,8 @@ layout_qualifier_id: $$.bind

[Mesa-dev] [PATCH 4/7] glsl: update comment on offset field

2016-01-10 Thread Timothy Arceri
The old comment was for the location not the offset, we now use the field for block members so mention that also. --- src/glsl/ir.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 7f5441f..b56ae8c 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.

[Mesa-dev] [PATCH 2/7] glsl: apply compile-time rules for the offset layout qualifier

2016-01-10 Thread Timothy Arceri
This implements the rules for the offset qualifier on block members. From Section 4.4.5 (Uniform and Shader Storage Block Layout Qualifiers) of the GLSL 4.50 spec: "The offset qualifier can only be used on block members of blocks declared with std140 or std430 layouts." ... "It is a

Re: [Mesa-dev] [PATCH] mesa/uniform_query: add IROUNDD and use for doubles->ints (v2)

2016-01-10 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Jan 10, 2016 at 7:57 PM, Dave Airlie wrote: > From: Dave Airlie > > For the case where we convert a double to an int, we should > round the same as we do for floats. > > This fixes GL41-CTS.gpu_shader_fp64.state_query > > v2: add IROUNDD (Ilia) > > Signed-off-by

[Mesa-dev] [PATCH] mesa/uniform_query: add IROUNDD and use for doubles->ints (v2)

2016-01-10 Thread Dave Airlie
From: Dave Airlie For the case where we convert a double to an int, we should round the same as we do for floats. This fixes GL41-CTS.gpu_shader_fp64.state_query v2: add IROUNDD (Ilia) Signed-off-by: Dave Airlie --- src/mesa/main/imports.h | 7 +++ src/mesa/main/uniform_query.cpp

Re: [Mesa-dev] [PATCH] Add missing platform information for KBL

2016-01-10 Thread Sarah Sharp
On Fri, Jan 08, 2016 at 04:30:20PM -0800, Mark Janes wrote: > In testing KBL, I found: > > - urb size was not set for slices gt1.5, gt2, and gt3. The value I >used for these slices (384) was taken from an earlier patch authored >by Ben Widawsky. > > - slice count was missing. This fie

Re: [Mesa-dev] [PATCH] Fix locking of GLsync objects

2016-01-10 Thread Steinar H. Gunderson
On Wed, Dec 09, 2015 at 11:42:59AM +0100, Steinar H. Gunderson wrote: >> Might be worth keeping _mesa_ref_sync_object(), even if it's an inline >> wrapper around the above. As things get a bit confusing - foo_get vs >> foo_unref. > What about _mesa_get_and_ref_sync()? Ping on this. >> Can you als

Re: [Mesa-dev] [PATCH] i965: Upload 3DSTATE_BINDING_TABLE_POINTERS_HS when !TCS on Gen9+.

2016-01-10 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-01-10 15:38:58, Kenneth Graunke wrote: > Gen9+ requires us to emit 3DSTATE_BINDING_TABLE_POINTERS_HS for the > hull shader push constants to take effect. The passthrough TCS uses > push constants for the default tessellation levels. So, when those > change, we

[Mesa-dev] [PATCH] i965: Upload 3DSTATE_BINDING_TABLE_POINTERS_HS when !TCS on Gen9+.

2016-01-10 Thread Kenneth Graunke
Gen9+ requires us to emit 3DSTATE_BINDING_TABLE_POINTERS_HS for the hull shader push constants to take effect. The passthrough TCS uses push constants for the default tessellation levels. So, when those change, we need to re-upload the binding table as well. Fixes five Piglit tests on Skylake: -

Re: [Mesa-dev] [PATCH v2] docs: Update todo regarding StencilOp and StencilOpSeparate.

2016-01-10 Thread Timothy Arceri
On Sun, 2016-01-10 at 17:13 +0100, Thomas Helland wrote: > > On Aug 20, 2015 3:30 PM, "Thomas Helland" > wrote: > > > > 2015-08-20 15:03 GMT+02:00 Rhys Kidd : > > > OpenGL 2.0 function StencilOp() is in part internally implemented > via > > > StencilOpSeparate(). This change happened some time ag

Re: [Mesa-dev] Hang in dri3_wait_for_event

2016-01-10 Thread Gustaw Smolarczyk
Hi, I have found additional information regarding this bug. It happens very often (~75%) when I move the chrome window between monitors. It's a simple multi-monitor setup, both of the adapters are connected to a single radeonsi GPU. I hope that helps somewhat. Regards, Gustaw 2016-01-08 18:44

[Mesa-dev] radeon cmask sync with EGL/GBM

2016-01-10 Thread Jay Cornwall
Hi, Using EGL with the GBM platform it is possible to bind a GBM surface to a GL renderbuffer. I believe it's also valid to use the GBM BO as a framebuffer target with drmModeAddFB/drmModePageFlip. I haven't been able to locate a clear statement on synchronizing GL operations with the DRM pa

Re: [Mesa-dev] [PATCH 9/9] st/mesa: add query buffer support

2016-01-10 Thread Ilia Mirkin
On Sun, Jan 10, 2016 at 8:49 AM, Marek Olšák wrote: > On Sun, Jan 10, 2016 at 6:14 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/state_tracker/st_cb_bufferobjects.c | 3 + >> src/mesa/state_tracker/st_cb_queryobj.c | 100 >> +- >> src/

Re: [Mesa-dev] [PATCH v2] docs: Update todo regarding StencilOp and StencilOpSeparate.

2016-01-10 Thread Thomas Helland
On Aug 20, 2015 3:30 PM, "Thomas Helland" wrote: > > 2015-08-20 15:03 GMT+02:00 Rhys Kidd : > > OpenGL 2.0 function StencilOp() is in part internally implemented via > > StencilOpSeparate(). This change happened some time ago, however the > > accompanying doxygen todo comment was not accordingly u

Re: [Mesa-dev] [PATCH 9/9] st/mesa: add query buffer support

2016-01-10 Thread Marek Olšák
On Sun, Jan 10, 2016 at 6:14 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_cb_bufferobjects.c | 3 + > src/mesa/state_tracker/st_cb_queryobj.c | 100 > +- > src/mesa/state_tracker/st_cb_texturebarrier.c | 3 + > src/mesa