[Mesa-dev] [PATCH shader-db 1/2] run: Add compute shader support.

2016-01-07 Thread Kenneth Graunke
--- run.c | 5 + 1 file changed, 5 insertions(+) diff --git a/run.c b/run.c index 82d8c91..a91b18d 100644 --- a/run.c +++ b/run.c @@ -84,6 +84,7 @@ get_shaders(const struct context_info *core, const struct context_info *compat, static const char *vs = "vertex "; static const char *

[Mesa-dev] [PATCH shader-db 2/2] run.py: Add compute shader support.

2016-01-07 Thread Kenneth Graunke
--- run.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/run.py b/run.py index ced8710..a0f1125 100755 --- a/run.py +++ b/run.py @@ -48,7 +48,7 @@ def run_test(filename): lines = (line for line in results.splitlines()) re_number = re.compile( -r'Nati

[Mesa-dev] [PATCH] glsl: track total amount of uniform locations used

2016-01-07 Thread Tapani Pälli
Linker missed a check for situation where we exceed max amount of uniform locations with explicit + implicit locations. Patch adds this check to already existing iteration over uniforms in linker. Fixes following CTS test: ES31-CTS.explicit_uniform_location.uniform-loc-negative-link-max-num-of

Re: [Mesa-dev] [PATCH 1/3] st/mesa: remove dead code from mesa_to_tgsi

2016-01-07 Thread eocallaghan
This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:12, Marek Olšák wrote: From: Marek Olšák These aren't part of ARB_fragment_program. --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 51 1 file changed, 51 deletions(-) diff --git a/src/mesa/s

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

2016-01-07 Thread eocallaghan
This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:30, Marek Olšák wrote: From: Marek Olšák It will become a system value, not an input. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 45 - 1 file changed, 22 insertions(+), 23 deletions(-) dif

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

2016-01-07 Thread eocallaghan
This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 12:29, Marek Olšák wrote: Hi, This series adds the possibility for drivers to get gl_FragCoord and gl_FrontFacing as system values. When FACE is a system value, it also changes its type to integer from floating-point. Each variabl

Re: [Mesa-dev] [PATCH 1/2] glsl: combine if blocks

2016-01-07 Thread eocallaghan
This series is: Reviewed-by: Edward O'Callaghan On 2016-01-08 15:25, Timothy Arceri wrote: --- src/glsl/link_uniforms.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 47bb771..33b2d4c 100644 --- a/sr

Re: [Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

2016-01-07 Thread Roland Scheidegger
Am 08.01.2016 um 05:01 schrieb Timothy Arceri: > On Thu, 2016-01-07 at 19:57 -0500, Nicolai Hähnle wrote: >> Hi, >> >> this series is intended to address a (big) part of the performance >> problems >> that occur when games use an index buffer from a VBO together with >> vertex >> attributes supplie

[Mesa-dev] [PATCH 2/2] glsl: replace unreachable code path with assert

2016-01-07 Thread Timothy Arceri
The lower_named_interface_blocks() pass is called before we try assign locations to varyings so this shouldn't be reachable. --- src/glsl/link_varyings.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 1a3

[Mesa-dev] [PATCH 1/2] glsl: combine if blocks

2016-01-07 Thread Timothy Arceri
--- src/glsl/link_uniforms.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 47bb771..33b2d4c 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -532,6 +532,8 @@ public:

Re: [Mesa-dev] [PATCH 01/28] glsl: only add outward facing varyings to resourse list for SSO

2016-01-07 Thread Timothy Arceri
On Thu, 2016-01-07 at 16:43 -0800, Ian Romanick wrote: > On 12/28/2015 09:00 PM, Timothy Arceri wrote: > > An SSO program can have multiple stages and we only want to add the > > externally > > facing varyings. The current code was adding both the packed inputs > > and outputs > > for the first and

Re: [Mesa-dev] [PATCH 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

2016-01-07 Thread Chris Forbes
I think this misses the image load/store case. (*samplerBuffer) - Chris From: Nicolai Hähnle Some games developers are unaware that an index buffer in a VBO still needs to be read by the CPU if some varying data comes from a user pointer (unless glDrawRangeElements and friends are used). This is

Re: [Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

2016-01-07 Thread Timothy Arceri
On Thu, 2016-01-07 at 19:57 -0500, Nicolai Hähnle wrote: > Hi, > > this series is intended to address a (big) part of the performance > problems > that occur when games use an index buffer from a VBO together with > vertex > attributes supplied by user pointer. On a lower-end Radeon (Carrizo), > i

Re: [Mesa-dev] [PATCH 09/23] radeonsi: use EXP_NULL for pixel shaders without outputs

2016-01-07 Thread Michel Dänzer
On 07.01.2016 20:45, Marek Olšák wrote: > On Thu, Jan 7, 2016 at 4:41 AM, Michel Dänzer wrote: >> On 06.01.2016 21:41, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This never happens currently. >> >> So this change is untested? If so, how confident are you that this won't >> break if it ever

Re: [Mesa-dev] [PATCH 3/8] gallium: add caps for POSITION and FACE system values

2016-01-07 Thread Ilia Mirkin
On Thu, Jan 7, 2016 at 8:29 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/docs/source/screen.rst | 5 + > src/gallium/docs/source/tgsi.rst | 6 -- > src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++ > src/gallium/drivers/i915/i915_s

Re: [Mesa-dev] [PATCH 1/4] mesa: merge bind_xfb_buffers_{base|range}

2016-01-07 Thread Ian Romanick
On 01/07/2016 05:22 PM, Ian Romanick wrote: > On 01/07/2016 04:33 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> Reduced code duplication should make the code more maintainable. >> --- >> src/mesa/main/bufferobj.c | 169 >> +++--- >> 1 file change

Re: [Mesa-dev] [PATCH] nv50/ir: don't touch degree on physreg RIG nodes

2016-01-07 Thread Ilia Mirkin
Withdrawn. This fix is bogus -- it doesn't actually fix the original issue! It's the result of me futzing a lot and a similar-but-different fix did change things around enough to fix the original issue but then proceeded to break other stuff. So... ignore. On Wed, Jan 6, 2016 at 5:30 PM, Ilia Mirk

Re: [Mesa-dev] [PATCH 01/28] glsl: only add outward facing varyings to resourse list for SSO

2016-01-07 Thread Ian Romanick
On 12/28/2015 09:00 PM, Timothy Arceri wrote: > An SSO program can have multiple stages and we only want to add the externally > facing varyings. The current code was adding both the packed inputs and > outputs > for the first and last stage of each program. Using just SSO and ARB_program_interfa

[Mesa-dev] [PATCH 3/8] gallium: add caps for POSITION and FACE system values

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 5 + src/gallium/docs/source/tgsi.rst | 6 -- src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++ src/gallium/drivers/i915/i915_screen.c | 2 ++ src/gallium/drivers/ilo/ilo_screen.c

[Mesa-dev] [PATCH 7/8] vl: allow fragment shader POSITION to be a system value

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/vl/vl_mc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_mc.c b/src/gallium/auxiliary/vl/vl_mc.c index 6c317bb..eb703a9 100644 --- a/src/gallium/auxiliary/vl/vl_mc.c +++ b/src/gallium/auxil

[Mesa-dev] [PATCH 6/8] util/pstipple: allow fragment shader POSITION to be a system value

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_pstipple.c| 30 -- src/gallium/auxiliary/util/u_pstipple.h| 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 3 ++- src/gallium/drivers/softpipe/sp_state_shader.c | 3 ++- src/gallium/drivers/svg

[Mesa-dev] [PATCH 8/8] nine: allow fragment shader POSITION and FACE to be system values

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/nine/nine_ff.c | 10 +- src/gallium/state_trackers/nine/nine_shader.c | 48 +-- 2 files changed, 46 insertions(+), 12 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_tracker

[Mesa-dev] [PATCH 2/2] radeonsi: move POSITION and FACE fragment shader inputs to system values

2016-01-07 Thread Marek Olšák
From: Marek Olšák And FACE becomes integer instead of float. --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +- src/gallium/drivers/radeonsi/si_shader.c| 58 ++--- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 +--- 3 files changed, 25 insertions(+),

[Mesa-dev] [PATCH 2/8] program: add a helper for rewriting FP position input to sysval

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/program/programopt.c | 27 +++ src/mesa/program/programopt.h | 2 ++ 2 files changed, 29 insertions(+) diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c index af78150..24dde57 100644 --- a/src/mesa/program/programo

[Mesa-dev] [PATCH 1/8] glsl: optionally declare gl_FragCoord & gl_FrontFacing as system values

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/glsl/ast_to_hir.cpp| 2 +- src/glsl/builtin_variables.cpp | 12 ++-- src/glsl/nir/shader_enums.h| 3 ++- src/mesa/main/mtypes.h | 4 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 5

[Mesa-dev] [PATCH 4/8] tgsi/scan: update for POSITION and FACE sytem values

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 6ea32ee..7a02e27 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_scan.c +++ b/s

[Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

2016-01-07 Thread Marek Olšák
From: Marek Olšák It will become a system value, not an input. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 45 - 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_st

[Mesa-dev] [PATCH 5/8] st/mesa: add support for POSITION and FACE system values

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 5 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 27 +++ src/mesa/state_tracker/st_mesa_to_tgsi.c | 23 --- src/mesa/state_tracker/st_program.c| 5 - 4 files change

[Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

2016-01-07 Thread Marek Olšák
Hi, This series adds the possibility for drivers to get gl_FragCoord and gl_FrontFacing as system values. When FACE is a system value, it also changes its type to integer from floating-point. Each variable has its own Const flag / Gallium CAP, so drivers can choose whether they want this for e

[Mesa-dev] [Bug 93570] the image of llvmpipe has a low quality on arm (with too many points on it)

2016-01-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93570 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/4] mesa: merge bind_xfb_buffers_{base|range}

2016-01-07 Thread Ian Romanick
On 01/07/2016 04:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reduced code duplication should make the code more maintainable. > --- > src/mesa/main/bufferobj.c | 169 > +++--- > 1 file changed, 56 insertions(+), 113 deletions(-) > > diff --gi

[Mesa-dev] [PATCH 1/3] st/mesa: remove dead code from mesa_to_tgsi

2016-01-07 Thread Marek Olšák
From: Marek Olšák These aren't part of ARB_fragment_program. --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 51 1 file changed, 51 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index 4b9dc99..d8f7b

[Mesa-dev] [PATCH 2/3] tgsi/ureg: remove index parameter from ureg_DECL_system_value

2016-01-07 Thread Marek Olšák
From: Marek Olšák It can be trivially derived from the number of already declared system values. This allows ureg users not to worry about which index to choose. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 12 ++-- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 1 - src/mesa/state_tr

[Mesa-dev] [PATCH 3/3] tgsi/ureg: handle redundant declarations in ureg_DECL_system_value

2016-01-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 9642723..5b78542 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_ureg.c +

[Mesa-dev] [PATCH 6/7] vbo: move vbo_get_minmax_indices into its own source file

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle We will add more code for caching/memoization. Moving the existing code into its own file helps keep things modular. --- src/mesa/Makefile.sources | 1 + src/mesa/vbo/vbo_exec_array.c | 148 - src/mesa/vbo/vbo_minmax_index.c | 179 ++

[Mesa-dev] [PATCH 4/7] mesa/main: add USAGE_PERSISTENT_WRITE_MAP flag to buffer UsageHistory

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle We will want to disable minmax index caching for buffers that are used in this way. --- src/mesa/main/bufferobj.c | 6 +- src/mesa/main/mtypes.h| 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

2016-01-07 Thread Nicolai Hähnle
Hi, this series is intended to address a (big) part of the performance problems that occur when games use an index buffer from a VBO together with vertex attributes supplied by user pointer. On a lower-end Radeon (Carrizo), it lifts This War Of Mine (the worst offender I've seen) from basically un

[Mesa-dev] [PATCH 2/7] mesa/main: add USAGE_TRANSFORM_FEEDBACK_BUFFER flag to buffer UsageHistory

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle We will want to disable minmax index caching for buffers that are used in this way. --- src/mesa/main/mtypes.h| 1 + src/mesa/main/transformfeedback.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5b

[Mesa-dev] [PATCH 1/7] util/hash_table: add _mesa_hash_table_clear

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/util/hash_table.c | 25 ++ src/util/hash_table.h | 2 + src/util/tests/hash_table/Makefile.am | 1 + src/util/tests/hash_table/clear.c | 91 +++ 4 files changed, 119 insertions(+) create m

[Mesa-dev] [PATCH 3/7] mesa/main: add USAGE_PIXEL_PACK_BUFFER flag to buffer UsageHistory

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle We will want to disable minmax index caching for buffers that are used in this way. --- src/mesa/main/bufferobj.c | 9 + src/mesa/main/mtypes.h| 1 + 2 files changed, 10 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index e2b60

Re: [Mesa-dev] [PATCH 17/28] glsl: enable lowering of varyings with explicit component

2016-01-07 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/ir_optimization.h | 3 ++- > src/glsl/link_varyings.cpp | 6 -- > src/glsl/lower_packed_varyings.cpp | 33 - > 3 files changed, 30 insertions(+), 12 deletions(-) > > diff

[Mesa-dev] [PATCH 5/7] mesa/main: bail earlier for size == 0 in _mesa_clear_buffer_sub_data

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Note that the conversion of the clear data (when data != NULL) can fail due to an out of memory condition, but it does not check any error conditions mandated by the spec. Therefore, it is safe to skip when size == 0. --- src/mesa/main/bufferobj.c | 16 1 fi

[Mesa-dev] [PATCH 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Some games developers are unaware that an index buffer in a VBO still needs to be read by the CPU if some varying data comes from a user pointer (unless glDrawRangeElements and friends are used). This is particularly bad when they tell us that the index buffer should live in

Re: [Mesa-dev] [PATCH 14/28] glsl: pass disable_varying_packing bool to the lowering pass

2016-01-07 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This will allow us to choose to ignore the disable which will be > useful for allowing support of the component layout qualifier while > still disabling packing for varyings without an explicit component. > --- > src/glsl/ir_optimization.h

Re: [Mesa-dev] [PATCH 3/5] radeon: use _mesa_delete_buffer_object

2016-01-07 Thread Nicolai Hähnle
On 07.01.2016 16:58, Ian Romanick wrote: On 01/05/2016 06:53 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle This is more future-proof, plugs the memory leak of Label and properly destroys the buffer mutex. --- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 ins

Re: [Mesa-dev] [PATCH 13/28] glsl: include varyings with explicit locations in slot count

2016-01-07 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This count is used by the packing pass and we need to include > varying with explicit locations to be able to pack varyings > with explicit components. > --- > src/glsl/link_varyings.cpp | 9 +++-- > 1 file changed, 7 insertions(+), 2 d

[Mesa-dev] [PATCH 3/4] mesa: merge bind_shader_storage_buffers_{base|range}

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 160 +++--- 1 file changed, 50 insertions(+), 110 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b

[Mesa-dev] [PATCH 4/4] mesa: merge bind_atomic_buffers_{base|range}

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 154 +++--- 1 file changed, 48 insertions(+), 106 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 7

[Mesa-dev] [PATCH 0/4] mesa/bufferobj: reduce code duplication

2016-01-07 Thread Nicolai Hähnle
Hi, four pretty much identical patches for the different targets of BindBuffersBase/Range handling. I was going through the code and this seemed like a good idea. Cheers, Nicolai -- src/mesa/main/bufferobj.c | 640 +--- 1 file changed, 203 insertions(+), 437 d

[Mesa-dev] [PATCH 1/4] mesa: merge bind_xfb_buffers_{base|range}

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 169 +++--- 1 file changed, 56 insertions(+), 113 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index a

[Mesa-dev] [PATCH 2/4] mesa: merge bind_uniform_buffers_{base|range}

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 155 ++ 1 file changed, 48 insertions(+), 107 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index f

Re: [Mesa-dev] [PATCH V3 11/28] glsl: cross validate varyings with a component qualifier

2016-01-07 Thread Anuj Phogat
On Thu, Jan 7, 2016 at 3:15 PM, Timothy Arceri wrote: > This change checks for component overlap, including handling overlap of > locations and components by doubles. Previously there was no validation > for assigning explicit locations to a location used by the second half > of a double. > > V3:

Re: [Mesa-dev] [PATCH 11/28] glsl: cross validate varyings with a component qualifier

2016-01-07 Thread Timothy Arceri
On Thu, 2016-01-07 at 13:47 -0800, Anuj Phogat wrote: > On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri > wrote: > > This change checks for component overlap, including handling > > overlap of > > locations and components by doubles. Previously there was no > > validation > > for assigning explici

Re: [Mesa-dev] [PATCH] mesa: Mark Identity as const

2016-01-07 Thread Ilia Mirkin
On Thu, Jan 7, 2016 at 6:16 PM, Ian Romanick wrote: > From: Ian Romanick > > I was going to send this as review for dce1e1a8, but I missed that > window. This saves 64 bytes of unshared data and prelaces it with 96 replaces > bytes shared text. My guess is that some of the calls to memcpy get

[Mesa-dev] [PATCH V3 11/28] glsl: cross validate varyings with a component qualifier

2016-01-07 Thread Timothy Arceri
This change checks for component overlap, including handling overlap of locations and components by doubles. Previously there was no validation for assigning explicit locations to a location used by the second half of a double. V3: simplify handling of doubles and fix double component aliasing det

[Mesa-dev] [PATCH] mesa: Mark Identity as const

2016-01-07 Thread Ian Romanick
From: Ian Romanick I was going to send this as review for dce1e1a8, but I missed that window. This saves 64 bytes of unshared data and prelaces it with 96 bytes shared text. My guess is that some of the calls to memcpy get optimized to something else. textdata bss dec hex fi

Re: [Mesa-dev] [PATCH] mesa: check that internalformat of CopyTexImage*D is not 1, 2, 3, 4

2016-01-07 Thread Ian Romanick
On 01/07/2016 12:31 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The piglit copyteximage check has recently been augmented to test this, but > apparently it hasn't been fixed in Mesa so far. > --- > src/mesa/main/teximage.c | 16 > 1 file changed, 16 insertions(+) > > d

Re: [Mesa-dev] [PATCH v2] vbo: create a new draw function interface for indirect draws

2016-01-07 Thread Ian Romanick
If we decide we want more or less in the interface later, we should be able to change it easily. This patch is Reviewed-by: Ian Romanick On 01/04/2016 08:20 PM, Ilia Mirkin wrote: > All indirect draws are passed to the new draw function. By default > there's a fallback implementation which pipe

Re: [Mesa-dev] [PATCH 3/5] radeon: use _mesa_delete_buffer_object

2016-01-07 Thread Ian Romanick
On 01/05/2016 06:53 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is more future-proof, plugs the memory leak of Label and properly > destroys the buffer mutex. > --- > src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [Mesa-dev] [PATCH 12/28] glsl: update explicit location matching to support component qualifier

2016-01-07 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This is needed so we don't optimise away the varying when more than > one shares the same location. > --- > src/glsl/linker.cpp | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/linker.cpp b/src/glsl

Re: [Mesa-dev] [PATCH 1/5] mesa/bufferobj: make _mesa_delete_buffer_object externally accessible

2016-01-07 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick I'm sending a comment on patch 3. When this series lands, I think it should also get tagged for stable. Cc: "11.0 11.1" On 01/05/2016 06:53 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > gl_buffer_object has grown more complicated and requires

Re: [Mesa-dev] [PATCH 11/28] glsl: cross validate varyings with a component qualifier

2016-01-07 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This change checks for component overlap, including handling overlap of > locations and components by doubles. Previously there was no validation > for assigning explicit locations to a location used by the second half > of a double. > > V2:

Re: [Mesa-dev] [PATCH] draw: initialize prim header flags when clipping lines

2016-01-07 Thread Jose Fonseca
On 07/01/16 18:39, srol...@vmware.com wrote: From: Roland Scheidegger Otherwise, clipped lines would have undefined stippling reset bit if line stippling is enabled. (Untested, and I just assume copying over the bits from the original line is actually the right thing to do.) --- src/gallium/a

Re: [Mesa-dev] [PATCH v2] configure.ac: add --enable-profile

2016-01-07 Thread Jose Fonseca
Thanks for the update. autotools is not my forte, but changes looks good AFAICT. Reviewed-by: Jose Fonseca Jose On 07/01/16 17:01, Oded Gabbay wrote: For profiling mesa's code, especially llvmpipe, PROFILE should be defined. Currently, this define can only be generated if mesa is built using

Re: [Mesa-dev] [PATCH] llvmpipe: use sse2 conv code for altivec

2016-01-07 Thread Jose Fonseca
On 07/01/16 18:18, Oded Gabbay wrote: In lp_build_conv() and lp_build_conv_auto(), there is a special case of conversion when sse2 is present. That code path is suitable without any changes to altivec, because all the functions that are called in that code path already support altivec. This patc

[Mesa-dev] [PATCH] mesa: check that internalformat of CopyTexImage*D is not 1, 2, 3, 4

2016-01-07 Thread Nicolai Hähnle
From: Nicolai Hähnle The piglit copyteximage check has recently been augmented to test this, but apparently it hasn't been fixed in Mesa so far. --- src/mesa/main/teximage.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH 3/3] i965/compiler: Enable more lowering in NIR

2016-01-07 Thread Matt Turner
With Iago's fix to 2/3, the series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: Add more lowering

2016-01-07 Thread Matt Turner
On Thu, Jan 7, 2016 at 10:21 AM, Iago Toral wrote: > On Wed, 2016-01-06 at 15:30 -0800, Jason Ekstrand wrote: >> This commit adds lowering options for the following opcodes: >> >> - nir_op_fmod >> - nir_op_bitfield_insert >> - nir_op_uadd_carry >> - nir_op_usub_borrow >> --- >> src/glsl/nir/n

Re: [Mesa-dev] [PATCH] glsl: replace null check with assert

2016-01-07 Thread Matt Turner
Have a Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

2016-01-07 Thread Roland Scheidegger
Am 07.01.2016 um 16:40 schrieb Jose Fonseca: > On 07/01/16 06:18, Roland Scheidegger wrote: >> Am 04.01.2016 um 20:38 schrieb Jose Fonseca: >>> On 02/01/16 20:39, srol...@vmware.com wrote: From: Roland Scheidegger This is quite a few less instructions, albeit still do the 2 64bit mu

[Mesa-dev] [PATCH] draw: initialize prim header flags when clipping lines

2016-01-07 Thread sroland
From: Roland Scheidegger Otherwise, clipped lines would have undefined stippling reset bit if line stippling is enabled. (Untested, and I just assume copying over the bits from the original line is actually the right thing to do.) --- src/gallium/auxiliary/draw/draw_pipe_clip.c | 2 ++ 1 file ch

[Mesa-dev] [Bug 93633] Assertion `texFormat != MESA_FORMAT_NONE' failed.

2016-01-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93633 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 93633] Assertion `texFormat != MESA_FORMAT_NONE' failed.

2016-01-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93633 --- Comment #2 from earl.malmr...@gmail.com --- Mint 17.3 is a brand new release. Mesa 11.0 (Ubuntu 16.04 Alpha 1) works fine. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

Re: [Mesa-dev] [PATCH 1/2] gallium/aux: Use TGSI chan name defines inplace of literals

2016-01-07 Thread Nicolai Hähnle
Series is: Reviewed-by: Nicolai Hähnle On 07.01.2016 11:44, Edward O'Callaghan wrote: Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/tgsi/tgsi_util.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/

[Mesa-dev] [Bug 93633] Assertion `texFormat != MESA_FORMAT_NONE' failed.

2016-01-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93633 --- Comment #1 from Ilia Mirkin --- Does this still happen with Mesa 11.1? Mesa 10.5 is pretty ancient. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

[Mesa-dev] [PATCH 1/2] gallium/aux: Use TGSI chan name defines inplace of literals

2016-01-07 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/tgsi/tgsi_util.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.c b/src/gallium/auxiliary/tgsi/tgsi_util.c index 653e650..5fff3f0 100644 --- a/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-llvmpipe-profile

2016-01-07 Thread Jose Fonseca
On 07/01/16 16:27, Oded Gabbay wrote: To profile llvmpipe you need to define PROFILE in mesa's code. Currently, this define can only be generated if mesa is built using scons. This patch makes it possible to generate this define also when building mesa through automake tools. Signed-off-by: Oded

[Mesa-dev] [Bug 93633] Assertion `texFormat != MESA_FORMAT_NONE' failed.

2016-01-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93633 Bug ID: 93633 Summary: Assertion `texFormat != MESA_FORMAT_NONE' failed. Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH] configure.ac: add --enable-llvmpipe-profile

2016-01-07 Thread Oded Gabbay
To profile llvmpipe you need to define PROFILE in mesa's code. Currently, this define can only be generated if mesa is built using scons. This patch makes it possible to generate this define also when building mesa through automake tools. Signed-off-by: Oded Gabbay --- configure.ac | 15

Re: [Mesa-dev] [PATCH] draw: fix line stippling with unfilled prims

2016-01-07 Thread Jose Fonseca
On 06/01/16 22:26, srol...@vmware.com wrote: From: Roland Scheidegger The unfilled stage was not filling in the prim header, and the line stage then decided to reset the stipple counter or not based on the uninitialized data. This causes some failures in conform linestipple test (albeit quite r

Re: [Mesa-dev] [PATCH 3/3] i965/compiler: Enable more lowering in NIR

2016-01-07 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2016-01-06 at 15:30 -0800, Jason Ekstrand wrote: > We don't need these for GLSL or ARB, but we need them for SPIR-V > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: Add more lowering

2016-01-07 Thread Iago Toral
On Wed, 2016-01-06 at 15:30 -0800, Jason Ekstrand wrote: > This commit adds lowering options for the following opcodes: > > - nir_op_fmod > - nir_op_bitfield_insert > - nir_op_uadd_carry > - nir_op_usub_borrow > --- > src/glsl/nir/nir.h| 4 > src/glsl/nir/nir_opt_algebrai

Re: [Mesa-dev] [PATCH 09/23] radeonsi: use EXP_NULL for pixel shaders without outputs

2016-01-07 Thread Marek Olšák
On Thu, Jan 7, 2016 at 4:41 AM, Michel Dänzer wrote: > On 06.01.2016 21:41, Marek Olšák wrote: >> From: Marek Olšák >> >> This never happens currently. > > So this change is untested? If so, how confident are you that this won't > break if it ever actually gets hit? :) I tested it by enforcing i