Re: [Mesa-dev] [PATCH 1/2] gallium/util: move conditional from _pipe_debug_message() to macro

2015-12-04 Thread Jose Fonseca
I suspect that adding the check in the macro amight cause compilers to warn that "taking the address of cb can never be false". Either way, series is Reviewed-by: Jose Fonseca On 05/12/15 02:17, Ilia Mirkin wrote: Actually nouveau can, in some situations, pass in a null debug object. I ha

Re: [Mesa-dev] [PATCH 2/2] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 7:52 PM, Brian Paul wrote: > Use the new debug callback hook to report conformance, performance > and fallbacks to the state tracker. The state tracker, in turn can > report this issues to the user via the GL_ARB_debug_output extension. > > More issues can be reported in th

Re: [Mesa-dev] [PATCH 1/2] gallium/util: move conditional from _pipe_debug_message() to macro

2015-12-04 Thread Ilia Mirkin
Actually nouveau can, in some situations, pass in a null debug object. I have a thing in the fence wait to say how long it waited, which can be invoked without a pipe_context, and hence no debug object. Other (most) times it will be invoked with a pipe_context in hand and be able to log the message

Re: [Mesa-dev] [PATCH v3 10/44] i965: Define and use REG_MASK macro to make masked MMIO writes slightly more readable.

2015-12-04 Thread Kristian Høgsberg
On Tue, Dec 01, 2015 at 12:19:28AM -0800, Jordan Justen wrote: > From: Francisco Jerez > > Reviewed-by: Samuel Iglesias Gonsálvez > --- > src/mesa/drivers/dri/i965/brw_defines.h | 6 ++ > src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- > src/mesa/drivers/dri/i965/gen7_l3_state.c

Re: [Mesa-dev] [PATCH 01/26] nir: Add a writemask to store intrinsics.

2015-12-04 Thread Kenneth Graunke
On Friday, December 04, 2015 04:45:03 PM Jason Ekstrand wrote: > On Wed, Dec 2, 2015 at 4:15 PM, Kenneth Graunke wrote: > > Tessellation control shaders need to be careful when writing outputs. > > Because multiple threads can concurrently write the same output > > variables, we need to only write

Re: [Mesa-dev] [PATCH 02/26] nir: Use writemasked store_vars in glsl_to_nir.

2015-12-04 Thread Jason Ekstrand
Yeah, I like this. On Wed, Dec 2, 2015 at 4:15 PM, Kenneth Graunke wrote: > Instead of performing the read-modify-write cycle in glsl->nir, we can > simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will > do the equivalent read-modify-write cycle for us, so we continue to get >

[Mesa-dev] [PATCH 2/2] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Brian Paul
Use the new debug callback hook to report conformance, performance and fallbacks to the state tracker. The state tracker, in turn can report this issues to the user via the GL_ARB_debug_output extension. More issues can be reported in the future; this is just a start. v2: remove conditionals aro

[Mesa-dev] [PATCH 1/2] gallium/util: move conditional from _pipe_debug_message() to macro

2015-12-04 Thread Brian Paul
To avoid function calls when the pointer is null. Also, assert that the pipe_debug_callback object is non-null. It looks like all the drivers which use this feature never pass a non-null pointer. --- src/gallium/auxiliary/util/u_debug.c | 3 +-- src/gallium/auxiliary/util/u_debug.h | 9 ++---

Re: [Mesa-dev] [PATCH 01/26] nir: Add a writemask to store intrinsics.

2015-12-04 Thread Jason Ekstrand
On Wed, Dec 2, 2015 at 4:15 PM, Kenneth Graunke wrote: > Tessellation control shaders need to be careful when writing outputs. > Because multiple threads can concurrently write the same output > variables, we need to only write the exact components we were told. > > Traditionally, for sub-vector w

[Mesa-dev] [Bug 93257] [SKL, bisected] ASTC dEQP tests segfault

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93257 Nanley Chery changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 QA Contact|mesa-

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: always re-validate program pipeline

2015-12-04 Thread Kenneth Graunke
On Wednesday, December 02, 2015 10:45:02 AM Timothy Arceri wrote: > On Tue, 2015-12-01 at 13:46 +0200, Tapani Pälli wrote: > > On 12/01/2015 02:13 AM, Timothy Arceri wrote: > > > Just because the validation passed the last time is was called > > > doesn't > > > automatically mean it will pass again

[Mesa-dev] [Bug 93257] [SKL, bisected] ASTC dEQP tests segfault

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93257 Bug ID: 93257 Summary: [SKL, bisected] ASTC dEQP tests segfault Product: Mesa Version: git Hardware: Other OS: All Status: ASSIGNED Severity: normal

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 6:32 PM, Jose Fonseca wrote: > On 04/12/15 23:27, Ilia Mirkin wrote: >> >> On Fri, Dec 4, 2015 at 6:25 PM, Jose Fonseca wrote: >>> >>> On 04/12/15 19:42, Brian Paul wrote: Use the new debug callback hook to report conformance, performance and fallbacks t

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 23:27, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 6:25 PM, Jose Fonseca wrote: On 04/12/15 19:42, Brian Paul wrote: Use the new debug callback hook to report conformance, performance and fallbacks to the state tracker. The state tracker, in turn can report this issues to the user

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 6:25 PM, Jose Fonseca wrote: > On 04/12/15 19:42, Brian Paul wrote: >> >> Use the new debug callback hook to report conformance, performance >> and fallbacks to the state tracker. The state tracker, in turn can >> report this issues to the user via the GL_ARB_debug_output e

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 19:42, Brian Paul wrote: Use the new debug callback hook to report conformance, performance and fallbacks to the state tracker. The state tracker, in turn can report this issues to the user via the GL_ARB_debug_output extension. More issues can be reported in the future; this is jus

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 23:20, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 6:14 PM, Jose Fonseca wrote: On 04/12/15 22:40, Jose Fonseca wrote: On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 23:08, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 6:00 PM, Jose Fonseca wrote: On 04/12/15 22:45, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 5:40 PM, Jose Fonseca wrote: On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 1

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 6:14 PM, Jose Fonseca wrote: > On 04/12/15 22:40, Jose Fonseca wrote: >> >> On 04/12/15 20:04, Ilia Mirkin wrote: >>> >>> On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: > > > On Fri, Dec 4, 2015 at 2:42 PM,

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 22:40, Jose Fonseca wrote: On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: + if (templ->poly_smooth && svga->debug.callback.debug_message) { +

[Mesa-dev] [PATCH v2 6/9] i965/vec4: Get rid of load/store_foo_indirect

2015-12-04 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp | 7 +-- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 91 +++ 2 files changed, 40 insertions(+), 58 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cp

[Mesa-dev] [PATCH v2 9/9] vc4/nir: Use the new unified io intrinsics

2015-12-04 Thread Jason Ekstrand
Cc: Eric Anholt --- src/gallium/drivers/vc4/vc4_nir_lower_io.c | 16 ++- src/gallium/drivers/vc4/vc4_program.c | 31 -- 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_nir_lower_io.c b/src/gallium/drivers/v

[Mesa-dev] [PATCH v2 7/9] tgsi_to_nir: Get rid of load/store_foo_indirect

2015-12-04 Thread Jason Ekstrand
Cc: Eric Anholt Cc: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 51 + 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 5fef542..480c0b9 100644 --- a

[Mesa-dev] [PATCH v2 4/9] nir/lower_io: Get rid of load/store_foo_indirect

2015-12-04 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 2 +- src/glsl/nir/nir_lower_io.c | 111 +--- 2 files changed, 44 insertions(+), 69 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index e161b70..2e72e66 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/n

[Mesa-dev] [PATCH v2 8/9] ir3/nir: Use the new unified io intrinsics

2015-12-04 Thread Jason Ekstrand
Cc: Rob Clark --- .../drivers/freedreno/ir3/ir3_compiler_nir.c | 79 +- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c b/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c index 8617704..99b4264 100

[Mesa-dev] [PATCH v2 5/9] i965/fs: Get rid of load/store_foo_indirect

2015-12-04 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 153 ++- src/mesa/drivers/dri/i965/brw_nir.c | 45 +++-- 3 files changed, 105 insertions(+), 95 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/s

[Mesa-dev] [PATCH v2 0/9] nir: Remove the *_indirect form of input/output

2015-12-04 Thread Jason Ekstrand
This is a second crack at my attempt to get rid of the *_indirect for of the input/output intrinsics. The primary change is that we decided to keep the const_index[0] base offset for all of the load/store intrinsics that operate on opaque memory. Along with this, the base offset is now much bette

[Mesa-dev] [PATCH v2 2/9] nir: Get rid of *_indirect variants of input/output load/store intrinsics

2015-12-04 Thread Jason Ekstrand
There is some special-casing needed in a competent back-end. However, they can do their special-casing easily enough based on whether or not the offset is a constant. In the mean time, having the *_indirect variants adds special cases a number of places where they don't need to be and, in general

[Mesa-dev] [PATCH v2 3/9] nir/glsl: Stop handling UBO/SSBO load/stores differently depending on indirect

2015-12-04 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 47 +++- 1 file changed, 7 insertions(+), 40 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 45d045c..ba23b91 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to

[Mesa-dev] [PATCH v2 1/9] vc4: Do all uniform loads with byte offsets

2015-12-04 Thread Jason Ekstrand
Previously, we lowered direct uniform loads to dword offsets and indirect loads to byte offsets in vc4_nir_lower_io. However, it simplifies things a bit if we just use byte offsets for everything and then divide by 4 when we handle the direct uniform load. Cc: Eric Anholt --- src/gallium/driver

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 6:00 PM, Jose Fonseca wrote: > On 04/12/15 22:45, Ilia Mirkin wrote: >> >> On Fri, Dec 4, 2015 at 5:40 PM, Jose Fonseca wrote: >>> >>> On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: > > > On 12/04/2015 12:

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 23:00, Jose Fonseca wrote: On 04/12/15 22:45, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 5:40 PM, Jose Fonseca wrote: On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:4

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 22:45, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 5:40 PM, Jose Fonseca wrote: On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: + if (temp

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 5:40 PM, Jose Fonseca wrote: > On 04/12/15 20:04, Ilia Mirkin wrote: >> >> On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: >>> >>> On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: > > > + if (templ-

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Jose Fonseca
On 04/12/15 20:04, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: + if (templ->poly_smooth && svga->debug.callback.debug_message) { + /* note: we always need a % someth

Re: [Mesa-dev] [RFC] r600g: evergreen/cayman tessellation support

2015-12-04 Thread Dieter Nützel
Am 04.12.2015 08:48, schrieb eocallag...@alterapraxis.com: On 2015-12-04 14:03, Dieter Nützel wrote: Am 03.12.2015 19:57, schrieb Dave Airlie: On 4 Dec 2015 03:01, "Aaron Watry" wrote: Hi Dave (and others), I cloned your fdo r600g-tess-submit branch and gave it a spin on CEDAR (Radeon 5400

[Mesa-dev] [Bug 93188] "nir/nir.h", line 552: Error: Unexpected type name "nir_src" encountered.

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93188 --- Comment #6 from Jason Ekstrand --- I had a patch at one point to help C++ out here. I ended up not sending it out because it only fixed warnings that only came up if you had extra warnings turned on. basically it boiled down to #ifdef __cp

[Mesa-dev] [PATCH] nv50/ir: fold shl + mul with immediates

2015-12-04 Thread Ilia Mirkin
On SM35 this gives: total instructions in shared programs : 6185058 -> 6181090 (-0.06%) total gprs used in shared programs: 910722 -> 910722 (0.00%) total local used in shared programs : 39072 -> 39072 (0.00%) localgpr inst bytes helped 0

[Mesa-dev] [PATCH 2/2] nv50/ir: propagate indirect loads into instructions

2015-12-04 Thread Ilia Mirkin
This way $r1 = $r0 + 4; c1[$r1] becomes c1[$r0+4]. On SM35: total instructions in shared programs : 6206257 -> 6185058 (-0.34%) total gprs used in shared programs: 911045 -> 910722 (-0.04%) total local used in shared programs : 39072 -> 39072 (0.00%) localgpr

[Mesa-dev] [PATCH 1/2] nv50/ir: flip shl(add, imm) into add(shl, imm)

2015-12-04 Thread Ilia Mirkin
This works when the add also has an immediate. This often happens in address calculations. These addresses can then be inlined as well. On code targeted to SM35: total instructions in shared programs : 6223346 -> 6206257 (-0.27%) total gprs used in shared programs: 911075 -> 911045 (-0.00%) t

Re: [Mesa-dev] [PATCH 1/2] radeonsi: apply the streamout workaround to Fiji as well

2015-12-04 Thread Alex Deucher
On Fri, Dec 4, 2015 at 3:27 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 11.0 11.1 For the series: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_

Re: [Mesa-dev] [PATCH] radeonsi: disable DCC on Stoney

2015-12-04 Thread Alex Deucher
On Fri, Dec 4, 2015 at 2:35 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 11.0 11.1 Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/r600_texture.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/radeon/r600_texture.c > b/src/gallium/drivers

[Mesa-dev] [PATCH 1/2] radeonsi: apply the streamout workaround to Fiji as well

2015-12-04 Thread Marek Olšák
From: Marek Olšák Cc: 11.0 11.1 --- src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 771d206..ee84a1f 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 2/2] radeonsi: don't use the CP DMA workaround on Fiji and newer

2015-12-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 36 ++-- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c index 0bf85a0..a5e3d79 100644 --- a/src/galli

Re: [Mesa-dev] [PATCH] gallium/util: fix pipe_debug_message macro to allow 0 args

2015-12-04 Thread Brian Paul
On 12/04/2015 01:09 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index aaf223c..9900703 100644 --- a/s

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #24 from Tobias Klausmann --- (In reply to poma from comment #22) > (In reply to Tobias Klausmann from comment #21) > > (In reply to Axel Davy from comment #20) > > > Should this bug report be closed ? > > > DRI3 has complete DRI_PRIM

[Mesa-dev] [PATCH] gallium/util: fix pipe_debug_message macro to allow 0 args

2015-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index aaf223c..9900703 100644 --- a/src/gallium/auxiliary/util/u_debug.h +++ b/src/g

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 3:01 PM, Brian Paul wrote: > On 12/04/2015 12:46 PM, Ilia Mirkin wrote: >> >> On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: >>> >>> + if (templ->poly_smooth && svga->debug.callback.debug_message) { >>> + /* note: we always need a % something in the message string

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Brian Paul
On 12/04/2015 12:46 PM, Ilia Mirkin wrote: On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: + if (templ->poly_smooth && svga->debug.callback.debug_message) { + /* note: we always need a % something in the message string */ Why? Did I mess something up? If I write it without the dumm

Re: [Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Ilia Mirkin
On Fri, Dec 4, 2015 at 2:42 PM, Brian Paul wrote: > + if (templ->poly_smooth && svga->debug.callback.debug_message) { > + /* note: we always need a % something in the message string */ Why? Did I mess something up? BTW, right now this callback is only set for debug contexts. Perhaps that

[Mesa-dev] [PATCH] svga: use the debug callback to report issues to the state tracker

2015-12-04 Thread Brian Paul
Use the new debug callback hook to report conformance, performance and fallbacks to the state tracker. The state tracker, in turn can report this issues to the user via the GL_ARB_debug_output extension. More issues can be reported in the future; this is just a start. --- src/gallium/drivers/svg

Re: [Mesa-dev] [PATCH 06/10] i965/fs: Get rid of load/store_foo_indirect

2015-12-04 Thread Jason Ekstrand
On Wed, Dec 2, 2015 at 12:33 AM, Kenneth Graunke wrote: > On Wednesday, November 25, 2015 09:00:09 PM Jason Ekstrand wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.h | 3 +- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 145 >> ++- >> src/mesa/drivers/dri/i

[Mesa-dev] [PATCH] radeonsi: disable DCC on Stoney

2015-12-04 Thread Marek Olšák
From: Marek Olšák Cc: 11.0 11.1 --- src/gallium/drivers/radeon/r600_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index e2947d9..e7b2aea 100644 --- a/src/gallium/drivers/radeon/r600_textur

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #23 from poma --- (In reply to Axel Davy from comment #20) > Should this bug report be closed ? > DRI3 has complete DRI_PRIME support now. > Actually, I have some questions, but if you closing, bye bye. > Also I'm not sure why you

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #22 from poma --- (In reply to Tobias Klausmann from comment #21) > (In reply to Axel Davy from comment #20) > > Should this bug report be closed ? > > DRI3 has complete DRI_PRIME support now. > > > > As far as it concerns me, DRI3

[Mesa-dev] [PATCH 2/3] winsys/amdgpu: addrlib - port Checks mip 0 for czDispCompatible

2015-12-04 Thread Marek Olšák
From: Sonny Jiang Change-Id: I3a6ae6b76b13aa95103f68ca3a2a8d03d5d0aeb1 Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher --- src/gallium/winsys/amdgpu/drm/addrlib/r800/egbaddrlib.cpp | 4 +++- src/gallium/winsys/amdgpu/drm/addrlib/r800/egbaddrlib.h | 3 ++- 2 files changed, 5 insertions(

[Mesa-dev] [PATCH 1/3] winsys/amdgpu: addrlib - port fix error for workaround for 1D tiling

2015-12-04 Thread Marek Olšák
From: Sonny Jiang Change-Id: I1383d2b2670ed02bc6a6761531ee20f27fd6492f Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher --- src/gallium/winsys/amdgpu/drm/addrlib/r800/egbaddrlib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/addrlib/r

[Mesa-dev] [PATCH 3/3] winsys/amdgpu: addrlib - port a Fiji bug fix

2015-12-04 Thread Marek Olšák
From: Sonny Jiang Fiji: Fixed tiled resource failures Change-Id: Idbad4c09ded6dd5cb28d6342f9b04a3345377c82 Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher --- .../winsys/amdgpu/drm/addrlib/r800/ciaddrlib.cpp | 45 +- .../winsys/amdgpu/drm/addrlib/r800/ciaddrlib.h

Re: [Mesa-dev] [PATCH] nir: Optimize useless comparisons against true/false.

2015-12-04 Thread Neil Roberts
Matt Turner writes: > # Written in the form (, ) where is an expression > # and is either an expression or a value. An expression is > # defined as a tuple of the form (, , , , ) > @@ -94,6 +97,8 @@ optimizations = [ > (('inot', ('ige', a, b)), ('ilt', a, b)), > (('inot', ('ieq', a,

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

2015-12-04 Thread Giuseppe Bilotta
> Hmm I thought I pushed those in a couple of days ago. Doing it now, thanks ! No, thank you 8-) >> This is one of those >> contexts in which things could be done marginally more elegantly with >> C++. I am proficient enough with C macros and xincludes that I could >> probably hack together somet

Re: [Mesa-dev] [PATCH 3/3v2] xvmc: force assertion in XvMC tests

2015-12-04 Thread Giuseppe Bilotta
Hello Emil, >> The comment on u_atomic_test.c is also fixed (read 'debug' where it >> should have been 'release'). > I've split that one to a separate patch, but for the future please do > so during submission. Doh, sorry. > Also can you take a look at the list of patches you've submitted [1] >

Re: [Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

2015-12-04 Thread eocallaghan
On 2015-12-05 01:33, Emil Velikov wrote: Hi Edward, A few trivial suggestions (for future patches) and a humble request On 4 December 2015 at 06:50, Edward O'Callaghan wrote: Signed-off-by: Edward O'Callaghan --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++ For the patches do

[Mesa-dev] [Bug 91806] configure does not test whether assembler supports sse4.1

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91806 --- Comment #2 from Jonathan Gray --- gcc returns 1. I tried various changes to configure.ac but didn't get anywhere. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #8 from Jonathan Gray --- There is no way to backport builtins for architectures that lack atomics at the ISA level. On arm/hppa/sh linux has a syscall which the gcc documentation claims can only do 64 bit values on arm: https://gcc.

[Mesa-dev] [Bug 91806] configure does not test whether assembler supports sse4.1

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91806 --- Comment #1 from Emil Velikov --- In the failing case does gcc return a non zero value ? I'm leaning that this is some sort of GCC/autotools bug as to the best of my knowledge we're doing things the "right way" (almost identical hunk is being

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #7 from Emil Velikov --- What Matt is saying is that surely Mesa is not the only project out there which relies on atomics, thus adding (backporting) those in GCC wouldn't be that bad of an idea. That aside I'm thinking that porting

[Mesa-dev] [Bug 93188] "nir/nir.h", line 552: Error: Unexpected type name "nir_src" encountered.

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93188 --- Comment #5 from Emil Velikov --- (In reply to Ian Romanick from comment #4) > I guess the question is whether or not this builds with Visual Studio's C++ > compiler. If not, maybe we should reopen with changes to the summary? Afaict MSVC wa

[Mesa-dev] [PATCH v3 1/1] i965: add opportunistic behaviour to opt_vector_float()

2015-12-04 Thread Juan A. Suarez Romero
opt_vector_float() transforms several scalar MOV operations to a single vectorial MOV. This is done when those MOV covers all the components of the destination register. So something like: mov vgrf3.0.xy:D, 0D mov vgrf3.0.w:D, 1065353216D mov vgrf3.0.z:D, 0D is transformed in: mov vgrf3.0:F, [0

Re: [Mesa-dev] [PATCH v2 1/1] i965: add opportunistic behaviour to opt_vector_float()

2015-12-04 Thread Juan A. Suarez Romero
On Thu, 2015-12-03 at 11:04 -0800, Matt Turner wrote: > > The improvement obtained regarding current upstream (56aff6bb4eaf) > is: > > > > total instructions in shared programs: 6819484 -> 6811698 (-0.11%) > > instructions in affected programs: 387245 -> 379459 (-2.01%) > > total loops in share

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-12-04 Thread Michel Thierry
On 11/18/2015 10:53 PM, Kristian Høgsberg wrote: On Wed, Oct 14, 2015 at 5:11 AM, Michel Thierry wrote: On 10/14/2015 8:19 AM, Daniel Vetter wrote: On Tue, Oct 13, 2015 at 02:51:36PM -0700, Kristian Høgsberg wrote: On Tue, Oct 13, 2015 at 7:55 AM, Michel Thierry wrote: On 10/13/2015 3:13

Re: [Mesa-dev] [PATCH 10/10] vc4/nir: Use the new unified io intrinsics

2015-12-04 Thread Emil Velikov
Hi Eric, On 4 December 2015 at 02:03, Eric Anholt wrote: > Jason Ekstrand writes: > >> On Dec 3, 2015 3:47 PM, "Eric Anholt" wrote: >>> >>> Jason Ekstrand writes: >>> >>> > Cc: Eric Anholt >>> >>> OK, I've pushed a branch of partial fixes for this series to nir-loads >>> of my fdo tree, but i

Re: [Mesa-dev] [PATCH 00/11] do not wrap header inclusion in extern "C"

2015-12-04 Thread Emil Velikov
On 24 November 2015 at 16:29, Emil Velikov wrote: > Hi all, > > As pointed out by Jose a while back adding extern C guard around header > inclusion is a bad idea. > > As I noticed a few in the glsl/nir code I went on and grepped through > mesa. > > I have build tested the series on Linux only, yet

Re: [Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

2015-12-04 Thread Emil Velikov
Hi Edward, A few trivial suggestions (for future patches) and a humble request On 4 December 2015 at 06:50, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++ For the patches do shorten up the prefix - here we'd want

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #21 from Tobias Klausmann --- (In reply to Axel Davy from comment #20) > Should this bug report be closed ? > DRI3 has complete DRI_PRIME support now. > As far as it concerns me, DRI3 Support is fine and this bug can be marked as "r

Re: [Mesa-dev] [PATCH] gallium/drivers/nouveau: Clean up clear_texture()

2015-12-04 Thread Ilia Mirkin
This will break depth/stencil clears. On Fri, Dec 4, 2015 at 9:18 AM, Edward O'Callaghan wrote: > We should translate and set the format before dispatching > the call to pipe->create_surface(), instead of creating > a surface with the given format and changing it after. > > Signed-off-by: Edward

[Mesa-dev] gallium/drivers/nouveau: Clean up clear_texture()

2015-12-04 Thread Edward O'Callaghan
I don't actually have access to Nvid ASIC's at the moment so this is untested for regressions in ARB_clear_texture piglits. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium/drivers/nouveau: Clean up clear_texture()

2015-12-04 Thread Edward O'Callaghan
We should translate and set the format before dispatching the call to pipe->create_surface(), instead of creating a surface with the given format and changing it after. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 72 - 1 file ch

Re: [Mesa-dev] [PATCH 3/3v2] xvmc: force assertion in XvMC tests

2015-12-04 Thread Emil Velikov
Hi Giuseppe, On 29 November 2015 at 17:19, Giuseppe Bilotta wrote: > This follows the src/util/u_atomic_test.c model of undefining NDEBUG > unconditionally throughouth the XvMC tests, to force asserts regardless > of debug mode. > > The comment on u_atomic_test.c is also fixed (read 'debug' where

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

2015-12-04 Thread Emil Velikov
On 4 December 2015 at 13:27, Giuseppe Bilotta wrote: > On Tue, Dec 1, 2015 at 6:04 PM, Emil Velikov wrote: > >> With the small comment in patch 3 addressed the series is >> Reviewed-by: Emil Velikov > > And also: > >> Reviewed-by: Ian Romanick > > for patch 1 and 2. Who should I ping fo

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

2015-12-04 Thread Giuseppe Bilotta
On Tue, Dec 1, 2015 at 6:04 PM, Emil Velikov wrote: > With the small comment in patch 3 addressed the series is > Reviewed-by: Emil Velikov And also: > Reviewed-by: Ian Romanick for patch 1 and 2. Who should I ping for to get them pushed? ;-) >>> The long version: >>> 1. Grep for R

Re: [Mesa-dev] [PATCH v3 07/44] i965: Import tables enumerating the set of validated L3 configurations.

2015-12-04 Thread Francisco Jerez
Kenneth Graunke writes: > On Tuesday, December 01, 2015 12:19:25 AM Jordan Justen wrote: >> From: Francisco Jerez >> >> It should be possible to use additional L3 configurations other than >> the ones listed in the tables of validated allocations ("BSpec » >> 3D-Media-GPGPU Engine » L3 Cache an

Re: [Mesa-dev] [PATCH v3 13/44] i965: Implement L3 state atom.

2015-12-04 Thread Francisco Jerez
Kenneth Graunke writes: > On Tuesday, December 01, 2015 12:19:31 AM Jordan Justen wrote: >> From: Francisco Jerez >> >> The L3 state atom calculates the target L3 partition weights when the >> program bound to some shader stage is modified, and in case they are >> far enough from the current pa

[Mesa-dev] [PATCH] st/va: WIP remove nonesense HEVC picture id handling

2015-12-04 Thread Christian König
From: Christian König The picture id in this case is a VA-API surface handle, checking for a certain value is can't be correct. Does anybody have any idea what the original intention was and how to fix it correctly? Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture_hevc

[Mesa-dev] [Bug 92850] Segfault loading War Thunder

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92850 --- Comment #46 from har...@gmx.de --- here is the code from ir.h where it fails: /** * Determine the number of operands used by an expression */ static unsigned int get_num_operands(ir_expression_operation); /** * Determin

[Mesa-dev] [Bug 92850] Segfault loading War Thunder

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92850 --- Comment #45 from har...@gmx.de --- Created attachment 120336 --> https://bugs.freedesktop.org/attachment.cgi?id=120336&action=edit backtrace with activated -finline-small-functions -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

2015-12-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 4, 2015 at 7:50 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/winsys/amdgpu/drm/amdg

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-04 Thread Marek Olšák
On Fri, Dec 4, 2015 at 1:37 AM, Ilia Mirkin wrote: > On Thu, Dec 3, 2015 at 7:25 PM, Roland Scheidegger wrote: >> Am 03.12.2015 um 23:48 schrieb Ilia Mirkin: >>> On Thu, Dec 3, 2015 at 4:44 AM, Edward O'Callaghan >>> wrote: ARB_clear_texture is reasonably generic enough that it should

[Mesa-dev] [Bug 92850] Segfault loading War Thunder

2015-12-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92850 --- Comment #44 from har...@gmx.de --- (In reply to bellamorte42 from comment #40) > compiling with -O3 -fno-inline-small-functions works. yep, i can confirm that '-finline-small-functions' is the black sheep. -- You are receiving this mail bec

[Mesa-dev] [PATCH 1/2] st/va: move HEVC functions into separate file v2

2015-12-04 Thread Christian König
From: Christian König v2: actually copy all of it Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 172 +--- src/gallium/state_trackers/va/picture_hevc.c | 207 +

[Mesa-dev] [PATCH 2/2] st/va: disable MPEG4 by default v2

2015-12-04 Thread Christian König
From: Christian König The workarounds are too hacky to enable them by default and otherwise MPEG4 doesn't work reliably. v2: add docs/envvars.html, CC stable and fix typos Signed-off-by: Christian König Reviewed-by: Emil Velikov (v1) Reviewed-by: Ilia Mirkin (v1) Cc: "11.1.0" --- docs/envv

Re: [Mesa-dev] [PATCH] mesa/tests: add KHR_debug GLES glGetPointervKHR entry points

2015-12-04 Thread Michel Dänzer
On 04.12.2015 10:06, Emil Velikov wrote: > On 4 December 2015 at 00:45, Matt Turner wrote: >> On Thu, Dec 3, 2015 at 4:37 PM, Emil Velikov >> wrote: FWIW, make check still fails for me even with this patch. >>> Do you have a log that I can take a look ? I've `make clean'ed and >>> rebuild a

Re: [Mesa-dev] [PATCH v2 0/1] Do not require all components to apply opt_vector_float()

2015-12-04 Thread Juan A. Suarez Romero
On Thu, 2015-12-03 at 11:04 -0800, Matt Turner wrote: > The GAINED: 3 is almost certainly because of a sporadic failure in > shader-db (or Mesa...?) during the baseline shader-db run. When you > ran shader-db with your patch applied, the same failure didn't occur, > so report.py thinks this means 3

Re: [Mesa-dev] [PATCH v4 0/6] nouveau: add support for vaapi

2015-12-04 Thread Julien Isorce
Hi Ilia, Please give another try with these patches (i.e. 1, 2, 3 and 5 from this patch series. 4 and 6 are already merged since I have resubmit them afterward and split in several series). I rebased these four patches on top of latest master here: https://github.com/CapOM/mesa/commits/st_va_nouve