Re: [Mesa-dev] [PATCH] mesa: error out in indirect draw when vertex bindings mismatch

On 11/13/2015 07:18 PM, Fredrik Höglund wrote: On Friday 13 November 2015, Tapani Pälli wrote: Patch adds additional mask for tracking which vertex buffer bindings are set. This array can be directly compared to which vertex arrays are enabled and should match when drawing. Fixes following CT

[Mesa-dev] [PATCH 2/2] mesa: do runtime validation of precision varyings only on ES

Precision qualifier should be ignored on desktop OpenGL. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 58ba041..dc39f24 100644 -

[Mesa-dev] [PATCH 1/2] glsl: initialize precision when adding per vertex record fields

Fixes issues with tessellation builtin variables since precision was introduced to IR with commit f84bc57d7dc02fceb805803131426c791eadeff9. Signed-off-by: Tapani Pälli --- src/glsl/builtin_variables.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl

Re: [Mesa-dev] Patchwork admin rights

On Sun, Nov 15, 2015 at 2:05 AM, Alejandro Piñeiro wrote: > On 13/11/15 20:17, Matt Turner wrote: >> On Fri, Nov 13, 2015 at 4:26 AM, Samuel Iglesias Gonsálvez >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA256 >>> >>> Hello, >>> >>> I would like to have admin permissions to Mesa a

Re: [Mesa-dev] [PATCH v2 0/9] gallium: batch query objects and related cleanups

On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: Hi, I have updated patches 6 - 9. Samuel, thank you for your input and I hope you find your points to be resolved satisfactorily ;) Yeah, I have no strong objections to remove those groups of GPU counters. :-) Cheers, Nicolai --- nha@deadlig

Re: [Mesa-dev] [PATCH v2 9/9] st/mesa: add support for batch driver queries to perfmon

See my comment below. On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: v2: forgot a null-pointer check (spotted by Samuel Pitoiset) --- src/mesa/state_tracker/st_cb_perfmon.c | 78 +++--- src/mesa/state_tracker/st_cb_perfmon.h | 6 +++ 2 files changed, 77 insertions

Re: [Mesa-dev] [PATCH v2 8/9] gallium/hud: add support for batch queries

One minor comment below. On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: v2: be more defensive about allocations --- src/gallium/auxiliary/hud/hud_context.c | 24 ++- src/gallium/auxiliary/hud/hud_driver_query.c | 265 +++ src/gallium/auxiliary/hud/hud_private.h

Re: [Mesa-dev] [PATCH v2 7/9] gallium: add the concept of batch queries

You'll need to update this patch and set 'info->flags = 0' in nv50_query.c as well. I pushed some performance counters for nv50 yesterday. Thanks for doing this change. On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: Some drivers (in particular radeon[si], but also freedreno judging from a quick

Re: [Mesa-dev] [PATCH v2 6/9] st/mesa: maintain active perfmon counters in an array

Reviewed-by: Samuel Pitoiset On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: It is easy enough to pre-determine the required size, and arrays are generally better behaved especially when they get large. v2: make sure init_perf_monitor returns true when no counters are active (spotted by Samuel P

Re: [Mesa-dev] [PATCH v2 1/9] gallium: remove pipe_driver_query_group_info field type

There is still one assignment to 'type' in nvc0_query.c at line 246 which needs to be removed. On 11/13/2015 08:17 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monito

Re: [Mesa-dev] Patchwork admin rights

On 13/11/15 20:17, Matt Turner wrote: > On Fri, Nov 13, 2015 at 4:26 AM, Samuel Iglesias Gonsálvez > wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> Hello, >> >> I would like to have admin permissions to Mesa and Piglit projects in >> patchwork [0] to change the status of patche