Re: [Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v3)

Hi Michel, Do you have any further comments/suggestions on this patch? Thanks and Regards, Vivek On Fri, 6 Nov 2015 18:56:13 +0900 Michel Dänzer wrote: > On 06.11.2015 12:08, Vivek Kasireddy wrote: > > For certain platforms that support rotated scanout buffers, > > currently, there is no way t

[Mesa-dev] [PATCH v3 2/3] i965: Introduce a MOV_INDIRECT opcode.

The geometry and tessellation control shader stages both read from multiple URB entries (one per vertex). The thread payload contains several URB handles which reference these separate memory segments. In GLSL, these inputs are represented as per-vertex arrays; the outermost array index selects w

[Mesa-dev] [PATCH 1/2] nir: Add support for gl_HelperInvocation system value.

--- src/glsl/nir/nir.c| 4 src/glsl/nir/nir_intrinsics.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index bb7a5fa..974438b 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1565,6 +1565,8 @@ nir_intrinsic_from_system_va

[Mesa-dev] [PATCH 2/2] i965/fs: Add support for gl_HelperInvocation system value.

--- This code generates mov(1) f0<1>UW g1.14<0,1,0>UW mov(8) g2<1>UD 0xUD (+f0) sel(8)g3<1>D g2<8,8,1>D -1D which I don't love because it uses the flag register, and likely uses of gl_HelperInvocation will be in a

[Mesa-dev] [PATCH v5 5/8] glsl: Add a parse check to check for the index layout qualifier

This can only be used if EXT_blend_func_extended is enabled --- src/glsl/glsl_parser.yy | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 4636435..40e60e5 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1463,6 +1

[Mesa-dev] [PATCH v5 8/8] mesa: Enable EXT_blend_func_extended if the driver supports the ARB version

--- docs/relnotes/11.1.0.html | 1 + src/mesa/main/extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index c35d91f..5c2e530 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -56,6 +56,7 @@ Note: some of

[Mesa-dev] [PATCH v5 0/8] Implement support for EXT_blend_func_extended

This implements support for a very new extension to ES, which allows you to do dual source blending just like in desktop OpenGL. This works with the piglits that I am writing that just need to be cleaned before they are pushed, and it also works fantastically with the Dolphin emulator (Only known a

[Mesa-dev] [PATCH v5 7/8] mesa: Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

--- src/mesa/main/get_hash_params.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index fbc7b8f..9b22b91 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -330,6 +330

[Mesa-dev] [PATCH v5 6/8] mesa: Enable usage of blend_func_extended blend factors

--- src/mesa/main/blend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 20aa498..ee5a513 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -67,7 +67,7 @@ legal_src_factor(const struct gl_context *ctx, G

[Mesa-dev] [PATCH v5 4/8] glsl: Add GL_EXT_blend_func_extended preprocessor define

--- src/glsl/glcpp/glcpp-parse.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 4acccf7..10bf83f 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -2384,6 +2384,8 @@ _glcpp_parser_handle_version_

[Mesa-dev] [PATCH v5 1/8] glapi: Add EXT_blend_func_extended XML definitions

--- src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- src/mapi/glapi/gen/es_EXT.xml | 26 ++ src/mesa/main/tests/dispatch_sanity.cpp | 8 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/EXT_gpu_shader4.xml b/src/mapi/gl

[Mesa-dev] [PATCH v5 3/8] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported Only for ESSL 1.0 it provides two builtins since you can't have user-defined color output variables gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] --- src/glsl/ast_to_hir.cpp| 24 +++ sr

[Mesa-dev] [PATCH v5 2/8] glsl: Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

This adds a state for the maximum dual source draw variables available and the variable for determining if the extension has been enabled in the program shaders. --- src/glsl/glsl_parser_extras.cpp | 3 +++ src/glsl/glsl_parser_extras.h | 5 + 2 files changed, 8 insertions(+) diff --git a/s

[Mesa-dev] [Bug 92946] [softpipe] piglit fcc-front-buffer-distraction regression

https://bugs.freedesktop.org/show_bug.cgi?id=92946 Bug ID: 92946 Summary: [softpipe] piglit fcc-front-buffer-distraction regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] r600g: Support TGSI_SEMANTIC_HELPER_INVOCATION

On Fri, 13 Nov 2015 18:57:28 +0100, Nicolai Hähnle wrote: On 13.11.2015 00:14, Glenn Kennard wrote: Signed-off-by: Glenn Kennard --- Maybe there is a better way to check if a thread is a helper invocation? Is ctx->face_gpr guaranteed to be initialized when load_helper_invocation is call

[Mesa-dev] [PATCH] i965: Set MaxCombinedUniformBlocks properly.

Up until now, we've been letting core Mesa initialize it to 36 for us (which is presumably BRW_MAX_UBO (12) * (VS+GS+FS stages -> 3)). With compute and tessellation, we need to increase this. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 ins

Re: [Mesa-dev] [PATCH] i965: Disable fast clears for MSRTs on SKL

On Fri, Nov 13, 2015 at 10:23:20PM +0100, Neil Roberts wrote: > There are currently a bunch of formats that behave strangely when > sampling the cleared color from the MCS buffer on SKL. They seem to > mostly be formats that don't have an alpha component, although it's > not all of them, and we hav

Re: [Mesa-dev] [PATCH 1/8] glsl: move ast layout qualifier handling code into its own function

On Fri, 2015-11-13 at 12:13 +1100, Timothy Arceri wrote: > From: Timothy Arceri > > We now also only apply these rules to variables rather than also > trying to apply them to function params. Please ignore this patch for now, I'm thinking of doing this in a slightly different way. However I'd

[Mesa-dev] [PATCH] radeonsi: enable optimal raster config setting for fiji (v2)

Requires proper kernel tiling configurarion so check the tiling config registers. v2: send the right version of the patch Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

[Mesa-dev] [Bug 92945] [llvmpipe] [softpipe] piglit fs-ldexp-dvec4 regression

https://bugs.freedesktop.org/show_bug.cgi?id=92945 Bug ID: 92945 Summary: [llvmpipe] [softpipe] piglit fs-ldexp-dvec4 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH] i965: Disable fast clears for MSRTs on SKL

There are currently a bunch of formats that behave strangely when sampling the cleared color from the MCS buffer on SKL. They seem to mostly be formats that don't have an alpha component, although it's not all of them, and we haven't yet found anything in the specs which would explain this. For now

[Mesa-dev] [PATCH] radeonsi: use proper GRBM_GFX_INDEX offset for CI+

The offset is different on CI and newer. Signed-off-by: Alex Deucher --- src/gallium/drivers/radeonsi/si_state.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index ff4d612.

Re: [Mesa-dev] [PATCH 2/2] i965: Clean up context constant initialization code.

On Friday, November 13, 2015 10:10:28 AM Pohjolainen, Topi wrote: > On Thu, Nov 12, 2015 at 03:38:52PM -0800, Kenneth Graunke wrote: > > This was getting pretty out of hand, and with compute partially in place > > and tessellation on the way, it was only going to get worse. > > > > This patch make

Re: [Mesa-dev] [Nouveau] llvm TGSI backend (WIP) questions

On Fri, Nov 13, 2015 at 3:42 PM, Emil Velikov wrote: > On 13 November 2015 at 14:38, Ilia Mirkin wrote: >> On Fri, Nov 13, 2015 at 9:25 AM, Emil Velikov >> wrote: >>> Hello Hans, >>> >>> Not to muddy the waters or anything, have you thought about the NIR >>> integration that Rob was thinking ab

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta/generate_mipmap: Only modify the draw framebuffer binding in fallback_required

On Fri, Nov 13, 2015 at 12:07 PM, Ian Romanick wrote: > From: Ian Romanick > > Previously GL_FRAMEBUFFER was used. However, if GL_EXT_framebuffer_blit > is supported (note: it is supported by every Mesa driver), this is > *sometimes* an alias for GL_DRAW_FRAMEBUFFER (getters) and *sometimes* > a

Re: [Mesa-dev] [Nouveau] llvm TGSI backend (WIP) questions

On 13 November 2015 at 14:38, Ilia Mirkin wrote: > On Fri, Nov 13, 2015 at 9:25 AM, Emil Velikov > wrote: >> Hello Hans, >> >> Not to muddy the waters or anything, have you thought about the NIR >> integration that Rob was thinking about ? >> I'm pretty sure he'll be happy to have extra people h

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

On Fri, Nov 13, 2015 at 2:37 PM, Ilia Mirkin wrote: > Looks like valgrind hates this for some reason. I'm seeing lots of > > ==16821== Conditional jump or move depends on uninitialised value(s) > ==16821==at 0xA074D09: glsl_type::record_compare(glsl_type const*) > const (glsl_types.cpp:783) >

Re: [Mesa-dev] [PATCH 2/7] i965: Add lossless compression to surface format table

On Wed 11 Nov 2015, Ben Widawsky wrote: > Background: Prior to Skylake and since Ivybridge Intel hardware has had the > ability to use a MCS (Multisample Control Surface) as auxiliary data in > "compression" operations on the surface. This reduces memory bandwidth. This > hardware was either used

Re: [Mesa-dev] [PATCH 4/7] [v2] i965/meta/gen9: Individually fast clear color attachments

On Fri 13 Nov 2015, Neil Roberts wrote: > Ben Widawsky writes: > > > Thanks a lot, I will squash it in - and sorry again about ignoring your > > feedback. > > Ok, no worries. Feel free to add > > Reviewed-by: Neil Roberts > > if you squash the changes in. Same for me. If you squash Neil's ch

Re: [Mesa-dev] [PATCH 3/7] [v2] i965/skl: skip fast clears for certain surface formats

On Wed 11 Nov 2015, Ben Widawsky wrote: > Some of the information originally in this commit message is now in the patch > before this. > > SKL adds compressible render targets and as a result mutates some of the > programming for fast clears and resolves. There is a new internal surface type > cal

[Mesa-dev] [PATCH] meta/generate_mipmap: Only modify the draw framebuffer binding in fallback_required

From: Ian Romanick Previously GL_FRAMEBUFFER was used. However, if GL_EXT_framebuffer_blit is supported (note: it is supported by every Mesa driver), this is *sometimes* an alias for GL_DRAW_FRAMEBUFFER (getters) and *sometimes* an alias for *both* GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER (se

Re: [Mesa-dev] [PATCH] i965: Don't write beyond allocated memory.

On Fri, Nov 13, 2015 at 3:36 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/dri/i965/brw_eu_validate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c > b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

Looks like valgrind hates this for some reason. I'm seeing lots of ==16821== Conditional jump or move depends on uninitialised value(s) ==16821==at 0xA074D09: glsl_type::record_compare(glsl_type const*) const (glsl_types.cpp:783) Where line 783 is: if (this->fields.structure[i].precisi

Re: [Mesa-dev] [PATCH 1/2] i965: Convert scalar_* flags to a scalar_stage array.

On Friday, November 13, 2015 10:06:23 AM Pohjolainen, Topi wrote: > On Thu, Nov 12, 2015 at 03:38:51PM -0800, Kenneth Graunke wrote: > > I was going to add scalar_tcs and scalar_tes flags, and then thought > > better of it and decided to convert this to an array. Simpler. > > > > Signed-off-by: K

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

On Wed, Nov 11, 2015 at 3:20 PM, Kenneth Graunke wrote: > On Monday, November 02, 2015 04:29:10 PM Matt Turner wrote: >> backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a >> brw_reg that's used for "hardware regs" -- precolored registers or >> architecture >> registers. Thi

Re: [Mesa-dev] [PATCH v2 10/11] i965/fs: Stomp the texture return type to UINT32

On Friday, November 13, 2015 10:14:56 AM Jason Ekstrand wrote: > Cc: Kenneth Graunke > > > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH v2 6/9] st/mesa: maintain active perfmon counters in an array

It is easy enough to pre-determine the required size, and arrays are generally better behaved especially when they get large. v2: make sure init_perf_monitor returns true when no counters are active (spotted by Samuel Pitoiset) --- src/mesa/state_tracker/st_cb_perfmon.c | 81 -

Re: [Mesa-dev] Patchwork admin rights

On Fri, Nov 13, 2015 at 4:26 AM, Samuel Iglesias Gonsálvez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hello, > > I would like to have admin permissions to Mesa and Piglit projects in > patchwork [0] to change the status of patches that are mine but they > are not assigned to me

[Mesa-dev] [PATCH v2 2/9] gallium/hud: remove unused field in query_info

Reviewed-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_driver_query.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c b/src/gallium/auxiliary/hud/hud_driver_query.c index f14305e..3198ab3 100644 --- a/src/gallium/auxiliary/hud/hud_driver_qu

[Mesa-dev] [PATCH v2 3/9] st/mesa: map semantic driver query types to underlying type

Reviewed-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 2 ++ src/mesa/state_tracker/st_cb_perfmon.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 7f241c8..7ed9f6d 100644 --- a/src/galli

[Mesa-dev] [PATCH v2 1/9] gallium: remove pipe_driver_query_group_info field type

This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor consists of a number of hardware and software counters that can be sampled by the GPU and reported back to the application. I guess one cou

[Mesa-dev] [PATCH v2 9/9] st/mesa: add support for batch driver queries to perfmon

v2: forgot a null-pointer check (spotted by Samuel Pitoiset) --- src/mesa/state_tracker/st_cb_perfmon.c | 78 +++--- src/mesa/state_tracker/st_cb_perfmon.h | 6 +++ 2 files changed, 77 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c

[Mesa-dev] [PATCH v2 8/9] gallium/hud: add support for batch queries

v2: be more defensive about allocations --- src/gallium/auxiliary/hud/hud_context.c | 24 ++- src/gallium/auxiliary/hud/hud_driver_query.c | 265 +++ src/gallium/auxiliary/hud/hud_private.h | 13 +- 3 files changed, 256 insertions(+), 46 deletions(-) diff --git

[Mesa-dev] [PATCH v2 5/9] st/mesa: use BITSET_FOREACH_SET to loop through active perfmon counters

Reviewed-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_perfmon.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tracker/st_cb_perfmon.c index 80ff170..ec12eb2 100644 --- a/src/mesa/state_tracker/st_cb_perf

[Mesa-dev] [PATCH v2 7/9] gallium: add the concept of batch queries

Some drivers (in particular radeon[si], but also freedreno judging from a quick grep) may want to expose performance counters that cannot be individually enabled or disabled. Allow such drivers to mark driver-specific queries as requiring a new type of batch query object that is used to start and

[Mesa-dev] [PATCH v2 0/9] gallium: batch query objects and related cleanups

Hi, I have updated patches 6 - 9. Samuel, thank you for your input and I hope you find your points to be resolved satisfactorily ;) Cheers, Nicolai --- nha@deadlights:~/amd/mesa$ git diff master | diffstat gallium/auxiliary/hud/hud_context.c | 24 +- gallium/auxiliary/hud/hud_driver_quer

[Mesa-dev] [PATCH v2 4/9] st/mesa: store mapping from perfmon counter to query type

Previously, when a performance monitor was initialized, an inner loop through all driver queries with string comparisons for each enabled performance monitor counter was used. This hurts when a driver exposes lots of queries. Reviewed-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_perfmon.

Re: [Mesa-dev] llvm TGSI backend (WIP) questions

On Fri, Nov 13, 2015 at 02:46:52PM +0100, Hans de Goede wrote: > Hi All, > > So as discussed I've started working on a TGSI backend for > llvm to use as a way to get compute going on nouveau (and other gpu-s). > > I'm still learning all the ins and outs of llvm so I do not have > much to show yet

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 07:27 PM, Ilia Mirkin wrote: On Fri, Nov 13, 2015 at 1:23 PM, Nicolai Hähnle wrote: So really, this is a question for everybody who cares about nouveau, because nouveau is the only driver that (if a #define is enabled) advertises a CPU driver_query_group. Do you want that group

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 07:23 PM, Nicolai Hähnle wrote: On 13.11.2015 18:35, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor c

Re: [Mesa-dev] [PATCH 3/9] st/mesa: map semantic driver query types to underlying type

On 11/13/2015 07:22 PM, Nicolai Hähnle wrote: On 13.11.2015 18:34, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/include/pipe/p_defines.h | 2 ++ src/mesa/state_tracker/st_cb_perfmon.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/g

Re: [Mesa-dev] [PATCH 0/9] gallium: batch query objects and related cleanups

On 11/13/2015 07:29 PM, Nicolai Hähnle wrote: Hi Samuel, thanks for taking a look! On 13.11.2015 18:35, Samuel Pitoiset wrote: Did you run amd_performance_monitor piglit tests to make sure all of your changes didn't break anything? Yes, everything passes here. Looks good. Thanks. Di

Re: [Mesa-dev] [PATCH 22/23] meta: Don't save or restore the VBO binding

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Nothing left in meta does anything with the VBO binding, so we don't > need to save or restore it. The VAO binding is still modified. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 6 -- >

Re: [Mesa-dev] [PATCH 23/23] meta: Don't save or restore the active client texture

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > This setting is only used by glTexCoordPointer and related glEnable > calls. Since the preceeding commits removed all of those, it is not > necessary to save, reset to default, or restore this state. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 21/23] meta/TexSubImage: Don't pollute the buffer object namespace

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 19/23] meta: Use internal functions for buffer object and VAO access in _mesa_meta_DrawTex

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 32 > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/d

Re: [Mesa-dev] [PATCH 20/23] meta: Don't pollute the buffer object namespace in _mesa_meta_DrawTex

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 18/23] meta: Track VBO using gl_buffer_object instead of GL API object handle in _mesa_meta_DrawTex

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 23 ++- > src/mesa/drivers/common/meta.h | 2 +- > 2 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 17/23] meta: Partially convert _mesa_meta_DrawTex to DSA

On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c >

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 --- Comment #5 from EoD --- Is there any reason this is not getting merged? Is there any way to help getting it merged? It would be great to fix the aforementioned bugs before an 11.1 release. -- You are receiving this mail because: You are th

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 13.11.2015 19:27, Ilia Mirkin wrote: On Fri, Nov 13, 2015 at 1:23 PM, Nicolai Hähnle wrote: So really, this is a question for everybody who cares about nouveau, because nouveau is the only driver that (if a #define is enabled) advertises a CPU driver_query_group. Do you want that group to b

Re: [Mesa-dev] [PATCH 0/9] gallium: batch query objects and related cleanups

Hi Samuel, thanks for taking a look! On 13.11.2015 18:35, Samuel Pitoiset wrote: Did you run amd_performance_monitor piglit tests to make sure all of your changes didn't break anything? Yes, everything passes here. Did you test on nvc0 driver which is the only driver that currently exposes

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On Fri, Nov 13, 2015 at 1:23 PM, Nicolai Hähnle wrote: > So really, this is a question for everybody who cares about nouveau, because > nouveau is the only driver that (if a #define is enabled) advertises a CPU > driver_query_group. > > Do you want that group to be accessible via AMD_performance_m

[Mesa-dev] [PATCH] st/mesa: maintain active perfmon counters in an array (v2)

It is easy enough to pre-determine the required size, and arrays are generally better behaved especially when they get large. v2: make sure init_perf_monitor returns true when no counters are active (spotted by Samuel Pitoiset) --- Thanks Samuel, good catch! I did test with piglit and the tests pa

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 13.11.2015 18:35, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor consists of a number of hardware and software c

Re: [Mesa-dev] [PATCH 3/9] st/mesa: map semantic driver query types to underlying type

On 13.11.2015 18:34, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/include/pipe/p_defines.h | 2 ++ src/mesa/state_tracker/st_cb_perfmon.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/inc

[Mesa-dev] [PATCH] radeonsi: enable optimal raster config setting for fiji

Requires proper kernel tiling configurarion so check the tiling config registers. Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

On Fri, Nov 13, 2015 at 1:12 PM, Ben Widawsky wrote: > On Thu, Nov 12, 2015 at 04:54:08PM +0100, Neil Roberts wrote: >> + default: >> + for (int i = 0; i < 3; i++) { >> + if (!_mesa_format_has_color_component(format, i)) >> +override_color.ui[i] = 0; >> + } > > Is t

[Mesa-dev] [PATCH v2 10/11] i965/fs: Stomp the texture return type to UINT32

Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 4877504..61c63d4 100644 --- a/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

On Thu, Nov 12, 2015 at 04:54:08PM +0100, Neil Roberts wrote: > It looks like the sampler hardware doesn't take into account the > surface format when sampling a cleared color after a fast clear has > been done. So for example if you clear a GL_RED surface to 1,1,1,1 > then the sampling instruction

Re: [Mesa-dev] [PATCH v3] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

On Fri, Nov 13, 2015 at 12:48 AM, Iago Toral Quiroga wrote: > If a source operand in a MOV has source modifiers, then we cannot > copy-propagate it from the parent instruction and remove the MOV. > > v2: remove the check for source modifiers from is_move() (Jason) > > v3: Put the check for source

Re: [Mesa-dev] llvm TGSI backend (WIP) questions

On 11/13/2015 02:46 PM, Hans de Goede wrote: Hi All, Hey Hans, So as discussed I've started working on a TGSI backend for llvm to use as a way to get compute going on nouveau (and other gpu-s). I'm still learning all the ins and outs of llvm so I do not have much to show yet. I've rebase

Re: [Mesa-dev] [PATCH] r600g: Support TGSI_SEMANTIC_HELPER_INVOCATION

On 13.11.2015 00:14, Glenn Kennard wrote: Signed-off-by: Glenn Kennard --- Maybe there is a better way to check if a thread is a helper invocation? Is ctx->face_gpr guaranteed to be initialized when load_helper_invocation is called? Aside, I'm not sure I understand correctly what this is su

Re: [Mesa-dev] [PATCH] nir/glsl_to_nir: use _mesa_fls() to compute num_textures

On Fri, Nov 13, 2015 at 7:44 AM, Juan A. Suarez Romero wrote: > On Fri, 2015-11-13 at 07:37 -0800, Jason Ekstrand wrote: >> I didn't want to pull a non-inline mesa function into NIR and add a >> link dependency and I was too lazy to move it into util. > > > But at this moment _mesa_fls() is an inl

Re: [Mesa-dev] [PATCH 8/9] gallium/hud: add support for batch queries

Some comments below. On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/auxiliary/hud/hud_context.c | 24 ++- src/gallium/auxiliary/hud/hud_driver_query.c | 248 +++ src/gallium/auxiliary/hud/hud_private.h | 13 +- 3 files changed, 240 insertio

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor consists of a number of hardware and software counters that can be sampled by the GPU and

Re: [Mesa-dev] [PATCH 5/9] st/mesa: use BITSET_FOREACH_SET to loop through active perfmon counters

Reviewed-by: Samuel Pitoiset On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tracker/st_cb_perfmon.c index 80ff170..ec

Re: [Mesa-dev] [PATCH 0/9] gallium: batch query objects and related cleanups

Hi Nicolai, Did you run amd_performance_monitor piglit tests to make sure all of your changes didn't break anything? Did you test on nvc0 driver which is the only driver that currently exposes GL_AMD_performance_monitor? In case you didn't, I'll test it myself in the next few days. You might

Re: [Mesa-dev] [PATCH 7/9] gallium: add the concept of batch queries

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: Some drivers (in particular radeon[si], but also freedreno judging from a quick grep) may want to expose performance counters that cannot be individually enabled or disabled. Allow such drivers to mark driver-specific queries as requiring a new typ

Re: [Mesa-dev] [PATCH 3/9] st/mesa: map semantic driver query types to underlying type

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/include/pipe/p_defines.h | 2 ++ src/mesa/state_tracker/st_cb_perfmon.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 7f241c8..7ed9f6d

Re: [Mesa-dev] [PATCH 6/9] st/mesa: maintain active perfmon counters in an array

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: It is easy enough to pre-determine the required size, and arrays are generally better behaved especially when they get large. --- src/mesa/state_tracker/st_cb_perfmon.c | 78 -- src/mesa/state_tracker/st_cb_perfmon

Re: [Mesa-dev] [PATCH 9/9] st/mesa: add support for batch driver queries to perfmon

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 75 ++ src/mesa/state_tracker/st_cb_perfmon.h | 6 +++ 2 files changed, 74 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/me

Re: [Mesa-dev] [PATCH 2/9] gallium/hud: remove unused field in query_info

Reviewed-by: Samuel Pitoiset On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/auxiliary/hud/hud_driver_query.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c b/src/gallium/auxiliary/hud/hud_driver_query.c index f14305e..3198ab3

Re: [Mesa-dev] [PATCH 4/9] st/mesa: store mapping from perfmon counter to query type

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: Previously, when a performance monitor was initialized, an inner loop through all driver queries with string comparisons for each enabled performance monitor counter was used. This hurts when a driver exposes lots of queries. When I wrote this cod

Re: [Mesa-dev] [PATCH] glsl: set matrix_stride for non matrices with atomic counter buffers

On 11/13/2015 05:57 PM, Ilia Mirkin wrote: On Fri, Nov 13, 2015 at 10:53 AM, Tapani Pälli wrote: On 11/12/2015 05:47 PM, Ilia Mirkin wrote: On Mon, Nov 2, 2015 at 6:36 AM, Tapani Pälli wrote: Patch sets matrix_stride as 0 for non matrix uniforms that are in a atomic counter buffer. Matrix st

Re: [Mesa-dev] [PATCH] mesa: error out in indirect draw when vertex bindings mismatch

On Friday 13 November 2015, Tapani Pälli wrote: > Patch adds additional mask for tracking which vertex buffer bindings > are set. This array can be directly compared to which vertex arrays > are enabled and should match when drawing. > > Fixes following CTS tests: > >ES31-CTS.draw_indirect.ne

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] r200: fix bgrx8/xrgb8 blits

On 12 November 2015 at 22:53, Ian Romanick wrote: > I'll try to swap the RV200 for the R200 next week. I'm not sure when > Emil is planning the next stable release... I'll try to test before > that... unless someone beats me to it. ;) > Next stable should be out a week from now. -Emil __

[Mesa-dev] [PATCH 10/10] radeon: count cs dwords separately for query begin and end

This will be important for perfcounter queries. --- src/gallium/drivers/radeon/r600_query.c | 33 +++-- src/gallium/drivers/radeon/r600_query.h | 3 ++- 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gall

[Mesa-dev] [PATCH 00/10] radeon: cleanup and refactor the query implementation

Hi, in preparation for performance counters, this series makes the implementation of queries pluggable, and separates query buffer handling from CS emit and result collection for hardware queries. Aside from two PIPE_QUERY_GPU_FINISHED-related fixes (using context flush, picked up from Marek, and

[Mesa-dev] [PATCH 08/10] radeon: implement r600_query_hw_get_result via function pointers

We will need the clear_result override for the batch query implementation. --- src/gallium/drivers/radeon/r600_query.c | 189 +++- src/gallium/drivers/radeon/r600_query.h | 4 + 2 files changed, 94 insertions(+), 99 deletions(-) diff --git a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 05/10] radeon: convert software queries to the new style

Software queries are all queries that do not require suspend/resume and explicit handling of result buffers. Note that this fixes a fence leak with PIPE_QUERY_GPU_FINISHED, and it contains Marek's fix to GPU_FINISHED's end_query() handling. --- src/gallium/drivers/radeon/r600_query.c | 366 ++

[Mesa-dev] [PATCH 01/10] radeon: move get_driver_query_info to r600_query.c

--- src/gallium/drivers/radeon/r600_pipe_common.c | 46 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_query.c | 49 +++ 3 files changed, 51 insertions(+), 45 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 06/10] radeon: convert hardware queries to the new style

Move r600_query and r600_query_hw into the header because we will want to reuse the buffer handling and suspend/resume logic outside of the common radeon code. --- src/gallium/drivers/radeon/r600_query.c | 281 +++- src/gallium/drivers/radeon/r600_query.h | 39 + 2

[Mesa-dev] [PATCH 04/10] radeon: add query handler function pointers

The goal here is to be able to move the implementation details of hardware- specific queries (in particular, performance counters) out of the common code. --- src/gallium/drivers/radeon/r600_query.c | 73 + src/gallium/drivers/radeon/r600_query.h | 16 2 fi

[Mesa-dev] [PATCH 02/10] radeon: cleanup driver query list

--- src/gallium/drivers/radeon/r600_query.c | 84 + 1 file changed, 55 insertions(+), 29 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index 8aa8774..60381b2 100644 --- a/src/gallium/drivers/radeon/r600

[Mesa-dev] [PATCH 03/10] radeon: move R600_QUERY_* constants into a new query header file

More query-related structures will have to be moved into their own header file to support hardware-specific performance counters. --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 15 src/gallium/drivers/radeon/r600_query.c |

[Mesa-dev] [PATCH 07/10] radeon: split hw query buffer handling from cs emit

The idea here is that driver queries implemented outside of common code will use the same query buffer handling with different logic for starting and stopping the corresponding counters. --- src/gallium/drivers/radeon/r600_query.c | 198 +++- src/gallium/drivers/radeon/

[Mesa-dev] [PATCH 09/10] radeon: expose r600_query_hw functions for reuse

--- src/gallium/drivers/radeon/r600_query.c | 30 +- src/gallium/drivers/radeon/r600_query.h | 10 ++ 2 files changed, 27 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index 59e2a5

Re: [Mesa-dev] [PATCH 4/7] [v2] i965/meta/gen9: Individually fast clear color attachments

Ben Widawsky writes: > Thanks a lot, I will squash it in - and sorry again about ignoring your > feedback. Ok, no worries. Feel free to add Reviewed-by: Neil Roberts if you squash the changes in. Regards, - Neil ___ mesa-dev mailing list mesa-dev@l

  1   2   >