[Mesa-dev] [PATCH] glsl: remove specical case subroutine type counting

Unlike samplers we can get the correct value for subroutines from component_slots() --- src/glsl/link_uniforms.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 4757fd5..3c6930a 100644 --- a/src/glsl/link_unif

[Mesa-dev] [PATCH 5/6] i965: enable ARB_arrays_of_arrays

--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 4a0..5febb95 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++ b/src/mesa/drivers/

[Mesa-dev] [PATCH 4/6] i965: add arrays of arrays support for varyings

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index ce1edc3..620ce13 100644 --- a/src/mesa/drivers/

[Mesa-dev] [PATCH 6/6] docs: Mark AoA as done for i965

--- docs/GL3.txt | 4 ++-- docs/relnotes/11.0.0.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 8124383..79c80e0 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -149,7 +149,7 @@ GL 4.2, GLSL 4.20: GL 4.3, GLSL 4.30: -

[Mesa-dev] [PATCH 1/6] glsl: avoid hitting assert for arrays of arrays

Also add TODO comment about adding proper support Signed-off-by: Timothy Arceri --- src/glsl/ir_set_program_inouts.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index b7a0f6e..d7c29b0 100644 --- a/src/glsl/i

[Mesa-dev] [PATCH 3/6] glsl: add AoA support to subroutines

--- src/glsl/ast_function.cpp | 43 ++- src/glsl/lower_subroutine.cpp | 2 +- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index d003655..42affad 100644 --- a/src/glsl/ast_function

[Mesa-dev] ARB_arrays_of_arrays Desktop series

This applies on top of my V3 ARB_arrays_of_arrays GLSL ES series If useful the series is in the 'desktop_AoA_no_interface' branch of the repo here: https://github.com/tarceri/Mesa_arrays_of_arrays.git This series: - Adds support for input/output AoA on i965 - AoA subroutine support - Enables

[Mesa-dev] [PATCH 2/6] glsl: disable interface block AoA

Desktop GL supports interface block AoA however AMD and Nvidia dont support it in their drivers curently so we can get away with disabling it for now. --- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_t

[Mesa-dev] [PATCH] glsl: Add missing spec quote about atomic counter in structs

--- src/glsl/ast_to_hir.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 9385922..f67c951 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5679,10 +5679,10 @@ ast_process_structure_or_inter

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Sat, 2015-08-08 at 14:25 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: > > > On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: > > > > On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: > > > > > On Wed, 2015-08-05 at

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

On Sat, Aug 8, 2015 at 3:14 PM, Oded Gabbay wrote: > On Sun, Aug 9, 2015 at 12:26 AM, Jason Ekstrand wrote: >> On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger >> wrote: >>> Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and gallium formats are defined a bit differently. In

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

On Sun, Aug 9, 2015 at 12:26 AM, Jason Ekstrand wrote: > On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger wrote: >> Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: >>> Mesa formats and gallium formats are defined a bit differently. In mesa >>> there are "packed" formats which are based on byte-

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

Am 08.08.2015 um 23:26 schrieb Jason Ekstrand: > On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger wrote: >> Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: >>> Mesa formats and gallium formats are defined a bit differently. In mesa >>> there are "packed" formats which are based on byte-order wit

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger wrote: > Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: >> Mesa formats and gallium formats are defined a bit differently. In mesa >> there are "packed" formats which are based on byte-order within a 8, 16, or >> 32-bit word and there are "array"

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: > Mesa formats and gallium formats are defined a bit differently. In mesa > there are "packed" formats which are based on byte-order within a 8, 16, or > 32-bit word and there are "array" formats which are simply an array of 8, > 16, or 32-bit values.

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

On Sat, Aug 8, 2015 at 2:10 PM, Rob Clark wrote: > On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand wrote: >> On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: >>> On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: > On Sat, Aug 8,

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand wrote: > On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: >> On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: >>> On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: > On

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

It's worth noting that this only fixes some of the more obvious problems. For the formats that mesa defines as array formats, I think things are still pretty broken. This also brings into question how "worth it" it is having different format enums. I personally prefer the way that mesa core has

[Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

Mesa formats and gallium formats are defined a bit differently. In mesa there are "packed" formats which are based on byte-order within a 8, 16, or 32-bit word and there are "array" formats which are simply an array of 8, 16, or 32-bit values. In gallium, they do something different called "plain

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: > On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: >> On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: >>> On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > This patch

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: > On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: >> On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: >>> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: This patch fixes a bug that is manifested in the read path of mesa wh

Re: [Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

On Sat, Aug 8, 2015 at 7:04 PM, Jason Ekstrand wrote: > Cc: Iago Toral > Cc: Oded Gabbay > --- > src/mesa/main/formats.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c > index baeb1bf..d927073 100644 > --- a/src/m

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: > On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: >> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >>> This patch fixes a bug that is manifested in the read path of mesa when >>> running on big-endian machines. The effects can be se

[Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

Cc: Iago Toral Cc: Oded Gabbay --- src/mesa/main/formats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index baeb1bf..d927073 100644 --- a/src/mesa/main/formats.c +++ b/src/mesa/main/formats.c @@ -372,10 +372,10 @@ u

Re: [Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

On Sat, 2015-08-08 at 17:23 +0800, Boyan Ding wrote: > We don't need to free driverName string from dri2 reply, on the other > hand, the driver name acquired from loader doesn't need duplication. > > This fixes commit 45e110ba > > Cc: Emil Velikov > Reported-by: Timothy Arceri > Signed-off-by:

Re: [Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

On 8 August 2015 at 10:23, Boyan Ding wrote: > We don't need to free driverName string from dri2 reply, on the other > hand, the driver name acquired from loader doesn't need duplication. > > This fixes commit 45e110ba > > Cc: Emil Velikov > Reported-by: Timothy Arceri > Signed-off-by: Boyan Din

[Mesa-dev] [PATCH] gallium/radeon: fix r600g build if LLVM is disabled

From: Marek Olšák MESA_LLVM_VERSION_PATCH is undefined. --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index d6b9a01..e50

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

Iago Toral writes: > On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: >> On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: >> > On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: >> > > On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: >> > > > --- >> > > > src/glsl/a

Re: [Mesa-dev] [PATCH] clover: Properly initialize LLVM targets when linking with component libs

Tom Stellard writes: > Calls to LLVMIntialize* fail when we are linking against individual > component libraries rather than one large shared object, because > we only include component libraries that are required by the drivers. > > We need to make sure to only initialize the targets that we nee

Re: [Mesa-dev] [PATCHv2 07/14] i965: Implement surface state set-up for shader images.

Jason Ekstrand writes: > On Wed, May 13, 2015 at 9:43 AM, Francisco Jerez > wrote: >> v2: Add SKL support. >> --- >> src/mesa/drivers/dri/i965/brw_context.h | 2 + >> src/mesa/drivers/dri/i965/brw_surface_formats.c | 109 >> +++ >> src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 1/2] i965: Add SKL support to brw_miptree_get_horizontal_slice_pitch().

Jason Ekstrand writes: > I'm not a huge fan of this patch. Really, given how complicated 3-D > textures are on SKL, there really is no sensible horizontal slice > pitch. We could return 0 as an "invalid value" but I think I'd rather > keep it an assert. Code that is dealing with 3-D textures s

Re: [Mesa-dev] [Mesa-stable] [PATCH 62/70] i965: Prevent coordinate overflow in intel_emit_linear_blit

On Fri, Aug 07, 2015 at 05:22:27PM -0700, Anuj Phogat wrote: >I don't see any new changes as compared to the original patch you sent >earlier. >Reviewed-by: Anuj Phogat <[11]anuj.pho...@gmail.com> Sorry, there were none, I just forgot about pushing to the head of the queue and commitin

[Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

We don't need to free driverName string from dri2 reply, on the other hand, the driver name acquired from loader doesn't need duplication. This fixes commit 45e110ba Cc: Emil Velikov Reported-by: Timothy Arceri Signed-off-by: Boyan Ding --- src/egl/drivers/dri2/platform_x11.c | 13 ++-

Re: [Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

2015-08-08 16:05 GMT+08:00 Timothy Arceri : > This change is causing a bunch of issues during a piglit run on my system. I'm > getting error messages like this: > > *** Error in `/home/timothy/data/piglit/bin/glslparsertest_gles2': free(): > invalid pointer: 0x022d4be0 *** > > Any ideas wha

Re: [Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

This change is causing a bunch of issues during a piglit run on my system. I'm getting error messages like this: *** Error in `/home/timothy/data/piglit/bin/glslparsertest_gles2': free(): invalid pointer: 0x022d4be0 *** Any ideas what might be wrong? __

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

Hi, On Friday, August 07, 2015 12:17:15 Ilia Mirkin wrote: > None of the other drivers appear to do it... should be safe. I'll def test > it out before pushing, of course... I've been meaning to plug a nv1x in so > I can play with a couple of minor items. Ideally it'd switch to the i965 > method,