Re: [Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-06-28 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Fri, 2015-06-26 at 13:15 -0700, Anuj Phogat wrote: > Currently used ctx->_ImageTransferState check is not sufficient > because it doesn't include the read color clamping enabled with > GL_CLAMP_READ_COLOR. So, use the helper function > _mesa_get_readpixels_trans

Re: [Mesa-dev] [PATCH] mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path

2015-06-28 Thread Iago Toral
On Mon, 2015-06-29 at 15:21 +0900, Michel Dänzer wrote: > On 25.06.2015 21:42, Marek Olšák wrote: > > Gallium should be alright. We'll let you know if we find a regression, > > but I don't think there will be any. > > Famous last words. :) This change broke the piglit test > spec@ext_texture_integ

Re: [Mesa-dev] [PATCH] mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path

2015-06-28 Thread Michel Dänzer
On 25.06.2015 21:42, Marek Olšák wrote: > Gallium should be alright. We'll let you know if we find a regression, > but I don't think there will be any. Famous last words. :) This change broke the piglit test spec@ext_texture_integer@fbo_integer_readpixels_sint_uint for me with the radeonsi driver:

Re: [Mesa-dev] [PATCH v2] glsl: use non-null context when cloning variable

2015-06-28 Thread Tapani Pälli
On 06/29/2015 08:34 AM, Kenneth Graunke wrote: On Monday, June 29, 2015 01:13:30 AM Ilia Mirkin wrote: ProgramResourceList might not yet have been initialized. In that case, parent the var to the program. Fixes: c2ff3485b3d (glsl: clone inputs and outputs during linking) Signed-off-by: Ilia M

Re: [Mesa-dev] [PATCH] i965: Don't try to print the GLSL IR if it has been freed

2015-06-28 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 06/26/2015 07:54 PM, Neil Roberts wrote: Since commit 104c8fc2c2aa5621261f8 the GLSL IR will be freed if NIR is being used. This was causing it to segfault if INTEL_DEBUG=wm is set. This patch just makes it avoid dumping the GLSL IR in that case. --- src/mesa/driv

Re: [Mesa-dev] [PATCH v2] glsl: use non-null context when cloning variable

2015-06-28 Thread Kenneth Graunke
On Monday, June 29, 2015 01:13:30 AM Ilia Mirkin wrote: > ProgramResourceList might not yet have been initialized. In that case, > parent the var to the program. > > Fixes: c2ff3485b3d (glsl: clone inputs and outputs during linking) > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-06-28 Thread Tapani Pälli
On 06/26/2015 05:38 PM, Ilia Mirkin wrote: On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli wrote: On 06/26/2015 01:06 AM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 5:08 AM, Marta Lofstedt wrote: From: Marta Lofstedt v4 : only expo

[Mesa-dev] [PATCH v2] glsl: use non-null context when cloning variable

2015-06-28 Thread Ilia Mirkin
ProgramResourceList might not yet have been initialized. In that case, parent the var to the program. Fixes: c2ff3485b3d (glsl: clone inputs and outputs during linking) Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- v1 -> v2: parent to prog only if the resource list doesn't

[Mesa-dev] [PATCH] glsl: use correct context when cloning variable

2015-06-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- I'm not really clear on how ralloc, clone, etc all work. However experimentally, this makes the leak go away from: bin/fbo-generatemipmap-formats GL_ARB_depth_texture -auto (and likely others). In fact the ProgramResourceList is reralloc'd with the shProg as a con

Re: [Mesa-dev] [PATCH] i965: Switch on shader stage in nir_setup_outputs().

2015-06-28 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-06-26 16:03:21, Kenneth Graunke wrote: > Adding new shader stages to a switch statement is less confusing than an > if-else-if ladder where all but the first case are fragment shader > specific (but don't claim to be). > > Signed-off-by: Kenneth Graunke > ---

Re: [Mesa-dev] [PATCH 2/4] egl/wayland: handle NULL native_window in create_surface

2015-06-28 Thread Michel Dänzer
On 26.06.2015 21:04, Emil Velikov wrote: > Rise EGL_BAD_NATIVE_WINDOW instead of crashing. Spelling: "Raise" -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-28 Thread Davin McCall
On 26/06/15 14:53, Francisco Jerez wrote: [...] Your first approach seemed quite reasonable IMHO. Were you able to measure any performance regression from it? Thanks. When I run an apitrace replay of a Dota 2 trace [1] with LIBGL_ALWAYS_SOFTWARE and without the patch I get (averaged over

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 --- Comment #9 from Tom Hughes --- I just looked, and there doesn't seem to be a mesa3d-dev list - did you mean mesa-dev? This bug is assigned there anyway, so presumably they are seeing all these comments... -- You are receiving this mail beca

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 Tom Hughes changed: What|Removed |Added Attachment #116242|0 |1 is obsolete|

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 --- Comment #7 from Tom Hughes --- Happy to try and improve the patch. I admit to having been a bit confused by the whole GLX_DONT_CARE thing when I was originally looking at this though because as I understand it config represents a set of capa

[Mesa-dev] [PATCH v4 1/6] mesa/main: Get rid of outdated GDB-hack

2015-06-28 Thread Erik Faye-Lund
All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/main/context.c | 27 --- 1 file changed, 27 deletions(-) diff --gi

[Mesa-dev] [PATCH v4 0/6] port _mesa_strto[df] to C

2015-06-28 Thread Erik Faye-Lund
Here's the fourth, and hopefully final version of this series. The only code-change this time is fixing up the definition of one_time_fini to have an explict void argument-list. Erik Faye-Lund (6): mesa/main: Get rid of outdated GDB-hack dri: don't touch the shader compiler mesa/main: only c

[Mesa-dev] [PATCH v4 6/6] mesa/main: free locale at exit

2015-06-28 Thread Erik Faye-Lund
In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/main/context.c | 12 +++- src/util/strtod.c | 8 +++

[Mesa-dev] [PATCH v4 2/6] dri: don't touch the shader compiler

2015-06-28 Thread Erik Faye-Lund
This function is for deleting per-screen resources, and the shader compiler resources are not of such nature. Besides, dri shouldn't need to even know about the presence of a shader compiler. These resources will already be released when mesa gets unloaded, and that should be sufficient. Signed-o

[Mesa-dev] [PATCH v4 5/6] util: port _mesa_strto[df] to C

2015-06-28 Thread Erik Faye-Lund
_mesa_strtod and _mesa_strtof are only used from the GLSL compiler and the ARB_[vertex|fragment]_program code, meaning that the locale doesn't need to be initialized before the first OpenGL context gets initialized. So let's use explicit initialization from the one-time init code instead of depend

[Mesa-dev] [PATCH v4 3/6] mesa/main: only call _mesa_destroy_shader_compiler once on exit

2015-06-28 Thread Erik Faye-Lund
There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/

[Mesa-dev] [PATCH v4 4/6] glsl: No need to lock in _mesa_glsl_release_types

2015-06-28 Thread Erik Faye-Lund
This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/glsl/glsl_types.cpp | 8 1 file ch

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 José Fonseca changed: What|Removed |Added CC||jfons...@vmware.com --- Comment #6 from J

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-28 Thread Jose Fonseca
On 25/06/15 23:18, Julien Isorce wrote: On 19 June 2015 at 10:24, Jose Fonseca mailto:jfons...@vmware.com>> wrote: On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY mailto:jon.tur...@dronecode.org.uk>> On

Re: [Mesa-dev] [Nouveau] [RFC PATCH 6/8] nv50: add support for compute/graphics global performance counters

2015-06-28 Thread Samuel Pitoiset
On 06/26/2015 01:09 AM, Ilia Mirkin wrote: What's with the \%'s everywhere? Maybe "percent" will be better ? On Mon, Jun 22, 2015 at 4:53 PM, Samuel Pitoiset wrote: This commit adds support for both compute and graphics global performance counters which have been reverse engineered with

Re: [Mesa-dev] [Nouveau] [RFC PATCH 4/8] nv50: configure the ring buffer for reading back PM counters

2015-06-28 Thread Samuel Pitoiset
On 06/26/2015 01:04 AM, Ilia Mirkin wrote: Yeah, this whole thing has to be guarded by a drm version check, otherwise it'll end up with errors in dmesg I assume. Perhaps only allocate screen->query when the drm version matches, and gate things on that for the rest of the code? Yes, this sound

Re: [Mesa-dev] [Nouveau] [RFC PATCH 3/8] nv50: allocate and map a notifier buffer object for PM

2015-06-28 Thread Samuel Pitoiset
On 06/26/2015 01:02 AM, Ilia Mirkin wrote: On Mon, Jun 22, 2015 at 4:53 PM, Samuel Pitoiset wrote: This notifier buffer object will be used to read back global performance counters results written by the kernel. For each domain, we will store the handle of the perfdom object, an array of 4 c