[Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes

2015-05-23 Thread Ilia Mirkin
nv30_validate_clip depends on the rasterizer state. Also we should upload all the new clip planes on change since next time the plane data won't have changed, but the enables might. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 16 +++- 1 fil

[Mesa-dev] [PATCH 1/2] nv30: avoid doing extra work on clear and hitting unexpected states

2015-05-23 Thread Ilia Mirkin
Clearing can happen at a time when various state objects are incoherent and not ready for a draw. Some of the validation functions don't handle this well, so only flush the framebuffer state. This has the advantage of also not doing extra work. This works around some crashes that can happen when c

Re: [Mesa-dev] [PATCH 1/2] gallivm: don't use control flow when doing indirect constant buffer lookups

2015-05-23 Thread Ilia Mirkin
Hi Roland, I've just bisected a nv30 swtnl regression to this commit. When running the nv30 driver (on a NV44, if it matters) and forcing swtnl (NV30_SWTNL=1), glxgears from 60% broken to 100% broken. Now, I'm not sure what the initial breakage is, but at least it shows a gears-looking thing some

Re: [Mesa-dev] [PATCH v2] nv50/ir: avoid messing up arg1 of PFETCH

2015-05-23 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 23.05.2015 18:56, Ilia Mirkin wrote: There can be scenarios where the "indirect" arg of a PFETCH becomes known, and so the code will attempt to propagate it. Use this opportunity to just fold it into the first argument, and prevent the load propagation pass from

Re: [Mesa-dev] [PATCH 2/2] clover: try userptr for CL_MEM_USE_HOST_PTR

2015-05-23 Thread Grigori Goronzy
On 23.05.2015 15:53, Francisco Jerez wrote: >> diff --git a/src/gallium/state_trackers/clover/core/resource.cpp >> b/src/gallium/state_trackers/clover/core/resource.cpp >> index 8ed4c42..8e51b3c 100644 >> --- a/src/gallium/state_trackers/clover/core/resource.cpp >> +++ b/src/gallium/state_trackers

[Mesa-dev] [PATCH] i965: Delete GS scratch space workaround warning.

2015-05-23 Thread Kenneth Graunke
This workaround is documented in the 3DSTATE_GS documentation. It appears to only apply to early steppings of Broadwell and Skylake. I don't think it ever affected production hardware, so at this point it probably makes sense to delete it. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] i965/skl: Add a message header for the TXF_MCS instruction in vec4vs

2015-05-23 Thread Kenneth Graunke
On Thursday, May 21, 2015 04:59:13 PM Neil Roberts wrote: > When using SIMD4x2 on Skylake, the sampler instructions need a message > header to select the correct mode. This was added for most sample > instructions in 0ac4c2727 but the TXF_MCS instruction is emitted > separately and it was missed. >

Re: [Mesa-dev] [PATCH] i965/fs: Fix implied_mrf_writes for scratch writes

2015-05-23 Thread Kenneth Graunke
On Saturday, May 23, 2015 11:57:32 AM Jason Ekstrand wrote: > On Sat, May 23, 2015 at 11:53 AM, Kenneth Graunke > wrote: > > On Tuesday, May 19, 2015 05:37:04 PM Jason Ekstrand wrote: > >> We build the entire message in the generator so all the MRF writes are > >> implied. > >> --- > >> src/mesa

Re: [Mesa-dev] [PATCH] i965/fs: Fix implied_mrf_writes for scratch writes

2015-05-23 Thread Jason Ekstrand
On Sat, May 23, 2015 at 11:53 AM, Kenneth Graunke wrote: > On Tuesday, May 19, 2015 05:37:04 PM Jason Ekstrand wrote: >> We build the entire message in the generator so all the MRF writes are >> implied. >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH] i965/fs: Fix implied_mrf_writes for scratch writes

2015-05-23 Thread Kenneth Graunke
On Tuesday, May 19, 2015 05:37:04 PM Jason Ekstrand wrote: > We build the entire message in the generator so all the MRF writes are > implied. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/2] prog_to_nir: Use a variable for uniform data

2015-05-23 Thread Jason Ekstrand
On Sat, May 23, 2015 at 11:47 AM, Kenneth Graunke wrote: > On Tuesday, May 19, 2015 05:28:17 PM Jason Ekstrand wrote: >> Previously, the prog_to_nir pass was directly generating uniform load/store >> intrinsics. This converts it to use a single giant "parameters" variable >> and we now depend on

Re: [Mesa-dev] [PATCH 1/2] prog_to_nir: Use a variable for uniform data

2015-05-23 Thread Kenneth Graunke
On Tuesday, May 19, 2015 05:28:17 PM Jason Ekstrand wrote: > Previously, the prog_to_nir pass was directly generating uniform load/store > intrinsics. This converts it to use a single giant "parameters" variable > and we now depend on lowering to get the uniform load/store intrinsics. > One advant

Re: [Mesa-dev] [PATCH v2] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Samuel Pitoiset
On 05/23/2015 06:59 PM, Ilia Mirkin wrote: On Sat, May 23, 2015 at 12:59 PM, Samuel Pitoiset wrote: On 05/23/2015 06:53 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Seems in line with nvc0, but I assume you tested this? e.g. the occlquery mesa demo, or the relevant piglit tests? Yes.

Re: [Mesa-dev] [PATCH v2] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Ilia Mirkin
On Sat, May 23, 2015 at 12:59 PM, Samuel Pitoiset wrote: > > > On 05/23/2015 06:53 PM, Ilia Mirkin wrote: >> >> Reviewed-by: Ilia Mirkin >> >> Seems in line with nvc0, but I assume you tested this? e.g. the >> occlquery mesa demo, or the relevant piglit tests? > > > Yes. And I added a temporary e

[Mesa-dev] [PATCH v2] nv50/ir: avoid messing up arg1 of PFETCH

2015-05-23 Thread Ilia Mirkin
There can be scenarios where the "indirect" arg of a PFETCH becomes known, and so the code will attempt to propagate it. Use this opportunity to just fold it into the first argument, and prevent the load propagation pass from touching PFETCH further. This fixes gs-input-array-vec4-index-rd.shader_

Re: [Mesa-dev] [PATCH v2] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Samuel Pitoiset
On 05/23/2015 06:53 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Seems in line with nvc0, but I assume you tested this? e.g. the occlquery mesa demo, or the relevant piglit tests? Yes. And I added a temporary entry to the Gallium HUD for testing timestamp-disjoint. On Sat, May 23, 2

Re: [Mesa-dev] [PATCH v2] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Seems in line with nvc0, but I assume you tested this? e.g. the occlquery mesa demo, or the relevant piglit tests? On Sat, May 23, 2015 at 12:52 PM, Samuel Pitoiset wrote: > PIPE_QUERY_TIMESTAMP_DISJOINT could not work because q->ready was always > set to FALSE. To fix

Re: [Mesa-dev] [PATCH] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Samuel Pitoiset
On 05/23/2015 06:47 PM, Ilia Mirkin wrote: On Sat, May 23, 2015 at 12:46 PM, Samuel Pitoiset wrote: PIPE_QUERY_TIMESTAMP_DISJOINT could not work because q->ready was always set to FALSE. To fix this issue, add more different states for queries according to nvc0. Signed-off-by: Samuel Pitoise

[Mesa-dev] [PATCH v2] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Samuel Pitoiset
PIPE_QUERY_TIMESTAMP_DISJOINT could not work because q->ready was always set to FALSE. To fix this issue, add more different states for queries according to nvc0. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 39 +++ 1 file changed, 22

Re: [Mesa-dev] [PATCH] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Ilia Mirkin
On Sat, May 23, 2015 at 12:46 PM, Samuel Pitoiset wrote: > PIPE_QUERY_TIMESTAMP_DISJOINT could not work because q->ready was always > set to FALSE. To fix this issue, add more different states for queries > according to nvc0. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau

[Mesa-dev] [PATCH] nv50: fix PIPE_QUERY_TIMESTAMP_DISJOINT, based on nvc0

2015-05-23 Thread Samuel Pitoiset
PIPE_QUERY_TIMESTAMP_DISJOINT could not work because q->ready was always set to FALSE. To fix this issue, add more different states for queries according to nvc0. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 39 +- .../drivers/nouveau/nvc0/nvc0_query_h

Re: [Mesa-dev] [PATCH 2/2] clover: try userptr for CL_MEM_USE_HOST_PTR

2015-05-23 Thread Francisco Jerez
Grigori Goronzy writes: > According to spec, CL_MEM_USE_HOST_PTR should directly use host memory, > if possible. This is just what userptr is for, so use it. > > In case the memory cannot be mapped, a fallback similar to > CL_MEM_COPY_HOST_PTR is used. > --- > src/gallium/state_trackers/clover/c

Re: [Mesa-dev] [PATCH 1/2] clover: implement CL_MEM_ALLOC_HOST_PTR

2015-05-23 Thread Francisco Jerez
Grigori Goronzy writes: > This flag is typically used to request pinned host memory, to avoid > any copies between GPU and CPU. > > This improves throughput with an older OpenCL app which I unfortunately > can't publish due to its licensing. > --- > src/gallium/state_trackers/clover/core/resourc

Re: [Mesa-dev] [PATCH 01/15] egl: remove unused _egl_global::ClientExtensions

2015-05-23 Thread Marek Olšák
Ping. Nobody has given me Reviewed-by for this series yet. Marek On Wed, May 13, 2015 at 12:54 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglglobals.c | 10 -- > src/egl/main/eglglobals.h | 9 - > 2 files changed, 19 deletions(-) > > diff --git a/src/eg

[Mesa-dev] [PATCH 1/3] egl: import egl.h from registry (v2)

2015-05-23 Thread Marek Olšák
From: Marek Olšák v2: split the commit into 3 patches --- include/EGL/egl.h | 562 ++ 1 file changed, 268 insertions(+), 294 deletions(-) diff --git a/include/EGL/egl.h b/include/EGL/egl.h index 99ea342..0d514e4 100644 --- a/include/EGL/egl.h

[Mesa-dev] [PATCH 2/3] egl: import eglext.h from registry and cleanup eglmesaext.h (v2)

2015-05-23 Thread Marek Olšák
From: Marek Olšák v2: include mesa and chromium extensions in eglext.h so as not to break existing users --- include/EGL/eglext.h | 258 --- include/EGL/eglmesaext.h | 34 --- 2 files changed, 246 insertions(+), 46 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] egl: import platform headers from registry (v2)

2015-05-23 Thread Marek Olšák
From: Marek Olšák v2: don't remove local Mesa changes --- include/EGL/eglplatform.h | 19 +-- include/KHR/khrplatform.h | 19 --- 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h index 2eb6865..

[Mesa-dev] [Bug 90600] IOError: [Errno 2] No such file or directory: 'gl_API.xml'

2015-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90600 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|