[Mesa-dev] [PATCH 1/4] Whitespace cleanup

2015-03-06 Thread Giuseppe Bilotta
--- src/gallium/include/pipe/p_screen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index ac88506..4018f8a 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_screen.h @

[Mesa-dev] [PATCH 2/4] Introduce get_device_vendor() entrypoint for pipes

2015-03-06 Thread Giuseppe Bilotta
This will be needed by Clover to return the correct information to CL_DEVICE_VENDOR info queries. --- src/gallium/docs/source/screen.rst | 6 ++ src/gallium/include/pipe/p_screen.h | 8 2 files changed, 14 insertions(+) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/

[Mesa-dev] [PATCHv3 0/4] Separate device from driver vendor

2015-03-06 Thread Giuseppe Bilotta
OpenCL (as opposed to OpenGL) has separate vendor strings for the implementation/driver/platform and the device. CL_PLATFORM_VENDOR is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to return the actual device vendor. (For example, the AMD OpenCL platform returns GenuineIntel as

[Mesa-dev] [PATCH 3/4] Implement get_device_vendor() for existing drivers

2015-03-06 Thread Giuseppe Bilotta
The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. --- src/gallium/drivers/freedreno/freedreno_screen.c | 8 src/gallium/drivers/galahad/glhd_screen.c| 10 ++ src/ga

[Mesa-dev] [PATCH 4/4] Clover: use get_device_vendor instead of get_vendor

2015-03-06 Thread Giuseppe Bilotta
The pipe's get_vendor method returns something more akin to a driver vendor string in most cases, instead of the actual device vendor. Use get_device_vendor instead, which was introduced specifically for this purpose. --- src/gallium/state_trackers/clover/core/device.cpp | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, ^ Suggested-by: Ilia Mirkin Signed-off-by: Vinson Lee --- src/egl/drivers

[Mesa-dev] [PATCH v2] nv30: Add unused attribute to function nv40_fp_bra.

2015-03-06 Thread Vinson Lee
Silences GCC unused-function warning. nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function] nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 2 +- 1 file changed, 1 inse

[Mesa-dev] [PATCH 1/4] Whitespace cleanup

2015-03-06 Thread Giuseppe Bilotta
--- src/gallium/include/pipe/p_screen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index ac88506..4018f8a 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_screen.h @

[Mesa-dev] [PATCH 4/4] Clover: use get_device_vendor instead of get_vendor

2015-03-06 Thread Giuseppe Bilotta
The pipe's get_vendor method returns something more akin to a driver vendor string in most cases, instead of the actual device vendor. Use get_device_vendor instead, which was introduced specifically for this purpose. --- src/gallium/state_trackers/clover/core/device.cpp | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 3/4] Implement get_device_vendor() for existing drivers

2015-03-06 Thread Giuseppe Bilotta
The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. --- src/gallium/drivers/freedreno/freedreno_screen.c | 8 src/gallium/drivers/galahad/glhd_screen.c| 10 ++ src/ga

[Mesa-dev] [PATCH 2/4] Introduce get_device_vendor() entrypoint for pipes

2015-03-06 Thread Giuseppe Bilotta
This will be needed by Clover to return the correct information to CL_DEVICE_VENDOR info queries. --- src/gallium/include/pipe/p_screen.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index 4018f8a..cba4c95 1

[Mesa-dev] [PATCHv2 0/4] Separate device from driver vendor

2015-03-06 Thread Giuseppe Bilotta
OpenCL (as opposed to OpenGL) has separate vendor strings for the implementation/driver/platform and the device. CL_PLATFORM_VENDOR is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to return the actual device vendor. (For example, the AMD OpenCL platform returns GenuineIntel as

Re: [Mesa-dev] [PATCH] nouveau: Silence GCC maybe-uninitialized warnings.

2015-03-06 Thread Ilia Mirkin
On Sat, Mar 7, 2015 at 2:23 AM, Vinson Lee wrote: > nouveau_compiler.c: In function ‘main’: > nouveau_compiler.c:216:27: warning: ‘code’ may be used uninitialized in this > function [-Wmaybe-uninitialized] >printf("%08x ", code[i / 4]); >^ > nouveau_compiler.c:

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Jose Fonseca
On 07/03/15 07:23, Jose Fonseca wrote: On 06/03/15 18:26, Brian Paul wrote: On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov mailto:emil.l.veli...@gm

[Mesa-dev] [PATCH] nouveau: Silence GCC maybe-uninitialized warnings.

2015-03-06 Thread Vinson Lee
nouveau_compiler.c: In function ‘main’: nouveau_compiler.c:216:27: warning: ‘code’ may be used uninitialized in this function [-Wmaybe-uninitialized] printf("%08x ", code[i / 4]); ^ nouveau_compiler.c:215:4: warning: ‘size’ may be used uninitialized in this funct

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Jose Fonseca
On 06/03/15 18:26, Brian Paul wrote: On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov mailto:emil.l.veli...@gmail.com>> --- include/c11_stdl

Re: [Mesa-dev] [PATCH] nv30: Remove unused function nv40_fp_bra.

2015-03-06 Thread Ilia Mirkin
On Sat, Mar 7, 2015 at 2:15 AM, Vinson Lee wrote: > Fix GCC unused-function warning. > > nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used > [-Wunused-function] > nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) > ^ NAK. Feel free to ifdef it out if it really annoys you

Re: [Mesa-dev] [PATCH] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-06 Thread Ilia Mirkin
On Sat, Mar 7, 2015 at 2:08 AM, Vinson Lee wrote: > egl_dri2.c: In function ‘dri2_bind_tex_image’: > egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, > ^ > > Signed-off

[Mesa-dev] [PATCH] nv30: Remove unused function nv40_fp_bra.

2015-03-06 Thread Vinson Lee
Fix GCC unused-function warning. nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function] nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 26 1 fi

[Mesa-dev] [PATCH] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, ^ Signed-off-by: Vinson Lee --- src/egl/drivers/dri2/egl_dri2.c | 1 + 1 f

[Mesa-dev] [PATCH] radeon: Fix GCC unused-but-set-variable warnings.

2015-03-06 Thread Vinson Lee
radeon_fbo.c: In function ‘radeon_map_renderbuffer_s8z24’: radeon_fbo.c:162:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret; ^ radeon_fbo.c: In function ‘radeon_map_renderbuffer_z16’: radeon_fbo.c:200:9: warning: variable ‘ret’ set but not used [-Wunu

[Mesa-dev] [PATCH] i965: Silence GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
brw_shader.cpp: In function ‘bool brw_saturate_immediate(brw_reg_type, brw_reg*)’: brw_shader.cpp:618:31: warning: ‘sat_imm.brw_saturate_immediate(brw_reg_type, brw_reg*)ud’ may be used uninitialized in this function [-Wmaybe-uninitialized] reg->dw1.ud = sat_imm.ud;

[Mesa-dev] [PATCH] i915: Fix GCC unused-but-set-variable warning in release build.

2015-03-06 Thread Vinson Lee
i915_fragprog.c: In function ‘i915ValidateFragmentProgram’: i915_fragprog.c:1453:11: warning: variable ‘k’ set but not used [-Wunused-but-set-variable] int k; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/i915_fragprog.c | 5 + 1 file changed, 1 insertion(+), 4

Re: [Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Eric Anholt
Kenneth Graunke writes: > The code in glsl_to_nir is entirely dead, as we translate from GLSL to > NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, > so every caller passes NULL. > > glsl_to_nir seems like the wrong place to try and create the shader > compiler options structu

[Mesa-dev] [PATCH] meta: Plug memory leak in blit shader creation

2015-03-06 Thread Ben Widawsky
It looks like this has existed since: commit f5a477ab76b6e0b268387699cd2253a43db0dfae Author: Ian Romanick Date: Mon Dec 16 11:54:08 2013 -0800 meta: Refactor shader generation code out of mipmap generation path Valgrind was complaining on the piglit test: fbo-generatemipmap-formats GL_ARB

[Mesa-dev] Mesa 10.5.0

2015-03-06 Thread Emil Velikov
Mesa 10.5.0 is now available. It's the three month effort of over 80 individuals, resulting in an excess of 1400 commits. Thanks to all who have contributed. Here are some of the highlights: - Initial support for the new Intel Skylake GPUs and Adreno 4xx GPUs. - Experimental EGL support for Haiku.

[Mesa-dev] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

2015-03-06 Thread Anuj Phogat
in different fragment shaders. This also applies to a case when gl_FragCoord is redeclared with no layout qualifiers in one fragment shader and not declared but used in other fragment shader. Signed-off-by: Anuj Phogat Khronos Bug#12957 Cc: "10.5" Cc: Ian Romanick --- src/glsl/linker.cpp | 15

Re: [Mesa-dev] [PATCH 2/2] radeonsi/compute: Use value from compiler for COMPUTE_PGM_RSRC1.FLOAT_MODE

2015-03-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Mar 6, 2015 at 4:53 PM, Tom Stellard wrote: > --- > src/gallium/drivers/radeonsi/si_compute.c | 3 ++- > src/gallium/drivers/radeonsi/si_shader.c | 1 + > src/gallium/drivers/radeonsi/si_shader.h | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-)

[Mesa-dev] Mesa 10.4.6

2015-03-06 Thread Emil Velikov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 10.4.6 has been released. Mesa 10.4.6 is a bug fix release fixing bugs since the 10.4.5 release, (see below for a list of changes). The tag in the git repository for Mesa 10.4.6 is 'mesa-10.4.6'. Mesa 10.4.6 is available for download at ftp://fr

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chad Versace
On 03/06/2015 01:58 PM, Chris Wilson wrote: > In order to facilitate the concurrency offered by triple buffering and to > offset the latency induced by swapping via an external process, which > may incur extra rendering itself, only throttle to the previous frame > and not the last. The second issu

Re: [Mesa-dev] [PATCH, v2 2/2] r300g: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Jose Fonseca
On 06/03/15 21:36, Mark Janes wrote: A previous patch to fix header inclusion within extern "C" neglected to fix the occurences of this pattern in r300 files. When the helper to detect this issue was pushed to master, it broke the build for the r300 driver. This patch fixes the r300 build. Bug

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

[Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chris Wilson
In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. The second issue that mostly affects swap benchmarks, but also can

Re: [Mesa-dev] [PATCH, v2 1/2] nouveau: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin Thanks for splitting them up! On Fri, Mar 6, 2015 at 4:36 PM, Mark Janes wrote: > A previous patch to fix header inclusion within extern "C" neglected > to fix the occurences of this pattern in nouveau files. > > When the helper to detect this issue was pushe

[Mesa-dev] [PATCH, v2 1/2] nouveau: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Mark Janes
A previous patch to fix header inclusion within extern "C" neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla: https://bugs.freedeskto

[Mesa-dev] [PATCH, v2 2/2] r300g: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Mark Janes
A previous patch to fix header inclusion within extern "C" neglected to fix the occurences of this pattern in r300 files. When the helper to detect this issue was pushed to master, it broke the build for the r300 driver. This patch fixes the r300 build. Bugzilla: https://bugs.freedesktop.org/sho

Re: [Mesa-dev] [PATCH] nouveau: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin However you should probably split off the r300_public.h change into a separate commit -- a little awkward to have 'nouveau:' as the subject of a change to r300. -ilia On Fri, Mar 6, 2015 at 4:16 PM, Mark Janes wrote: > The previous patch to fix header inclusion withi

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 --- Comment #2 from Mark Janes --- patch sent to list. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@

[Mesa-dev] [PATCH] nouveau: Fix build, invalid extern "C" around header inclusion.

2015-03-06 Thread Mark Janes
The previous patch to fix header inclusion within extern "C" neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla: https://bugs.freedesk

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 --- Comment #1 from Mark Janes --- Can you please include your configure line? I'm having trouble reproducing your failure. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

2015-03-06 Thread Mark Janes
Unfortunately, my build configuration does not build gallium. This caused me to miss some files which still have extern C includes. Due to this oversight, master encounters build errors. I'll send a patch asap. -Mark Mark Janes writes: > Assuming my patch to fix 'extern "C"' issues is pushed

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 Bug ID: 89477 Summary: include/no_extern_c.h:47:1: error: template with C linkage Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chad Versace
On 03/06/2015 06:56 AM, Chris Wilson wrote: > In order to facilitate the concurrency offered by triple buffering and to > offset the latency induced by swapping via an external process, which > may incur extra rendering itself, only throttle to the previous frame > and not the last. This doubles th

Re: [Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chad Versace
On 03/06/2015 06:56 AM, Chris Wilson wrote: > When rendering to an fbo, even though it may be acting as a winsys > frontbuffer or just generally, we never throttle. However, when rendering > to an fbo, there is no natural frame boundary. Conventionally we use > SwapBuffers and glFinish, but potenti

[Mesa-dev] [PATCH] i965/skl: Fix the order of the arguments for the LD sampler message

2015-03-06 Thread Neil Roberts
In Skylake the order of the arguments for sample messages with the LD type are u, v, lod, r whereas previously they were u, lod, v, r. This fixes 82 Piglit tests using texelFetch. --- I have a feeling this probably isn't the right way to do this patch so maybe someone who knows the compiler better

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Matt Arsenault
> On Mar 6, 2015, at 8:56 AM, Francisco Jerez wrote: > > Tom Stellard mailto:t...@stellard.net>> writes: > >> On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: >>> Tom Stellard writes: >>> This means dropping CL_FP_DENORM from the current return value. --- src/ga

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

2015-03-06 Thread Emil Velikov
On 4 March 2015 at 18:07, Roland Scheidegger wrote: > Am 04.03.2015 um 12:38 schrieb Jose Fonseca: >> On 04/03/15 02:00, Emil Velikov wrote: >>> On 27 February 2015 at 23:28, Sedat Dilek wrote: On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov wrote: > On 07/02/15 21:44, Sedat Dilek wro

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Brian Paul
On Fri, Mar 6, 2015 at 11:26 AM, Brian Paul wrote: > On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov > wrote: > >> Used for aligned_alloc and other C11 functions missing from the header. >> >> Signed-off-by: Emil Velikov >> --- >> include/c11_stdlib.h | 118 ++ > > > I

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Brian Paul
On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov wrote: > Used for aligned_alloc and other C11 functions missing from the header. > > Signed-off-by: Emil Velikov > --- > include/c11_stdlib.h | 118 ++ I wonder if this should be include/c11/stdlib.h instead. I also wond

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Brian Paul
On Fri, Mar 6, 2015 at 10:14 AM, Emil Velikov wrote: > On 06/03/15 17:05, Emil Velikov wrote: > > Hi all, > > > > Just accidently pushed the series to master. I'll revert them in a > second. > > > All done. Apologies for the noise. Series looks OK to me. You can re-push with Reviewed-by: Brian

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Francisco Jerez
Jan Vesely writes: > On Fri, 2015-03-06 at 15:53 +, Tom Stellard wrote: >> This means dropping CL_FP_DENORM from the current return value. >> >> v2: >> - Add comments about minimum values for OpenCL 1.2. >> --- >> src/gallium/state_trackers/clover/api/device.cpp | 5 - >> 1 file chang

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Jan Vesely
On Fri, 2015-03-06 at 15:53 +, Tom Stellard wrote: > This means dropping CL_FP_DENORM from the current return value. > > v2: > - Add comments about minimum values for OpenCL 1.2. > --- > src/gallium/state_trackers/clover/api/device.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletio

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
On 06/03/15 17:05, Emil Velikov wrote: > Hi all, > > Just accidently pushed the series to master. I'll revert them in a second. > All done. Apologies for the noise. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
On 06/03/15 17:05, Emil Velikov wrote: > Hi all, > > Just accidently pushed the series to master. I'll revert them in a second. > All done. Apologies for the noise. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
Hi all, Just accidently pushed the series to master. I'll revert them in a second. -Emil On 06/03/15 16:54, Emil Velikov wrote: > Remove the inline wrappers/abstraction layer. > > Signed-off-by: Emil Velikov > --- > src/egl/main/Makefile.sources | 1 - > src/egl/main/eglapi.c | 14 +

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Francisco Jerez
Tom Stellard writes: > On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > This means dropping CL_FP_DENORM from the current return value. >> > --- >> > src/gallium/state_trackers/clover/api/device.cpp | 4 +++- >> > 1 file changed, 3 insertions(+),

[Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Tom Stellard
This means dropping CL_FP_DENORM from the current return value. v2: - Add comments about minimum values for OpenCL 1.2. --- src/gallium/state_trackers/clover/api/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH 2/2] radeonsi/compute: Use value from compiler for COMPUTE_PGM_RSRC1.FLOAT_MODE

2015-03-06 Thread Tom Stellard
--- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi/si_shader.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_comput

[Mesa-dev] [PATCH 3/5] configure: require pthreads for POSIX builds

2015-03-06 Thread Emil Velikov
This has been an implicit rule for building mesa for a long time. Let's make it official and just bail out at configure time. This way we can cleaning up some of our glx code. Signed-off-by: Emil Velikov --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/confi

[Mesa-dev] [PATCH 4/5] glx: remove final reference to THREADS

2015-03-06 Thread Emil Velikov
Left over from commit 18db13f5865(mapi: THREADS was always defined, remove it) Signed-off-by: Emil Velikov --- src/glx/glxcurrent.c | 4 1 file changed, 4 deletions(-) diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c index dc2acd5..86fb658 100644 --- a/src/glx/glxcurrent.c +++ b/sr

[Mesa-dev] [PATCH 2/5] egl/main: convert thread management to use c11 threads

2015-03-06 Thread Emil Velikov
Convert the code to use the C11 threads implementation, and nuke the Windows non-pthreads code-path. The c11/threads_win32.h abstraction should be better than the current code. Signed-off-by: Emil Velikov --- src/egl/main/eglcurrent.c | 48 ++- 1 file

[Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
Remove the inline wrappers/abstraction layer. Signed-off-by: Emil Velikov --- src/egl/main/Makefile.sources | 1 - src/egl/main/eglapi.c | 14 + src/egl/main/eglcurrent.c | 13 - src/egl/main/egldisplay.c | 13 + src/egl/main/egldisplay.h | 4 +-- sr

[Mesa-dev] [PATCH 5/5] glx: remove support for non-multithreaded platforms

2015-03-06 Thread Emil Velikov
Implicitly required for a while, although commit 9385c592c68 (mapi: remove u_thread.h) was the one that put the final nail on the coffin. Signed-off-by: Emil Velikov --- docs/dispatch.html| 7 ++- src/glx/glxclient.h | 18 +- src/glx/glxcurrent.

Re: [Mesa-dev] [PATCH 1/5] i915: Remove unused IS_MOBILE macro

2015-03-06 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2015-03-05 11:49:54, Ian Romanick wrote: > From: Ian Romanick > > Inspired by Damien's recent libdrm changes. > > Signed-off-by: Ian Romanick > Cc: Damien Lespiau > --- > src/mesa/drivers/dri/i915/intel_chipset.h | 10 -- > 1 file changed, 10 del

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Tom Stellard
On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > This means dropping CL_FP_DENORM from the current return value. > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --g

Re: [Mesa-dev] [PATCH 5/6] st/mesa: don't use the mesa wrapper _mesa_align_free

2015-03-06 Thread Ilia Mirkin
On Fri, Mar 6, 2015 at 11:32 AM, Emil Velikov wrote: > Upon closer look it seems that TexData is no longer used. Perhaps > we can nuke it ? http://patchwork.freedesktop.org/patch/43969/ > > Signed-off-by: Emil Velikov > --- > src/mesa/state_tracker/st_cb_texture.c | 6 -- > 1 file changed,

[Mesa-dev] [PATCH 4/6] dri/intel: the aligned_alloc/free over the _mesa_* wrappers

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 19 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 5 +++-- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_buffer_objects.c b/src/mesa/dri

[Mesa-dev] [PATCH 5/6] st/mesa: don't use the mesa wrapper _mesa_align_free

2015-03-06 Thread Emil Velikov
Upon closer look it seems that TexData is no longer used. Perhaps we can nuke it ? Signed-off-by: Emil Velikov --- src/mesa/state_tracker/st_cb_texture.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 2/6] mesa: inline _mesa_align_{re, c}alloc into their only users

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/main/imports.c | 74 +-- src/mesa/main/imports.h | 7 src/mesa/program/prog_parameter.c | 18 +++--- src/mesa/tnl/t_vertex.c | 5 ++- 4 files changed, 18 insertions(+), 86 deletio

[Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Emil Velikov
Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov --- include/c11_stdlib.h | 118 +++ 1 file changed, 118 insertions(+) create mode 100644 include/c11_stdlib.h diff --git a/include/c11_stdlib.h b/

[Mesa-dev] [PATCH 3/6] mesa: use c11_stdlib.h' aligned_alloc/free

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/main/bufferobj.c | 8 +--- src/mesa/math/m_debug_norm.c | 6 -- src/mesa/math/m_debug_xform.c | 6 -- src/mesa/math/m_matrix.c | 10 ++ src/mesa/math/m_vector.c | 5 +++-- src/mesa/program/prog_par

[Mesa-dev] [PATCH 0/6] Slimdown import.[ch] - add c11_stdlib.h wrapper

2015-03-06 Thread Emil Velikov
C11 introduces the aligned_alloc() function, while mesa already has it's own wrapper. Create a new header, and make use of it. I was aiming to convert gallium as well, although that code diverges depending on the debugging state required but wrapping around malloc and friends. #This series poi

[Mesa-dev] [PATCH 6/6] mesa/main: remove _mesa_align_malloc/free

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/main/imports.c | 76 - src/mesa/main/imports.h | 6 2 files changed, 82 deletions(-) diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c index 5961587..3937a02 100644 --- a/src/mesa/main/imp

[Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chris Wilson
In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. This doubles the maximum possible latency at the benefit of improvi

Re: [Mesa-dev] [PATCH 1/5] i915: Remove unused IS_MOBILE macro

2015-03-06 Thread Damien Lespiau
On Thu, Mar 05, 2015 at 11:49:54AM -0800, Ian Romanick wrote: > From: Ian Romanick > > Inspired by Damien's recent libdrm changes. > > Signed-off-by: Ian Romanick > Cc: Damien Lespiau For the whole series (not that my r-b tag has a lot of value on the mesa code base): Reviewed-by: Damien Les

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

Re: [Mesa-dev] [PATCH 1/2] util: rework _MSC_VER >= 1200 checks

2015-03-06 Thread Jose Fonseca
On 06/03/15 14:26, Brian Paul wrote: On 03/06/2015 05:34 AM, Emil Velikov wrote: Replace the _MSC_VER >= 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov --- src/util/macros.h | 8 +++- 1 file

Re: [Mesa-dev] [PATCH 1/6] glsl: Mark array access when copying to a temporary for the ?: operator.

2015-03-06 Thread Jason Ekstrand
I gave you an back on 3; I'll let Eric actually review it. The rest are Reviewed-by: Jason Ekstrand On Mar 6, 2015 2:18 AM, "Kenneth Graunke" wrote: > Piglit's spec/glsl-1.20/compiler/structure-and-array-operations/ > array-selection.vert test contains the following code: > >gl_Position =

Re: [Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Mar 6, 2015 2:18 AM, "Kenneth Graunke" wrote: > The code in glsl_to_nir is entirely dead, as we translate from GLSL to > NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, > so every caller passes NULL. > > glsl_to_nir seems like the wrong place to t

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-06 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 02:38:44PM -0800, Ian Romanick wrote: > On 03/04/2015 10:28 AM, Chad Versace wrote: > > That text does not appear in the GL spec. When I read the manpage alongside > > the GL spec, to get a more complete context, I think the manpage contains > > that phrase simply to contras

Re: [Mesa-dev] [PATCH 1/2] util: rework _MSC_VER >= 1200 checks

2015-03-06 Thread Brian Paul
On 03/06/2015 05:34 AM, Emil Velikov wrote: Replace the _MSC_VER >= 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov --- src/util/macros.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

Re: [Mesa-dev] [PATCH 2/2] glx: remove unneeded ifdef _WIN32 guard

2015-03-06 Thread Brian Paul
On 03/06/2015 05:34 AM, Emil Velikov wrote: The C99 header exists on other platforms as well. Signed-off-by: Emil Velikov --- src/glx/glxclient.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index a140c87..122ae5d 100644 --- a/src/glx/glxclie

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- >> src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 >> ++-- >> src/mesa/drivers/dri/i965/brw_fs_gene

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 > ++-- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 55 +---

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 02:46:51PM +0200, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: > >> "Pohjolainen, Topi" writes: > >> > >> > On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: > >> >> Change brw_

Re: [Mesa-dev] [PATCH 08/13] i965/vec4: Add support for untyped surface message sends from GRF.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Feb 27, 2015 at 05:34:51PM +0200, Francisco Jerez wrote: >> This doesn't actually enable untyped surface message sends from GRF >> yet, the upcoming atomic counter and image intrinsic lowering code >> will. >> --- >> src/mesa/drivers/dri/i965/brw_vec4.cpp

Re: [Mesa-dev] [PATCH 04/13] i965: Mask out unused Align16 components in brw_untyped_atomic.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Feb 27, 2015 at 05:34:47PM +0200, Francisco Jerez wrote: >> This is currently not a problem because the vec4 visitor happens to >> mask out unused components from the destination, but it might become >> an issue when we start using atomics without writeback m

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: >> "Pohjolainen, Topi" writes: >> >> > On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: >> >> Change brw_untyped_atomic() and brw_untyped_surface_read() to take the >> >> surface index

Re: [Mesa-dev] [PATCH] Fix invalid extern "C" around header inclusion.

2015-03-06 Thread Jose Fonseca
On 06/03/15 00:11, Mark Janes wrote: Matt Turner writes: On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca wrote: Thanks for doing this. It looks great. Reviewed-by: Jose Fonseca Feel free to push my patch or I'll push it after you push this one. Thanks José. I've just pushed it.

[Mesa-dev] [PATCH 1/2] util: rework _MSC_VER >= 1200 checks

2015-03-06 Thread Emil Velikov
Replace the _MSC_VER >= 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov --- src/util/macros.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/util/macros.h b/src/util/m

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: > >> Change brw_untyped_atomic() and brw_untyped_surface_read() to take the > >> surface index as a register instead of a constant

[Mesa-dev] [PATCH 2/2] glx: remove unneeded ifdef _WIN32 guard

2015-03-06 Thread Emil Velikov
The C99 header exists on other platforms as well. Signed-off-by: Emil Velikov --- src/glx/glxclient.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index a140c87..122ae5d 100644 --- a/src/glx/glxclient.h +++ b/src/glx/glxclient.h @@ -47,9 +47,7 @@

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: >> Change brw_untyped_atomic() and brw_untyped_surface_read() to take the >> surface index as a register instead of a constant and to use >> brw_send_indirect_message() to emit the indirect variant of s

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: > Change brw_untyped_atomic() and brw_untyped_surface_read() to take the > surface index as a register instead of a constant and to use > brw_send_indirect_message() to emit the indirect variant of send with > a dynamically calculated

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Fri, Mar 06, 2015 at 10:37:06AM +0200, Pohjolainen, Topi wrote: >> On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: >> >[..] >> > +/** >> > + * Send message to shared unit \p sfid with a possibly indirect >> > descriptor \p >> > + * desc. If the

Re: [Mesa-dev] [PATCH] i965/nir: Resolve source modifiers on Gen8+ logic operations.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 01:33:05AM -0800, Kenneth Graunke wrote: > On Gen8+, AND/OR/XOR/NOT don't support the abs() source modifier, and > negate changes meaning to bitwise-not (~, not -). This isn't what NIR > expects, so we should resolve the source modifers via a MOV. > > +30 Piglits (fs-op-bi

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 10:37:06AM +0200, Pohjolainen, Topi wrote: > On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: > > --- > > src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- > > src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 > > ++--

[Mesa-dev] [PATCH 4/6] nir: Add native_integers to nir_shader_compiler_options.

2015-03-06 Thread Kenneth Graunke
glsl_to_nir, tgsi_to_nir, and prog_to_nir all want to know whether the driver supports native integers. Presumably other passes may as well. Adding this to nir_shader_compiler_options is an easy way to provide that information, as it's accessible via nir_shader::options. Signed-off-by: Kenneth G

[Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Kenneth Graunke
The code in glsl_to_nir is entirely dead, as we translate from GLSL to NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, so every caller passes NULL. glsl_to_nir seems like the wrong place to try and create the shader compiler options structure anyway - tgsi_to_nir, prog_to_nir,

  1   2   >