Re: [Mesa-dev] [PATCH 3/3] i965: implement ARB_pipeline_statistics_query

2015-02-13 Thread Ilia Mirkin
On Sat, Feb 14, 2015 at 2:02 AM, Ben Widawsky wrote: > diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html > index 10e926a..a8e22ea 100644 > --- a/docs/relnotes/10.6.0.html > +++ b/docs/relnotes/10.6.0.html > @@ -40,7 +40,7 @@ TBD. > New features > > > -Note: some of the new feat

[Mesa-dev] [PATCH] st/mesa: add ARB_pipeline_statistics_query support

2015-02-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This applies on top of Ben Widawsky's patch series. Mildly tested on nvc0 and llvmpipe/softpipe. src/mesa/state_tracker/st_cb_queryobj.c | 58 ++--- src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 55 insertions(+), 4 de

Re: [Mesa-dev] [PATCH 2/3] mesa: Add support for the ARB_pipeline_statistics_query extension

2015-02-13 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Feb 14, 2015 at 2:02 AM, Ben Widawsky wrote: > This was originally part of a single patch which added the extension, and > implemented it for i965 classic. For information about the evolution of the > patch, please see the subsequent commit. > > One difference he

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-13 Thread Ilia Mirkin
On Sat, Feb 14, 2015 at 2:02 AM, Ben Widawsky wrote: > From: Jordan Justen > > Signed-off-by: Jordan Justen > Reviewed-by: Ben Widawsky > --- > src/mesa/main/context.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h > inde

[Mesa-dev] [PATCH 2/3] mesa: Add support for the ARB_pipeline_statistics_query extension

2015-02-13 Thread Ben Widawsky
This was originally part of a single patch which added the extension, and implemented it for i965 classic. For information about the evolution of the patch, please see the subsequent commit. One difference here as compared to the original mega patch is this does build support for the compute shade

[Mesa-dev] [PATCH 3/3] i965: implement ARB_pipeline_statistics_query

2015-02-13 Thread Ben Widawsky
NOTE: The implementation was initially one patch, this. All the history is kept here, even though all the core mesa changes were moved to the parent of this patch. This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the ex

[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

2015-02-13 Thread Ben Widawsky
From: Jordan Justen Signed-off-by: Jordan Justen Reviewed-by: Ben Widawsky --- src/mesa/main/context.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index d902ea7..69389ae 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/m

[Mesa-dev] [Bug 89131] [Bisected] Graphical corruption in Weston, shows old framebuffer pieces

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89131 --- Comment #3 from James Harvey --- Hi Michel, Yes, both pp_jimenezmlaa and pp_jimenezmlaa_color were set to 8. Changing pp_jimenezmlaa to zero or setting "always_have_depth_buffer=true" seems to fix the problem. Would that mean this is a bug

[Mesa-dev] [PATCH 2/2] nvc0: allow holes in xfb target lists

2015-02-13 Thread Ilia Mirkin
Tested with a modified xfb-streams test which outputs to streams 0, 2, and 3. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 9 - src/gallium/drivers/nouveau/nvc0/nvc0_state.c| 8 +--- 2 files changed, 13 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 1/2] st/mesa: treat resource-less xfb buffers as if they weren't there

2015-02-13 Thread Ilia Mirkin
If a transform feedback buffer's size is 0, st_bufferobj_data doesn't end up creating a buffer for it. There's no point in trying to write to such a buffer, so just pretend as if it's not really there. This fixes arb_gpu_shader5-xfb-streams-without-invocations on nvc0. Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH] nvc0: bail out of 2d blits with non-A8_UNORM alpha formats

2015-02-13 Thread Ilia Mirkin
This fixes the teximage-colors uploads with GL_ALPHA format and non-GL_UNSIGNED_BYTE type. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/

[Mesa-dev] [Bug 89131] [Bisected] Graphical corruption in Weston, shows old framebuffer pieces

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89131 --- Comment #2 from Michel Dänzer --- Have you enabled any of pp_celshade / pp_jimenezmlaa / pp_jimenezmlaa_color / pp_nored / pp_nogreen / pp_noblue in /etc/drirc or ~/.drirc or the environment? -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH v3] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Tom Stellard
On Fri, Feb 13, 2015 at 09:16:17PM -0500, Shawn Starr wrote: > v3: Fix my typo, 3rd time's a charm, right? > Pushed, thanks! -Tom > From 5712d95cb12d8e82d34fafe66bf827ee6726220e Mon Sep 17 00:00:00 2001 > From: Shawn Starr > Date: Fri, 13 Feb 2015 20:30:01 -0500 > Subject: [PATCH] clover: Use

[Mesa-dev] [Bug 86980] [swrast] piglit fp-rfl regression

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86980 --- Comment #7 from Vinson Lee --- mesa: 8323796840a343ee39687cc8e8b424ee43d6fee7 (master 10.6.0-devel) piglit fp-rfl regression on swrast is still present. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 78318] [swrast] piglit glsl-kwin-blur-1 regression

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78318 --- Comment #4 from Vinson Lee --- mesa: 8323796840a343ee39687cc8e8b424ee43d6fee7 (master 10.6.0-devel) piglit glsl-kwin-blur-1 regression is still present. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 77288] [swrast] piglit glean glsl1 regression

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77288 --- Comment #5 from Vinson Lee --- mesa: 8323796840a343ee39687cc8e8b424ee43d6fee7 (10.6.0-devel) piglit glean glsl1 regression on swrast is still present. -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [PATCH v3] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Shawn Starr
v3: Fix my typo, 3rd time's a charm, right? From 5712d95cb12d8e82d34fafe66bf827ee6726220e Mon Sep 17 00:00:00 2001 From: Shawn Starr Date: Fri, 13 Feb 2015 20:30:01 -0500 Subject: [PATCH] clover: Use Legacy PassManager for LLVM trunk (3.7) Signed-off-by: Shawn Starr --- src/gallium/state_track

[Mesa-dev] [Bug 45348] [swrast] piglit fbo-drawbuffers-arbfp regression

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45348 --- Comment #4 from Vinson Lee --- mesa: 8323796840a343ee39687cc8e8b424ee43d6fee7 (10.6.0-devel) piglit fbo-drawbuffers-arbfp still fails on swrast. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH v2] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Matt Turner
On Fri, Feb 13, 2015 at 5:49 PM, Shawn Starr wrote: > From: Shawn Starr > > Use the LegacyPassManager for now. > > v2: Not #ifdef, should be #if > > Signed-off-by: Shawn Starr > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- > 1 file changed, 10 insertions(+), 1 d

[Mesa-dev] [PATCH RESEND v2] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Shawn Starr
From: Shawn Starr Use the LegacyPassManager for now. v2: Not #ifdef, should be #if Signed-off-by: Shawn Starr --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invo

[Mesa-dev] [PATCH v2] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Shawn Starr
From: Shawn Starr Use the LegacyPassManager for now. v2: Not #ifdef, should be #if Signed-off-by: Shawn Starr --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invo

Re: [Mesa-dev] [PATCH] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Matt Turner
On Fri, Feb 13, 2015 at 5:37 PM, Shawn Starr wrote: > From: Shawn Starr s/ at /@/ > > Use the LegacyPassManager for now. > > Signed-off-by: Shawn Starr > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --

[Mesa-dev] [PATCH] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Shawn Starr
From: Shawn Starr Use the LegacyPassManager for now. Signed-off-by: Shawn Starr --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_t

[Mesa-dev] [PATCH] clover: Use Legacy PassManager for LLVM trunk (3.7)

2015-02-13 Thread Shawn Starr
From: Shawn Starr Use the LegacyPassManager for now. Signed-off-by: Shawn Starr --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_t

Re: [Mesa-dev] [PATCH 5/5] i965/vec4: Silence unused parameter warnings

2015-02-13 Thread Ian Romanick
On 02/13/2015 01:26 PM, Matt Turner wrote: > On Fri, Feb 13, 2015 at 12:52 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> brw_vec4_copy_propagation.cpp:243:59: warning: unused parameter 'reg' >> [-Wunused-parameter] >> int arg, struct copy_entry *entry, int reg) >>

Re: [Mesa-dev] [PATCH 5/5] i965/vec4: Silence unused parameter warnings

2015-02-13 Thread Matt Turner
On Fri, Feb 13, 2015 at 12:52 PM, Ian Romanick wrote: > From: Ian Romanick > > brw_vec4_copy_propagation.cpp:243:59: warning: unused parameter 'reg' > [-Wunused-parameter] > int arg, struct copy_entry *entry, int reg) >

[Mesa-dev] [PATCH 4/5] mesa/main: Silence unused parameter warning

2015-02-13 Thread Ian Romanick
From: Ian Romanick Just remove the _mesa_free_lighting_data function. The body has been empty since the shine table was moved into the tnl module (commit ba1d921). main/light.c:1216:46: warning: unused parameter 'ctx' [-Wunused-parameter] _mesa_free_lighting_data( struct gl_context *ctx )

[Mesa-dev] [PATCH 1/5] glcpp: Silence GCC warning

2015-02-13 Thread Ian Romanick
From: Ian Romanick glcpp/glcpp.c:124:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] const static struct option ^ Signed-off-by: Ian Romanick --- src/glsl/glcpp/glcpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 2/5] util/hash: Silence unused parameter warnings in tests

2015-02-13 Thread Ian Romanick
From: Ian Romanick delete_and_lookup.c:37:21: warning: unused parameter ‘key’ [-Wunused-parameter] badhash(const void *key) ^ delete_and_lookup.c:43:10: warning: unused parameter ‘argc’ [-Wunused-parameter] main(int argc, char **argv) ^ delete_and_lookup.c:43:23:

[Mesa-dev] [PATCH 3/5] util/hash: Silence comparison between signed and unsigned integer warnings in tests

2015-02-13 Thread Ian Romanick
From: Ian Romanick delete_management.c:56:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < size; i++) { ^ delete_management.c:69:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

[Mesa-dev] [PATCH 5/5] i965/vec4: Silence unused parameter warnings

2015-02-13 Thread Ian Romanick
From: Ian Romanick brw_vec4_copy_propagation.cpp:243:59: warning: unused parameter 'reg' [-Wunused-parameter] int arg, struct copy_entry *entry, int reg) ^ brw_vec4_generator.cpp:869:57: warning: unused parameter 'in

[Mesa-dev] [Bug 89112] u_atomic_test: u_atomic_test.c:124: test_atomic_8bits_bool: Assertion `r == 65 && "p_atomic_add"' failed.

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89112 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 89112, which changed state. Bug 89112 Summary: u_atomic_test: u_atomic_test.c:124: test_atomic_8bits_bool: Assertion `r == 65 && "p_atomic_add"' failed. https://bugs.freedesktop.org/show_bug.cgi?id=89112 What

Re: [Mesa-dev] make check failure in u_atomic_test

2015-02-13 Thread Jose Fonseca
On 13/02/15 18:52, Ian Romanick wrote: Starting this morning I'm seeing 'make check' failures in u_atomic_test. It looks like José was the last person to touch that area. I haven't investigated any further. ../../bin/test-driver: line 107: 11024 Aborted (core dumped) "$@" > $l

[Mesa-dev] [PATCH 1/2] i965/fs: Call calculate_cfg() before optimize().

2015-02-13 Thread Matt Turner
The CFG is fundamental to the FS IR, not merely a piece of optimization. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index c7c6acc..41473fa 100644 ---

[Mesa-dev] [PATCH 2/2] i965: Let dump_instructions() work before calculate_cfg().

2015-02-13 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 24 src/mesa/drivers/dri/i965/brw_shader.cpp | 17 - 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 41473fa..

[Mesa-dev] make check failure in u_atomic_test

2015-02-13 Thread Ian Romanick
Starting this morning I'm seeing 'make check' failures in u_atomic_test. It looks like José was the last person to touch that area. I haven't investigated any further. ../../bin/test-driver: line 107: 11024 Aborted (core dumped) "$@" > $log_file 2>&1 FAIL: u_atomic_test

Re: [Mesa-dev] [PATCH] mesa: Handle transferOps in texstore_rgba

2015-02-13 Thread Ian Romanick
Please tag the commit with Cc: "10.5" On 02/13/2015 01:23 AM, Iago Toral Quiroga wrote: > In the recent rewrite of the format conversion code we did not handle this. > This patch adds the missing support. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89068 > --- > src/mesa/main/te

Re: [Mesa-dev] [PATCH] mesa: Fix element count for byte-swaps in texstore, readpix and texgetimage

2015-02-13 Thread Ian Romanick
Also... please tag the commit with Cc: "10.5" On 02/13/2015 03:56 AM, Iago Toral Quiroga wrote: > Some old format conversion code in pack.c implemented byte-swapping like this: > > GLint comps = _mesa_components_in_format(dstFormat); > GLint swapSize = _mesa_sizeof_packed_type(dstType); > if (s

Re: [Mesa-dev] [PATCH] i965/vec4: Override destination register writemask in sampler message send.

2015-02-13 Thread Ian Romanick
Please tag the commit with Cc: "10.5" On 02/13/2015 05:03 AM, Francisco Jerez wrote: > This line was removed by accident in commit > 16b911257440afbd77a6eb762e28df62e3c19bc7 causing a regression in the > ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert Khronos conformance > test. It's necessar

Re: [Mesa-dev] [PATCH] mesa: Fix element count for byte-swaps in texstore, readpix and texgetimage

2015-02-13 Thread Ian Romanick
On 02/13/2015 03:56 AM, Iago Toral Quiroga wrote: > Some old format conversion code in pack.c implemented byte-swapping like this: > > GLint comps = _mesa_components_in_format(dstFormat); > GLint swapSize = _mesa_sizeof_packed_type(dstType); > if (swapSize == 2) >_mesa_swap2((GLushort *) dstAd

Re: [Mesa-dev] [PATCH 04/11 v2] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

2015-02-13 Thread Ian Romanick
On 02/13/2015 02:21 AM, Eduardo Lima Mitev wrote: > Fixes 3 dEQP tests: > * dEQP-GLES3.functional.negative_api.state.get_program_info_log > * dEQP-GLES3.functional.negative_api.state.get_shader_info_log > * dEQP-GLES3.functional.negative_api.state.get_programiv > --- > src/mesa/main/shaderapi.c |

Re: [Mesa-dev] [PATCH] i965: Fix a crash in the texture gradient lowering pass with cube samplers

2015-02-13 Thread Ian Romanick
Reviewed-by: Ian Romanick On 02/12/2015 11:29 PM, Iago Toral Quiroga wrote: > We need to swizzle the rhs to match the number of components in the writemask, > otherwise we'll hit an assertion in ir_assignment. > --- > src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp | 4 +++- > 1 file c

Re: [Mesa-dev] [PATCH 1/2] i965: Add an is_negative_one() method.

2015-02-13 Thread Ian Romanick
With Tom's indentation fixes in patch 2 applied, this series is Reviewed-by: Ian Romanick On 02/12/2015 03:36 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 16 > src/mesa/drivers/dri/i965/brw_shader.h | 1 + > 2 files changed, 17 insertions(+) >

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 Eero Tamminen changed: What|Removed |Added Status|REOPENED|NEEDINFO CC|

Re: [Mesa-dev] [PATCH] i965/vec4: Override destination register writemask in sampler message send.

2015-02-13 Thread Matt Turner
On Fri, Feb 13, 2015 at 5:03 AM, Francisco Jerez wrote: > This line was removed by accident in commit > 16b911257440afbd77a6eb762e28df62e3c19bc7 causing a regression in the > ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert Khronos conformance > test. It's necessary because the swizzle_result()

Re: [Mesa-dev] [PATCH 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-13 Thread Matt Turner
On Fri, Feb 13, 2015 at 4:36 AM, Francisco Jerez wrote: > Francisco Jerez writes: > >> Matt Turner writes: >> >>> On Mon, Feb 9, 2015 at 11:25 AM, Matt Turner wrote: On Fri, Feb 6, 2015 at 2:40 PM, Matt Turner wrote: > 8 - Sent a question > 9 - Like mine better? > 10 - Looks w

Re: [Mesa-dev] [PATCH] i965/vec4: Calculate register allocation q values manually.

2015-02-13 Thread Francisco Jerez
Connor Abbott writes: > I'll ask the same question I asked Jason when he did this for FS... > did you verify that the new q_values is the same as the old one? > Yeah, I did. > On Fri, Feb 13, 2015 at 8:02 AM, Francisco Jerez > wrote: >> This fixes a regression in the running time of Piglit int

Re: [Mesa-dev] [PATCH] i965/vec4: Calculate register allocation q values manually.

2015-02-13 Thread Connor Abbott
I'll ask the same question I asked Jason when he did this for FS... did you verify that the new q_values is the same as the old one? On Fri, Feb 13, 2015 at 8:02 AM, Francisco Jerez wrote: > This fixes a regression in the running time of Piglit introduced by > commit 78e9043475d4bed8b50f7e413963c

Re: [Mesa-dev] [PATCH] os, llvmpipe: Set rasterizer thread names on Linux.

2015-02-13 Thread Jose Fonseca
On 13/02/15 15:23, Roland Scheidegger wrote: Just one trivial issue, otherwise Reviewed-by: Roland Scheidegger Am 13.02.2015 um 15:05 schrieb Jose Fonseca: To help identify llvmpipe rasterizer threads -- especially when there can be so many. We can eventually generalize this to other OSes,

Re: [Mesa-dev] [PATCH] uti/u_atomic: Don't test p_atomic_add with booleans.

2015-02-13 Thread Roland Scheidegger
Looks good to me. Roland Am 13.02.2015 um 10:47 schrieb Jose Fonseca: > Add another class of tests. > > Fixes > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D89112&d=AwIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9

Re: [Mesa-dev] [PATCH] os, llvmpipe: Set rasterizer thread names on Linux.

2015-02-13 Thread Roland Scheidegger
Just one trivial issue, otherwise Reviewed-by: Roland Scheidegger Am 13.02.2015 um 15:05 schrieb Jose Fonseca: > To help identify llvmpipe rasterizer threads -- especially when there > can be so many. > > We can eventually generalize this to other OSes, but for that we must > restrict the func

Re: [Mesa-dev] [PATCH] mesa: Fix element count for byte-swaps in texstore, readpix and texgetimage

2015-02-13 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Feb 13, 2015 3:56 AM, "Iago Toral Quiroga" wrote: > Some old format conversion code in pack.c implemented byte-swapping like > this: > > GLint comps = _mesa_components_in_format(dstFormat); > GLint swapSize = _mesa_sizeof_packed_type(dstType); > if (swapSize == 2)

Re: [Mesa-dev] [PATCH] mesa: Handle transferOps in texstore_rgba

2015-02-13 Thread Jason Ekstrand
On Feb 13, 2015 1:23 AM, "Iago Toral Quiroga" wrote: > > In the recent rewrite of the format conversion code we did not handle this. > This patch adds the missing support. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89068 > --- > src/mesa/main/texstore.c | 58 ++

Re: [Mesa-dev] [PATCH v5 00/29] add fp64 support to mesa and glsl compiler

2015-02-13 Thread Ilia Mirkin
Matt and Ian -- thanks a lot for doing the reviews you already have done! Matt mentioned that it'd be helpful to have a list of the patches that have yet to be reviewed, so here it is: $ grep -L Reviewed-by *.patch | xargs grep -h 'PATCH v5' | sed 's/Subject: //' [PATCH v5 04/29] mesa: add double

[Mesa-dev] [PATCH] os, llvmpipe: Set rasterizer thread names on Linux.

2015-02-13 Thread Jose Fonseca
To help identify llvmpipe rasterizer threads -- especially when there can be so many. We can eventually generalize this to other OSes, but for that we must restrict the function to be called from the current thread. See also http://stackoverflow.com/a/7989973 --- src/gallium/auxiliary/os/os_thre

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #12 from Brad King --- (In reply to Iago Toral from comment #10) > Sent a patch for review to mesa-dev: > http://lists.freedesktop.org/archives/mesa-dev/2015-February/076851.html I've confirmed that fixes all the VTK test regressions

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #11 from Iago Toral --- Also, patch that adds a piglit test for this to avoid new regressions here: http://lists.freedesktop.org/archives/piglit/2015-February/014490.html -- You are receiving this mail because: You are the QA Conta

[Mesa-dev] [PATCH] i965/vec4: Override destination register writemask in sampler message send.

2015-02-13 Thread Francisco Jerez
This line was removed by accident in commit 16b911257440afbd77a6eb762e28df62e3c19bc7 causing a regression in the ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert Khronos conformance test. It's necessary because the swizzle_result() code below expects all four components of the vector to be valid.

[Mesa-dev] [PATCH] i965/vec4: Calculate register allocation q values manually.

2015-02-13 Thread Francisco Jerez
This fixes a regression in the running time of Piglit introduced by commit 78e9043475d4bed8b50f7e413963c960fa0935bb, which increased the number of register allocation classes set up by the VEC4 back-end from 2 to 16. The algorithm used by ra_set_finalize() to calculate them is unnecessarily expens

Re: [Mesa-dev] [PATCH 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-13 Thread Francisco Jerez
Francisco Jerez writes: > Matt Turner writes: > >> On Mon, Feb 9, 2015 at 11:25 AM, Matt Turner wrote: >>> On Fri, Feb 6, 2015 at 2:40 PM, Matt Turner wrote: 8 - Sent a question 9 - Like mine better? 10 - Looks wrong to me 11-13 - Asked Jason to review 14 - Asked for a

Re: [Mesa-dev] [PATCH 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-13 Thread Francisco Jerez
Matt Turner writes: > On Mon, Feb 9, 2015 at 11:25 AM, Matt Turner wrote: >> On Fri, Feb 6, 2015 at 2:40 PM, Matt Turner wrote: >>> 8 - Sent a question >>> 9 - Like mine better? >>> 10 - Looks wrong to me >>> 11-13 - Asked Jason to review >>> 14 - Asked for an example showing the problem >>> 15

[Mesa-dev] [Bug 89107] [Radeonsi/Hawaii] Rendering errors when running basic opengl 3 demo

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89107 --- Comment #5 from Sebastian Parborg --- (In reply to Tapani Pälli from comment #4) > It looks like lab1-1.c source does not match provided binary lab1-1. If I > compile sources again I get segfault at _mesa_UniformMatrix4fv. The binary should

[Mesa-dev] [PATCH] mesa: Fix element count for byte-swaps in texstore, readpix and texgetimage

2015-02-13 Thread Iago Toral Quiroga
Some old format conversion code in pack.c implemented byte-swapping like this: GLint comps = _mesa_components_in_format(dstFormat); GLint swapSize = _mesa_sizeof_packed_type(dstType); if (swapSize == 2) _mesa_swap2((GLushort *) dstAddr, n * comps); else if (swapSize == 4) _mesa_swap4((GLuint

Re: [Mesa-dev] [PATCH 21/32] i965/vec4: Fix the scheduler to take into account reads and writes of multiple registers.

2015-02-13 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 6, 2015 at 6:43 AM, Francisco Jerez wrote: >> --- > > We don't have any operations today that return more than a single > register in the vec4 backend, do we? Presumably this is partly > preparation for image_load_store? > Yeah, of course :). > Reviewed-by: Mat

[Mesa-dev] [PATCH 04/11 v2] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

2015-02-13 Thread Eduardo Lima Mitev
Fixes 3 dEQP tests: * dEQP-GLES3.functional.negative_api.state.get_program_info_log * dEQP-GLES3.functional.negative_api.state.get_shader_info_log * dEQP-GLES3.functional.negative_api.state.get_programiv --- src/mesa/main/shaderapi.c | 92 +++ 1 file cha

[Mesa-dev] [PATCH] uti/u_atomic: Don't test p_atomic_add with booleans.

2015-02-13 Thread Jose Fonseca
Add another class of tests. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=89112 I failed to spot this in my previous change, because bool was a typedef for char on the system I tested. --- src/util/u_atomic_test.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions

[Mesa-dev] [Bug 89107] [Radeonsi/Hawaii] Rendering errors when running basic opengl 3 demo

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89107 --- Comment #4 from Tapani Pälli --- It looks like lab1-1.c source does not match provided binary lab1-1. If I compile sources again I get segfault at _mesa_UniformMatrix4fv. -- You are receiving this mail because: You are the QA Contact for th

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #10 from Iago Toral --- Sent a patch for review to mesa-dev: http://lists.freedesktop.org/archives/mesa-dev/2015-February/076851.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee f

[Mesa-dev] [PATCH] mesa: Handle transferOps in texstore_rgba

2015-02-13 Thread Iago Toral Quiroga
In the recent rewrite of the format conversion code we did not handle this. This patch adds the missing support. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- src/mesa/main/texstore.c | 58 +++- 1 file changed, 53 insertions(+), 5 del