[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #18 from Iago Toral --- (In reply to Jason Ekstrand from comment #17) > (In reply to Iago Toral from comment #16) > > We also need new mesa_format enums and pack/unpack functions for byte > > swapped variants of non-array types. > >

[Mesa-dev] [Bug 84570] Borderlands 2: Constant frame rate drops while playing; really bad with additionl lighting

2014-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 --- Comment #17 from Michel Dänzer --- Can you attach a new GALLIUM_HUD screenshot corresponding to a remaining drop? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa

[Mesa-dev] [Bug 84570] Borderlands 2: Constant frame rate drops while playing; really bad with additionl lighting

2014-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 --- Comment #16 from Michel Dänzer --- (In reply to Kai from comment #15) > THAT is a LOT better! Even with DynamicLights on I only get occasional FPS > drops. Usually directly after entering a new area. Sometimes, when there's a > lot to draw, t

[Mesa-dev] [PATCH] egl/drm: do not crash when swapping buffers without any rendering

2014-10-14 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/egl/drivers/dri2/platform_drm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index 70bd7d4..f6b9c3a 100644 --- a/src/egl/drivers/dri2/platform_drm.c +++ b/src/egl/dri

Re: [Mesa-dev] [PATCH] i965: Fix an off-by-1 error in the draw upload code's size calculation.

2014-10-14 Thread Kenneth Graunke
On Tuesday, October 14, 2014 04:42:39 PM Kenneth Graunke wrote: > According to INTEL_DEBUG=perf, "Borderlands: The Pre-Sequel" was > stalling on nearly every glBufferSubData call, with very slightly > overlapping busy ranges. > > It turns out the draw upload code was accidentally including an extr

Re: [Mesa-dev] [PATCH 17/17] i965/fs: don't make a fake ir_texture in the Mesa IR frontend

2014-10-14 Thread Connor Abbott
On Tue, Oct 14, 2014 at 12:54 AM, Kenneth Graunke wrote: > From: Connor Abbott > > Now that we've made all the texture emit code mostly independent of GLSL > IR, this isn't necessary any more. > > Signed-off-by: Connor Abbott > Reviewed-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH] i965: Fix an off-by-1 error in the draw upload code's size calculation.

2014-10-14 Thread Kenneth Graunke
According to INTEL_DEBUG=perf, "Borderlands: The Pre-Sequel" was stalling on nearly every glBufferSubData call, with very slightly overlapping busy ranges. It turns out the draw upload code was accidentally including an extra stride's worth of data in the vertex buffer size due to a simple off-by-

Re: [Mesa-dev] [PATCH 12/17] i965/fs: don't pass in ir_texture to emit_texture_*

2014-10-14 Thread Jason Ekstrand
On Tue, Oct 14, 2014 at 3:03 PM, Jason Ekstrand wrote: > > > On Mon, Oct 13, 2014 at 9:54 PM, Kenneth Graunke > wrote: > >> From: Connor Abbott >> >> At this point, the only thing it's used for is the opcode. >> >> Signed-off-by: Connor Abbott >> Reviewed-by: Kenneth Graunke >> --- >> src/me

Re: [Mesa-dev] [PATCH 12/17] i965/fs: don't pass in ir_texture to emit_texture_*

2014-10-14 Thread Jason Ekstrand
On Mon, Oct 13, 2014 at 9:54 PM, Kenneth Graunke wrote: > From: Connor Abbott > > At this point, the only thing it's used for is the opcode. > > Signed-off-by: Connor Abbott > Reviewed-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.h | 6 ++--- > src/mesa/drivers/dri/

Re: [Mesa-dev] Assertion `key->nr_vertex_elements <= llvm->draw->pt.nr_vertex_elements' failed.

2014-10-14 Thread Roland Scheidegger
On 10/14/2014 01:14 PM, Thomas Sondergaard wrote: using llvmpipe I'm hitting the following assertion in some old code that use glEdgeFlag(). src/gallium/auxiliary/draw/draw_llvm.c:1824:draw_llvm_make_variant_key: Assertion `key->nr_vertex_elements <= llvm->draw->pt.nr_vertex_elements' failed. I

[Mesa-dev] Assertion `key->nr_vertex_elements <= llvm->draw->pt.nr_vertex_elements' failed.

2014-10-14 Thread Thomas Sondergaard
using llvmpipe I'm hitting the following assertion in some old code that use glEdgeFlag(). src/gallium/auxiliary/draw/draw_llvm.c:1824:draw_llvm_make_variant_key: Assertion `key->nr_vertex_elements <= llvm->draw->pt.nr_vertex_elements' failed. I have captured a trace with apitrace from the p

Re: [Mesa-dev] [PATCH] i965/fs: Use the correct regs_written on unspill instructions

2014-10-14 Thread Kenneth Graunke
On Tuesday, October 14, 2014 12:03:00 PM Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH] i965/fs: Use the correct regs_written on unspill instructions

2014-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp index 28a7483..46e465f 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #17 from Jason Ekstrand --- (In reply to Iago Toral from comment #16) > We also need new mesa_format enums and pack/unpack functions for byte > swapped variants of non-array types. Why? Is this for the byte_swapped flag on GL upload

Re: [Mesa-dev] [PATCH] i965: Allow CSE on Gen4-5 unary math.

2014-10-14 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2.9/4] i965/fs: Properly precolor payload registers on GEN5 in SIMD16

2014-10-14 Thread Jason Ekstrand
For GEN6 SIMD16 mode, we have to 2-align all the registers, so we only have the even-numbered ones. This means that we have to divide the register number by 2 when we precolor. This wasn't a problem before because we were setting up the interference between ra_node registers wrong. This will be

[Mesa-dev] [PATCH 3/4] auxiliary: ship all files in the distribution tarball

2014-10-14 Thread Emil Velikov
- Add all headers into Makefile.sources - Don't forget the target-helpers - Add the python scripts & the formats table/list (csv) - Temporary add vl/vl_winsys_dri.c to EXTRA_DIST until we rework the way VL is build. - Add the following to EXTRA_DIST - they are included via the generated u_indi

[Mesa-dev] [PATCH 1/4] pipe-loader: consolidate sources into Makefile.sources

2014-10-14 Thread Emil Velikov
Drop the unneeded subdir-objects. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/Makefile.am | 10 ++ src/gallium/auxiliary/pipe-loader/Makefile.sources | 8 2 files changed, 10 insertions(+), 8 deletions(-) create mode 100644 src/gallium/auxiliary/pipe

[Mesa-dev] [PATCH 2/4] gallium: ship the gallium API headers

2014-10-14 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/Makefile.am b/src/gallium/Makefile.am index 21595a1..b12802a 100644 --- a/src/gallium/Makefile.am +++ b/src/gallium/Makefile.am @@ -179,6 +179,7 @@ endif ## EXTRA_DIST += \

[Mesa-dev] [PATCH 4/4] targets: bundle all files in the tarball

2014-10-14 Thread Emil Velikov
We were missing a few files - The version scripts - Android & scons build scripts - A few headers. Signed-off-by: Emil Velikov --- src/gallium/targets/dri/Makefile.am | 5 + src/gallium/targets/egl-static/Makefile.am | 7 ++- src/gallium/targets/gbm/Makefile.am | 3 ++

[Mesa-dev] The final batch of gallium 'make dist'

2014-10-14 Thread Emil Velikov
Hello list, As the title says it - this ought to be the final batch of patches needed to get 'make dist' working for gallium. With that one out of the way I'll start looking into egl, gbm . and mapi. Some of the patches may contain rather controversial changes, but I would rather get thing

Re: [Mesa-dev] [PATCH] r300/compiler: remove useless check

2014-10-14 Thread Tom Stellard
On Tue, Oct 14, 2014 at 03:27:58AM +0200, David Heidelberger wrote: > > This code is already in if (!variable->C->is_r500) so no need check > twice. > I've pushed this patch, thanks! -Tom > Signed-off-by: David Heidelberger > --- > src/gallium/drivers/r300/compiler/radeon_pair_regalloc.c |

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-10-14 Thread Emil Velikov
Humble ping. On 23/09/14 01:25, Emil Velikov wrote: > From: Sjoerd Simons > > When using RGBA EGLConfigs allow both RGB and RGBA X visuals, such that > application can decide whether they want to use RGBA (and have the > compositor blend their windows). > > On my system with this change EGLConf

[Mesa-dev] [PATCH 1/3] gallium/vc4: correctly include the source files

2014-10-14 Thread Emil Velikov
The kernel files are built into a separate static library and all the functions that require it are already wrapped in ifdef USE_VC4_SIMULATOR. Don't forget the header file :) Cc: Eric Anholt Signed-off-by: Emil Velikov --- src/gallium/drivers/vc4/Makefile.sources| 3 --- src/gallium/dr

[Mesa-dev] [PATCH 2/3] gallium/vc4: move 'kernel' declarations to kernel/vc4_drv.h

2014-10-14 Thread Emil Velikov
- Used only within kernel/*.c - Remove the unused min/max macros Cc: Eric Anholt Signed-off-by: Emil Velikov --- src/gallium/drivers/vc4/kernel/vc4_drv.h | 16 src/gallium/drivers/vc4/vc4_simulator_validate.h | 18 -- 2 files changed, 16 insertions(+),

[Mesa-dev] [PATCH 3/3] gallium/vc4: rework the USE_VC4_SIMULATOR build

2014-10-14 Thread Emil Velikov
- Conditionally build and link libvc4_kernel.la - Move -lsimpenrose from SIM_LDFLAGS to SIM_LIB Cc: Eric Anholt Signed-off-by: Emil Velikov --- src/gallium/drivers/vc4/Makefile.am| 16 +--- src/gallium/drivers/vc4/kernel/Makefile.am | 6 +- src/gallium/drivers/vc4/ker

Re: [Mesa-dev] [PATCH] mesa: validate sampler uniforms during gluniform calls

2014-10-14 Thread Tapani
On 10/14/2014 03:35 PM, Francisco Jerez wrote: Tapani Pälli writes: Patch fixes 'glsl-2types-of-textures-on-same-unit' in WebGL conformance test suite, no Piglit regressions. To avoid adding potentially heavy check during draw (valid_to_render), check is done during uniform updates by inspect

[Mesa-dev] [PATCH] mesa: validate sampler uniforms during gluniform calls

2014-10-14 Thread Tapani Pälli
Patch fixes 'glsl-2types-of-textures-on-same-unit' in WebGL conformance test suite, no Piglit regressions. To avoid adding potentially heavy check during draw (valid_to_render), check is done during uniform updates by inspecting TexturesUsed mask. A new boolean variable is introduced to cache val

[Mesa-dev] [PATCH] egl/drm: do not crash when swapping buffers without any rendering

2014-10-14 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/egl/drivers/dri2/platform_drm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index 70bd7d4..f6b9c3a 100644 --- a/src/egl/drivers/dri2/platform_drm.c +++ b/src/egl/dri

[Mesa-dev] Trivial fix for ChromeOS unit test

2014-10-14 Thread Lionel Landwerlin
Hey there, While enabling LibVA on the Ozone backend of ChromeOS (EGL/GLES2 without X), I stumbled upon a crash. This patch is a fix for that problem. It's pretty much a copy/paste of a snippet already in EGL/wayland file. Cheers, - Lionel ___ mesa-d

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #16 from Iago Toral --- We also need new mesa_format enums and pack/unpack functions for byte swapped variants of non-array types. -- You are receiving this mail because: You are the QA Contact for the bug. _

Re: [Mesa-dev] [PATCH 01/17] i965: Restore a lost comment about TXF offset bugs.

2014-10-14 Thread Chris Forbes
I haven't tested to make sure this doesn't regress anything, but all looks sensible. For the series: Reviewed-by: Chris Forbes On Tue, Oct 14, 2014 at 5:54 PM, Kenneth Graunke wrote: > Eric's original code to work around TXF offset bugs contained a comment > explaining the problem, which was l