Re: [Mesa-dev] SandyBridge not handling GL_TRIANGLE_STRIP_ADJACENCY with repeating vertex indices correctly

2014-07-29 Thread Iago Toral Quiroga
On mar, 2014-07-29 at 10:16 -0700, Kenneth Graunke wrote: > On Tuesday, July 29, 2014 10:12:23 AM Iago Toral Quiroga wrote: > > Hi, > > > > running the piglit tests on my implementation of geometry shaders for > > Sandy Bridge produces a GPU hang for the following test: > > > > ./glsl-1.50-geomet

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-07-29 Thread Tapani Pälli
Patches 5..10 Reviewed-by: Tapani Pälli Also tested that these fix the new Piglit tests and esconform3 test. I made a little proposal for patch 10 but not sure if this change would be worth the trouble. On 06/21/2014 04:00 AM, Ian Romanick wrote: > This patch series fixes bugs in the i965 w.r.

Re: [Mesa-dev] [PATCH 10/13] glsl: Add a lowering pass for gl_VertexID

2014-07-29 Thread Tapani Pälli
On 06/21/2014 04:01 AM, Ian Romanick wrote: > From: Ian Romanick > > Converts gl_VertexID to (gl_VertexIDMESA + gl_BaseVertex). gl_VertexIDMESA > is backed by SYSTEM_VALUE_VERTEX_ID_ZERO_BASE, and gl_BaseVertex is backed > by a built-in uniform from {STATE_INTERNAL, STATE_BASE_VERTEX}. > > NOTE: T

[Mesa-dev] [Bug 81834] TGSI constant buffer overrun causes assertion failure

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81834 --- Comment #5 from Michel Dänzer --- (In reply to comment #4) > Should I create a new bug report? Yes, please. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev

Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-29 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:14 -0700, Ian Romanick wrote: > From: Ian Romanick > > Returns the type without any arrays. > > This will be used in later patches in this series. > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri > --- > src/glsl/glsl_types.h | 12

Re: [Mesa-dev] [PATCH v2] glsl: Use the without_array predicate to simplify some code

2014-07-29 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:15 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Reviewed-by: Matt Turner [v1] > Cc: Timothy Arceri > --- > src/glsl/ast_to_hir.cpp| 3 +-- > src/glsl/glsl_types.cpp| 3 +-- > src/glsl/link_uniforms.cpp | 23 --

Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-29 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:14 -0700, Ian Romanick wrote: > From: Ian Romanick > > Returns the type without any arrays. > > This will be used in later patches in this series. > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri > --- > src/glsl/glsl_types.h | 12

Re: [Mesa-dev] [PATCH 19/29] glsl: Don't use strtod_l in Mesa on Android.

2014-07-29 Thread Ian Romanick
I think we should replace all the #ifdef garbage around this with a HAVE_STRTOD_L macro. Having lots of platform knowledge sprinkled around the code is ugly, at best. Also... doesn't strtof_l (later in strtod.c) need the same treatment? On 07/29/2014 03:54 PM, Emil Velikov wrote: > From: "Myles

[Mesa-dev] [PATCH] gallivm: fix up out-of-bounds level when using conformant out-of-bound behavior

2014-07-29 Thread sroland
From: Roland Scheidegger When using (d3d10) conformant out-of-bound behavior for texel fetching (currently always enabled) the level still needs to be set to a safe value even though the offset in the end won't get used because the level is used to look up the mip offset itself and the actual str

Re: [Mesa-dev] [PATCH] glsl/glcpp: rename ERROR to ERROR_TOKEN to fix MSVC build

2014-07-29 Thread Kenneth Graunke
On Tuesday, July 29, 2014 05:02:39 PM Brian Paul wrote: > ERROR is a #define in the MSVC WinGDI.h header file. > Add the _TOKEN suffix as we do for a few other lexer tokens. How about ERROR_TOK? That's what we use in the main compiler. Either way, Reviewed-by: Kenneth Graunke > --- > src/glsl

Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-29 Thread Kenneth Graunke
On Tuesday, July 29, 2014 04:14:45 PM Ian Romanick wrote: > From: Ian Romanick > > Returns the type without any arrays. > > This will be used in later patches in this series. > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri > --- > src/glsl/glsl_types.h |

Re: [Mesa-dev] [PATCH 0/3] Some register allocator cleanups and optimizations

2014-07-29 Thread Connor Abbott
On Tue, Jul 29, 2014 at 5:53 PM, Connor Abbott wrote: > This patch series contains some improvements to the register allocator > used by the i965 fs and vec4 backends and r300g. The most important > patch, and the only one with an intended functional change, is the last > one. Full shader-db resul

[Mesa-dev] [PATCH 1/3] ra: cleanup the public API

2014-07-29 Thread Connor Abbott
Previously, there were 3 entrypoints into parts of the actual allocator, and an API called ra_allocate_no_spills() that called all 3. Nobody would ever want to call any of the 3 entrypoints by themselves, so everybody just used ra_allocate_no_spills(). So just make them static functions, and while

[Mesa-dev] [PATCH 3/3] ra: optimistically color only one node at a time

2014-07-29 Thread Connor Abbott
Before, when we encountered a situation where we had to optimistically color a node, we would immediately give up and push all the remaining nodes on the stack in the order of their index - which is a random, and potentially not optimal, order. Instead, choose one node to optimistically color in ra

[Mesa-dev] [PATCH 2/3] ra: make the p, q test more efficient

2014-07-29 Thread Connor Abbott
We can store the q total that pq_test() would've calculated in the node itself, updating it when we add a node to the stack. This way, we only have to walk the adjacency list when we push a node on the stack (i.e. when the p, q test succeeds) instead of every time we do the p, q test. No differenc

[Mesa-dev] [PATCH 0/3] Some register allocator cleanups and optimizations

2014-07-29 Thread Connor Abbott
This patch series contains some improvements to the register allocator used by the i965 fs and vec4 backends and r300g. The most important patch, and the only one with an intended functional change, is the last one. Full shader-db results are reproduced in its commit message, but here's the summary

Re: [Mesa-dev] [PATCH 21/29] mesa: stop going behind the user's back wrt sse4.1 optimisations

2014-07-29 Thread Matt Turner
On Tue, Jul 29, 2014 at 5:02 PM, Emil Velikov wrote: > On 30/07/14 00:24, Matt Turner wrote: >> On Tue, Jul 29, 2014 at 3:54 PM, Emil Velikov >> wrote: >>> If the user/builder has a setup capable of using sse4.1 it's their >>> responsibility to enable it. >>> >>> Let's unconditionally include ma

Re: [Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

2014-07-29 Thread Jordan Justen
On Wed, Jul 23, 2014 at 2:39 PM, Ian Romanick wrote: > On 07/21/2014 03:17 PM, Matt Turner wrote: >> On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick wrote: >>> +enum glsl_matrix_layout { >>> + GLSL_MATRIX_LAYOUT_DEFAULT, >> >> Does this mean language-default, or does it really means the inherited

Re: [Mesa-dev] [PATCH 13/15] mesa: Add gles3 error condition for GL_RGBA10_A2 buffer format in glCopyTexImage*()

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Fixes many failures in gles3 Khronos CTS test: packed_pixels > > Khronos bug# 9807 > Cc: > Signed-off-by: Anuj Phogat > > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximage.c | 45 > - > 1

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Fixes few failures in gles3 Khronos CTS test: packed_pixels > > Cc: "10.2" > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximage.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/teximage.c b/src/mes

Re: [Mesa-dev] [PATCH 15/15] mesa: Add gles3 condition for normalized internal formats in glCopyTexImage*()

2014-07-29 Thread Jason Ekstrand
Looks good to me. Reviewed-by: Jason Ekstrand On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Fixes many failures in gles3 Khronos CTS test: packed_pixels > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximage.c | 15 +++ > 1 file changed, 15 insertions(+) > >

Re: [Mesa-dev] [PATCH 21/29] mesa: stop going behind the user's back wrt sse4.1 optimisations

2014-07-29 Thread Emil Velikov
On 30/07/14 00:24, Matt Turner wrote: > On Tue, Jul 29, 2014 at 3:54 PM, Emil Velikov > wrote: >> If the user/builder has a setup capable of using sse4.1 it's their >> responsibility to enable it. >> >> Let's unconditionally include main/streaming-load-memcpy.c, as it >> already features a ifdef

Re: [Mesa-dev] [PATCH 11/15] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Function is utilized by next patch in the series. > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.c | 18 ++ > src/mesa/main/glformats.h | 3 +++ > 2 files changed, 21 insertions(+) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 08/15] mesa: Fix condition for using compressed internalformat in glCompressedTexImage3D()

2014-07-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximage.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index b86

Re: [Mesa-dev] [PATCH 14/15] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-07-29 Thread Jason Ekstrand
I think you're missing the SRGB and SLUMINANCE formats. Other than that, I think that's all of them. On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.c | 67 > +++ > src/mesa/mai

Re: [Mesa-dev] [PATCH 09/15] mesa: Add utility function mesa_is_enum_format_snorm()

2014-07-29 Thread Jason Ekstrand
You should fix the commit message to be _mesa_is_enum_format_snorm (you forgot the beginning underscore). Other than that, looks good. Reviewed-by: Jason Ekstrand On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.c | 37 +

Re: [Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-07-29 Thread Jason Ekstrand
On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Fixes gles3 Khronos CTS test: texture_storage_texture_internal_formats > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/texstorage.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/mesa/main/texstor

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-29 Thread Jason Ekstrand
If we're going to make a utility function declared in glformats.h, let's move the function body to glformats.c. On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.h | 3 +++ > src/mesa/main/teximage.c | 12 ++-- > 2

Re: [Mesa-dev] [PATCH 05/15] mesa: Fix error condition for valid texture targets in glTexStorage* functions

2014-07-29 Thread Jordan Justen
On Fri, Jun 6, 2014 at 9:13 PM, Matt Turner wrote: > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> Fixes gles3 Khronos CTS test: texture_storage_texture_targets >> >> Cc: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/texstorage.c | 7 +++ >> 1 file changed, 7 insertions(+)

[Mesa-dev] [PATCH 17/23] i965: Make some brw_sampler_state.c functions static again.

2014-07-29 Thread Kenneth Graunke
Now that gen7_sampler_state.c is gone, everything is once again in a single file. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 4 ++-- src/mesa/drivers/dri/i965/brw_state.h | 6 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 21/23] i965: Replace sizeof(struct gen7_sampler_state) with the size itself.

2014-07-29 Thread Kenneth Graunke
These are the last users of struct gen7_sampler_state. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 +- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 3 +-- src/mesa/drivers/dri/i965/gen8_

[Mesa-dev] [PATCH 03/23] i965: Write a better file comment for brw_sampler_state.c.

2014-07-29 Thread Kenneth Graunke
The old one has been inaccurate for years. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c b/src/mesa/drivers/dri/i965/brw_sampler_sta

[Mesa-dev] [PATCH 04/23] i965: Drop the degenerate brw_sampler_default_color structure.

2014-07-29 Thread Kenneth Graunke
It's just an array of four floats, and we have an array of four floats, so this is literally just a memcpy...but with custom structs and strange macros to give the appearance of doing something more. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 9 +++--

[Mesa-dev] [PATCH 02/23] i965: Rename brw_wm_sampler_state.c to brw_sampler_state.c.

2014-07-29 Thread Kenneth Graunke
When the driver was originally written, it only supported texturing in the pixel shader backend; vertex and geometry shader texturing came much later. Originally, the pixel shader was referred to as "WM" (the Windowizer/Masker unit). So, this code happened to only be relevant for the WM stage, at

[Mesa-dev] [PATCH 01/23] i965/blorp: Don't set min_mag_neq bit in Gen6 SAMPLER_STATE.

2014-07-29 Thread Kenneth Graunke
The "Min/Mag State Not Equal" bit is supposed to be set when the min/mag filters or address rounding modes differ. BLORP uses identical min/mag settings, so the bit should be unset. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 2 -- 1 file changed, 2 deletions(-

[Mesa-dev] [PATCH 07/23] i965: Push computation for sampler state batch offsets up a level.

2014-07-29 Thread Kenneth Graunke
Other than this, brw_update_sampler_state only deals with a single SAMPLER_STATE structure, and doesn't need to know which position it is in the table. The caller takes care of dealing with multiple surface states. Pushing this up a level allows us to drop the ss_index parameter. Signed-off-by:

[Mesa-dev] i965 sampler state cleanups

2014-07-29 Thread Kenneth Graunke
A while back, I wrote a patch to skip border color upload, and got annoyed by having to write it twice - once for the Gen4-6 code, and once for Gen7+. So I decided to clean that up. 23 patches and a bug fix later, I've unified the code, deleting gen7_sampler_state.c entirely. There's now one cop

[Mesa-dev] [PATCH 18/23] i965: Delete redundant sampler state dumping code.

2014-07-29 Thread Kenneth Graunke
Although the Gen4-6 and Gen7+ variants used different structure types, they didn't use any of the fields - only the size, which is identical. So both decoders did exactly the same thing. Someday we should implement useful decoders for SAMPLER_STATE. Signed-off-by: Kenneth Graunke --- src/mesa/d

[Mesa-dev] [PATCH 19/23] i965: Make BLORP use brw_emit_sampler_state().

2014-07-29 Thread Kenneth Graunke
This simplifies the code, removes use of the old structures, and also allows us to combine the Gen6 and Gen7+ code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_blorp.h| 4 ++ src/mesa/drivers/dri/i965/gen6_blorp.cpp | 65 ++-- src/mesa/driver

[Mesa-dev] [PATCH 13/23] i965: Introduce a function to emit a SAMPLER_STATE structure.

2014-07-29 Thread Kenneth Graunke
This simply assembles all the SAMPLER_STATE fields into their proper bit locations. Making it work on all generations was easy enough; some of the fields are even in the same place. Not used by anything yet, but will be soon. I made it non-static so BLORP can use it too. Signed-off-by: Kenneth

[Mesa-dev] [PATCH 23/23] i965: Skip uploading border color when unnecessary.

2014-07-29 Thread Kenneth Graunke
The border color is only needed when using the GL_CLAMP_TO_BORDER or (deprecated) GL_CLAMP wrap modes; all others ignore it, including the common GL_CLAMP_TO_EDGE and GL_REPEAT wrap modes. In those cases, we can skip uploading it entirely, saving a bit of space in the batchbuffer. Instead, we jus

[Mesa-dev] [PATCH 12/23] i965: Add #defines for SAMPLER_STATE fields.

2014-07-29 Thread Kenneth Graunke
We'll use these to replace the existing structures. I've adopted the convention that "BRW" applies to all hardware, and "GENX" applies starting with generation X, but might be replaced by some later generation. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 54

[Mesa-dev] [PATCH 20/23] i965: Drop sizeof(struct brw_sampler_state) from estimated prim size.

2014-07-29 Thread Kenneth Graunke
This is the last user of the structure. Hardcoding 16 is poor style, but this code is already a senseless mess, so it's not that much worse. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_draw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 08/23] i965: Shift brw_upload_sampler_state_table away from structures.

2014-07-29 Thread Kenneth Graunke
The Gen4-6 and Gen7+ code is virtually identical, but both use different structure types. Switching to use a uint32_t pointer and operate on the number of DWords will make it possible to share code. It turns out that SURFACE_STATE is the same number of DWords on every platform currently; it will

[Mesa-dev] [PATCH 10/23] i965: Delete gen7_upload_sampler_state_table and vtable mechanism.

2014-07-29 Thread Kenneth Graunke
brw_upload_sampler_state_table now handles all generations, so we don't need the vtable mechanism either. There's still a lot of code duplication; the next patches will address that. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c| 3 -- src/mesa/drivers/dri/

[Mesa-dev] [PATCH 22/23] i965: Delete sampler state structures.

2014-07-29 Thread Kenneth Graunke
We've moved to using bitshifts (like we did for surface state); nothing uses the structures anymore. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_structs.h | 99 - 1 file changed, 99 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_stru

[Mesa-dev] [PATCH 16/23] i965: Stop using gen7_update_sampler_state; rm gen7_sampler_state.c.

2014-07-29 Thread Kenneth Graunke
The code in brw_sampler_state.c now handles all generations; we don't need the extra Gen7+ only code anymore. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_sampler_state.c | 11 +- src/mesa/drivers/dri/i965/brw_state.h

[Mesa-dev] [PATCH 11/23] i965: Convert wrap mode #defines to an enum.

2014-07-29 Thread Kenneth Graunke
This makes it easy to tell that they're grouped together, and also improves gdb printing. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src

[Mesa-dev] [PATCH 06/23] i965: Drop unused 'ss_index' parameter from gen7_update_sampler_state.

2014-07-29 Thread Kenneth Graunke
This was copied from the Gen4-6 code, but is unused. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_sampler_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sampler_state.c b/src/mesa/drivers/dri/i965/gen7_sampler_

[Mesa-dev] [PATCH 05/23] i965: Stop storing sdc_offset in brw_stage_state.

2014-07-29 Thread Kenneth Graunke
sdc_offset is produced and consumed in the same function, so there's no need to store it in the context, nor pass pointers to it through various call chains. Saves 128 bytes per brw_stage_state structure, and makes the code clearer as well. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dr

[Mesa-dev] [PATCH 14/23] i965: Make brw_update_sampler_state() use brw_emit_sampler_state().

2014-07-29 Thread Kenneth Graunke
Instead of stuffing bits directly into the brw_sampler_state structure, we now store them in local variables, then use brw_emit_sampler_state() to assemble the packet. This separates the decision about what values to use from the actual packet emission, which makes the code more reusable across ge

[Mesa-dev] [PATCH 15/23] i965: Make brw_update_sampler_state use 8 bits for LOD fields on Gen7+.

2014-07-29 Thread Kenneth Graunke
This was the only actual difference between Gen4-6 and Gen7+ in terms of the values we program. The rest was just mechanical structure rearrangement. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) d

[Mesa-dev] [PATCH 09/23] i965: Make brw_upload_sampler_state_table handle Gen7+ as well.

2014-07-29 Thread Kenneth Graunke
This copies a few changes from gen7_upload_sampler_state_table; the next patch will delete that function. Gen7+ has per-stage sampler state pointer update packets, so we emit them as soon as we emit a new table for a stage. On Gen6 and earlier, we have a single packet, so we delay until we've cha

Re: [Mesa-dev] [PATCH 21/29] mesa: stop going behind the user's back wrt sse4.1 optimisations

2014-07-29 Thread Matt Turner
On Tue, Jul 29, 2014 at 3:54 PM, Emil Velikov wrote: > If the user/builder has a setup capable of using sse4.1 it's their > responsibility to enable it. > > Let's unconditionally include main/streaming-load-memcpy.c, as it > already features a ifdef __SSE4_1__ check and add a stub implementation >

Re: [Mesa-dev] [PATCH 6/7] glsl: fix inconsistent struct/class warning in vs12

2014-07-29 Thread Ian Romanick
Reviewed-by: Ian Romanick On 07/22/2014 02:07 PM, Alon Levy wrote: > Remove incorrect struct prefix, ir_variable is a class > > Signed-off-by: Alon Levy > --- > src/glsl/opt_dead_builtin_varyings.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/opt_dead_bu

[Mesa-dev] [PATCH v2] glsl: Use the without_array predicate to simplify some code

2014-07-29 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Matt Turner [v1] Cc: Timothy Arceri --- src/glsl/ast_to_hir.cpp| 3 +-- src/glsl/glsl_types.cpp| 3 +-- src/glsl/link_uniforms.cpp | 23 --- src/glsl/link_varyings.cpp | 6 ++ 4 files changed, 12 in

[Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-29 Thread Ian Romanick
From: Ian Romanick Returns the type without any arrays. This will be used in later patches in this series. Signed-off-by: Ian Romanick Suggested-by: Timothy Arceri Cc: Timothy Arceri --- src/glsl/glsl_types.h | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/glsl_ty

[Mesa-dev] [PATCH] glsl/glcpp: rename ERROR to ERROR_TOKEN to fix MSVC build

2014-07-29 Thread Brian Paul
ERROR is a #define in the MSVC WinGDI.h header file. Add the _TOKEN suffix as we do for a few other lexer tokens. --- src/glsl/glcpp/glcpp-lex.l |2 +- src/glsl/glcpp/glcpp-parse.y |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/

[Mesa-dev] [PATCH 18/29] android: drop HAL_PIXEL_FORMAT_RGBA_{5551, 4444}

2014-07-29 Thread Emil Velikov
Upstream Android (system/core) has dropped these formats with commit 6bac41f1bf9(get rid of HAL pixelformats 5551 and ) yet does not mention why. These formats never really worked so we're safe to drop them as well. Identical commit is available in the android-x86 external/mesa repo comm

[Mesa-dev] [PATCH 03/29] android: egl/main: fixup the nouveau build

2014-07-29 Thread Emil Velikov
For a while the nouveau pipe driver has been a static library and it has been using STL for even longer. Correct add the link and cleanup the gallium_DRIVERS. Cc: "10.1 10.2" Signed-off-by: Emil Velikov --- src/egl/main/Android.mk | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) d

[Mesa-dev] [PATCH 16/29] android: gallium/auxiliary: drop log2/log2f redefitions

2014-07-29 Thread Emil Velikov
Recent versions of bionic has picked up support for these functions, leading to build issues due to the redefition of the symbols. Note: wrapping things in #ifdef does not cut it :\ Identical patch is available in chromium, android-x86 and perhaps other projects. commit 66c1c789ce3407472de9e

[Mesa-dev] [PATCH 07/29] android: gallium/freedreno: add preliminary build

2014-07-29 Thread Emil Velikov
For all the people interested in testing the freedreno driver on their Android devices. The next commit will hook these up within the libEGL driver (via the gallium-egl backend). There may be some rough edges but those can be sorted when a willing builder/tester comes along. v2: - s/freefreno/fr

[Mesa-dev] [PATCH 10/29] automake: merge gallium/state_trackers/Makefile into gallium/Makefile

2014-07-29 Thread Emil Velikov
One makefile less, with the potential of further compacting the automake build. Signed-off-by: Emil Velikov --- configure.ac | 1 - src/Makefile.am| 1 - src/gallium/Makefile.am| 49 + src/gallium/state_t

[Mesa-dev] [PATCH 06/29] automake: gallium/freedreno: drop spurious include dirs

2014-07-29 Thread Emil Velikov
Rather than including two extra folders only for two headers, just prefix the headers and be done with it. Cc: "10.1 10.2" Cc: Rob Clark Cc: freedr...@lists.freedesktop.org Signed-off-by: Emil Velikov Reviewed-by: Rob Clark --- src/gallium/drivers/freedreno/Makefile.am| 2 -- src/gall

[Mesa-dev] [PATCH 22/29] automake: mesa: whitespace fixes

2014-07-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/Makefile.am | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am index d59af99..e7d55c9 100644 --- a/src/mesa/Makefile.am +++ b/src/mesa/Makefile.am @@ -120,20 +120,18 @@ endif libmesa_

[Mesa-dev] [PATCHv2 00/29] Android inspired fixes and automake cleanups

2014-07-29 Thread Emil Velikov
Hello list, Here is an update+expansion of a lovely series that cleans up our builds and as an added bonus it makes things build for android on almost every driver but - radeonsi - driver requires llvm but the build is not there yet. - nouveau - bionic loves tr1/* C++ headers + broken drm_gral

[Mesa-dev] [PATCH 25/29] android: loader: use the installed libdrm headers

2014-07-29 Thread Emil Velikov
One step closer to the way we handle automake builds. Signed-off-by: Emil Velikov --- src/loader/Android.mk | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/loader/Android.mk b/src/loader/Android.mk index 6890af4..1c6fdae 100644 --- a/src/loader/Android.mk +++ b/src/

[Mesa-dev] [PATCH 14/29] scons: group state-trackers' and targets' scons

2014-07-29 Thread Emil Velikov
Both share the identical dependencies, as such we can simplify the scons script. Signed-off-by: Emil Velikov --- src/gallium/SConscript | 42 +++--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/src/gallium/SConscript b/src/gallium/SConscript

[Mesa-dev] [PATCH 05/29] android: egl/main: resolve radeon linking issues

2014-07-29 Thread Emil Velikov
From: Paulo Sergio Travaglia - link against libdrm_radeon - link the r600 driver against libstlport - linkin the newly added libmesa_pipe_radeon library required by r600 and radeonsi drivers v2: Include pipe_radeon after pipe_r600/radeonsi. Cc: "10.1 10.2" [Emil Velikov] Split up and add co

[Mesa-dev] [PATCH 11/29] automake: compact gallium/target/Makefile into gallium/Makefile

2014-07-29 Thread Emil Velikov
Yet another makefile less to worry about. Signed-off-by: Emil Velikov --- configure.ac| 1 - src/Makefile.am | 3 +- src/gallium/Makefile.am | 25 --- src/gallium/targets/Makefile.am | 71 - 4 files

[Mesa-dev] [PATCH 27/29] android: dri: use the installed libdrm headers

2014-07-29 Thread Emil Velikov
Saves us a few lines and brings us closer to the automake build. Drop DRM_TOP as it's not longer used. Signed-off-by: Emil Velikov --- Android.mk | 1 - src/mesa/drivers/dri/Android.mk | 3 +-- src/mesa/drivers/dri/i915/Android.mk | 3 +-- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 09/29] automake: compact gallium/drivers and gallium/winsys makefiles

2014-07-29 Thread Emil Velikov
Rather than having two separate almost empty and identical makefiles, compact them thus improving the configure and build time. Additionally this makes the automake build symmetrical to the scons and android one. Signed-off-by: Emil Velikov --- configure.ac| 3 +- src/Makef

[Mesa-dev] [PATCH 26/29] android: gallium: use the installed libdrm headers

2014-07-29 Thread Emil Velikov
Saves us a few lines and brings us closer to the automake build. Signed-off-by: Emil Velikov --- src/gallium/winsys/i915/drm/Android.mk | 5 + src/gallium/winsys/intel/drm/Android.mk | 5 + src/gallium/winsys/svga/drm/Android.mk | 3 +-- 3 files changed, 3 insertions(+), 10 deletions(-

[Mesa-dev] [PATCH 21/29] mesa: stop going behind the user's back wrt sse4.1 optimisations

2014-07-29 Thread Emil Velikov
If the user/builder has a setup capable of using sse4.1 it's their responsibility to enable it. Let's unconditionally include main/streaming-load-memcpy.c, as it already features a ifdef __SSE4_1__ check and add a stub implementation for people that don't have -msse4.1 enabled at compile-time. Th

[Mesa-dev] [PATCH 19/29] glsl: Don't use strtod_l in Mesa on Android.

2014-07-29 Thread Emil Velikov
From: "Myles C. Maxfield" Android includes a fix to asm/posix_types.h inside /ndk/toolchains/x86-4.7/prebuilt/linux-x86_64/lib/gcc/ i686-linux-android/4.7/include-fixed/asm/posix_types.h. That file #include_next's the real asm/posix_types.h, but then fixes (redefines) the __FD_ZERO macro. However

[Mesa-dev] [PATCH 20/29] android: glsl: the stlport over the limited Android STL

2014-07-29 Thread Emil Velikov
The latter lacks various functionality used by mesa/glsl. Cc: "10.1 10.2" Signed-off-by: Emil Velikov --- src/glsl/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/Android.mk b/src/glsl/Android.mk index 8a39426..7b1fa7e 100644 --- a/src/glsl/Android.mk +++

[Mesa-dev] [PATCH 29/29] android: dri/i9*5: remove used _INCLUDES variable

2014-07-29 Thread Emil Velikov
No longer needed as of last commit. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/Android.mk | 3 +-- src/mesa/drivers/dri/i915/Makefile.sources | 4 src/mesa/drivers/dri/i965/Android.mk | 3 +-- src/mesa/drivers/dri/i965/Makefile.sources | 7 +-- 4 files changed

[Mesa-dev] [PATCH 04/29] android: gallium/radeon: attempt to fix the android build

2014-07-29 Thread Emil Velikov
From: Paulo Sergio Travaglia - include the correct folders - add a new buildscript for the common radeon folder v2: Use the installed libdrm headers over the DRM_TOP ones. Cc: "10.1 10.2" [Emil Velikov] Split up and add commit message. Signed-off-by: Emil Velikov --- src/gallium/Android.mk

[Mesa-dev] [PATCH 01/29] egl/main: Bring in the Makefile.sources

2014-07-29 Thread Emil Velikov
Rather than having the sources list duplicated across all three build systems, define it once and use it whenever needed. Signed-off-by: Emil Velikov --- src/egl/main/Android.mk | 23 --- src/egl/main/Makefile.am | 40 +++- src/e

[Mesa-dev] [PATCH 15/29] android: targets/egl-static: add correct include for DRM headers

2014-07-29 Thread Emil Velikov
Android build never really installs the headers, as such we need to explicitly add their location in the source tree otherwise it will fail to find them. v2: Android now installs the headers, so let's use that ;) Signed-off-by: Emil Velikov --- src/gallium/targets/egl-static/Android.mk | 4 +---

[Mesa-dev] [PATCH 23/29] android: dri/i915: do not build an 'empty' driver

2014-07-29 Thread Emil Velikov
The variable i915_C_FILES changed to i915_FILES with commit 34d4216e641 back in mesa 9.1/9.2. Yet we've missed to update the the android build, essentially creating an dummy/empty driver that can never work. Cc: "10.1 10.2" Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/Android.mk |

[Mesa-dev] [PATCH 28/29] android: drivers/dri: add $(mesa_top)/src to the includes list

2014-07-29 Thread Emil Velikov
Will allow us to nuke an include or two from the drivers. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/Android.mk b/src/mesa/drivers/dri/Android.mk index 5cb6d7b..1ffa845 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 24/29] android: egl/dri2: use the installed libdrm headers

2014-07-29 Thread Emil Velikov
Trying to get rid of the hardcoded dependency of DRM_TOP which expects that mesa is localted in /external/drm. Will Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/driver

[Mesa-dev] [PATCH 13/29] android: reorder gallium SUBDIRS

2014-07-29 Thread Emil Velikov
To be closer to its automake counterpart. Signed-off-by: Emil Velikov --- src/gallium/Android.mk | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/Android.mk b/src/gallium/Android.mk index 767361a..bf99e4f 100644 --- a/src/gallium/Android.mk +++ b/sr

[Mesa-dev] [PATCH 17/29] swrast: Fix a bug with Multiple Render Targets.

2014-07-29 Thread Emil Velikov
See https://code.google.com/p/chromium/issues/detail?id=308715 for more info. Review URL: https://codereview.chromium.org/27740005 Patch authored by hu...@chromium.org, as per https://android.googlesource.com/platform/external/chromium_org/third_party/mesa/src/+/009d829daee69743d77f4eaea702633a2f

[Mesa-dev] [PATCH 12/29] automake: handle gallium SUBDIRs in gallium/Makefile

2014-07-29 Thread Emil Velikov
Considering the way we've been consolidating things it makes sense to add the final two (aux and tests) in here. Signed-off-by: Emil Velikov --- src/Makefile.am | 10 +- src/gallium/Makefile.am | 16 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a

[Mesa-dev] [PATCH 02/29] android: gallium/nouveau: fix include folders, link against libstlport

2014-07-29 Thread Emil Velikov
nouveau uses STL for a while now thus we need to include external/stlport/libstlport.mk in order to get the build at least partially working. v2: Use the installed libdrm headers over the DRM_TOP ones. Cc: "10.1 10.2" Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/Android.mk|

[Mesa-dev] [PATCH 08/29] android: egl/main: add/enable freedreno

2014-07-29 Thread Emil Velikov
For all everyone willing to give the freedreno driver a go they can now build it under Android. Cc: "10.1 10.2" Cc: Rob Clark Cc: freedr...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/egl/main/Android.mk | 6 ++ src/gallium/targets/egl-static/Android.mk | 3

Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-07-29 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 7:18 AM, Matt Turner wrote: > > On Mon, Jul 28, 2014 at 8:47 PM, Anuj Phogat wrote: > > Fixes Khronos GLES3 CTS test: > > dynamic_expression_array_access_vertex > > > > Cc: > > Signed-off-by: Anuj Phogat > > --- > > I don't have a test case though it might be useful to a

Re: [Mesa-dev] State of llvmpipe geometry shaders?

2014-07-29 Thread P.A. Jimenez
master indeed works without having to set the environment variable (at least with a simple test program targeting OpenGL 3.3 core using a geometry shader). OpenGL Extensions Viewer, however, still sees only OpenGL 3.0 without the environment variable set. Although, it would be nice to find out what

[Mesa-dev] [Bug 81881] Scons+MSVC 12.0 shared targets build fails

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81881 --- Comment #2 from Yury Blokhin --- Yes, this fix helped, thanx! -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org htt

Re: [Mesa-dev] Env var for forcing sw driver (Re: [PATCH 3/6] Add support for swrast to the DRM EGL platform)

2014-07-29 Thread Emil Velikov
On 25/07/14 07:34, Pekka Paalanen wrote: > On Fri, 25 Jul 2014 09:14:40 +0300 > Pekka Paalanen wrote: > [snip] > Hm, reading Kenneth's comments about variable naming at > http://lists.freedesktop.org/archives/mesa-dev/2014-July/064103.html > I wonder, is there real benefit for different driver lo

Re: [Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_BUFFER_SHARE cap and get_param sw_winsys hook

2014-07-29 Thread Emil Velikov
On 24/07/14 01:43, Emil Velikov wrote: > The kms_swrast driver has a separate InitScreen hook for its DriverAPI > from the rest of the DRI2 drivers, all of which capable of buffer > sharing. As such we no longer need to dive through the pipe-driver and > winsys layers in order to determine if the d

[Mesa-dev] [Bug 81881] Scons+MSVC 12.0 shared targets build fails

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81881 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] State of llvmpipe geometry shaders?

2014-07-29 Thread Jose Fonseca
On 29/07/14 16:31, Brian Paul wrote: On 07/19/2014 09:16 AM, Paul wrote: Brian Paul vmware.com> writes: On 07/11/2014 01:47 AM, Florian Link wrote: Hi everyone, I read a post from 2012 that MESA supports geometry shaders. I tried a current MESA 10.2.x release, but MESA GL_VERSION returns O

Re: [Mesa-dev] [PATCH] main/get_hash_params: Add GL_SAMPLE_SHADING_ARB

2014-07-29 Thread Kenneth Graunke
On Monday, July 28, 2014 06:32:47 PM Jason Ekstrand wrote: > GL_SAMPLE_SHADING is specified as a valid pname for glGet in the > GL_ARB_sample_shading extension. It seems as if we forgot to add it to the > table of pnames. > > Signed-off-by: Jason Ekstrand > --- > src/mesa/main/get_hash_params.p

Re: [Mesa-dev] SandyBridge not handling GL_TRIANGLE_STRIP_ADJACENCY with repeating vertex indices correctly

2014-07-29 Thread Kenneth Graunke
On Tuesday, July 29, 2014 10:12:23 AM Iago Toral Quiroga wrote: > Hi, > > running the piglit tests on my implementation of geometry shaders for > Sandy Bridge produces a GPU hang for the following test: > > ./glsl-1.50-geometry-primitive-id-restart GL_TRIANGLE_STRIP_ADJACENCY > ffs > > That test

[Mesa-dev] [Bug 81881] Scons+MSVC 12.0 shared targets build fails

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81881 Yury Blokhin changed: What|Removed |Added CC||ultrab...@gmail.com -- You are receiving

[Mesa-dev] [Bug 81881] New: Scons+MSVC 12.0 shared targets build fails

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81881 Priority: medium Bug ID: 81881 Assignee: mesa-dev@lists.freedesktop.org Summary: Scons+MSVC 12.0 shared targets build fails Severity: normal Classification: Unclassified OS:

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #15 from Emil Velikov --- (In reply to comment #14) > I paste the contents here for both xcb.pc files as they're short. > Directories/files where they point are valid, I don't see anything wrong in > these. > AFAICT they look good an

  1   2   >