https://bugs.freedesktop.org/show_bug.cgi?id=77502
Matt Turner changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Am 26.04.2014 01:45, schrieb Ilia Mirkin:
> On Fri, Apr 25, 2014 at 5:44 PM, Roland Scheidegger
> wrote:
>> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>>> Signed-off-by: Ilia Mirkin
>>> ---
>>> src/gallium/auxiliary/tgsi/tgsi_exec.c | 188
>>> +
>>> src/gallium/a
On 04/25/2014 11:23 AM, Anuj Phogat wrote:
> In OpenGL 3.1 attribute 0 becomes non-magic, just like in
> OpenGL ES 2.0. Earlier versions of OpenGL used attribute 0
> exclusively for vertex position.
>
> V2: Add a utility function _mesa_attr_zero_aliases_vertex() in
> varray.h
>
> Fixes 4 Khro
This was introduced with the comment and code below it, though the code
only touches prog_data (CACHE_NEW_WM_PROG).
---
src/mesa/drivers/dri/i965/gen6_wm_state.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/gen6_wm_state.c
b/src/mesa/drivers/dri/i965/gen6_wm_state.
This keeps us from having to emit the nonpipelined state packet on every
FBO binding.
-4.42003% +/- 1.09961% effect on cairo-perf-trace runtime on glamor (n=110).
---
src/mesa/drivers/dri/i965/brw_context.h| 8
src/mesa/drivers/dri/i965/brw_state_upload.c | 6 ++
No more walking 96*6 pointers looking to see if they're the current
texture, when we only use the first 2 out of 96 units. -6.26002% +/-
1.87817% effect on cairo runtime on no-fbo-cache glamor (n=36).
---
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/texobj.c | 4 +++-
src/mesa/main/texstate.
---
src/mesa/drivers/dri/i965/gen6_wm_state.c| 1 +
src/mesa/drivers/dri/i965/gen7_wm_state.c| 2 +-
src/mesa/drivers/dri/i965/gen8_blend_state.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/gen6_wm_state.c
b/src/mesa/drivers/dri/i965/gen6
Ilia Mirkin writes:
> On Thu, Apr 24, 2014 at 8:50 PM, Eric Anholt wrote:
>> Instead of walking 6 shader stages for each of the 96 combined texture
>> image units, now we just walk the samplers used in each shader stage.
>>
>> With cairo-perf-trace on Xephyr with glamor, I'm seeing a -6.50518% +
On Fri, Apr 25, 2014 at 5:44 PM, Roland Scheidegger wrote:
> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>> Signed-off-by: Ilia Mirkin
>> ---
>> src/gallium/auxiliary/tgsi/tgsi_exec.c | 188
>> +
>> src/gallium/auxiliary/util/u_math.h| 11 ++
>> 2 files change
On Thu, Apr 24, 2014 at 8:50 PM, Eric Anholt wrote:
> Instead of walking 6 shader stages for each of the 96 combined texture
> image units, now we just walk the samplers used in each shader stage.
>
> With cairo-perf-trace on Xephyr with glamor, I'm seeing a -6.50518% +/-
> 2.55601% effect on runt
https://bugs.freedesktop.org/show_bug.cgi?id=77917
--- Comment #1 from Chia-I Wu ---
Did you git-bisect to 75143ef05576ee9f25ee176bc28c3c4d03705bf5? I do not
recall seeing this issue 4 years ago... Commit
144bbb7b78ecac33c62c6dc28df1747a73c4eb39 is more likely to contribute to this,
per #77502.
On Sat, Apr 26, 2014 at 2:53 AM, Emil Velikov wrote:
> On 25/04/14 11:41, Chia-I Wu wrote:
>> Hi,
>>
>> This series cleans up GL_KHR_debug support, fixes message control for some
>> corner cases, and makes one enhancement: cheap
>> glPushDebugGroup/glPopDebugGroup for command stream annotation.
>>
On Fri, Apr 25, 2014 at 6:20 PM, Roland Scheidegger wrote:
> Am 25.04.2014 23:19, schrieb Ilia Mirkin:
>> On Fri, Apr 25, 2014 at 5:02 PM, Roland Scheidegger
>> wrote:
>>> As for the addc/subb I guess this is an area where just about everything
>>> you do won't really match hw in any case. A qui
On Fri, Apr 25, 2014 at 10:30 PM, Brian Paul wrote:
> On 04/25/2014 04:42 AM, Chia-I Wu wrote:
>>
>> When GL_DEBUG_OUTPUT_SYNCHRONOUS is GL_TRUE, drivers are allowed to log
>> debug
>> messages from other threads. That requires gl_debug_state to be protected
>> by
>> a mutex, even when it is a co
Am 25.04.2014 23:19, schrieb Ilia Mirkin:
> On Fri, Apr 25, 2014 at 5:02 PM, Roland Scheidegger
> wrote:
>> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>>> Signed-off-by: Ilia Mirkin
>>> ---
>>> src/gallium/auxiliary/tgsi/tgsi_info.c | 8 +
>>> src/gallium/docs/source/tgsi.rst
On Fri, Apr 25, 2014 at 10:30 PM, Brian Paul wrote:
> On 04/25/2014 04:42 AM, Chia-I Wu wrote:
>>
>> _mesa_HashTable is not well-suited for us: it locks a mutex unnecessarily
>> and
>> it does not accept 0 as the key (and have branches to handle 1 specially).
>> What we really need is a sparse arr
Am 25.04.2014 23:11, schrieb Ilia Mirkin:
> On Fri, Apr 25, 2014 at 4:43 PM, Roland Scheidegger
> wrote:
>> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>>> This is enough to catch up to core mesa, with the exception of
>>> uaddCarry/usubBorrow -- those will require some thought. I don't like the
>
Am 25.04.2014 19:41, schrieb Ilia Mirkin:
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/auxiliary/tgsi/tgsi_exec.c | 188
> +
> src/gallium/auxiliary/util/u_math.h| 11 ++
> 2 files changed, 199 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tg
On Tue, Apr 8, 2014 at 1:49 PM, Thomas Hellstrom wrote:
> On 04/08/2014 10:28 PM, Ander Conselvan de Oliveira wrote:
>> From: Ander Conselvan de Oliveira
>>
>> Changes from previous version:
>>
>> - make it clearer that the interface is optional;
>
> No! this is still a NAK!
I don't agree with
On 23/04/14 00:24, Eric Anholt wrote:
> I was reading an article on LTO in firefox today, and it pointed to
> https://github.com/wmanley/bloat-blame so I decided to try it on Mesa
> (i965_dri.so in a release build). It looks like it's pointing at some
> silly inlines we're doing that we can probab
Am 25.04.2014 19:41, schrieb Ilia Mirkin:
> Also pipe through [IU]MUL_HI, MAD, and lower ldexp. This provides
> coverage of all new ARB_gpu_shader5 functions except uaddCarry,
> usubBorrow and interpolateAt*.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 70
On Fri, Apr 25, 2014 at 5:02 PM, Roland Scheidegger wrote:
> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>> Signed-off-by: Ilia Mirkin
>> ---
>> src/gallium/auxiliary/tgsi/tgsi_info.c | 8 +
>> src/gallium/docs/source/tgsi.rst | 51
>> ++
>> src/gall
On Fri, Apr 25, 2014 at 4:43 PM, Roland Scheidegger wrote:
> Am 25.04.2014 19:41, schrieb Ilia Mirkin:
>> This is enough to catch up to core mesa, with the exception of
>> uaddCarry/usubBorrow -- those will require some thought. I don't like the way
>> they were done in core mesa, so I may redo it
Am 25.04.2014 19:41, schrieb Ilia Mirkin:
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/auxiliary/tgsi/tgsi_info.c | 8 +
> src/gallium/docs/source/tgsi.rst | 51
> ++
> src/gallium/include/pipe/p_shader_tokens.h | 11 ++-
> 3 files changed,
https://bugs.freedesktop.org/show_bug.cgi?id=77502
--- Comment #14 from farmboy0+freedesk...@googlemail.com ---
Created attachment 97995
--> https://bugs.freedesktop.org/attachment.cgi?id=97995&action=edit
patch in git email format
--
You are receiving this mail because:
You are the assignee f
Am 25.04.2014 19:41, schrieb Ilia Mirkin:
> This is enough to catch up to core mesa, with the exception of
> uaddCarry/usubBorrow -- those will require some thought. I don't like the way
> they were done in core mesa, so I may redo it differently. (Will start a
> discussion on that topic after I've
On 08/04/14 21:28, Ander Conselvan de Oliveira wrote:
> From: Ander Conselvan de Oliveira
>
> Changes from previous version:
>
> - make it clearer that the interface is optional;
>
> - fix other issues raised on the last review round.
>
Hi Ander,
I have picked up patch 1,2,3 and 5, annota
changed according to Francisco Jerez's comments
(v2 won't compil, sorry about that)
EdB (2):
clover: Update opencl headers to version 1.2
clover: Add clEnqueue{Marker,Barrier}WithWaitList
include/CL/cl.h| 332 +-
include/CL/cl.hpp
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +-
src/gallium/state_trackers/clover/api/event.cpp| 48 ++
2 files changed, 42 insertions(+), 10 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp
b/src/gallium/state_trackers/clover/a
On Fri, Apr 25, 2014 at 3:36 PM, Matt Turner wrote:
> On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote:
>> This is enough to catch up to core mesa, with the exception of
>> uaddCarry/usubBorrow -- those will require some thought. I don't like the way
>> they were done in core mesa, so I may re
On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote:
> This is enough to catch up to core mesa, with the exception of
> uaddCarry/usubBorrow -- those will require some thought. I don't like the way
> they were done in core mesa, so I may redo it differently. (Will start a
> discussion on that topi
On Fri, Apr 25, 2014 at 3:24 PM, Matt Turner wrote:
> bitfieldInsert takes scalar integers for its last two arguments. Since
> bitfieldInsert is lowered on i965 to two instructions that have more
> flexible arguments, I didn't notice when I wrote this.
Reviewed-by: Ilia Mirkin
Thanks!
> ---
>
bitfieldInsert takes scalar integers for its last two arguments. Since
bitfieldInsert is lowered on i965 to two instructions that have more
flexible arguments, I didn't notice when I wrote this.
---
src/glsl/lower_instructions.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
On Fri, Apr 25, 2014 at 2:44 PM, Ilia Mirkin wrote:
> On Fri, Apr 25, 2014 at 2:38 PM, Matt Turner wrote:
>> On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote:
>>> bitfield_insert expects glsl_type::int_type arguments, not uint vectors
>>>
>>> Signed-off-by: Ilia Mirkin
>>> ---
>>>
>>> Identi
On Fri, Apr 25, 2014 at 11:40 AM, Emil Velikov wrote:
> On 25/04/14 19:02, Kristian Høgsberg wrote:
>> On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov
>> wrote:
>>> Use a const arrays with the extensions, and use the correct one at
>>> runtime. This removes the assumption that the dri2_screen has
On 05/04/14 13:45, Emil Velikov wrote:
> On 05/04/14 13:27, Kai Wasserbäch wrote:
>> Dear Emil,
>> Emil Velikov schrieb am 05.04.2014 04:10:
>>> On 01/04/14 01:32, Emil Velikov wrote:
> [snip]
>>>
>>> https://github.com/evelikov/Mesa/ branch exported-symbol-cleanup
>>>
>>> Feel free to checkout and
changed according to Francisco Jerez's comments
*** BLURB HERE ***
EdB (2):
clover: Update opencl headers to version 1.2
clover: add clEnqueue{Marker,Barrier}WithWaitList
include/CL/cl.h| 332 +-
include/CL/cl.hpp | 1210
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 4 +-
src/gallium/state_trackers/clover/api/event.cpp| 46 ++
2 files changed, 41 insertions(+), 9 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp
b/src/gallium/state_trackers/clover/ap
https://bugs.freedesktop.org/show_bug.cgi?id=77502
--- Comment #13 from Matt Turner ---
(In reply to comment #11)
> Created attachment 97975 [details] [review]
> patch to fix build for libOpenVG
Would you attach a git-formatted patch, preferably with your real name, etc?
I'll commit that.
--
Y
On 25/04/14 11:41, Chia-I Wu wrote:
> Hi,
>
> This series cleans up GL_KHR_debug support, fixes message control for some
> corner cases, and makes one enhancement: cheap
> glPushDebugGroup/glPopDebugGroup for command stream annotation.
>
> Patch 1-12 refactor the code. There should be no functio
https://bugs.freedesktop.org/show_bug.cgi?id=77502
--- Comment #12 from farmboy0+freedesk...@googlemail.com ---
Chia-I Wu is right.
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freed
https://bugs.freedesktop.org/show_bug.cgi?id=77502
--- Comment #11 from farmboy0+freedesk...@googlemail.com ---
Created attachment 97975
--> https://bugs.freedesktop.org/attachment.cgi?id=97975&action=edit
patch to fix build for libOpenVG
--
You are receiving this mail because:
You are the ass
On Fri, Apr 25, 2014 at 2:38 PM, Matt Turner wrote:
> On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote:
>> bitfield_insert expects glsl_type::int_type arguments, not uint vectors
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> Identical to the patch I sent out last night. Without it ldexp lower
Jan Vesely writes:
> v2: use a new variable for aligned size
> add comment
> make both vars const
> only use the aligned value in argument constructors
> fix comment typo
>
> Signed-off-by: Jan Vesely
Looks good to me, thanks,
Reviewed-by: Francisco Jerez
> ---
> .../state_tr
On 25/04/14 19:02, Kristian Høgsberg wrote:
> On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov
> wrote:
>> Use a const arrays with the extensions, and use the correct one at
>> runtime. This removes the assumption that the dri2_screen has a
>> fixed size dri extension list and avoids the individual
On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote:
> bitfield_insert expects glsl_type::int_type arguments, not uint vectors
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Identical to the patch I sent out last night. Without it ldexp lowering
> (without bfi lowering) causes assertion failures in the
On 25/04/14 18:53, Kristian Høgsberg wrote:
> On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov
> wrote:
>> Rather than keeping a separate and unused copy of the screen extensions
>> within the radeon screen, use a constant array that can be used directly
>> with __DRIscreen.
>
> The copy in the rad
On 25/04/14 18:44, Kristian Høgsberg wrote:
> On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov
> wrote:
>> With commit e59fa4c46c8("dri2: release texture image.") we updated the
>> extension without bumping the version number. The patch itself added an
>> interface required to enable texture_from_pi
v2: use a new variable for aligned size
add comment
make both vars const
only use the aligned value in argument constructors
fix comment typo
Signed-off-by: Jan Vesely
---
.../state_trackers/clover/llvm/invocation.cpp | 23 +++---
1 file changed, 16 insertion
In OpenGL 3.1 attribute 0 becomes non-magic, just like in
OpenGL ES 2.0. Earlier versions of OpenGL used attribute 0
exclusively for vertex position.
V2: Add a utility function _mesa_attr_zero_aliases_vertex() in
varray.h
Fixes 4 Khronos OpenGL CTS failures:
glGetVertexAttrib
depth24_basic
de
Currently overlapping locations of input variables are not allowed for all
the shader types in OpenGL and OpenGL ES.
>From OpenGL ES 3.0 spec, page 56:
"Binding more than one attribute name to the same location is referred
to as aliasing, and is not permitted in OpenGL ES Shading Language
Marek Olšák writes:
> Have you considered disabling creating the fallback textures for
> hardware which can return the correct constant for a texture fetch if
> a texture isn't bouńd?
No, I hadn't. Given that nobody ever intentionally executes with a
fallback texture, do we care to reduce its o
This patch makes changes to the behavior of glGetAttribLocation(),
glGetFragDataLocation() and glGetFragDataIndex() functions.
Code changes handle a case described in following example:
shader program:
layout(location = 1)in vec4[4] a;
void main()
{
}
Currently, glGetAttribLocation("a") returns
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> ... to improve readability of code. Set indirect_screen_vtable as a static
> const.
>
> Signed-off-by: Emil Velikov
This and patches 13-16
Reviewed-by: Kristian Høgsberg
> ---
> src/glx/indirect_glx.c | 26 ++
>
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> ... to improve readability of code. Set applegl_screen_vtable as a static
> const.
>
> Signed-off-by: Emil Velikov
Reviewed-by: Kristian Høgsberg
> ---
> src/glx/applegl_glx.c | 25 ++---
> 1 file changed, 14 insertio
On Thu, Apr 24, 2014 at 5:50 PM, Eric Anholt wrote:
> Here's a series I got built when profiling to see why glamor's FBO cache
> is necessary. It turns out the worst spots in the no-cache profile were
> present even with the cache, and they were about walking the 96 texture
> units we've got thes
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> Use designated initialisers, and store the extensions pointers as const.
>
> The loader extensions __DRIdri2LoaderExtension and __DRIswrastLoaderExtension
> are setup by the platform backends so they should not be constified.
>
> Signed-off-by
ville.syrj...@linux.intel.com writes:
> From: Ville Syrjälä
>
> I was a bit annoyed when chromium-bsu stopped rendering the spinning
> title text on my gen2 machine. So I bisected it down and found the
> problem with the renderbuffer code overwriting the selected depth
> buffer format.
>
> This s
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> Use a const arrays with the extensions, and use the correct one at
> runtime. This removes the assumption that the dri2_screen has a
> fixed size dri extension list and avoids the individual assignment
> of each extension at runtime.
This cha
The subject line should be "tgsi: ..."
On 04/25/2014 11:41 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 188 +
src/gallium/auxiliary/util/u_math.h| 11 ++
2 files changed, 199 insertions(+)
diff --git a
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> Explicitly set the version that is implemented, as that may differ
> from the one defined in dri_interface.h. Use designated initialisers
> and constify whereever possible.
>
> Note: __DRIimageExtension should not be made const as it's modifie
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> Rather than keeping a separate and unused copy of the screen extensions
> within the radeon screen, use a constant array that can be used directly
> with __DRIscreen.
The copy in the radeon screen isn't unused, that's where the array is
built
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> Uniformly use the typecasted extension name, constify extension instances
> and use designated initialisers. Set the implemented version of the
> extension, over the one defined in dri_infertace.h. Patch covers the
> following extensions:
>
>
On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov wrote:
> With commit e59fa4c46c8("dri2: release texture image.") we updated the
> extension without bumping the version number. The patch itself added an
> interface required to enable texture_from_pixmap on certain platforms.
>
> The new code was effe
This is enough to catch up to core mesa, with the exception of
uaddCarry/usubBorrow -- those will require some thought. I don't like the way
they were done in core mesa, so I may redo it differently. (Will start a
discussion on that topic after I've given it more thought.)
I ran the various piglit
Also pipe through [IU]MUL_HI, MAD, and lower ldexp. This provides
coverage of all new ARB_gpu_shader5 functions except uaddCarry,
usubBorrow and interpolateAt*.
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 70 ++
1 file changed, 53 inser
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 188 +
src/gallium/auxiliary/util/u_math.h| 11 ++
2 files changed, 199 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index 5
bitfield_insert expects glsl_type::int_type arguments, not uint vectors
Signed-off-by: Ilia Mirkin
---
Identical to the patch I sent out last night. Without it ldexp lowering
(without bfi lowering) causes assertion failures in the next mesa/st patch.
src/glsl/lower_instructions.cpp | 6 +++---
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_info.c | 8 +
src/gallium/docs/source/tgsi.rst | 51 ++
src/gallium/include/pipe/p_shader_tokens.h | 11 ++-
3 files changed, 69 insertions(+), 1 deletion(-)
diff --git a/src/gallium
https://bugs.freedesktop.org/show_bug.cgi?id=76976
Roland Scheidegger changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Am 24.04.2014 05:48, schrieb Ilia Mirkin:
> This adds support for gl_SampleMaskIn and gl_InvocationID system values to
> gallium, mesa/st, and nvc0. The relevant piglit tests pass, except 2
> gl_InvocationID-related ones that fail due to the linking being delayed by
> mesa/st (I think). I wrote a l
On 04/25/2014 04:42 AM, Chia-I Wu wrote:
_mesa_HashTable is not well-suited for us: it locks a mutex unnecessarily and
it does not accept 0 as the key (and have branches to handle 1 specially).
What we really need is a sparse array. Whether it should be implemented as a
hash table, a list, or a
On 04/25/2014 04:42 AM, Chia-I Wu wrote:
When GL_DEBUG_OUTPUT_SYNCHRONOUS is GL_TRUE, drivers are allowed to log debug
messages from other threads. That requires gl_debug_state to be protected by
a mutex, even when it is a context state. While we do not spawn threads in
Mesa yet, this commit ma
On 04/25/2014 04:41 AM, Chia-I Wu wrote:
Hi,
This series cleans up GL_KHR_debug support, fixes message control for some
corner cases, and makes one enhancement: cheap
glPushDebugGroup/glPopDebugGroup for command stream annotation.
Patch 1-12 refactor the code. There should be no functional dif
Looks reasonable to me (didn't look at the nv parts).
Reviewed-by: Roland Scheidegger
Am 25.04.2014 02:28, schrieb Ilia Mirkin:
> Thanks. Roland, mind taking a look, IIRC you're the one who had the
> most objections last time around.
>
> On Thu, Apr 24, 2014 at 5:44 PM, Marek Olšák wrote:
>> P
On 04/24/2014 08:45 PM, Michel Dänzer wrote:
From: Michel Dänzer
This can happen with glamor, which uses EGL_KHR_surfaceless_context and
only explicitly binds GL_READ_FRAMEBUFFER for glReadPixels.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Michel Dänzer
---
src/mesa/state_tracker/
Have you considered disabling creating the fallback textures for
hardware which can return the correct constant for a texture fetch if
a texture isn't bouńd?
Marek
On Fri, Apr 25, 2014 at 2:50 AM, Eric Anholt wrote:
> I want to avoid walking the entire long array texture image units, but the
> o
https://bugs.freedesktop.org/show_bug.cgi?id=77502
--- Comment #10 from Chia-I Wu ---
(In reply to comment #3)
> 144bbb7b78ecac33c62c6dc28df1747a73c4eb39 is the first bad commit
> commit 144bbb7b78ecac33c62c6dc28df1747a73c4eb39
> Author: Matt Turner
> Date: Sun Nov 10 19:01:58 2013 -0800
>
>
In both call sites, it could be easily replaced by direct
debug_is_message_enabled calls. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/src/mesa/main/errors
_mesa_HashTable is not well-suited for us: it locks a mutex unnecessarily and
it does not accept 0 as the key (and have branches to handle 1 specially).
What we really need is a sparse array. Whether it should be implemented as a
hash table, a list, or a bsearch()-able array requires investigation
Do not copy the debug group until it is about to be written. One likely
scenario of using glPushDebugGroup/glPopDebugGroup is to enclose a sequence of
GL commands and give them a human-readable description. There is no message
control change in this scenario, and thus no need to copy.
This also
Move most of the code to debug_set_message_enable_all. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 113 +++--
1 file changed, 62 insertions(+), 51 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors
When GL_DEBUG_OUTPUT_SYNCHRONOUS is GL_TRUE, drivers are allowed to log debug
messages from other threads. That requires gl_debug_state to be protected by
a mutex, even when it is a context state. While we do not spawn threads in
Mesa yet, this commit makes it easier to do when we want to.
Since
Move group copying to debug_push_group. Save the group message before pushing
instead of after, since we will need it after popping. No functional change
otherwise.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 102 +
1 file changed, 60 i
Add struct gl_debug_group to hold all namespaces of a debug group. Replace
the 3-dimensional array, Namespaces, in struct gl_debug_state by a
1-dimensional array of type struct gl_debug_groups.
Turn the 4-dimensional array, Defaults, in struct gl_debug_state to a
1-dimensional array in struct gl_
Merge control_app_messages with the only caller. Eliminate set_message_state
and control_messages too as they are unused. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 83 +++---
1 file changed, 17 insertions(+), 66 dele
Move the message filtering logic to debug_is_message_enabled. No functional
change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 111 +++--
1 file changed, 61 insertions(+), 50 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main
Move message state update to debug_set_message_enable. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 70 --
1 file changed, 39 insertions(+), 31 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors
Add functions to provide these operations on a struct gl_debug_namespace:
init():initialize the namespace
copy():copy all elements from one namespace to another
clear(): clear all elements (to free the memories)
set(): set the value of an element
set_all(): set the value of
Remove NextMsgLength, and move members of struct gl_debug_state that belong to
the message log to a new struct, gl_debug_log. Rename gl_debug_msg to
gl_debug_message.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 78 +++---
1 file changed, 42
Hi,
This series cleans up GL_KHR_debug support, fixes message control for some
corner cases, and makes one enhancement: cheap
glPushDebugGroup/glPopDebugGroup for command stream annotation.
Patch 1-12 refactor the code. There should be no functional difference.
These patches are also part of the
Add validate_length, and call it together with log_msg directly instead of
message_insert. No functional change.
v2: make sure length is non-negative (i.e., known) before calling
validate_length, noted by Timothy Arceri
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 45 +
Move gl_debug_state allocation to a new function, debug_create. No functional
change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 62 ++
1 file changed, 37 insertions(+), 25 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/ma
Replace free_errors_data by debug_clear_group. Add debug_pop_group and
debug_destroy for use in _mesa_PopDebugGroup and _mesa_free_errors_data
respectively. No funcitonal change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 125 +
1 file
Move message logging to debug_log_message. Replace store_message_details by
debug_message_store. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 134 +++--
1 file changed, 75 insertions(+), 59 deletions(-)
diff --git a/sr
Merge get_msg with the only caller. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 99 +-
1 file changed, 26 insertions(+), 73 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
index f363049..2
Move message fetching to debug_fetch_message and message deletion to
debug_delete_messages. No functional change.
Signed-off-by: Chia-I Wu
---
src/mesa/main/errors.c | 58 --
1 file changed, 47 insertions(+), 11 deletions(-)
diff --git a/src/mesa
https://bugs.freedesktop.org/show_bug.cgi?id=77917
Frederic Romagne changed:
What|Removed |Added
CC||frederic.roma...@gmail.com
--
You ar
Jan Vesely writes:
> Signed-off-by: Jan Vesely
> ---
>
> Hi,
>
> this is the alternative (power of 2) approach to hadling kernel args,
> as discussed in this thread:
> http://lists.freedesktop.org/archives/mesa-dev/2014-April/thread.html#58209
>
> Jan
>
> src/gallium/state_trackers/clover/llvm/
https://bugs.freedesktop.org/show_bug.cgi?id=77917
Priority: medium
Bug ID: 77917
Assignee: mesa-dev@lists.freedesktop.org
Summary: VG/openvg.h defines non existent functions
Severity: normal
Classification: Unclassified
OS:
1 - 100 of 101 matches
Mail list logo
