On Fri, Apr 25, 2014 at 3:24 PM, Matt Turner <matts...@gmail.com> wrote: > bitfieldInsert takes scalar integers for its last two arguments. Since > bitfieldInsert is lowered on i965 to two instructions that have more > flexible arguments, I didn't notice when I wrote this.
Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Thanks! > --- > src/glsl/lower_instructions.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp > index 01ea0f0..49316d0 100644 > --- a/src/glsl/lower_instructions.cpp > +++ b/src/glsl/lower_instructions.cpp > @@ -359,8 +359,8 @@ lower_instructions_visitor::ldexp_to_arith(ir_expression > *ir) > > ir_constant *sign_mask = new(ir) ir_constant(0x80000000u, vec_elem); > > - ir_constant *exp_shift = new(ir) ir_constant(23u, vec_elem); > - ir_constant *exp_width = new(ir) ir_constant(8u, vec_elem); > + ir_constant *exp_shift = new(ir) ir_constant(23); > + ir_constant *exp_width = new(ir) ir_constant(8); > > /* Temporary variables */ > ir_variable *x = new(ir) ir_variable(ir->type, "x", ir_var_temporary); > -- > 1.8.3.2 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
