Re: [Mesa-dev] [PATCH] glsl: removed unused dimension_count varible

Reviewed-by: Matt Turner I'll commit this soon. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is not advertised for OpenGL ES contexts due to the terrible performance. It is still enabled for desktop GL because it was believed GL 3.0+ requires Z16. It turns out only GL 3.0 requires Z16, and that is corrected in later GL versions.

[Mesa-dev] [PATCH] glsl: removed unused dimension_count varible

This variable is no longer needed after the cleanup to the code prior to the first arrays of array series Signed-off-by: Timothy Arceri --- src/glsl/ast.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index 0bda28d..1191900 100644 ---

[Mesa-dev] [PATCH] nv50: enable cube map array texture support

Signed-off-by: Ilia Mirkin --- All the arb_texture_cube_map_array piglits pass except the sampler-cube-shadow one. However, nva0+ appear to all fail at the non-array version of that test, sampler-cube-shadow, so I think it's very likely to be related. Probably some sampler setup bits changed. s

Re: [Mesa-dev] [PATCH 3/3] gallivm: optimize repeat linear npot code in the aos int path

I tested these patches out and they seem to work well enough for my test cases. -Jeff On Feb 14, 2014, at 8:06 PM, Roland Scheidegger wrote: > FWIW I've just cleaned 1/3 and 3/3 up a little and splitted it off into > two patches (I really want to be able to track any changes this might > cause

[Mesa-dev] [Bug 75061] bug in clearing color buffer

https://bugs.freedesktop.org/show_bug.cgi?id=75061 --- Comment #5 from Michel Dänzer --- Created attachment 94321 --> https://bugs.freedesktop.org/attachment.cgi?id=94321&action=edit Bail if rr->buf is NULL Does this patch help? (In reply to comment #3) > valgrind + hellgrind Thanks, but the

Re: [Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

On 02/09/2014 01:50 AM, Juha-Pekka Heikkilä wrote: > The place which cause Klocwork to highlight this is at > src/mesa/main/ff_fragment_shader.cpp around line 897 where it says: > > ... > float const_data[4] = { > float(1 << rgb_shift), > float(1 << rgb_shift), > float

Re: [Mesa-dev] [PATCH 19/38] glx/drisw: use the implemented version of __DRIswrastLoaderExtension

On 02/12/2014 05:17 PM, Emil Velikov wrote: > ... over the one provided by the headers. > Explicitly set extension members to improve clarity. > > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 3 +++ > src/glx/drisw_glx.c | 11 ++- > 2 files c

Re: [Mesa-dev] [PATCH 25/43] dri/radeon: explicitly set __DRIimageExtension members

On 02/18/2014 05:20 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/radeon/radeon_screen.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c > b/src/mesa/drivers/dri/radeon/radeon

Re: [Mesa-dev] [PATCH 18/38] glx/dri: use the implemented version of __DRIdamageExtension

On 02/18/2014 06:05 PM, Ian Romanick wrote: > Patches 7 through 19 are ^^ 18 > Reviewed-by: Ian Romanick > > with the same caveats on patches 9 and 11 as for patch 5. > > On 02/12/2014 05:17 PM, Emil Velikov wrote: >> ... over the one provided by the headers. >> Explicitly s

Re: [Mesa-dev] [PATCH 18/38] glx/dri: use the implemented version of __DRIdamageExtension

Patches 7 through 19 are Reviewed-by: Ian Romanick with the same caveats on patches 9 and 11 as for patch 5. On 02/12/2014 05:17 PM, Emil Velikov wrote: > ... over the one provided by the headers. > Explicitly set extension members to improve clarity. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 05/38] st/dri: set the implemented version of __DRItexBufferExtension

On 02/18/2014 06:01 PM, Ian Romanick wrote: > On 02/12/2014 05:17 PM, Emil Velikov wrote: >> ... over the version number provided by the headers. >> >> Explicitly set extension members to improve clarity. >> >> Signed-off-by: Emil Velikov > > Reviewed-by: Ian Romanick > > But you might also wai

Re: [Mesa-dev] [PATCH 05/38] st/dri: set the implemented version of __DRItexBufferExtension

On 02/12/2014 05:17 PM, Emil Velikov wrote: > ... over the version number provided by the headers. > > Explicitly set extension members to improve clarity. > > Signed-off-by: Emil Velikov Reviewed-by: Ian Romanick But you might also wait for an R-b from someone that works on that code. > ---

Re: [Mesa-dev] [PATCH 06/38] dri_interface: note introduction of __DRIdri2LoaderExtension members

On 02/12/2014 05:17 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index 7d22654..5b333a1 100644 > ---

Re: [Mesa-dev] [PATCH 01/38] dri_util: explicitly set __DRIswrastExtension members.

Patches 1 and 2 are Reviewed-by: Ian Romanick On 02/12/2014 05:17 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/common/dri_util.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/common/dri_util.c

Re: [Mesa-dev] [PATCH 03/38] dri_interface: note introduction of various __DRItexBufferExtension members

On 02/12/2014 05:17 PM, Emil Velikov wrote: > Note the member function releaseTexBuffer was added without > bumping spec version, and currently no drivers implement it. > > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [Mesa-dev] [PATCH 04/38] drivers/dri: set the implemented version of __DRItexBufferExtension

On 02/12/2014 06:56 PM, Emil Velikov wrote: > On 13/02/14 02:47, Emil Velikov wrote: >> On 13/02/14 02:34, Ilia Mirkin wrote: >>> On Wed, Feb 12, 2014 at 8:17 PM, Emil Velikov >>> wrote: ... over the version number provided by the headers. Explicitly set extension members to improve cla

[Mesa-dev] [PATCH] dri: Properly unbind surfaceless contexts

In driUnbindContext(), call the driver UnbindContext function even if both the draw and read drawables are NULL, since we may be dealing with a surfaceless context. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74563 --- src/mesa/drivers/dri/common/dri_util.c | 10 +++--- 1 file chan

Re: [Mesa-dev] [PATCH 04/38] drivers/dri: set the implemented version of __DRItexBufferExtension

>-Original Message- >From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >Sent: Tuesday, February 18, 2014 7:29 AM >To: Ilia Mirkin; Zhao, Juan J >Cc: emil.l.veli...@gmail.com; mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 04/38] drivers/dri: set the implemented >version

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] glcpp: Only warn for macro names containing __

On Tue, Feb 18, 2014 at 10:19 AM, Ian Romanick wrote: > > From: Ian Romanick > > Section 3.3 (Preprocessor) of the GLSL 1.30 spec (and later) and the > GLSL ES spec (all versions) say: > > "All macro names containing two consecutive underscores ( __ ) are > reserved for future use as pred

Re: [Mesa-dev] [PATCH 1/3] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

On 02/18/2014 03:36 PM, Anuj Phogat wrote: > On Tue, Feb 18, 2014 at 11:01 AM, Ian Romanick wrote: >> On 02/10/2014 05:29 PM, Anuj Phogat wrote: >>> GLSL 1.50 spec says: >>>"If gl_FragCoord is redeclared in any fragment shader in a program, >>> it must be redeclared in all the fragment sha

[Mesa-dev] [PATCH 39/43] glx/indirect: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Set indirect_screen_vtable as a static const. Signed-off-by: Emil Velikov --- src/glx/indirect_glx.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0

[Mesa-dev] [PATCH 16/43] glx/dri3: set the implemented version of __DRIimageLoaderExtension

... over the one provided by the spec. Currently both versions are identical, but that is not guaranteed to be the case in the future. Signed-off-by: Emil Velikov --- src/glx/dri3_glx.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_g

[Mesa-dev] [PATCH 37/43] dri/radeon: use a const __DRIextension array

Rather than keeping a separate and used copy of the screen extensions within the raderon screen, move to use a constant array that can be fed directly to the __DRIscreen. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/radeon/radeon_screen.c | 29 ++--- src/mesa/driv

[Mesa-dev] [PATCH 42/43] glx/dri3: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Signed-off-by: Emil Velikov --- src/glx/dri3_glx.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index 8fbf125..c014c40 100644 --- a/src/glx/dri3_glx.c +++ b/src/glx/dri3_

[Mesa-dev] [PATCH 18/43] glx/dri: use the implemented version of __DRIgetDrawableInfoExtension

... over the one provided by the headers. Signed-off-by: Emil Velikov --- src/glx/dri_glx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 03ecc5b..8593750 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c @@ -299,8 +299,

[Mesa-dev] [PATCH 11/43] st/dri: set the implemented version of __DRI2flushExtension

over the version number provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/drm/dri2.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c

[Mesa-dev] [PATCH 22/43] egl_dri gbm: explicitly set __DRIuseInvalidateExtension members

Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/gbm/backends/dri/gbm_dri.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 2c2a893..6711bd3 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 34/43] dri_util: constify remaining __DRI*Extensions

Already treated as such, but stored as non-const. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/dri_util.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.h b/src/mesa/drivers/dri/common/dri_util.h index a37a0bb..113

[Mesa-dev] [PATCH 31/43] drivers/dri: use typecast'ed name and constify __DRIimageExtension

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_screen.c| 2 +- src/mesa/drivers/dri/i965/intel_screen.c| 2 +- src/mesa/drivers/dri/radeon/radeon_screen.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/sr

[Mesa-dev] [PATCH 29/43] glx/tests: explicitly set __DRI2rendererQueryExtension members

While we're here use the typcast'ed name and constify. Signed-off-by: Emil Velikov --- src/glx/tests/query_renderer_implementation_unittest.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glx/tests/query_renderer_implementation_unittest.cpp b/src/glx/tests/qu

[Mesa-dev] [PATCH 40/43] glx/dri: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Signed-off-by: Emil Velikov --- src/glx/dri_glx.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 3b7502d..04a0847 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx

[Mesa-dev] [PATCH 43/43] glx/drisw: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Signed-off-by: Emil Velikov --- src/glx/drisw_glx.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 173ba22..0ca6d14 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/d

[Mesa-dev] [PATCH 33/43] dri/nouveau: constify usage of __DRIdri2LoaderExtension

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/nouveau/nouveau_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_driver.c b/src/mesa/drivers/dri/nouveau/nouveau_driver.c index 809b5ff..1a8afa2 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 36/43] egl_dri2: constify remaining __DRI*Extensions

Already treated as such, but stored as non-const. The loader extensions - __DRIdri2LoaderExtension and __DRIdri2LoaderExtension are set up by the platform backends. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- src/egl/drivers/dri2/egl_dri2.h | 16

[Mesa-dev] [PATCH 27/43] dri_util: use the implemented version of __DRI2configQueryExtension

... over the one provided by the headers. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/dri_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index aed73c7..c4ff9c7 100644 ---

[Mesa-dev] [PATCH 03/43] dri_interface: Note the version introducing __DRIswrastLoaderExtensionRec::putImage2

Signed-off-by: Emil Velikov --- include/GL/internal/dri_interface.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 9e82904..e0ed7f9 100644 --- a/include/GL/internal/dri_interface.h +++ b/include/GL/internal/d

[Mesa-dev] [PATCH 19/43] glx/dri_common: use the implemented version of __DRIsystemTimeExtension

... over the one provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/glx/dri_common.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c index 012c8f4..8bf4705 100644

[Mesa-dev] [PATCH 41/43] glx/dri2: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Signed-off-by: Emil Velikov --- src/glx/dri2_glx.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 16b9b0a..6d3749b 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri

[Mesa-dev] [PATCH 38/43] glx/apple: explicitly assign struct components for glx_*_vtable

... to improve readability of code. Set applegl_screen_vtable as a static const. Signed-off-by: Emil Velikov --- src/glx/applegl_glx.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/glx/applegl_glx.c b/src/glx/applegl_glx.c index a67416e..4e2d

[Mesa-dev] [PATCH 23/43] glx/dri2: use the implemented version of __DRIuseInvalidateExtension

... over the one provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/glx/dri2_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 58b7bf1..16b9b0a 100644 --- a/src/gl

[Mesa-dev] [PATCH 26/43] egl_dri gbm: explicitly set __DRIimageLookupExtension members

Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 5 +++-- src/gbm/backends/dri/gbm_dri.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 6711bd3..1040a27 100644 --- a/src/egl/driver

[Mesa-dev] [PATCH 15/43] gbm: explicitly set __DRIimageLoaderExtension members

Signed-off-by: Emil Velikov --- src/gbm/backends/dri/gbm_dri.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 5a0dad0..5b9998f 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/g

[Mesa-dev] [PATCH 12/43] drivers/dri: explicitly set __DRI2flushExtension members

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/nouveau/nouveau_screen.c | 7 --- src/mesa/drivers/dri/radeon/radeon_screen.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_screen.c b/src/mesa/drivers/dri/nouveau/nouvea

[Mesa-dev] [PATCH 28/43] dri/i965: explicitly set __DRIrobustnessExtension members

Use typecast'ed type while we're here. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/intel_screen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b013f5d..3b3fe9f 1006

[Mesa-dev] [PATCH 35/43] gbm/dri: constify remaining __DRI*Extensions

Already treated as such, but stored as non-const. Signed-off-by: Emil Velikov --- src/gbm/backends/dri/gbm_driint.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gbm/backends/dri/gbm_driint.h b/src/gbm/backends/dri/gbm_driint.h index fdf694d..36a6d34 100644

[Mesa-dev] [PATCH 24/43] st/dri: explicitly set __DRIimageExtension members

While we're here use the typcast'ed name and constify. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/drm/dri2.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c b/src/gallium/state_trackers

[Mesa-dev] [PATCH 21/43] glx/drisw: use the implemented version of __DRIswrastLoaderExtension

... over the one provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/glx/drisw_glx.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 9e49838..173ba22 1006

[Mesa-dev] [PATCH 30/43] st/dri/drm: constify __DRI*Extension pointers

Note: the __DRIimageExtension should not be made const as it's modified at runtime. v2: s/DRM_PRIME/DRI_PRIME/ Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/drm/dri2.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/dri/dr

[Mesa-dev] [PATCH 32/43] dri/i9*5: use typecast'ed name and constify __DRI2rendererQueryExtension

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_screen.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915/intel_screen.c index 74e90c2..a564

[Mesa-dev] [PATCH 10/43] gbm: explicitly set __DRIdri2LoaderExtension members

Signed-off-by: Emil Velikov --- src/gbm/backends/dri/gbm_dri.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index e013980..5a0dad0 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri

[Mesa-dev] [PATCH 06/43] drivers/dri: set the implemented version of __DRItexBufferExtension

... over the version number provided by the headers. Explicitly set extension members to improve clarity. v2: all drivers 'implement' version 3 of the extension. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_screen.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH 05/43] dri_interface: Update __DRItexBufferExtensionRec to version 3

Commit e59fa4c46c8("dri2: release texture image.") updated the extension without bumping the version number. This commit handles this, adding a stub for _eglReleaseTexImage() to prevent compilation issues. Note that with this patch glXReleaseTexImageEXT and eglReleaseTexImage will use slighly high

[Mesa-dev] [PATCH 02/43] dri_util: explicitly set __DRIcopySubBufferExtension members

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/dri_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index 0aa997e..0873927 100644 --- a/src/mesa/drivers/dri/common/dri_util

[Mesa-dev] [PATCH 25/43] dri/radeon: explicitly set __DRIimageExtension members

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/radeon/radeon_screen.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c b/src/mesa/drivers/dri/radeon/radeon_screen.c index d6ec090..6de3d4f 100644 --- a/src/mesa/dri

[Mesa-dev] [PATCH 20/43] glx/dri: use the implemented version of __DRIdamageExtension

... over the one provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/glx/dri_glx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 8593750..3b7502d 100644 --- a/src/

[Mesa-dev] [PATCH 14/43] egl/wayland: explicitly set __DRIimageLoaderExtension members

Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 50750a9..a9c067f 100644 --- a/src/egl/drivers/dri2/platform_w

[Mesa-dev] [PATCH 13/43] st/dri: set the implemented version of __DRI2throttleExtension

... over the version number provided by the headers. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/common/dri_drawable.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/common/dri_drawable.c b/src/gallium/state_trackers/dr

[Mesa-dev] [PATCH 08/43] dri_interface: note introduction of __DRIdri2LoaderExtension members

Signed-off-by: Emil Velikov --- include/GL/internal/dri_interface.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 8821e73..ae01546 100644 --- a/include/GL/internal/dri_interface.h +++ b/include/GL/interna

[Mesa-dev] [PATCH 04/43] dri_interface: note introduction of various __DRItexBufferExtension members

Note the member function releaseTexBuffer was added without bumping spec version, and currently no drivers implement it. v2: releaseTexBuffer was introduced by version 3 Signed-off-by: Emil Velikov --- include/GL/internal/dri_interface.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[Mesa-dev] [PATCH 01/43] dri_util: explicitly set __DRIswrastExtension members.

Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/dri_util.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index d09d50a..0aa997e 100644 --- a/src/mesa/drivers/dri/common

[Mesa-dev] [PATCH 09/43] glx/dri2: set the implemented version of __DRIdri2LoaderExtension

... over the version number provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/glx/dri2_glx.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 1cb00

[Mesa-dev] [PATCH 17/43] dri_util: use the implemented version of __DRIimageDriverExtension

... over the one provided by the headers. Currently both versions are identical, but that is not guaranteed to be the case in the future. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/dri_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/d

[Mesa-dev] [PATCH 00/43] Constify __DRI*Extension usage and misc cleanup v2

A few changes since v1 - New patches 03/43- Added yet another version note within dri_interface.h 05/43 - dumps the __DRItexBufferExtension's version to 3 and adds a stub to prevent compilation problems. 38-43 - glx/*: explicit assignment of struct members - Changes 06/43 - All drivers provide

[Mesa-dev] [PATCH 07/43] st/dri: set the implemented version of __DRItexBufferExtension

... over the version number provided by the headers. Explicitly set extension members to improve clarity. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/common/dri_drawable.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/

Re: [Mesa-dev] [PATCH] specs: MESA_query_renderer.spec resolve a couple of typos

On 02/18/2014 04:43 PM, Emil Velikov wrote: > Cc: Ian Romanick Reviewed-by: Ian Romanick > Cc: 10.0 10.1 I don't think I'd bother with this on the stable branches. The files from docs/ aren't installed, and the OpenGL extension registry will be the official home... once it gets posted. :( >

[Mesa-dev] [Bug 75098] OpenGL ES2 with fbdev - link error

https://bugs.freedesktop.org/show_bug.cgi?id=75098 Emil Velikov changed: What|Removed |Added Attachment #94216|0 |1 is obsolete|

[Mesa-dev] [PATCH] configure: use shared-glapi when more than one gl* API is used

Current behaviour states that shared-glapi is usefull when building with dri, which is not the case. Shared-glapi is used to dispatch the gl* functions across the one or more gl api's which can be dri based but do not need to be. Fixed the following build ./configure --enable-gles2 --disable-dri

[Mesa-dev] [PATCH] specs: MESA_query_renderer.spec resolve a couple of typos

Cc: Ian Romanick Cc: 10.0 10.1 Signed-off-by: Emil Velikov --- docs/specs/MESA_query_renderer.spec | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/specs/MESA_query_renderer.spec b/docs/specs/MESA_query_renderer.spec index bf09756..2845545 100644 --- a/docs/

Re: [Mesa-dev] [PATCH 2/3] glsl: Only warn for macro names containing __

On 02/18/2014 10:19 AM, Ian Romanick wrote: > From: Ian Romanick > > From page 14 (page 20 of the PDF) of the GLSL 1.10 spec: > > "In addition, all identifiers containing two consecutive underscores > (__) are reserved as possible future keywords." > > The intention is that names conta

Re: [Mesa-dev] [PATCH 1/3] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

On Tue, Feb 18, 2014 at 11:01 AM, Ian Romanick wrote: > On 02/10/2014 05:29 PM, Anuj Phogat wrote: >> GLSL 1.50 spec says: >>"If gl_FragCoord is redeclared in any fragment shader in a program, >> it must be redeclared in all the fragment shaders in that >> program that have a static us

Re: [Mesa-dev] [PATCH] glx: Fix the default values for GLXFBConfig attributes

On 02/17/2014 02:10 PM, Fredrik Höglund wrote: > The default values for GLX_DRAWABLE_TYPE and GLX_RENDER_TYPE are > GLX_WINDOW_BIT and GLX_RGBA_BIT respectively, as specified in > the GLX 1.4 specification. > > This fixes the glx-choosefbconfig-defaults piglit test. I've forward this patch to the

Re: [Mesa-dev] [PATCH] clover: Don't call pipe_loader_release() when deleting a device

On Tue, 2014-02-18 at 17:50 +0100, Francisco Jerez wrote: > Tom Stellard writes: > > > From: Tom Stellard > > > > After pipe_loader_release() is called, if any of the pipe_* objects > > try to call into the gallium API the application will segfault. > > > > The only time devices are deleted is w

Re: [Mesa-dev] [PATCH 1/3] i965: Bump MAX_3D_TEXTURE_SIZE to 2048.

I just realized that I never actually sent my R-b after we discussed this series. Reviewed-by: Ian Romanick On 02/02/2014 03:16 AM, Kenneth Graunke wrote: > It's highly unlikely that there will be enough memory in the system to > allocate enough space for this, but we should still expose the har

Re: [Mesa-dev] [PATCH] glx: Fix the default values for GLXFBConfig attributes

On Tue, Feb 18, 2014 at 8:10 AM, Fredrik Höglund wrote: > The default values for GLX_DRAWABLE_TYPE and GLX_RENDER_TYPE are > GLX_WINDOW_BIT and GLX_RGBA_BIT respectively, as specified in > the GLX 1.4 specification. > > This fixes the glx-choosefbconfig-defaults piglit test. Looks good to me, I c

Re: [Mesa-dev] [PATCH] clover: Pass buffer offsets to the driver in set_global_binding()

Tom Stellard writes: > On Sat, Feb 15, 2014 at 12:22:45PM +0100, Francisco Jerez wrote: >> Tom Stellard writes: >> >> > From: Tom Stellard >> > >> > The offsets will be stored in the handles parameter. This makes >> > it possible to use sub-buffers. >> > --- >> > src/gallium/drivers/r600/eve

Re: [Mesa-dev] [PATCH 6/8] i965: Implement HiZ resolves on Broadwell.

Kenneth Graunke writes: > Broadwell's 3DSTATE_WM_HZ_OP packet makes this much easier. > > Instead of programming the whole pipeline, we simply have to emit the > depth/stencil packets, a state override, and a pipe control. Then > arrange for the state to be put back. This is easily done from a

Re: [Mesa-dev] [PATCH] i965: Avoid dependency hints on math opcodes

m...@lunarg.com writes: > From: Mike Stroyan > > Putting NoDDClr and NoDDChk dependency control on instruction > sequences that include math opcodes can cause corruption of channels. > Treat math opcodes like send opcodes and suppress dependency hinting. > > Signed-off-by: Mike Stroyan > Teste

Re: [Mesa-dev] [PATCH] clover: Pass buffer offsets to the driver in set_global_binding()

On Sat, Feb 15, 2014 at 12:22:45PM +0100, Francisco Jerez wrote: > Tom Stellard writes: > > > From: Tom Stellard > > > > The offsets will be stored in the handles parameter. This makes > > it possible to use sub-buffers. > > --- > > src/gallium/drivers/r600/evergreen_compute.c | 2 +- > >

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Add an optimization pass to remove rendant flags movs.

On Fri, Feb 14, 2014 at 4:48 PM, Eric Anholt wrote: > We generate steaming piles of these for the centroid workaround, and this > quickly cleans them up. > > total instructions in shared programs: 1591228 -> 1590047 (-0.07%) > instructions in affected programs: 26111 -> 24930 (-4.52%) Nice. I

Re: [Mesa-dev] [PATCH 3/3] i965: Bump MaxTexMbytes from 1GB to 1.5GB.

Series Reviewed-by: Jordan Justen On Sun, Feb 2, 2014 at 3:16 AM, Kenneth Graunke wrote: > Even with the other limits raised, TestProxyTexImage would still reject > textures > 1GB in size. This is an artificial limit; nothing prevents > us from having a larger texture. I stayed shy of 2GB to a

Re: [Mesa-dev] [PATCH 1/3] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

On 02/10/2014 05:29 PM, Anuj Phogat wrote: > GLSL 1.50 spec says: >"If gl_FragCoord is redeclared in any fragment shader in a program, > it must be redeclared in all the fragment shaders in that > program that have a static use gl_FragCoord. All redeclarations of > gl_FragCoord in a

Re: [Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

On 02/17/2014 04:21 PM, Courtney Goeltzenleuchter wrote: > I've updated the patch to set the flipped flag as well. > > I verified that all the flags were being set. As for the data in the > rest of the structure that is filled in from the compressed data using > whatever technique was coded in the

Re: [Mesa-dev] [PATCH] glsl: Fix condition to generate shader link error

On 12/19/2013 03:12 PM, Anuj Phogat wrote: > GL_ARB_ES2_compatibility don't say anything about shader linking > when one of the shaders (vertex or fragment shader) is absent. > So, the extention shouldn't change the behavior specified in > GLSL specification. If you add the above text to the comme

[Mesa-dev] [PATCH 2/3] glsl: Only warn for macro names containing __

From: Ian Romanick From page 14 (page 20 of the PDF) of the GLSL 1.10 spec: "In addition, all identifiers containing two consecutive underscores (__) are reserved as possible future keywords." The intention is that names containing __ are reserved for internal use by the implementation

[Mesa-dev] [PATCH 3/3] glsl: Silence "type qualifiers ignored on function return type" warning

From: Ian Romanick The const in const unsigned foo(void); is meaningless. Removing it silences this warning: src/glsl/ast_to_hir.cpp:1802:56: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 2 +-

[Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

From: Ian Romanick Section 3.3 (Preprocessor) of the GLSL 1.30 spec (and later) and the GLSL ES spec (all versions) say: "All macro names containing two consecutive underscores ( __ ) are reserved for future use as predefined macro names. All macro names prefixed with "GL_" ("GL" fol

[Mesa-dev] [Bug 75165] New: compute.c:464:49: error: function definition is not allowed here

https://bugs.freedesktop.org/show_bug.cgi?id=75165 Priority: medium Bug ID: 75165 Assignee: mesa-dev@lists.freedesktop.org Summary: compute.c:464:49: error: function definition is not allowed here Severity: blocker Classi

Re: [Mesa-dev] [PATCH 6/8] i965: Drop some duplicated code in DRI winsys BO updates.

Kenneth Graunke writes: > On 02/14/2014 03:00 PM, Eric Anholt wrote: > [snip] >> @@ -666,78 +667,6 @@ intel_miptree_create_for_bo(struct brw_context *brw, >> return mt; >> } >> >> - >> -/** >> - * For a singlesample DRI2 buffer, this simply wraps the given region with >> a miptree. >> - *

Re: [Mesa-dev] [PATCH 5/8] i965: Simplify intel_miptree_updownsample.

Kenneth Graunke writes: > On 02/14/2014 03:00 PM, Eric Anholt wrote: >> Pretty silly to pass in values dereferenced out of one of the arguments. >> --- >> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 35 >> +-- >> 1 file changed, 11 insertions(+), 24 deletions(-) >>

Re: [Mesa-dev] [PATCH] mesa: Fix error code generation in glReadPixels()

On Fri, Feb 14, 2014 at 7:00 PM, Ian Romanick wrote: > On 02/14/2014 04:49 PM, Anuj Phogat wrote: >> Section 4.3.1, page 220, of OpenGL 3.3 specification explains >> the error conditions for glreadPixels(): >> >>"If the format is DEPTH_STENCIL, then values are taken from >> both the depth

Re: [Mesa-dev] [PATCH] clover: Don't call pipe_loader_release() when deleting a device

Tom Stellard writes: > From: Tom Stellard > > After pipe_loader_release() is called, if any of the pipe_* objects > try to call into the gallium API the application will segfault. > > The only time devices are deleted is when the global _clover_platform > object is deleted by the static destruct

[Mesa-dev] [PATCH 2/4] i965: Change intel_region interface to not depend on intelScreen

From: Ander Conselvan de Oliveira The only field from intelScreen used by the intel_region code is the drm_intel_bufmgr, so take that as a parameter instead of the whole screen. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- sr

[Mesa-dev] [PATCH 1/4] i965: Support allocation of subregions of an intel_region

From: Ander Conselvan de Oliveira Both __DRIimage and intel_region have width and height fields. They actually differ when an image is created for a texture but are the same in all the other cases. For images created from a planar image, a special intel_region that represents only a part of the s

[Mesa-dev] [PATCH v2 0/4] i965: refactor DRI image code

From: Ander Conselvan de Oliveira Hi, This is an attempt to refactor the DRI image implementation in the i965. While the main motivation for this was to make it possible to compile that code independently, this also simplifies the format handling (there is one less format field in __DRIimageRec)

[Mesa-dev] [PATCH 3/4] i965: Make names of DRI image extension functions more consistent

From: Ander Conselvan de Oliveira Prefix everything with intel_dri_image. --- src/mesa/drivers/dri/i965/intel_screen.c | 116 --- 1 file changed, 59 insertions(+), 57 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/inte

Re: [Mesa-dev] [PATCH] st/xvmc: fix tests so that they pass

On Sun, Feb 16, 2014 at 02:26:33AM -0500, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > Tom, any objections to enabling xvmc by default again? You turned it off in > commit 6a19bb56e ("configure: Disable xvmc by default") complaining about the > tests failing. These all pass for me no

[Mesa-dev] [Bug 59941] glxinfo segfault with GL_ARB_uniform_buffer_object

https://bugs.freedesktop.org/show_bug.cgi?id=59941 Iaroslav changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] drm/radeon: fix CP semaphores on CIK

From: Christian König The CP semaphore queue on CIK has a bug that triggers if uncompleted waits use the same address while a signal is still pending. Work around this by using different addresses for each sync. Signed-off-by: Christian König Cc: sta...@vger.kernel.org --- drivers/gpu/drm/rade

[Mesa-dev] [Bug 75061] bug in clearing color buffer

https://bugs.freedesktop.org/show_bug.cgi?id=75061 --- Comment #3 from Maxim --- Created attachment 94276 --> https://bugs.freedesktop.org/attachment.cgi?id=94276&action=edit valgrind + hellgrind -- You are receiving this mail because: You are the assignee for the bug. ___

  1   2   >