Re: [Mesa-dev] GLSL built-in functions rewrite

Awesome work. I had comments about 9, 14, 16, and 20 and with those addressed 1-17, and 19-21 are Reviewed-by: Matt Turner I'm not sure if there's value in trying to review all of patch 18, given a lack of piglit regressions? What do you think? At the very least, patch 18 gets an Acked-by: Mat

Re: [Mesa-dev] [PATCH 20/21] glsl: Remove builtin_compiler from the build system.

On Wed, Sep 4, 2013 at 3:22 PM, Kenneth Graunke wrote: > diff --git a/configure.ac b/configure.ac > index b19ab18..382f26f 100644 > --- a/configure.ac > +++ b/configure.ac All of the *FOR_BUILD stuff in configure.ac, including m4/*for_build.m4, is now dead and should be removed too. Yay! Commit

Re: [Mesa-dev] [PATCH 16/21] glsl: Add IR builder shortcuts for a bunch of random opcodes.

On Wed, Sep 4, 2013 at 3:22 PM, Kenneth Graunke wrote: > Adding new convenience emitters makes it easier to generate IR involving > these opcodes. > > bitfield_insert is particularly useful, since there is no expr() for > quadops. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/ir_builder.cp

Re: [Mesa-dev] [PATCH 14/21] glsl: Add a new ir_builder::dotlike() function.

On Wed, Sep 4, 2013 at 3:22 PM, Kenneth Graunke wrote: > dotlike() uses ir_binop_mul for scalars, and ir_binop_dot for vectors. > > When generating built-in functions, we often want to use regular > multiply for scalar signatures, and dot() for vector signatures. > ir_binop_dot only works on vecto

Re: [Mesa-dev] [PATCH 09/21] glsl: Add missing type inference support for ARB_gpu_shader5 unops.

On Wed, Sep 4, 2013 at 3:22 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/glsl/ir.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp > index e9317f8..4abadd8 100644 > --- a/src/glsl/ir.cpp > +++ b/src/glsl/ir.cpp > @@ -250

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

>>> +         /* explicit length */ >>> +         *labelPtr = (char *) malloc(length); >>> +         if (*labelPtr) { >>> +            memcpy(*labelPtr, label, length); >>> +         } >>> +      } >>> +      else { >>> +         /* null-terminated string */ >>> +         int len = strlen(label);

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

>> +/** >> + * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel(). >> + */ >> +static void >> +set_label(struct gl_context *ctx, char **labelPtr, const char *label, >> +          int length, const char *caller) >> +{ >> +  if (*labelPtr) { >> +      /* free old label string */ >> +      fr

Re: [Mesa-dev] [PATCH 18/21] glsl: Write a new built-in function module.

On 09/04/2013 04:36 PM, Erik Faye-Lund wrote: On Thu, Sep 5, 2013 at 12:22 AM, Kenneth Graunke wrote: +#define B0(X) ir_function_signature *_##X(); +#define B1(X) ir_function_signature *_##X(const glsl_type *); +#define B2(X) ir_function_signature *_##X(const glsl_type *, const glsl_type *); +

Re: [Mesa-dev] [PATCH 02/15] mesa: Share common code between ARB_debug_output and KHR_debug functions

>Since the calling functions all should alias, all of this should be >removed too. The functions have to do different validations on types they are not exactly the same. If there is some way to signal this to be done using an alias can you please give me some advice on how to do this so I can l

Re: [Mesa-dev] [PATCH 18/21] glsl: Write a new built-in function module.

On Thu, Sep 5, 2013 at 12:22 AM, Kenneth Graunke wrote: > +#define B0(X) ir_function_signature *_##X(); > +#define B1(X) ir_function_signature *_##X(const glsl_type *); > +#define B2(X) ir_function_signature *_##X(const glsl_type *, const glsl_type > *); > +#define B3(X) ir_function_signature *_#

Re: [Mesa-dev] [PATCH 13/15] mesa: Remap debug type and severity

On 09/04/2013 03:43 PM, Timothy Arceri wrote: > Hi Ian, > > Thanks for the review. An let me say I'm here to learn so sorry if my > questions/comments are something that should be obvious. I wish I hadn't been so busy with the 9.2 release over the last couple weeks... and then took a couple much

Re: [Mesa-dev] [PATCH v2] glx: Initialize OpenGL version to 1.0

On 09/04/2013 12:23 PM, Rico Schüller wrote: > Some driver/card combinations (r200/RV280, i915/915G) don't support OpenGL > 2.1. > These create in some corner cases an indirect context instead of a direct > context when calling glXCreateContextAttribsARB(). This happens because of a > bad default

Re: [Mesa-dev] [PATCH 13/15] mesa: Remap debug type and severity

Hi Ian, Thanks for the review. An let me say I'm here to learn so sorry if my questions/comments are something that should be obvious. >> Remap any type or severity exclusive to KHR_debug to >> something suitable for ARB_debug_output >There is no need for any of this remapping.  The only way t

[Mesa-dev] [PATCH 20/21] glsl: Remove builtin_compiler from the build system.

We don't actually use anything from builtin_function.cpp, so we don't need to generate it anymore. Signed-off-by: Kenneth Graunke --- configure.ac| 1 - src/glsl/.gitignore | 2 - src/glsl/Android.mk | 26

[Mesa-dev] [PATCH 19/21] glsl: Switch to the new built-in function module.

All built-ins are now handled by the new code; the old system is dead. Signed-off-by: Kenneth Graunke --- src/glsl/ast_function.cpp | 29 ++--- src/glsl/glsl_parser_extras.cpp | 2 +- src/glsl/main.cpp | 2 +- 3 files changed, 4 insertions(+), 29 del

[Mesa-dev] [PATCH 17/21] glsl: Add optional parameters to the ir_factory constructor.

Each ir_factory needs an instruction list and memory context in order to be useful. Rather than creating an object and manually assigning these, we can just use optional parameters in the constructor. This makes it possible to create a ready-to-use factory in one line: ir_factory body(&sig->b

[Mesa-dev] [PATCH 16/21] glsl: Add IR builder shortcuts for a bunch of random opcodes.

Adding new convenience emitters makes it easier to generate IR involving these opcodes. bitfield_insert is particularly useful, since there is no expr() for quadops. Signed-off-by: Kenneth Graunke --- src/glsl/ir_builder.cpp | 66 + src/glsl/ir_bu

[Mesa-dev] [PATCH 15/21] glsl: Expose IR builder support for arbitrary swizzling.

IR builder already offers a lot of swizzling functions, such as swizzle_, swizzle_z, or swizzle_for_size. The swizzle_ style is convenient if you statically know which components you want. swizzle_for_size is great if you want to select the first few components. However, if you want to s

[Mesa-dev] [PATCH 14/21] glsl: Add a new ir_builder::dotlike() function.

dotlike() uses ir_binop_mul for scalars, and ir_binop_dot for vectors. When generating built-in functions, we often want to use regular multiply for scalar signatures, and dot() for vector signatures. ir_binop_dot only works on vectors, so we have to switch opcodes, even if the code is otherwise i

[Mesa-dev] [PATCH 13/21] glsl: Add IR builder support for generating return statements.

We use "ret" as the function name since "return" is a C++ keyword, and "ir_return" is already a class name. Signed-off-by: Kenneth Graunke --- src/glsl/ir_builder.cpp | 7 +++ src/glsl/ir_builder.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir

[Mesa-dev] [PATCH 12/21] glsl: Add IR builder support for conditional assignments.

This adds two new signatures: assign(lhs, rhs, condition, writemask); assign(lhs, rhs, condition); All the other existing APIs still exist. Signed-off-by: Kenneth Graunke --- src/glsl/ir_builder.cpp | 17 +++-- src/glsl/ir_builder.h | 2 ++ 2 files changed, 17 insertions(+

[Mesa-dev] [PATCH 11/21] glsl: Add IR builder support for triops.

Now that we have the ir_expression constructor that does type inference, this is trivial to do. Signed-off-by: Kenneth Graunke --- src/glsl/ir_builder.cpp | 8 src/glsl/ir_builder.h | 1 + 2 files changed, 9 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp

[Mesa-dev] [PATCH 09/21] glsl: Add missing type inference support for ARB_gpu_shader5 unops.

Signed-off-by: Kenneth Graunke --- src/glsl/ir.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index e9317f8..4abadd8 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -250,6 +250,7 @@ ir_expression::ir_expression(int op, ir_rvalue *op0) case

[Mesa-dev] [PATCH 10/21] glsl: Add an ir_expression triop constructor with type inference.

We already have ir_expression constructors for unary and binary operations, which automatically infer the type based on the opcode and operand types. These are convenient and also required for ir_builder support. Signed-off-by: Kenneth Graunke --- src/glsl/ir.cpp | 31 ++

[Mesa-dev] [PATCH 08/21] glsl: Initialize lod_info in the ir_texture constructor.

This isn't strictly necessary, since creators of ir_texture objects should set LOD when relevant. However, it's nice to have a NULL pointer in case they forget. Signed-off-by: Kenneth Graunke --- src/glsl/ir.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h ind

[Mesa-dev] [PATCH 07/21] glsl: Skip unavailable built-ins when printing out similar candidates.

Signed-off-by: Kenneth Graunke --- src/glsl/ast_function.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 7580bec..e0fdfc3 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_function.cpp @@ -472,6 +472,9 @@ no_matching_f

[Mesa-dev] [PATCH 06/21] glsl: Skip unavailable built-ins when matching signatures.

Signed-off-by: Kenneth Graunke --- src/glsl/ir_function.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index 2dd98bc..53cf469 100644 --- a/src/glsl/ir_function.cpp +++ b/src/glsl/ir_function.cpp @@ -145,6 +145,10 @@ ir_function:

[Mesa-dev] [PATCH 05/21] glsl: Pass _mesa_glsl_parse_state into matching_signature and such.

During compilation, we'll use this to determine built-in availability. All the prototypes will be available, but we can filter out the ones that aren't actually available. At link time, we don't actually need this filtering capability, since we've already imported the prototypes and flagged them a

[Mesa-dev] [PATCH 04/21] glsl: Add a method to tell whether a built-in is available.

We can simply call the stored predicate function. In the case where we don't have a _mesa_glsl_parse_state pointer, it doesn't much matter whether we return true or false. Signed-off-by: Kenneth Graunke --- src/glsl/ir.cpp | 11 +++ src/glsl/ir.h | 3 +++ 2 files changed, 14 insertio

[Mesa-dev] [PATCH 03/21] glsl: Mark _mesa_glsl_parse_state::is_version() as const.

This promises the method won't modify the contents of the object. This allows us to call it even with a const pointer to the state. Signed-off-by: Kenneth Graunke --- src/glsl/glsl_parser_extras.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.h b

Re: [Mesa-dev] [PATCH] glsl: propagate max_array_access through function calls

Updated patch. Previous one would reference NULL pointer if the list of formal parameters was empty. -- Dominik On Wed, Sep 4, 2013 at 2:40 PM, Dominik Behr wrote: > Fixes a bug where if an uniform array is passed to a function the accesses > to the array are not propagated so later all but th

Re: [Mesa-dev] [PATCH] glsl: propagate max_array_access through function calls

Updated patch. Previous one would reference NULL pointer if the list of formal parameters was empty. On Wed, Sep 4, 2013 at 2:40 PM, Dominik Behr wrote: > Fixes a bug where if an uniform array is passed to a function the accesses > to the array are not propagated so later all but the first vect

[Mesa-dev] [PATCH 02/21] glsl: Convert ir_function_signature::is_builtin to a method.

A signature is a built-in if and only if builtin_info != NULL, so we don't actually need a separate flag bit. Making a boolean-valued method allows existing code to ask the same question while not worrying about the internal representation. Signed-off-by: Kenneth Graunke --- src/glsl/ir.cpp

[Mesa-dev] [PATCH 01/21] glsl: Store a predicate for whether a built-in signature is available.

For the upcoming built-in function rewrite, we'll need to be able to answer "Is this built-in function signature available?". This is actually a somewhat complex question, since it depends on the language version, GLSL vs. GLSL ES, enabled extensions, and the current shader stage. Storing such a

[Mesa-dev] GLSL built-in functions rewrite

Hello! This series (at long last!) rewrites the GLSL built-in function handling, for the third time. It's available on the builtins-v3 branch of ~kwg/mesa. The existing built-in function code had a lot of drawbacks: 1. Writing new built-ins in the S-Expression style IR was painful: Somethin

[Mesa-dev] [PATCH] r600g: pad IBs to a multiple of 4 DWs on r6xx

IBs need to be a multiple of 4 dwords on r6xx asics to avoid a hw bug. Signed-off-by: Alex Deucher CC: "9.2" CC: "9.1" --- src/gallium/drivers/r600/r600_hw_context.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/dri

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

>Since you obviously didn't run 'make check', I will be reverting this >entire series later today. > >YOU MUST RUN 'make check'. Ok, well what can I say I didnt know (or I guess didnt check) that Mesa had a Testsuite I will submit a patch to add a section to devinfo.html about submitting patch

[Mesa-dev] [PATCH] glsl: propagate max_array_access through function calls

Fixes a bug where if an uniform array is passed to a function the accesses to the array are not propagated so later all but the first vector of the uniform array are removed in parcel_out_uniform_storage resulting in broken shaders and out of bounds access to arrays in brw::vec4_visitor::pack_unifo

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

On Wed, Sep 4, 2013 at 2:33 PM, Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > > > > On Wed, Sep 4, 2013 at 12:46 PM, Zack Rusin wrote: > >> Hi, Stéphane. >> >> No we should not revert to the old behavior. The old behavior was >> incorrect. Consider this: >> >> -- setup state that dr

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

On Wed, Sep 4, 2013 at 12:46 PM, Zack Rusin wrote: > Hi, Stéphane. > > No we should not revert to the old behavior. The old behavior was > incorrect. Consider this: > > -- setup state that draws a wireframe -> draw should inject frontface > -- the driver needs to be able to find the injected wire

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

On 08/26/2013 03:43 AM, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > --- > src/mesa/main/objectlabel.c | 277 > +++ > src/mesa/main/objectlabel.h | 61 ++ > 2 files changed, 338 insertions(+) > create mode 100644 src/mesa/main/obj

[Mesa-dev] [Bug 65475] Inconsistent use of both stderr and stdout for debug output

https://bugs.freedesktop.org/show_bug.cgi?id=65475 --- Comment #1 from Ian Romanick --- It seems like most of the messages should use one of _mesa_problem, _mesa_error, or _mesa_warning. We may even want an additional _mesa_info. The advantage of using these (instead of printf directly) is they

Re: [Mesa-dev] [PATCH 13/15] mesa: Remap debug type and severity

On 08/26/2013 03:43 AM, Timothy Arceri wrote: > Remap any type or severity exclusive to KHR_debug to > something suitable for ARB_debug_output There is no need for any of this remapping. The only way the new enums can be passed back to the application is if the application specifically requests t

Re: [Mesa-dev] [PATCH 14/15] glapi: Setup autogeneration infrastructure for KHR_debug

For new extensions, we've been adding the entry points to a new, per-extension, .xml file. More comments below. On 08/26/2013 03:43 AM, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > --- > src/mapi/glapi/gen/gl_API.xml| 149 > +- > src/mapi/

Re: [Mesa-dev] [PATCH 02/15] mesa: Share common code between ARB_debug_output and KHR_debug functions

Since the calling functions all should alias, all of this should be removed too. I think this entire patch should be removed. On 08/26/2013 03:43 AM, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > --- > src/mesa/main/errors.c | 308 > +--

Re: [Mesa-dev] [PATCH] mesa: add GL_KHR_debug functions to dispatch_sanity.cpp

In addition to missing make check, I'm pretty sure that all of the functions that also have an ARB version (from GL_ARB_debug) should alias those functions. Arg. On 09/04/2013 12:30 PM, Brian Paul wrote: > Fixes 'make check' failures. > --- > src/mesa/main/tests/dispatch_sanity.cpp | 12 ++

Re: [Mesa-dev] [PATCH 4/4] i965: Enable AMD_seamless_cubemap_per_texture

For the series, Reviewed-by: Chris Forbes On Thu, Sep 5, 2013 at 6:29 AM, Ian Romanick wrote: > From: Ian Romanick > > The change is very small. Do seamless filtering if either the context > enable is set or the sampler enable is set. > > The AMD_seamless_cubemap_per_texture says: > > "If

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

Hi, Stéphane. No we should not revert to the old behavior. The old behavior was incorrect. Consider this: -- setup state that draws a wireframe -> draw should inject frontface -- the driver needs to be able to find the injected wireframe output -- draw -- setup state the draws solid fill wi

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

On 09/04/2013 12:28 PM, Brian Paul wrote: > OK, make check passes or fails depending on how you configure. My tree > configured for LLVM/softpipe says make check passes. But in my > DRI/vmware-svga tree, make check fails. Aren't the software pipe drivers DRI? It seems like they should still hit

Re: [Mesa-dev] [PATCH] Revert "draw: cleanup the extra attribs"

> This reverts commit 57cd3267782fcf92d1e7d772760956516d4367df. > > This fixes piglit regressions with additional draw stages on > llvmpipe, softpipe and i915g. The attributes can't be cleared at > this point because they might be in use by the additional draw > stages. The attributes have to cle

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

OK, make check passes or fails depending on how you configure. My tree configured for LLVM/softpipe says make check passes. But in my DRI/vmware-svga tree, make check fails. I think the fix is pretty simple: add the new GL_KHR_debug functions to dispatch_sanity.cpp. I'll post a patch... -

[Mesa-dev] [PATCH] mesa: add GL_KHR_debug functions to dispatch_sanity.cpp

Fixes 'make check' failures. --- src/mesa/main/tests/dispatch_sanity.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index 8d37747..bea6e96 100644 --- a/src/mesa/main/tests/dispatch_sanity.cp

[Mesa-dev] [PATCH v2] glx: Initialize OpenGL version to 1.0

Some driver/card combinations (r200/RV280, i915/915G) don't support OpenGL 2.1. These create in some corner cases an indirect context instead of a direct context when calling glXCreateContextAttribsARB(). This happens because of a bad default value. To avoid this, choose a more sane default OpenGL

[Mesa-dev] [PATCH] Revert "draw: cleanup the extra attribs"

This reverts commit 57cd3267782fcf92d1e7d772760956516d4367df. This fixes piglit regressions with additional draw stages on llvmpipe, softpipe and i915g. The attributes can't be cleared at this point because they might be in use by the additional draw stages. https://bugs.freedesktop.org/show_bug.

Re: [Mesa-dev] Mesa (git 20130828) fails to build on MIPS

According to tis https://lists.gnu.org/archive/html/bug-tar/2005-02/msg1.html error 141 is 128+13 = SIGPIPE (broke pipe signal) And this may be relevant https://groups.google.com/forum/#!topic/golang-nuts/xjZ8jJx0IFw Check whether you are using right yacc and bison? On Wed, Sep 4, 2013 at 10:

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

On Tue, Sep 3, 2013 at 9:38 PM, Matt Turner wrote: > On Tue, Sep 3, 2013 at 8:20 PM, Stéphane Marchesin > wrote: > > Hi Zack, > > > > This change regresses a bunch of point sprite piglit tests on i915g. > Should > > we revert back to the old behaviour? As far as I can see, it was correct > (it >

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

I just did a 'make check' here and didn't see any failures. However, my output looks different from what Paul posted. I need to do a fresh reconfigure/test... -Brian On 09/04/2013 12:24 PM, Ian Romanick wrote: Since you obviously didn't run 'make check', I will be reverting this entire ser

[Mesa-dev] [Bug 68953] New: DispatchSanity_test.GL31_CORE regression

https://bugs.freedesktop.org/show_bug.cgi?id=68953 Priority: medium Bug ID: 68953 Keywords: regression CC: t_arc...@yahoo.com.au Assignee: mesa-dev@lists.freedesktop.org Summary: DispatchSanity_test.GL31_CORE regression

[Mesa-dev] [PATCH 3/4] mesa: Always use seamless cubemap filtering in GLES3

From: Ian Romanick Appendix F.2 of the OpenGL ES 3.0.0 spec says: "OpenGL ES 3.0 requires that all cube map filtering be seamless. OpenGL ES 2.0 specified that a single cube map face be selected and used for filtering." Setting the field only in the context will work fine with sampl

[Mesa-dev] [PATCH 1/4] docs: initial 9.3 release notes file

From: Ian Romanick Signed-off-by: Ian Romanick --- docs/relnotes.html | 1 + docs/relnotes/9.3.html | 57 ++ 2 files changed, 58 insertions(+) create mode 100644 docs/relnotes/9.3.html diff --git a/docs/relnotes.html b/docs/relnotes.html in

[Mesa-dev] [PATCH 4/4] i965: Enable AMD_seamless_cubemap_per_texture

From: Ian Romanick The change is very small. Do seamless filtering if either the context enable is set or the sampler enable is set. The AMD_seamless_cubemap_per_texture says: "If TEXTURE_CUBE_MAP_SEAMLESS_ARB is emabled (sic) globally or the value of the texture's TEXTURE_CUBE_MAP_SEA

[Mesa-dev] [PATCH 2/4] mesa: Don't allow glSamplerParameteriv(GL_TEXTURE_CUBE_MAP_SEAMLESS) in ES

From: Ian Romanick There is no GL_TEXTURE_CUBE_MAP_SEAMLESS in any version of OpenGL ES or in any extension that applies to OpenGL ES. The same error check already occurs for glTexParameteri. Signed-off-by: Ian Romanick Cc: Maxence Le Dore --- src/mesa/main/samplerobj.c | 3 ++- 1 file chang

Re: [Mesa-dev] [PATCH 00/15] Implement KHR_debug

Since you obviously didn't run 'make check', I will be reverting this entire series later today. YOU MUST RUN 'make check'. On 08/26/2013 03:43 AM, Timothy Arceri wrote: > The following patchset implements the KHR_debug extension. > > Here are some notes/assumptions I have made: > > * These pat

Re: [Mesa-dev] [PATCH 1/4] glsl: Refactor a bunch of the code out of cross_validate_outputs_to_inputs

On 4 September 2013 08:17, Ian Romanick wrote: > On 09/03/2013 09:41 AM, Paul Berry wrote: > > On 30 August 2013 16:07, Ian Romanick > > wrote: > > > > From: Ian Romanick > > > > > > The new function, cross_validate_types

Re: [Mesa-dev] Mesa (git 20130828) fails to build on MIPS

On Tue, Sep 3, 2013 at 10:41 PM, Christophe Jarry wrote: > Hello, > > I encounter an error when I build mesa from git. I am on a MIPS > computer with ATI RS780E. > > Here are the instructions I use for the build: > > ./autogen.sh \ > --prefix=/usr \ > --enable-gles2 \ > --disable-galli

Re: [Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

The explanatory text from the mangled version of the patch should be included here as well. Can you give some more explanation of how this can occur? I'd like to have a piglit test. Looking at the documentation for glXUseXFont, there needs to be a valid context bound, and there is some commentar

[Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

Signed-off-by: Lukasz Maniak --- src/glx/xfont.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glx/xfont.c b/src/glx/xfont.c index 316c585..60e28ab 100644 --- a/src/glx/xfont.c +++ b/src/glx/xfont.c @@ -215,7 +215,6 @@ _X_HIDDEN void DRI_glXUseXFont(struct glx_con

[Mesa-dev] [PATCH] glx: Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver when calling XCreatePixmap or fill_bitmap from DRI_glXUseXFont. currentDrawable which came from __glXGetCurrentContext was not correct in this case, we use DefaultRootWindow(dpy) instead. Signed-off-b

Re: [Mesa-dev] [PATCH 1/4] glsl: Refactor a bunch of the code out of cross_validate_outputs_to_inputs

On 09/03/2013 09:41 AM, Paul Berry wrote: > On 30 August 2013 16:07, Ian Romanick > wrote: > > From: Ian Romanick > > > The new function, cross_validate_types_and_qualifiers, will have > multiple callers from this fil

Re: [Mesa-dev] [PATCH 14/15] glapi: Setup autogeneration infrastructure for KHR_debug

On 26 August 2013 03:43, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > --- > src/mapi/glapi/gen/gl_API.xml| 149 > +- > src/mapi/glapi/gen/gl_genexec.py |1 + > 2 files changed, 149 insertions(+), 1 deletion(-) > > diff --git a/src/mapi/g

Re: [Mesa-dev] [PATCH] glx: Initialize OpenGL version to 1.0

On 3 September 2013 13:19, Rico Schüller wrote: > So yes, we agree here, the version number needs to be fixed. The simplest > one is to "just change the number". I'm fine with it. I have no strong > opinion about it. Though I think it should be consistent across all > initialization occurrences (i

Re: [Mesa-dev] Vendor-neutral OpenGL dispatching library

(mesa-dev: please let us know if libglvnd implementation discussion is inappropriate for this alias) Hi Brian, I was thinking about the GetProcAddress'ed GLX entry point problem the libglvnd implementation highlights: online-generate-and-resolve-at-MakeCurrent, as suggested in linux-opengl-ab