We're now emitting this error from a point where we have easy access
to the name of the block that failed to match, so go ahead and include
that in the error message, as we do for intrastage interface block
mismatches.
---
src/glsl/link_interface_blocks.cpp | 3 ++-
1 file changed, 2 insertions(+)
The linker_error() function sets prog->LinkStatus to false. There's
no reason for the caller of linker_error() to also do so.
---
src/glsl/ir_function_detect_recursion.cpp | 1 -
src/mesa/program/ir_to_mesa.cpp | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/glsl/ir_function_de
This patch changes link_shaders() so that it sets prog->LinkStatus to
true when it starts, and then relies on linker_error() to set it to
false if a link failure occurs.
Previously, link_shaders() would set prog->LinkStatus to true halfway
through its execution; as a result, linker functions that
Previously we failed to link (which is correct), but we did not output
an error message, which could have been confusing for users.
---
src/glsl/link_interface_blocks.cpp | 5 -
src/glsl/linker.cpp| 3 ++-
src/glsl/linker.h | 3 ++-
3 files changed, 8 insertion
A comment in link_intrastage_shaders(), and an if-test that followed
it, seemed to indicate that link_uniform_blocks() would return a
negative value in the event of an error. But this is not the
case--all error checking has already been performed by
validate_intrastage_interface_blocks(), and link
I recently discovered a bug in my geometry shader branch wherein we
were responding to certain kinds of link errors by calling
linker_error(), but the program was still linking successfully. The
root cause turned out to be that during the first half of the
execution of link_shaders(), it was not s
https://bugs.freedesktop.org/show_bug.cgi?id=67411
Priority: medium
Bug ID: 67411
Keywords: have-backtrace, regression
CC: srol...@vmware.com
Assignee: mesa-dev@lists.freedesktop.org
Summary: lp_bld_conv.c:757:lp_build_conv: Asse
On 07/27/2013 01:29 AM, gregory hainaut wrote:
On Fri, 24 May 2013 16:27:59 -0700
Ian Romanick wrote:
I'm finally getting off my lazy behind and reviewing this series. I'll
probably only be able to review one or two patches today, but I should
be able to get through the rest shortly.
So far,
On 07/26/2013 10:55 PM, Ian Romanick wrote:
From: Ian Romanick
The second 'const' says that the pointer itself is constant. This in
unenforcible in C++, so GCC emits a warning (see) below for each of
these functions in every file that includes glsl_types.h. It's a lot of
warning spam.
../../
That formula 2.2 existed for quite some time and was only used for
vertex specification.
And then came along textures using that format, and in good OpenGL
tradition the old formula was kept for vertex data (I guess the new
formula was used for textures because that was what hardware and other
spec
Series looks alright AFAICT.
Jose
- Original Message -
> From: Roland Scheidegger
>
> Just like the UNORM case we need to use round to nearest, not trunc.
> (There's also another problem, we're using the formula for SNORM->float
> which will produce a value below -1.0 for the most negat
Series looks good to me.
You should add a mention of this in src/gallium/docs/source/tgsi.rst too as it
is not an obvious feature.
Jose
- Original Message -
> From: Roland Scheidegger
>
> Same as for gallivm (though these don't quite work correctly in softpipe,
> so untested).
> ---
>
- Original Message -
> Free all our temporary buffers in one place at the end of the
> function. Fixes memory leak detected by Coverity.
>
> Note: This is a candidate for the 9.x branches
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/mesa/main/mipmap.c | 17 +++--
>
D3D10 specifies equation 2.3 (and I'm sure so that D3D9). So probably all
hardware can handle it.
I'm surprised that formula 2.2 even exists, and that OpenGL could have been so
lax about it.
Jose
- Original Message -
> Hello all,
>
> I've been looking at https://bugs.freedesktop.org/s
On Fri, 24 May 2013 16:27:59 -0700
Ian Romanick wrote:
> I'm finally getting off my lazy behind and reviewing this series. I'll
> probably only be able to review one or two patches today, but I should
> be able to get through the rest shortly.
>
> So far, it's just little stuff.
>
Hello. Di
Fixes "Uninitialized scalar field" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
index f
16 matches
Mail list logo
