[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 --- Comment #2 from Vinson Lee --- (In reply to comment #1) > Created attachment 81814 [details] [review] > use a function to convert from GLhandleARB to GLuint > > Vinson, can you try this patch? There may be other files to fix similarly...

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-07-01 Thread Ian Romanick
The series is Reviewed-by: Ian Romanick On 06/13/2013 05:25 AM, Marek Olšák wrote: Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and adds a few improvements to the GLSL linker in the process. Before I show y

[Mesa-dev] [Bug 66476] New: translate_test.c:263:10: error: too few arguments to function ‘translate?=[0]->=?UTF-8?Q?run_elts’

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66476 Priority: medium Bug ID: 66476 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: translate_test.c:263:10: error: too few arguments to

Re: [Mesa-dev] [PATCH] prog_parameter.c ASAN Patch

2013-07-01 Thread Myles C. Maxfield
Looks good to me. Thanks for fixing it up. Do the prospects look good for getting this committed? It would be cool if my name was attached to the patch, but since you really ended up writing it, its fine with me if you're marked as the author. Thanks, Myles On Mon, Jul 1, 2013 at 2:08 PM, Brian

[Mesa-dev] [Bug 66466] Account request for Mesa related development

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66466 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

[Mesa-dev] Mesa 9.1.4

2013-07-01 Thread Ian Romanick
Mesa 9.1.4 has been released. Mesa 9.1.4 is a bug fix release which fixes bugs fixed since the 9.1.3 release. The tag in the GIT repository for Mesa 9.1.4 is 'mesa-9.1.4'. Mesa 9.1.4 is available for download at ftp://freedesktop.org/pub/mesa/9.1.4/ md5sums: a2c4e25d0e27918bc67f61bae04d0cb8

Re: [Mesa-dev] [PATCH] gallivm: Fix indirect immediate registers.

2013-07-01 Thread Zack Rusin
> Am 01.07.2013 21:54, schrieb jfons...@vmware.com: > > From: José Fonseca > > > > If reg->Register.Indirect then the immediate is not truly a constant > > expression. > > > > There is no performance regression -- LLVMBuildBitCast will fallback to > > LLVMConstBitCast internally when the argumen

Re: [Mesa-dev] [PATCH] gallivm: Fix indirect immediate registers.

2013-07-01 Thread Roland Scheidegger
Am 01.07.2013 21:54, schrieb jfons...@vmware.com: > From: José Fonseca > > If reg->Register.Indirect then the immediate is not truly a constant > expression. > > There is no performance regression -- LLVMBuildBitCast will fallback to > LLVMConstBitCast internally when the argument is a constant.

[Mesa-dev] [Bug 66423] [bisected] postprocess/pp_run.c :56:pp_run: Assertion ppq->tmp[1] failed

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66423 Matthew McClure changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@l

Re: [Mesa-dev] [PATCH] prog_parameter.c ASAN Patch

2013-07-01 Thread Brian Paul
I took a closer look at your patch and I think it's incorrect. Note that the 'values' pointer is incremented by 4 in each loop iteration and size is decremented by 4. So accessing values[i*4+j] will eventually go out of bounds. I think something like this would work. diff --git a/src/mesa/p

Re: [Mesa-dev] [PATCH 08/14] glsl: Add copy-constructor for ast_struct_specifier.

2013-07-01 Thread Chad Versace
On 06/29/2013 07:43 PM, Matt Turner wrote: --- src/glsl/ast.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index 13c5e6b..0b70bb7 100644 --- a/src/glsl/ast.h +++ b/src/glsl/ast.h @@ -453,6 +453,13 @@ class ast_declarator_list; class ast_struct_s

[Mesa-dev] [Bug 66466] Account request for Mesa related development

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66466 Matthew McClure changed: What|Removed |Added Assignee|sitewranglers@lists.freedes |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] gallivm: Fix indirect immediate registers.

2013-07-01 Thread jfonseca
From: José Fonseca If reg->Register.Indirect then the immediate is not truly a constant expression. There is no performance regression -- LLVMBuildBitCast will fallback to LLVMConstBitCast internally when the argument is a constant. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 4 ++--

[Mesa-dev] [Bug 66357] pipe_loader_sw fails to build without libx11 headers

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66357 --- Comment #2 from Martin Jansa --- To fix build with xlib enabled: #ifdef HAVE_PIPE_LOADER_XLIB - x11_sw_create, + xlib_create_sw_winsys #endif But HAVE_PIPE_LOADER_XLIB was removed recently: commit 657cfe62521f05dab744824e9d72e0a753fd9

Re: [Mesa-dev] [PATCH] i965: fix alpha test for MRT

2013-07-01 Thread Chris Forbes
Paul, That's much nicer -- I noticed the new flag was pretty much redundant with the alpha-to-coverage flag as soon as I'd sent out the patch. Will fix that up, and cook up a piglit test for this tonight. -- Chris On Tue, Jul 2, 2013 at 5:28 AM, Paul Berry wrote: > On 1 July 2013 04:45, Chris

[Mesa-dev] [Bug 66357] pipe_loader_sw fails to build without libx11 headers

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66357 --- Comment #1 from Martin Jansa --- Created attachment 81827 --> https://bugs.freedesktop.org/attachment.cgi?id=81827&action=edit 0002-pipe_loader_sw-include-xlib_sw_winsys.h-only-when-HA.patch -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH] draw/translate: fix instancing

2013-07-01 Thread Jose Fonseca
- Original Message - > We were incorrectly computing the buffer offset when using the > instances. The buffer offset is always equal to: > start_instance * stride + (instance_num / instance_divisor) * > stride > We were completely ignoring the start instance quite > often producing instan

[Mesa-dev] [PATCH 4/6] glsl/linker: eliminate unused and set-but-unused built-in varyings

2013-07-01 Thread Marek Olšák
This eliminates built-in varyings such as gl_Color, gl_SecondaryColor, gl_TexCoord, and gl_FogFragCoord if they are unused by the next stage or not written at all (e.g. gl_TexCoord elements). The gl_TexCoord array is broken down into separate vec4s if needed. v2: - use a switch statement in varyin

Re: [Mesa-dev] [PATCH V5 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-07-01 Thread Paul Berry
On 28 June 2013 16:59, Anuj Phogat wrote: > Current implementation of ext_framebuffer_multisample_blit_scaled in > i965/blorp uses nearest filtering for multisample scaled blits. Using > nearest filtering produces blocky artifacts and negates the benefits > of MSAA. That is the reason why extensi

Re: [Mesa-dev] [PATCH 04/14] glsl: Add a comment to note what an exec_list is a list of.

2013-07-01 Thread Chad Versace
On 06/29/2013 07:43 PM, Matt Turner wrote: --- src/glsl/ast.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index df2a21f..af7fcd9 100644 --- a/src/glsl/ast.h +++ b/src/glsl/ast.h @@ -526,6 +526,7 @@ public: struct _mesa_glsl_pars

Re: [Mesa-dev] [PATCH 03/14] glsl: Fix inverted conditional in error message.

2013-07-01 Thread Chad Versace
Patches 1-3 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] fixup! glsl: Add support for C-style initializers.

2013-07-01 Thread Matt Turner
--- src/glsl/glsl_parser_extras.cpp | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index f4b4924..2eb5fb7 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -674,

Re: [Mesa-dev] [PATCH] mesa: simplify some _mesa_IsEnabled() queries

2013-07-01 Thread Chad Versace
On 07/01/2013 07:58 AM, Brian Paul wrote: No need to test array->Enabled != 0 since the Enabled field can only be 0 or 1. --- src/mesa/main/enable.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH] i965: fix alpha test for MRT

2013-07-01 Thread Paul Berry
On 1 July 2013 04:45, Chris Forbes wrote: > Include src0 alpha in the RT write message when using MRT, so it is used > for the alpha test instead of the normal per-RT alpha value. > > Fixes broken rendering in Dota2 under Wine [FDO #62647] -- but not > tested against much else. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/2] eglplatform: use unsigned long instead of 32-bit ints in generic platform

2013-07-01 Thread Chad Versace
On 06/27/2013 07:04 AM, Brian Paul wrote: On 06/27/2013 05:35 AM, Ross Burton wrote: In the generic Unix case use the "unsigned long" type instead of 32-bit integers so that the type sizes are consistant on 64-bit machines between X11 and not-X11. Signed-off-by: Ross Burton --- include/EGL/e

Re: [Mesa-dev] [PATCH] i965: Initialize brw_blorp_const_color_program member variables.

2013-07-01 Thread Chad Versace
On 06/27/2013 10:40 PM, Vinson Lee wrote: Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Thanks, committed to master. ___

Re: [Mesa-dev] [PATCH] mesa: simplify some _mesa_IsEnabled() queries

2013-07-01 Thread Matt Turner
On Mon, Jul 1, 2013 at 7:58 AM, Brian Paul wrote: > No need to test array->Enabled != 0 since the Enabled field can > only be 0 or 1. > --- > src/mesa/main/enable.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/main/enable.c b/src/mesa

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Jesus Cortez changed: What|Removed |Added Version|9.0 |9.1 -- You are receiving this mail becau

[Mesa-dev] [PATCH] mesa: simplify some _mesa_IsEnabled() queries

2013-07-01 Thread Brian Paul
No need to test array->Enabled != 0 since the Enabled field can only be 0 or 1. --- src/mesa/main/enable.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 5c72b3c..21e5931 100644 --- a/src/mesa/main

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 --- Comment #1 from Brian Paul --- Created attachment 81814 --> https://bugs.freedesktop.org/attachment.cgi?id=81814&action=edit use a function to convert from GLhandleARB to GLuint Vinson, can you try this patch? There may be other files to

[Mesa-dev] [Bug 66213] Certain Mesa Demos Rendering Inverted (vertically)

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66213 Jesus Cortez changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail becau

[Mesa-dev] [Bug 66236] glext.h:4609: error: redefinition of typedef 'GLclampf'

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66236 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: H.264/MPEG2 decoding support via VP2, available on NV84-NV96, NVA0

2013-07-01 Thread Roland Scheidegger
Am 30.06.2013 03:02, schrieb Ilia Mirkin: > Well, as luck would have it, I've redone it as SSE2 and it's faster > (more instructions, but fewer cycles). So I'm just going to replace it > with SSE2, which is on by default for x86_64. I didn't see any runtime > feature detection logic in gallium, onl

[Mesa-dev] [Bug 62647] Wrong rendering of Dota 2 on Wine (apitrace attached) - Intel IVB HD4000

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62647 --- Comment #26 from Alexandre Derumier --- Works fine here too ! Thanks Chris ! Thanks Vedran ! -- You are receiving this mail because: You are on the CC list for the bug. ___ mesa-dev mailing list m

[Mesa-dev] [Bug 62647] Wrong rendering of Dota 2 on Wine (apitrace attached) - Intel IVB HD4000

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62647 --- Comment #25 from Vedran Rodic --- Confirmed fixed. Thanks Chris! -- You are receiving this mail because: You are on the CC list for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH 04/12] r600g: fix texture offset computation for mapped MSAA depth buffers

2013-07-01 Thread Christian König
Ok, then I guess it is explanation number two. Your bug description just sounded like you steeped to that specific memory write with a debugger and executing this specific write was causing a lockup... Then sorry for the noise, Christian. Am 01.07.2013 13:25, schrieb Marek Olšák: I only know

[Mesa-dev] [Bug 62647] Wrong rendering of Dota 2 on Wine (apitrace attached) - Intel IVB HD4000

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62647 --- Comment #24 from Chris Forbes --- I've just sent a (fairly dodgy) patch to the mesa list which fixes this. -- You are receiving this mail because: You are on the CC list for the bug. ___ mesa-dev

[Mesa-dev] [PATCH] i965: fix alpha test for MRT

2013-07-01 Thread Chris Forbes
Include src0 alpha in the RT write message when using MRT, so it is used for the alpha test instead of the normal per-RT alpha value. Fixes broken rendering in Dota2 under Wine [FDO #62647] -- but not tested against much else. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs_emi

Re: [Mesa-dev] [PATCH 04/12] r600g: fix texture offset computation for mapped MSAA depth buffers

2013-07-01 Thread Marek Olšák
I only know that the offset was wrong and the state tracker was writing outside of a mapped resource. The lockup disappeared by commenting out the call to _mesa_pack_ubyte_stencil_row, which was reading from and writing to the mapped resource. Two possible explanations are: - the memory controller

Re: [Mesa-dev] [PATCH] mesa: renumber shader indices according to their placement in pipeline

2013-07-01 Thread Jose Fonseca
- Original Message - > See my explanation in mtypes.h. > > v2: don't do this in gallium Thanks for the update, Marek. I think that the "These MUST have the same values as gallium's PIPE_SHADER_*" comment in gl_shader_type enum can be removed now. Otherwise looks good AFAICT (but note

[Mesa-dev] [Bug 63404] [wayland egl] intel_do_flush_locked failed: invalid argument, crash

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63404 Ander Conselvan de Oliveira changed: What|Removed |Added CC||m...@mail.mailinator.com -

Re: [Mesa-dev] [PATCH 04/12] r600g: fix texture offset computation for mapped MSAA depth buffers

2013-07-01 Thread Christian König
Am 01.07.2013 03:53, schrieb Marek Olšák: It was wrong, because the offset shouldn't be applied to MSAA depth buffers. This small cleanup should prevent such issues in the future. This fixes a lockup in "piglit/fbo-depthstencil default_fb -samples=n". The lockup was special, because it was trig