Re: [Mesa-dev] [PATCH 1/3] glsl: Bail on parsing if the #version directive is bogus.

2013-06-07 Thread Matt Turner
On Fri, Jun 7, 2013 at 10:42 PM, Kenneth Graunke wrote: > If we didn't successfully parse the #version line, there's no point in > continuing with parsing and compiling: it's already failed. > > Furthermore, it can actually be harmful: right after handling #version, > we call _mesa_glsl_initialize

[Mesa-dev] [PATCH 3/3] glcpp: Automatically #define GL_core_profile 1 on GLSL 1.50+.

2013-06-07 Thread Kenneth Graunke
Page 17 of the GLSL 1.50.11 specification states: "There is a built-in macro definition for each profile the implementation supports. All implementations provide the following macro: Signed-off-by: Kenneth Graunke --- src/glsl/glcpp/glcpp-parse.y | 3 +++ 1 file changed, 3 insertions(+) diff

[Mesa-dev] [PATCH 2/3] glsl: Parse "#version 150 core" directives.

2013-06-07 Thread Kenneth Graunke
Previously we only supported "#version 150". This patch recognizes "compatibility" to give the user a more descriptive error message. Fixes Piglit's version-150-core-profile test. Signed-off-by: Kenneth Graunke --- src/glsl/glsl_parser_extras.cpp | 13 + 1 file changed, 13 insertio

[Mesa-dev] [PATCH 1/3] glsl: Bail on parsing if the #version directive is bogus.

2013-06-07 Thread Kenneth Graunke
If we didn't successfully parse the #version line, there's no point in continuing with parsing and compiling: it's already failed. Furthermore, it can actually be harmful: right after handling #version, we call _mesa_glsl_initialize_types(), which checks state->es_shader and language_version. If

Re: [Mesa-dev] [PATCH 1/3] i965/vs: Use the MAD instruction when possible.

2013-06-07 Thread Matt Turner
On Fri, Jun 7, 2013 at 6:55 PM, Eric Anholt wrote: > This is different from how we do it in the FS - we are using MAD even when > some of the args are constants, because with the relatively unrestrained > ability to schedule a MOV to prepare a temporary with that data, we can > get lower latency f

Re: [Mesa-dev] [PATCH 3/3] i965/vs: Avoid the MUL/MACH/MOV sequence for small integer multiplies.

2013-06-07 Thread Kenneth Graunke
On 06/07/2013 06:55 PM, Eric Anholt wrote: We do a lot of multiplies by 3 or 4 for skinning shaders, and we can avoid the sequence if we just move them into the right argument of the MUL. On SNB, this means reliably putting a constant in a position where it can't be constant folded, but that's s

[Mesa-dev] [PATCH 1/3] i965/vs: Use the MAD instruction when possible.

2013-06-07 Thread Eric Anholt
This is different from how we do it in the FS - we are using MAD even when some of the args are constants, because with the relatively unrestrained ability to schedule a MOV to prepare a temporary with that data, we can get lower latency for the sequence of instructions. No significant performance

[Mesa-dev] [PATCH 3/3] i965/vs: Avoid the MUL/MACH/MOV sequence for small integer multiplies.

2013-06-07 Thread Eric Anholt
We do a lot of multiplies by 3 or 4 for skinning shaders, and we can avoid the sequence if we just move them into the right argument of the MUL. On SNB, this means reliably putting a constant in a position where it can't be constant folded, but that's still better than MUL/MACH/MOV. Improves GLB

[Mesa-dev] [PATCH 2/3] i965/vs: Allow copy propagation into MUL/MACH.

2013-06-07 Thread Eric Anholt
This is a trivial port of 1d6ead38042cc0d1e667d8ff55937c1e32d108b1 from the FS. No significant performance difference on trex (misplaced the data, but it was about n=20). --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[Mesa-dev] [Bug 65525] New: [llvmpipe] lp_scene.h:210:lp_scene_alloc: Assertion `size <= (64 * 1024)' failed.

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65525 Priority: medium Bug ID: 65525 Keywords: have-backtrace, regression CC: e...@anholt.net Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] lp_scene.h:210:lp_scene_alloc

Re: [Mesa-dev] R600/SI: Intrinsics for derivatives

2013-06-07 Thread Tom Stellard
On Fri, Jun 07, 2013 at 05:24:42PM +0200, Michel Dänzer wrote: > > The most important difference to the previous version of these is that > whole quad mode is now enabled and M0 initialized appropriately for the > LDS instructions, which now allows all of the relevant piglit tests to > pass. > Hi

Re: [Mesa-dev] [PATCH] r600g: implement fast color clears on evergreen+

2013-06-07 Thread Grigori Goronzy
On 08.06.2013 00:40, Marek Olšák wrote: Also the fast clear shouldn't be used for array, cube, and 3D textures unless all layers are cleared together. OK. I hadn't really thought about these. One more thing. If you don't use piglit, I recommend using it before sending patches to the mailing

Re: [Mesa-dev] R600/SI: Intrinsics for derivatives

2013-06-07 Thread Tom Stellard
On Fri, Jun 07, 2013 at 05:24:42PM +0200, Michel Dänzer wrote: > > The most important difference to the previous version of these is that > whole quad mode is now enabled and M0 initialized appropriately for the > LDS instructions, which now allows all of the relevant piglit tests to > pass. > >

Re: [Mesa-dev] [PATCH] Fixed bug in unclamped float to ubyte conversion.

2013-06-07 Thread Stéphane Marchesin
Ping, does anyone else want to review this patch? Stéphane On Fri, May 10, 2013 at 3:56 PM, Manfred Ernst wrote: > Problem: The IEEE float optimized version of UNCLAMPED_FLOAT_TO_UBYTE in > macros.h > computed incorrect results for inputs in the range 0x3f7f (=0.99609375) to > 0x3f7f7f80 (

[Mesa-dev] [Bug 65423] Remove gl_config::haveDepthBuffer, haveAccumBuffer, haveStencilBuffer fields

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65423 --- Comment #2 from Brian Paul --- (In reply to comment #1) > struct gl_config doesn't have member accumBits, but it has accumR, accumG > and accumB members. Maybe I should change `if(visual->haveAccumBuffer)` to > if((visual->accumG + visual->ac

Re: [Mesa-dev] [PATCH] r600g: implement fast color clears on evergreen+

2013-06-07 Thread Marek Olšák
The idea is good. Now if only it supported multiple colorbuffers and all colorbuffer formats. It shouldn't be hard. Also the fast clear shouldn't be used for array, cube, and 3D textures unless all layers are cleared together. One more thing. If you don't use piglit, I recommend using it before se

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-07 Thread Jose Fonseca
- Original Message - > Am 07.06.2013 16:55, schrieb Jose Fonseca: > > > > > > - Original Message - > >> Am 06.06.2013 03:15, schrieb Brian Paul: > >>> Reviewed-by: Brian Paul > >>> > >>> Just two minor nits below. > >>> > >>> > >>> On 06/05/2013 05:44 PM, srol...@vmware.com wro

[Mesa-dev] hw_gl_select branch status

2013-06-07 Thread Jerry Gamache
I've rebased the patch and fixed up some build failures. If you want to play with it, here is the updated branch: http://cgit.freedesktop.org/~ab/mesa/log/?h=hw_gl_select2 I have a test where I draw 3 overlapped triangles in the XY

Re: [Mesa-dev] Random results in piglit spec/!OpenGL 1.1/read-front on r600g

2013-06-07 Thread Martin Andersson
On Fri, Jun 7, 2013 at 8:58 AM, Martin Andersson wrote: > On Fri, Jun 7, 2013 at 12:37 AM, Marek Olšák wrote: >> There are bugs in both piglit and DRI2. I haven't looked into the >> issue, but Paul Berry seems to be working on it. >> >> See: >> http://lists.freedesktop.org/archives/piglit/2013-Ma

[Mesa-dev] [Bug 65423] Remove gl_config::haveDepthBuffer, haveAccumBuffer, haveStencilBuffer fields

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65423 --- Comment #1 from Arnas Milaševičius --- struct gl_config doesn't have member accumBits, but it has accumR, accumG and accumB members. Maybe I should change `if(visual->haveAccumBuffer)` to if((visual->accumG + visual->accumB + visual-> accumR)

Re: [Mesa-dev] [PATCH 1/7] mesa: Hide weirdness of 1D_ARRAY textures from Driver.CopyTexSubImage().

2013-06-07 Thread Brian Paul
On 06/07/2013 12:13 PM, Eric Anholt wrote: Brian Paul writes: On 06/05/2013 10:14 AM, Eric Anholt wrote: - /* 1D array textures need special treatment. -* Blit rows from the source to layers in the destination. */ - if (texImage->TexObject->Target == GL_TEXTURE_1D_ARRAY) { - int

Re: [Mesa-dev] [PATCH 5/7] intel: Directly implement blit glBlitFramebuffer instead of awkward reuse.

2013-06-07 Thread Kenneth Graunke
On 06/07/2013 12:58 PM, Eric Anholt wrote: Kenneth Graunke writes: On 06/05/2013 10:14 AM, Eric Anholt wrote: This gets us support for blitting to attachment types other than textures. + /* Blit to all active draw buffers. We don't do any pre-checking, + * because we assume that c

[Mesa-dev] [PATCH] intel: Make batch macros for doing BCS_SWCTRL setup.

2013-06-07 Thread Eric Anholt
We're going to add more BCS_SWCTRL setup instances soon, and you have to be careful to have the set and restore atomic with the rendering that's done, so that our state doesn't leak out to other rendering processes. v2: Rewrite the patch to do have batch begin/advance macros so that magic numb

Re: [Mesa-dev] [PATCH 5/7] intel: Directly implement blit glBlitFramebuffer instead of awkward reuse.

2013-06-07 Thread Eric Anholt
Kenneth Graunke writes: > On 06/05/2013 10:14 AM, Eric Anholt wrote: >> This gets us support for blitting to attachment types other than >> textures. >> + /* Blit to all active draw buffers. We don't do any pre-checking, >> + * because we assume that copying to MRTs is rare, and failu

[Mesa-dev] [PATCH] r600g: implement fast color clears on evergreen+

2013-06-07 Thread Grigori Goronzy
Allows MSAA colorbuffers, which have a CMASK automatically and don't need any further special handling, to be fast cleared. Instead of clearing the buffer, set the clear color and the CMASK to the cleared state. --- src/gallium/drivers/r600/evergreen_state.c | 8 +++- src/gallium/drivers/r600

[Mesa-dev] [RFC] r600g: implement fast color clears on evergreen+

2013-06-07 Thread Grigori Goronzy
This is my first try to contribute anything useful to Mesa, so please bear with me. This is not finished, but I'd like feedback to make sure the code's quality and style is in line with what is expected in Mesa. ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH 1/7] mesa: Hide weirdness of 1D_ARRAY textures from Driver.CopyTexSubImage().

2013-06-07 Thread Eric Anholt
Paul Berry writes: > On 5 June 2013 10:14, Eric Anholt wrote: > >> Intel had brokenness here, and I'd like to continue moving Mesa toward >> hiding 1D_ARRAY's ridiculousness inside of the core, like we did with >> MapTextureImage. Fixes copyteximage 1D_ARRAY on intel. >> >> There's still an imp

Re: [Mesa-dev] [PATCH 1/7] mesa: Hide weirdness of 1D_ARRAY textures from Driver.CopyTexSubImage().

2013-06-07 Thread Eric Anholt
Brian Paul writes: > On 06/05/2013 10:14 AM, Eric Anholt wrote: >> Intel had brokenness here, and I'd like to continue moving Mesa toward >> hiding 1D_ARRAY's ridiculousness inside of the core, like we did with >> MapTextureImage. Fixes copyteximage 1D_ARRAY on intel. >> >> There's still an impe

Re: [Mesa-dev] [PATCH] i965: Shrink Gen5 VUE map layout to be the same as Gen4.

2013-06-07 Thread Kenneth Graunke
On 06/07/2013 11:30 AM, Paul Berry wrote: On 7 June 2013 03:17, Chris Forbes mailto:chr...@ijw.co.nz>> wrote: The PRM suggests a larger layout, mostly to support having gl_ClipDistance[] somewhere predictable for the fixed-function clipper -- but it didn't actually arrive in Gen5.

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-07 Thread Roland Scheidegger
Am 07.06.2013 16:55, schrieb Jose Fonseca: > > > - Original Message - >> Am 06.06.2013 03:15, schrieb Brian Paul: >>> Reviewed-by: Brian Paul >>> >>> Just two minor nits below. >>> >>> >>> On 06/05/2013 05:44 PM, srol...@vmware.com wrote: From: Roland Scheidegger Mostly j

[Mesa-dev] [PATCH 1/2] i965/fs: Dump IR when fatally not compiling due to bad register spilling.

2013-06-07 Thread Eric Anholt
It should never happen, but it does, and at this point, you're going to _mesa_problem() and abort() (unless it's just in precompile). Give the developer something to look at. --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/2] ra: Fix register spilling.

2013-06-07 Thread Eric Anholt
Commit 551c991606e543c3a264a762026f11348b37947e tried to avoid spilling registers that were trivially colorable. But since we do optimistic coloring, the top of the stack also contains nodes that are not trivially colorable, so we need to consider them for spilling (since they are some of our best

Re: [Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-07 Thread Kenneth Graunke
On 06/07/2013 08:49 AM, Brian Paul wrote: Kenneth, it turns out that git blame handles file renaming just fine. You'll see the line-by-line change information, along with the old filename when you do git blame. Did you, or anyone else, have any other objections? -Brian Huh. I could have swor

Re: [Mesa-dev] [PATCH 0/2] Fix gl_ClipVertex support on pre-Gen6 i965

2013-06-07 Thread Paul Berry
On 7 June 2013 02:25, Chris Forbes wrote: > Hi Paul > > Thanks for that suggestion -- you're right, the hardware does seem > quite happy with the Gen4 layout. I'm doing a full piglit run to be > safe. > > As far as performance goes, it's good for about a 3% speedup on the > CS:S video stress test

Re: [Mesa-dev] [PATCH] i965: Shrink Gen5 VUE map layout to be the same as Gen4.

2013-06-07 Thread Paul Berry
On 7 June 2013 03:17, Chris Forbes wrote: > The PRM suggests a larger layout, mostly to support having > gl_ClipDistance[] somewhere predictable for the fixed-function clipper > -- but it didn't actually arrive in Gen5. > > Just use the same layout for both Gen4 and Gen5. > > No Piglit regression

Re: [Mesa-dev] [PATCH 5/7] intel: Directly implement blit glBlitFramebuffer instead of awkward reuse.

2013-06-07 Thread Paul Berry
On 5 June 2013 10:14, Eric Anholt wrote: > This gets us support for blitting to attachment types other than > textures. > I don't follow everything in this patch, but I trust Ken's review, so consider it Acked-by: Paul Berry I already made comments on patches 1 and 2. Patches 3, 4, 6, and 7

Re: [Mesa-dev] [PATCH] u_vbuf: fix index buffer leak

2013-06-07 Thread Alex Deucher
On Fri, Jun 7, 2013 at 1:36 PM, Chia-I Wu wrote: > On Fri, Jun 7, 2013 at 9:25 PM, Alex Deucher wrote: >> Candidate for the stable branches? > Ah, I already committed it. I will let it settle in master for a few > days and cherry-pick it to 9.1, unless this is against some policy > about stable

Re: [Mesa-dev] [PATCH] u_vbuf: fix index buffer leak

2013-06-07 Thread Chia-I Wu
On Fri, Jun 7, 2013 at 9:25 PM, Alex Deucher wrote: > Candidate for the stable branches? Ah, I already committed it. I will let it settle in master for a few days and cherry-pick it to 9.1, unless this is against some policy about stable branches. > On Fri, Jun 7, 2013 at 5:58 AM, Marek Olšák w

Re: [Mesa-dev] [PATCH 2/2] util: fix util_clear_render_target and util_clear_depth_stencil layer handling

2013-06-07 Thread Marek Olšák
I understand, though the current hackish approach in the radeon (and also nouveau) drivers has been working really well for the last 3 years and it doesn't look like anybody would like to change that. Just saying. Not that it's important. Marek On Fri, Jun 7, 2013 at 4:57 PM, Roland Scheidegger

[Mesa-dev] [PATCH 2/2] radeonsi: Handle TGSI_OPCODE_DDX/Y

2013-06-07 Thread Michel Dänzer
From: Michel Dänzer 16 more little piglits. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 35 ++ src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 1 + 3 files changed, 37 inserti

[Mesa-dev] [PATCH 1/2] radeonsi: Handle TGSI_OPCODE_TXD

2013-06-07 Thread Michel Dänzer
From: Michel Dänzer One more little piglit. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 0/2] radeonsi: Derivatives support

2013-06-07 Thread Michel Dänzer
I wonder how we should deal with LLVM 3.3 for these: Might we be able to get the intrinsics into an LLVM 3.3.y release, or do we need to only enable this stuff as of LLVM 3.4? [PATCH 1/2] radeonsi: Handle TGSI_OPCODE_TXD [PATCH 2/2] radeonsi: Handle TGSI_OPCODE_DDX/Y __

Re: [Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-07 Thread Brian Paul
On 06/06/2013 01:57 AM, Arnas Milaševičius wrote: On Thu, Jun 6, 2013 at 3:23 AM, Brian Paul mailto:bri...@vmware.com>> wrote: On 06/05/2013 03:25 PM, Kenneth Graunke wrote: On 06/05/2013 12:09 PM, Arnas Milasevicius wrote: --- src/mesa/Makefile.sources

[Mesa-dev] [Bug 65513] New: In TGSI module, replace string arrays with functions

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65513 Priority: medium Bug ID: 65513 Assignee: mesa-dev@lists.freedesktop.org Summary: In TGSI module, replace string arrays with functions Severity: trivial Classification: Unclassified

Re: [Mesa-dev] [PATCH] llvmpipe: Use saturating add/sub for UNORM formats

2013-06-07 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > lp_build_add and lp_build_sub have fallback code for cases > that cannot be handled by known intrinsics. For UNORM formats, > this code was using modulo rather than saturating arithmetic. > > This fixes some rendering issues for a gnome sess

Re: [Mesa-dev] [PATCH v5] mesa: Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-07 Thread Brian Paul
On 06/06/2013 03:21 PM, Arnas Milasevicius wrote: Moved draw_arrays() to st_draw_feedback.c and removed draw_arrays_instanced() I updated the comments a bit and pushed to master. Thanks. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH v5] mesa: Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-07 Thread Arnas Milaševičius
Someone, please, check this patch. On Fri, Jun 7, 2013 at 1:21 AM, Arnas Milasevicius wrote: > > Moved draw_arrays() to st_draw_feedback.c and removed draw_arrays_instanced() > --- > v5: combined patches together > src/gallium/auxiliary/draw/draw_context.h | 11 - > src/gallium/auxiliar

[Mesa-dev] R600/SI: Intrinsics for derivatives

2013-06-07 Thread Michel Dänzer
The most important difference to the previous version of these is that whole quad mode is now enabled and M0 initialized appropriately for the LDS instructions, which now allows all of the relevant piglit tests to pass. -- Earthling Michel Dänzer | http://www.amd.com

Re: [Mesa-dev] [PATCH] glsl: Fix null check in read_dereference.

2013-06-07 Thread Brian Paul
On 06/06/2013 11:11 PM, Vinson Lee wrote: Fixes "Logically dead code" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/glsl/ir_reader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir_reader.cpp b/src/glsl/ir_reader.cpp index b366712..51534ca 1

Re: [Mesa-dev] [PATCH 1/2] util: add util_resource_is_array_texture()

2013-06-07 Thread Brian Paul
On 06/07/2013 12:44 AM, Chia-I Wu wrote: Checking if array_size is greater than 1 is not enough for single-layered array textures. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_resource.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH 2/2] util: fix util_clear_render_target and util_clear_depth_stencil layer handling

2013-06-07 Thread Jose Fonseca
- Original Message - > Am 07.06.2013 12:14, schrieb Marek Olšák: > >> diff --git a/src/gallium/auxiliary/util/u_transfer.c > >> b/src/gallium/auxiliary/util/u_transfer.c > >> index 56e059b..7804f2a 100644 > >> --- a/src/gallium/auxiliary/util/u_transfer.c > >> +++ b/src/gallium/auxiliary/ut

Re: [Mesa-dev] [PATCH 2/2] util: fix util_clear_render_target and util_clear_depth_stencil layer handling

2013-06-07 Thread Roland Scheidegger
Am 07.06.2013 12:14, schrieb Marek Olšák: >> diff --git a/src/gallium/auxiliary/util/u_transfer.c >> b/src/gallium/auxiliary/util/u_transfer.c >> index 56e059b..7804f2a 100644 >> --- a/src/gallium/auxiliary/util/u_transfer.c >> +++ b/src/gallium/auxiliary/util/u_transfer.c >> @@ -25,6 +25,7 @@ voi

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: bump 3d and cube map limits to 2048 and 8192 respectively

2013-06-07 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > These should just work (?), required by d3d10. Too large resources will > get thrown out separately anyway. > --- > src/gallium/drivers/llvmpipe/lp_limits.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Mesa-dev] [PATCH 1/3] gallium/tgsi: add missing string for layer semantic

2013-06-07 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > Also report if a shader writes the layer semantic > --- > src/gallium/auxiliary/draw/draw_context.c |2 +- > src/gallium/auxiliary/tgsi/tgsi_scan.c|5 + > src/gallium/auxiliary/tgsi/tgsi_scan.h|1 + > src/galli

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-07 Thread Jose Fonseca
- Original Message - > Am 06.06.2013 03:15, schrieb Brian Paul: > > Reviewed-by: Brian Paul > > > > Just two minor nits below. > > > > > > On 06/05/2013 05:44 PM, srol...@vmware.com wrote: > >> From: Roland Scheidegger > >> > >> Mostly just make sure the layer parameter gets passed t

Re: [Mesa-dev] [PATCH] u_vbuf: fix index buffer leak

2013-06-07 Thread Alex Deucher
Candidate for the stable branches? On Fri, Jun 7, 2013 at 5:58 AM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Fri, Jun 7, 2013 at 6:25 AM, Chia-I Wu wrote: >> >> Signed-off-by: Chia-I Wu >> --- >> src/gallium/auxiliary/util/u_vbuf.c |3 +++ >> 1 file changed, 3 inserti

[Mesa-dev] [PATCH] llvmpipe: Use saturating add/sub for UNORM formats

2013-06-07 Thread Richard Sandiford
lp_build_add and lp_build_sub have fallback code for cases that cannot be handled by known intrinsics. For UNORM formats, this code was using modulo rather than saturating arithmetic. This fixes some rendering issues for a gnome session on System z. It also fixes various piglit tests on z, such a

[Mesa-dev] [PATCH] i965: Shrink Gen5 VUE map layout to be the same as Gen4.

2013-06-07 Thread Chris Forbes
The PRM suggests a larger layout, mostly to support having gl_ClipDistance[] somewhere predictable for the fixed-function clipper -- but it didn't actually arrive in Gen5. Just use the same layout for both Gen4 and Gen5. No Piglit regressions. Improves performance in CS:S Video Stress Test by ~3

[Mesa-dev] [Bug 65426] openGL glDeleteBuffers does not delete buffers created using glGenBuffers

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65426 --- Comment #12 from José Fonseca --- (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > Is this really a problem? Mesa might not always reuse buffer names, but > > > that > > > does not mean the buffer wasn't

Re: [Mesa-dev] [PATCH 2/2] util: fix util_clear_render_target and util_clear_depth_stencil layer handling

2013-06-07 Thread Marek Olšák
On Fri, Jun 7, 2013 at 2:32 AM, wrote: > From: Roland Scheidegger > > These functions must clear all bound layers, not just the first. > --- > src/gallium/auxiliary/util/u_surface.c | 190 > +-- > src/gallium/auxiliary/util/u_transfer.c |1 + > 2 files changed

Re: [Mesa-dev] [PATCH] u_vbuf: fix index buffer leak

2013-06-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 7, 2013 at 6:25 AM, Chia-I Wu wrote: > > Signed-off-by: Chia-I Wu > --- > src/gallium/auxiliary/util/u_vbuf.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_vbuf.c > b/src/gallium/auxiliary/util/u_vbuf.c

[Mesa-dev] [Bug 65426] openGL glDeleteBuffers does not delete buffers created using glGenBuffers

2013-06-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65426 --- Comment #11 from Michel Dänzer --- (In reply to comment #7) > If we'd ever hit 0x (or whatever the new hash table's limit is) we'd > resort to searching the hash table for a lower, unused ID. I doubt that any > app/test has ever exer

Re: [Mesa-dev] [PATCH 0/2] Fix gl_ClipVertex support on pre-Gen6 i965

2013-06-07 Thread Chris Forbes
Hi Paul Thanks for that suggestion -- you're right, the hardware does seem quite happy with the Gen4 layout. I'm doing a full piglit run to be safe. As far as performance goes, it's good for about a 3% speedup on the CS:S video stress test. -- Chris __

Re: [Mesa-dev] [PATCH] gallium/docs: fix up transfer description for 1d arrays, add cube map arrays

2013-06-07 Thread Eric Anholt
srol...@vmware.com writes: > -For PIPE_TEXTURE_2D_ARRAY, the box::z and box::depth fields refer to the > -array dimension of the texture. > +For PIPE_TEXTURE_1D_ARRAY nad PIPE_TEXTURE_2D_ARRAY, the box::z and > box::depth "and" pgp9RJLIcFMTs.pgp Description: PGP sig

[Mesa-dev] [PATCH 2/2] ilo: fix textureSize() for single-layered array textures

2013-06-07 Thread Chia-I Wu
We returned 0 instead of 1 for the number of layers when the array texutre is single-layered. This fixes it on GEN7+. Signed-off-by: Chia-I Wu --- src/gallium/drivers/ilo/ilo_gpe_gen7.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 1/2] util: add util_resource_is_array_texture()

2013-06-07 Thread Chia-I Wu
Checking if array_size is greater than 1 is not enough for single-layered array textures. Signed-off-by: Chia-I Wu --- src/gallium/auxiliary/util/u_resource.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_resource.h b/src