[Mesa-dev] [Bug 58972] New: [softpipe] util/u_tile.c:795:pipe_put_tile_z: Assertion `0' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=58972 Priority: medium Bug ID: 58972 Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] util/u_tile.c:795:pipe_put_tile_z: Assertion `0' failed. Severity: critical Cl

Re: [Mesa-dev] [PATCH 1/5] driconf: Add option definitions to source file, not generated target

On 12/03/2012 03:43 PM, Carl Worth wrote: For the last two most-recently-added driconf options, their definition was manually added to options.h, a file which is intended to be automatically generated, (as part of support for translated driconf option descriptions). This means that these options

Re: [Mesa-dev] [PATCH 6/8] glcpp: Add --disable-line-continuations argument to standalone glcpp

On Wed, Dec 5, 2012 at 5:32 PM, Carl Worth wrote: > This will allow testing of disabled line-continuation on a case-by-case basis, > (with the option communicated to the preprocessor via the GL context). > --- > src/glsl/glcpp/glcpp.c | 43 +-- > 1 file c

Re: [Mesa-dev] [PATCH 1/8] driconf: Add a new option: disable_glsl_line_continuations

On 12/05/2012 05:32 PM, Carl Worth wrote: This is to enable a quirk for Savage2 which includes a shader with a stray '\' at the end of a comment line. Interpreting that backslash as a line continuation will break the compilation of the shader, so we need a way to disable this. Patches 1-5 and 7

Re: [Mesa-dev] [PATCH 6/8] glcpp: Add --disable-line-continuations argument to standalone glcpp

On 12/05/2012 05:32 PM, Carl Worth wrote: This will allow testing of disabled line-continuation on a case-by-case basis, (with the option communicated to the preprocessor via the GL context). --- src/glsl/glcpp/glcpp.c | 43 +-- 1 file changed, 41 inse

[Mesa-dev] Fwd: [PATCH] mesa: Correctly set base and max texture levels in glTexparameterf

On Wed, Jan 2, 2013 at 11:50 PM, Brian Paul wrote: > > On 01/02/2013 10:39 AM, Paul Berry wrote: >> >> On 2 January 2013 07:38, Anuj Phogat > > wrote: >> >> gles3 conformance sgis_texture_lod_basic_getter.test expects base >> and max texture levels to be round

Re: [Mesa-dev] [PATCH] i965/fs: Remove force_sechalf stack.

On 01/01/2013 03:12 PM, Kenneth Graunke wrote: Only Gen4 color write setup uses the force_sechalf flag, and it only sets it on a single instruction. It also already has to get a pointer to the instruction and manually set the saturate flag, so we may as well just set force_sechalf the same way a

Re: [Mesa-dev] r600g: RFC: ISA information tables and shader disassembler

On Sat, Dec 29, 2012 at 08:36:36PM +0400, Vadim Girlin wrote: > The patches are pretty big so you can find the branch here: > > http://cgit.freedesktop.org/~vadimg/mesa/log/?h=r600-disasm > > My primary goal was to have a shader disassembler in the driver to > simplify the debugging. The disassem

Re: [Mesa-dev] [PATCH 10/11] mesa: Add GetProgramiv support for GL_PROGRAM_BINARY_LENGTH

On 01/02/2013 12:53 PM, Brian Paul wrote: On 12/19/2012 05:14 PM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 39a883e..c7934

Re: [Mesa-dev] [PATCH 10/11] mesa: Add GetProgramiv support for GL_PROGRAM_BINARY_LENGTH

On 12/19/2012 05:14 PM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 39a883e..c7934d7 100644 --- a/src/mesa/main/shaderapi.c +

[Mesa-dev] [PATCH] gallivm: support more immediates in lp_build_tgsi_info()

Bump limit from 32 to 128. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=58545 --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c b/src/gallium/auxiliary/gallivm/lp_bl

Re: [Mesa-dev] [PATCH] glu: src/libtess: memory has been freed using uninitialized pointer

On 12/19/2012 11:26 PM, Mike Gorchak wrote: Hi ! I've attached the patch which fixes access to unitialized pointer during memory free operation. pqNewPriorityQ() function creates and setups PriorityQ structure, all except for the field "order". It is filled later in function pqInit(). Depending

Re: [Mesa-dev] [PATCH 00/14] GetTexImage and CopyTexSubImage fixes and improvements

On Thu, Dec 20, 2012 at 10:56 AM, Marek Olšák wrote: > This series contains some fixes for rarely used OpenGL features. What's more > interesting here is that it uses 2 features we could use in gallium more > often: 3D blits and 3D texture tranfers. The interfaces have been in place > already.

Re: [Mesa-dev] [PATCH 1/2] gallium: extend pipe_context::flush for it to accept an END_OF_FRAME flag

On 12/21/2012 09:23 AM, Marek Olšák wrote: Usage with pipe_context: pipe->flush(pipe, NULL, PIPE_FLUSH_END_OF_FRAME); Usage with st_context_iface: st->flush(st, ST_FLUSH_END_OF_FRAME, NULL); The flag is only a hint for drivers. Radeon will use it for buffer eviction heuristics in the kern

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add support for GL_ARB_texture_buffer_range

On 12/22/2012 05:49 AM, Christoph Bumiller wrote: v2: Update to handle BufferSize being -1 and return a NULL sampler view if the specified range would cause out of bounds access. --- src/mesa/state_tracker/st_atom_texture.c | 22 +- src/mesa/state_tracker/st_extensions.c

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

On 12/22/2012 05:49 AM, Christoph Bumiller wrote: v2: Record texObj.BufferSize as -1 in TexBuffer(non-Range) instead of the buffer's current size so we know we always have to use the full size of the buffer object (i.e. even if it changes without the user calling TexBuffer again) for the texture.

Re: [Mesa-dev] [PATCH 1/5] mesa: Add ALIGN() macro to main/macros.h.

On 01/02/2013 11:59 AM, Paul Berry wrote: Previously this macro existed in 3 separate places, some inside the intel driver and some outside of it. It makes more sense to have it in main/macros.h --- src/glsl/linker.cpp| 2 -- src/mesa/drivers/dri/i965/brw_context.h

Re: [Mesa-dev] [PATCH] i965: Fix glCompressedTexSubImage2D offsets for ETC textures.

On 2 January 2013 10:55, Ian Romanick wrote: > On 12/29/2012 11:50 AM, Paul Berry wrote: > >> This patch fixes intel_miptree_unmap_etc() (which decompresses ETC >> textures to linear) to pay attention to map->x and map->y when writing >> to the destination image. Previously these values were ign

Re: [Mesa-dev] [PATCH] i965: Replace structs with bit-shifting for Gen7 SURFACE_STATE entries.

On 12/29/2012 04:48 PM, Kenneth Graunke wrote: On 12/29/2012 02:38 PM, Ben Widawsky wrote: Anyway, we all agree it's a mess, and I just wanted to point out that this patch is the nail in the coffin. Maybe you should CC the maintainers for the other projects which depend on this? The nail in th

Re: [Mesa-dev] [PATCH] i965: Replace structs with bit-shifting for Gen7 SURFACE_STATE entries.

On 12/28/2012 09:21 PM, Kenneth Graunke wrote: Every generation except Gen7 creates SURFACE_STATE entries via a uint32_t array. Only Gen7 uses the older bitfield structure, which we moved away from because it was less efficient. Convert it for consistency. This reduces the compiled size of gen

[Mesa-dev] [PATCH 5/5] glsl: Pack flat "varyings" of mixed types together.

This patch enhances the varying packing code so that flat varyings of uint, int, and float types can be packed together. We accomplish this in lower_packed_varyings.cpp by making the type of all flat varyings ivec4, and then using information-preserving type conversions (e.g. ir_unop_bitcast_f2i)

[Mesa-dev] [PATCH 4/5] glsl: Prohibit structs and bools from being used as "varyings".

The GLSL 1.30 spec only allows vertex shader outputs and fragment shader inputs ("varyings" in pre-GLSL-1.30 parlance) to be of type int, uint, float, or vectors, matrices, or arrays thereof. Bools, bvec's, and structs are prohibited. (Integral varyings were prohibited prior to GLSL 1.30). Previ

[Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

This patch adds logic to allow the ast_to_hir function apply_type_qualifier_to_variable() to tell whether it is acting on a variable declaration or a function parameter. This will allow it to correctly interpret the meaning of "out" and "in" keywords (which have different meanings in those two con

[Mesa-dev] [PATCH 0/5] Varying packing improvements

This is a re-send of a patch series from Dec 19 (I think most people went away on holiday and didn't get a chance to review it). It cleans up the following shortcomings of my previous varying packing series: - It contained a silly duplicate copy of the ALIGN() macro. - It made linker.cpp enormou

[Mesa-dev] [PATCH 1/5] mesa: Add ALIGN() macro to main/macros.h.

Previously this macro existed in 3 separate places, some inside the intel driver and some outside of it. It makes more sense to have it in main/macros.h --- src/glsl/linker.cpp| 2 -- src/mesa/drivers/dri/i965/brw_context.h| 1 + src/mesa/drivers/dri/intel/intel_cont

Re: [Mesa-dev] [PATCH] xlib: handle _mesa_initialize_visual()'s return value

On 01/02/2013 11:52 AM, Ian Romanick wrote: On 12/26/2012 03:28 PM, Brian Paul wrote: From: Brian Paul If the call fails, we should return NULL from XMesaCreateVisual(). This was found when Waffle tried to create a visual with depth/stencil bits = -1. That's an illegal value for glXChooseFBCon

Re: [Mesa-dev] [PATCH] i965: Fix glCompressedTexSubImage2D offsets for ETC textures.

On 12/29/2012 11:50 AM, Paul Berry wrote: This patch fixes intel_miptree_unmap_etc() (which decompresses ETC textures to linear) to pay attention to map->x and map->y when writing to the destination image. Previously these values were ignored, causing the xoffset and yoffset parameters passed to

Re: [Mesa-dev] [PATCH] xlib: handle _mesa_initialize_visual()'s return value

On 12/26/2012 03:28 PM, Brian Paul wrote: From: Brian Paul If the call fails, we should return NULL from XMesaCreateVisual(). This was found when Waffle tried to create a visual with depth/stencil bits = -1. That's an illegal value for glXChooseFBConfig() and we should Isn't -1 == GLX_DONT_C

Re: [Mesa-dev] [PATCH] i965: Fail to blit rather than assert on invalid pitch requirements.

On 12/26/2012 09:29 AM, Kenneth Graunke wrote: On 12/26/2012 08:32 AM, Paul Berry wrote: On 25 December 2012 20:55, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: Dungeon Defenders hits TexImage()'s try_pbo_upload() path where image->Width == 2, which doesn't meet intelEmitCopyBl

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

On 12/22/2012 04:49 AM, Christoph Bumiller wrote: v2: Record texObj.BufferSize as -1 in TexBuffer(non-Range) instead of the buffer's current size so we know we always have to use the full size of the buffer object (i.e. even if it changes without the user calling TexBuffer again) for the texture.

Re: [Mesa-dev] [PATCH] i965: Fix border color handling for deprecated SNORM formats.

On 12/20/2012 04:07 PM, Eric Anholt wrote: We don't have native hardware support for these, so they get promoted to RGBA, in which case we don't have hardware dealing with the channel swizzling for us. Fixes piglit EXT_texture_snorm/texwrap formats bordercolor (-swizzled). --- src/mesa/drivers

Re: [Mesa-dev] [PATCH] mesa: Correctly set base and max texture levels in glTexparameterf

On 01/02/2013 10:39 AM, Paul Berry wrote: On 2 January 2013 07:38, Anuj Phogat mailto:anuj.pho...@gmail.com>> wrote: gles3 conformance sgis_texture_lod_basic_getter.test expects base and max texture levels to be rounded to nearest integer. e.g. round 2.3 to 2 and 2.6 to 3. OpenGL 3.0

Re: [Mesa-dev] [RFC PATCH 19/26] mesa: implement TexImage*Multisample

On 12/29/2012 05:35 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes --- src/mesa/main/teximage.c | 150 +-- 1 file changed, 144 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index b24efda..48ca997

Re: [Mesa-dev] [RFC PATCH 16/26] mesa: support multisample textures in framebuffer completeness check

On 12/29/2012 05:35 AM, Chris Forbes wrote: - sample count must be the same on all attachments - fixedsamplepositions must be the same on all attachments (renderbuffers have fixedsamplepositions=true implicitly; only multisample textures can choose to have it false) Signed-off-by: Chris Forbes -

Re: [Mesa-dev] [RFC PATCH 18/26] fbo: allow stencil textures

In the description the "fbo:" should just be "mesa:". On 12/29/2012 05:35 AM, Chris Forbes wrote: ARB_texture_multisample allows STENCIL_INDEX and sized variants with the multisample texture targets; similar to renderbuffers. Signed-off-by: Chris Forbes --- src/mesa/main/fbobject.c | 29 +

Re: [Mesa-dev] [RFC PATCH 13/26] mesa: implement sample mask

On 12/29/2012 05:35 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes --- src/mesa/main/enable.c | 15 +++ src/mesa/main/get.c | 9 + src/mesa/main/get_hash_params.py | 2 ++ src/mesa/main/mtypes.h | 6 +- src/mesa/main/multisamp

Re: [Mesa-dev] [RFC PATCH 12/26] mesa: implement GetMultisamplefv

On 12/29/2012 05:35 AM, Chris Forbes wrote: Actual sample locations deferred to a driverfunc since only the driver really knows where they will be. V2: pass the draw buffer to the driverfunc; don't fallback to pixel center if driverfunc is missing. Signed-off-by: Chris Forbes --- src/mesa/dri

Re: [Mesa-dev] [RFC PATCH 10/26] mesa: add new max sample count state

On 12/29/2012 05:35 AM, Chris Forbes wrote: - GL_MAX_COLOR_TEXTURE_SAMPLES - GL_MAX_DEPTH_TEXTURE_SAMPLES - GL_MAX_INTEGER_SAMPLES Signed-off-by: Chris Forbes --- src/mesa/main/get_hash_params.py | 5 - src/mesa/main/mtypes.h | 5 + 2 files changed, 9 insertions(+), 1 delet

Re: [Mesa-dev] [PATCH] i965/fs: Remove force_sechalf stack.

On 1 January 2013 15:12, Kenneth Graunke wrote: > Only Gen4 color write setup uses the force_sechalf flag, and it only > sets it on a single instruction. It also already has to get a pointer > to the instruction and manually set the saturate flag, so we may as well > just set force_sechalf the s

Re: [Mesa-dev] [RFC PATCH 06/26] mesa: add new texture state for ARB_texture_multisample

On 12/29/2012 05:35 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes --- src/mesa/main/mtypes.h | 4 src/mesa/main/texobj.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index db87ead..4be1074 100644 --- a/src/mesa/main/mtypes.

Re: [Mesa-dev] [RFC PATCH 04/26] mesa: add texobj support for ARB_texture_multisample

On 12/29/2012 05:35 AM, Chris Forbes wrote: V2: Allow multisample texture targets in glInvalidateTexSubImage too. This was already partly there, but I missed it the first time around since the interaction is defined in a newer extension. Signed-off-by: Chris Forbes --- src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH] mesa: Correctly set base and max texture levels in glTexparameterf

On 2 January 2013 07:38, Anuj Phogat wrote: > gles3 conformance sgis_texture_lod_basic_getter.test expects base > and max texture levels to be rounded to nearest integer. e.g. round > 2.3 to 2 and 2.6 to 3. OpenGL 3.0 and OpenGL ES 3.0 specifications > suggest similar rounding to select level whe

[Mesa-dev] [Bug 58844] [swrast] piglit fbo-generatemipmap-formats-signed regression

https://bugs.freedesktop.org/show_bug.cgi?id=58844 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] mesa: Correctly set base and max texture levels in glTexparameterf

gles3 conformance sgis_texture_lod_basic_getter.test expects base and max texture levels to be rounded to nearest integer. e.g. round 2.3 to 2 and 2.6 to 3. OpenGL 3.0 and OpenGL ES 3.0 specifications suggest similar rounding to select level when filtering mode is GL_NEAREST. This patch makes sgis

[Mesa-dev] [PATCH 6/6] intel: Create a miptree using offsets in intel_set_texture_image_region

When binding a region to a texture image, re-create the miptree base-level considering the offset and dimension information exported by DRIImage. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_tex_image.c | 27 -- 1 file changed, 21 insertions(+), 6

[Mesa-dev] [PATCH 5/6] intel: implement create image from texture

Save miptree level info to DRIImage, taking offsets into consideration. In non-tile-aligned surface cases where resolving back to the original image proves problematic due to alignment issues, copy the image to a single-level miptree and refer to the offsets there instead to avoid orphaning Signed

[Mesa-dev] [PATCH 4/6] i965: Account for offsets when emitting SURFACE_STATE.

If the offsets are present, this lets us specify a particular level and slice in a shared region using the base level of an exported mip-map tree. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 +++- src/mesa/drivers/dri/i965/gen7_wm_surface_s

[Mesa-dev] [PATCH 3/6] intel: add new miptree helper functions

Expose intel_miptree_copy_slice and add function calculating x and y offsets of a miptree level within a tiled region. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 17 - src/mesa/drivers/dri/intel/intel_mipmap_tree.h | 13 +

[Mesa-dev] [PATCH 2/6] intel: create a miptree for a region based on an offset, size, and level.

Add intel_miptree_create_for_offset which adds support for creating a single- level miptree based on the existing offsets and dimensions of another mip-tree level. Use this function as well in intel_miptree_create_for_region, but for the whole region. Signed-off-by: Abdiel Janulgue --- src/mesa/

[Mesa-dev] [PATCH 1/6] dri2: Create image from texture

Add create image from texture extension. Signed-off-by: Abdiel Janulgue --- include/GL/internal/dri_interface.h | 12 + src/egl/drivers/dri2/egl_dri2.c | 83 +++ 2 files changed, 95 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/inc

[Mesa-dev] intel: add support for EGL_KHR_gl_image v2

Version 2 of EGL_KHR_gl_image support. The changes addressed the comments from Eric Anholt in intel_setup_image_from_mipmap_tree(). The previous implementation had a potential for orphaning EGL images when we overwrite the original miptree for non-tile-aligned surfaces in order to obtain corre