On 01/02/2013 11:52 AM, Ian Romanick wrote:
On 12/26/2012 03:28 PM, Brian Paul wrote:
From: Brian Paul <bri...@vmware.com>

If the call fails, we should return NULL from XMesaCreateVisual().
This was found when Waffle tried to create a visual with depth/stencil
bits = -1. That's an illegal value for glXChooseFBConfig() and we
should

Isn't -1 == GLX_DONT_CARE? If it's truly invalid, shouldn't it have
been caught (and rejected) before this point?

Ugh. I missed GLX_DONT_CARE. It's only accepted by glXChooseFBConfig(), not glXChooseVisual(). I can add checks for that in the GLX code. The patch I committed is still good though.

-Brian

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to