Re: [Mesa-dev] [PATCH 07/10] i965: Replace brw_wm_* with dumping code into the fs_visitor.

Kenneth Graunke writes: > On 09/22/2012 02:04 PM, Eric Anholt wrote: >> This makes a giant pile of code newly dead. It also fixes TXB on newer >> chipsets, which has been totally broken (I now have a piglit test for that). >> It passes the same set of Ian's ARB_fragment_program tests. It also i

Re: [Mesa-dev] [PATCH 7/7] i965: Don't spill "smeared" registers.

Paul Berry writes: > On 19 September 2012 13:28, Kenneth Graunke wrote: >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp >> b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp >> index e7f11ae..a819ae0 100644 >> --- a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp >> +++ b/sr

Re: [Mesa-dev] [PATCH 6/7] i965: Complain about variable index lowering when INTEL_DEBUG=perf.

Kenneth Graunke writes: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > Admittedly most of the other messages from INTEL_DEBUG=perf are hints for > application developers while this is a res

Re: [Mesa-dev] [PATCH 1/7] i965: Create local temporaries for depth buffer slice dimensions.

Kenneth Graunke writes: > We use these in a couple of places, and slice_width/height is a lot > shorter than mt->level[depth_irb->mt_level].width. Saves a few > dereferences as well. I think we could just use fb->Width/fb->Height, which would similarly save on typing. pgp2sBy6LvGB3.pgp Descri

Re: [Mesa-dev] [PATCH 06/10] i965: Reduce maximum GL_ARB_fragment_program instruction count to 1024.

Ian Romanick writes: > On 09/24/2012 12:06 PM, Kenneth Graunke wrote: >> On 09/22/2012 02:04 PM, Eric Anholt wrote: >>> I don't know of any programs that would need more than this. The larger >>> programs I've seen have neared 100 instructions. This prevent excessive >>> runtimes of automatic t

Re: [Mesa-dev] [PATCH 3/7] i965/fs: Use the sampler for FS pull constant loading on Ivybridge.

Kenneth Graunke writes: > Data port reads are absurdly slow on Ivybridge due to cache issues. > > The LD message ignores the sampler unit index and SAMPLER_STATE pointer, > instead relying on hard-wired default state. Thus, there's no need to > worry about running out of sampler units or providi

Re: [Mesa-dev] [PATCH] intel: Fix yet-another-bug in intel_texsubimage_tiled_memcpy

Chad Versace writes: > The most recent commit that touched this function, > > commit 88836663ac3baaf156e84584674aac7dcbfc7e95 > Author: Chad Versace > Date: Wed Sep 26 11:05:12 2012 -0700 > > intel: Fix segfault in intel_texsubimage_tiled_memcpy > > did fix the segfault, bu

[Mesa-dev] [Bug 28304] build fails on nouveau_stateobj.h

https://bugs.freedesktop.org/show_bug.cgi?id=28304 Matt Turner changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 52435] Classic DRI drivers fail to install when libdricore8.1.0.so isn't already in the system

https://bugs.freedesktop.org/show_bug.cgi?id=52435 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

On 09/27/2012 06:28 AM, Brian Paul wrote: Looks good to me, Oliver. Reviewed-by: Brian Paul One question below... On 09/27/2012 02:56 AM, Oliver McFadden wrote: Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx

[Mesa-dev] [Bug 21979] glBlendEquationSeparate not exported in linux-x86 builds

https://bugs.freedesktop.org/show_bug.cgi?id=21979 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 34455] sed in mesa Makefile: expanded PC_LIB_PRIV might contain comma

https://bugs.freedesktop.org/show_bug.cgi?id=34455 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 45444] Compilation error with git 6386f80dbd6f1230abf16fa5ac65dc0dca70033a

https://bugs.freedesktop.org/show_bug.cgi?id=45444 Matt Turner changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [PATCH 00/16] Automake patches for 9.0

These 16 patches (some from my automake-gallium work) should be suitable for master and 9.0. Please review. Thanks, Matt ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 16/16] build: Don't build libdricore if not building classic drivers

--- configure.ac |1 + src/mesa/Makefile.am |6 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3cc4377..69ceb05 100644 --- a/configure.ac +++ b/configure.ac @@ -1102,6 +1102,7 @@ if test "x$enable_dri" = xyes; then DRI_L

[Mesa-dev] [PATCH 15/16] libdricore: Remove dead C(XX)FLAGS_NOVISIBILITY

--- src/mesa/libdricore/Makefile.am |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/libdricore/Makefile.am b/src/mesa/libdricore/Makefile.am index 897aeda..efd836e 100644 --- a/src/mesa/libdricore/Makefile.am +++ b/src/mesa/libdricore/Makefile.am @@ -30,11 +

[Mesa-dev] [PATCH 14/16] build: Add visibility CFLAGS to OSMesa

--- src/mesa/drivers/osmesa/Makefile.am |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/osmesa/Makefile.am b/src/mesa/drivers/osmesa/Makefile.am index 21b8dfb..c4b178b 100644 --- a/src/mesa/drivers/osmesa/Makefile.am +++ b/src/mesa/drivers/osmesa/Mak

[Mesa-dev] [PATCH 13/16] build: Link OSMesa with glapi, libdl, libstdc++

Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=399813 https://bugs.freedesktop.org/show_bug.cgi?id=53179 --- src/mesa/drivers/osmesa/Makefile.am | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/osmesa/Makefile.am b/src/mesa/dr

[Mesa-dev] [PATCH 12/16] build: Set visibility CFLAGS in dri/swrast

--- src/mesa/drivers/dri/swrast/Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/swrast/Makefile.am b/src/mesa/drivers/dri/swrast/Makefile.am index 16a3441..244aa8b 100644 --- a/src/mesa/drivers/dri/swrast/Makefile.am +++ b/src/mesa/drive

[Mesa-dev] [PATCH 11/16] build: Set visibility CFLAGS in dri/r200

--- src/mesa/drivers/dri/r200/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/r200/Makefile.am b/src/mesa/drivers/dri/r200/Makefile.am index 5ec53de..1819f17 100644 --- a/src/mesa/drivers/dri/r200/Makefile.am +++ b/src/mesa/drivers/dri/r20

[Mesa-dev] [PATCH 10/16] build: Set visibility CFLAGS in dri/radeon

--- src/mesa/drivers/dri/radeon/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/Makefile.am b/src/mesa/drivers/dri/radeon/Makefile.am index ec2d42e..3980f92 100644 --- a/src/mesa/drivers/dri/radeon/Makefile.am +++ b/src/mesa/drivers

[Mesa-dev] [PATCH 09/16] build: Set visibility CFLAGS in dri/nouveau

--- src/mesa/drivers/dri/nouveau/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/nouveau/Makefile.am b/src/mesa/drivers/dri/nouveau/Makefile.am index 82d3804..a1c2068 100644 --- a/src/mesa/drivers/dri/nouveau/Makefile.am +++ b/src/mesa/dri

[Mesa-dev] [PATCH 08/16] build: Set visibility CFLAGS in dri/i915

--- src/mesa/drivers/dri/i915/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i915/Makefile.am b/src/mesa/drivers/dri/i915/Makefile.am index 7ec4c22..85bb09e 100644 --- a/src/mesa/drivers/dri/i915/Makefile.am +++ b/src/mesa/drivers/dri/i91

[Mesa-dev] [PATCH 07/16] build: Set visibility CFLAGS in dri/common

--- src/mesa/drivers/dri/common/Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/common/Makefile.am b/src/mesa/drivers/dri/common/Makefile.am index 6e9d738..a662919 100644 --- a/src/mesa/drivers/dri/common/Makefile.am +++ b/src/mesa/drive

[Mesa-dev] [PATCH 06/16] build: Build src/glsl with visibility CFLAGS

--- src/glsl/Makefile.am |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index 20639c9..1ecc003 100644 --- a/src/glsl/Makefile.am +++ b/src/glsl/Makefile.am @@ -23,7 +23,7 @@ # builtin_compiler is built before libglsl to ge

[Mesa-dev] [PATCH 05/16] build: Turn on visibility CFLAGS for core mesa

--- src/mesa/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am index 8e4530d..a76df8c 100644 --- a/src/mesa/Makefile.am +++ b/src/mesa/Makefile.am @@ -94,8 +94,8 @@ BUILDDIR = $(top_builddir)/src/mesa/ include sourc

[Mesa-dev] [PATCH 04/16] build: Order src/Makefile correctly

--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 0dd189a..3cc4377 100644 --- a/configure.ac +++ b/configure.ac @@ -1951,6 +1951,7 @@ CXXFLAGS="$CXXFLAGS $USER_CXXFLAGS" dnl Substitute the config AC_CONFIG_FILES([configs/

[Mesa-dev] [PATCH 03/16] build: Use AX_PTHREAD's HAVE_PTHREAD preprocessor definition

--- Android.common.mk |2 +- configure.ac| 12 ++-- docs/dispatch.html |2 +- scons/gallium.py|2 +- src/egl/main/eglcurrent.c |6 +++--- src/egl/main/eglmutex.h |2 +-

[Mesa-dev] [PATCH 02/16] build: Use PTHREAD_LIBS and PTHREAD_CFLAGS

--- configure.ac| 32 +++--- src/glsl/tests/Makefile.am |8 -- src/glx/tests/Makefile.am |3 +- src/mapi/glapi/tests/Makefile.am|3 +- src/mapi/shared-glapi/tests/Makefile.am |3 +- src/mes

[Mesa-dev] [PATCH 01/16] build: Set PTHREAD_LIBS for pkgconfig files if empty

--- configure.ac |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 896f98a..b67655d 100644 --- a/configure.ac +++ b/configure.ac @@ -509,6 +509,10 @@ AC_CHECK_DECLS([signbit],[], dnl Check for pthreads AX_PTHREAD +dnl AX_PTHREADS leav

Re: [Mesa-dev] [PATCH] meta: Use float for temporary images, not (un)signed normalized.

On 09/17/2012 11:38 AM, Jordan Justen wrote: > Does this cause any regressions for the packed-px-uint test? > > -Jordan No it doesn't. Since it's been 12 days and there were no other comments, I'm pushing it without any review tags. ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH v3 1/3] main/version: consolodate version string creation for ES/Desktop GL

On 09/04/2012 09:00 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Reviewed-by: Chad Versace Patches 1-2 are: Reviewed-by: Kenneth Graunke ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH 11/19] glx: Replace DRI2WaitForSBC custom protocol with XCB.

I would have used the checked variant of the xcb call, xcb_dri2_wait_xbc, and then returned 1 if an error had occured. Why did you choose to use the unchecked variant? I'm aware that the old DRI2WaitSBC also always blindly returned success, but is there justification for the new code to also do th

Re: [Mesa-dev] [PATCH 10/19] glx/dri1: Remove uncompiled __DRI_SWAP_BUFFER_COUNTER code.

On first readthrough, I thought "OMG, glXGetSyncValuesOML must segfault because the function pointer is never set." But, it's actually implemented with dri2DrawableGetMSC, so all is good. Reviewed-by: Chad Versace On 09/25/2012 07:50 PM, Eric Anholt wrote: > It's been in place but never enabled

Re: [Mesa-dev] [PATCH 09/19] egl: Quit checking for a bug in old xcb when we require new xcb.

Patches 8-9 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/19] egl: Unifdef dri_interface.h defines.

I'm up to patch 7 now. Patches 1-7 are Reviewed-by: Chad Versace I'm still working on the other patches. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] intel: Don't advertise GLX_SWAP_COPY_OML

Chad Versace writes: > On 08/14/2012 11:09 AM, Ian Romanick wrote: >> On 08/13/2012 08:43 AM, Eric Anholt wrote: >>> Ian Romanick writes: The tail should not wag the dog. If the application requests such a config, we should not page flip. There are cases where the copy is prefera

Re: [Mesa-dev] Adding support for sRGB framebuffers to EGL

I failed to consider that premultiplied sRGB color channels can be stored two ways. The friendly way, to_srgb_gamma(color * alpha) and what applications actually use, to_srgb_gamma(color) * alpha. That might affect this proposal. On Thu, Sep 27, 2012 at 3:49 PM, Brian Paul wrote: > Just some quic

Re: [Mesa-dev] [PATCH 1/2] i965: Don't leave dangling pointer to brw context on failure

On 09/26/2012 11:12 AM, Ian Romanick wrote: > From: Ian Romanick > > Otherwise intelDestroyContext would try to dereference the pointer to > freed memory. > > v2: Don't call intelDestroyContext if the context already freed due to > failure. > > NOTE: This is a candidate for the 9.0 branch. > >

[Mesa-dev] [PATCH] intel: Fix yet-another-bug in intel_texsubimage_tiled_memcpy

The most recent commit that touched this function, commit 88836663ac3baaf156e84584674aac7dcbfc7e95 Author: Chad Versace Date: Wed Sep 26 11:05:12 2012 -0700 intel: Fix segfault in intel_texsubimage_tiled_memcpy did fix the segfault, but introduced yet another bug. From Anh

Re: [Mesa-dev] Mesa (master): intel: Fix segfault in intel_texsubimage_tiled_memcpy

On 09/27/2012 09:49 AM, Eric Anholt wrote: > Chad Versace writes: > >> Module: Mesa >> Branch: master >> Commit: b1d0fe022dc4826dadce014ab8fe062a82f75a16 >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1d0fe022dc4826dadce014ab8fe062a82f75a16 >> >> Author: Chad Versace >> Date:

Re: [Mesa-dev] [PATCH] i915: Don't leave dangling pointer to i915 context on failure

Ian Romanick writes: > From: Ian Romanick > > Otherwise intelDestroyContext would try to dereference the pointer to > freed memory. Does DestroyContext get called out of all these error paths? If so, why not just remove our freeing? pgp2rPWph3DFA.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH] intel/i965: Disable SampleAlphaToOne if dual source blending enabled

Anuj Phogat writes: > From SandyBridge PRM, volume 2 Part 1, section 12.2.3, BLEND_STATE: > DWord 1, Bit 30 (AlphaToOne Enable): > "If Dual Source Blending is enabled, this bit must be disabled" This is the sort of thing I wish we had a WARN_ON_ONCE macro for. It's really obscure, but if someon

Re: [Mesa-dev] Mesa (master): intel: Fix segfault in intel_texsubimage_tiled_memcpy

Chad Versace writes: > Module: Mesa > Branch: master > Commit: b1d0fe022dc4826dadce014ab8fe062a82f75a16 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1d0fe022dc4826dadce014ab8fe062a82f75a16 > > Author: Chad Versace > Date: Wed Sep 26 11:05:12 2012 -0700 > > intel: Fix segfault

Re: [Mesa-dev] [PATCH] egl-util: Adds probe_front_pixel_rgb function

On Thu, Sep 20, 2012 at 8:59 AM, Robert Bragg wrote: > This adds an egl_probe_front_pixel_rgb function that is analogous to > piglit_probe_pixel_rgba except it probes the front buffer instead of > probing the back buffer. > --- > tests/egl/egl-util.c | 31 +++ > test

Re: [Mesa-dev] [PATCH 2/5] r600g: flush FMASK and CMASK when changing colorbuffers on Evergreen

On Wed, Sep 26, 2012 at 4:09 AM, Alex Deucher wrote: > > This actually exists on r7xx as well. > > 7xx has the following additional events compared to 6xx: > 43 - FLUSH_AND_INV_DB_DATA_TS > 44 - FLUSH_AND_INV_DB_META > 45 - FLUSH_AND_INV_CB_DATA_TS > 46 - FLUSH_AND_INV_CB_META Thanks for info. I

Re: [Mesa-dev] [PATCH v3 3/3] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

Jordan Justen writes: > Change the format to MAJOR.MINOR[FC] > For example: 2.1, 3.0FC, 3.1 > > The FC suffix indicates a forward compatible context, and > is only valid for versions >= 3.0. > > Examples: > 2.1: GL Legacy/Compatibility context > 3.0: GL Legacy/Compatibility context > 3.0FC: GL

Re: [Mesa-dev] Adding support for sRGB framebuffers to EGL

Just some quick comments. I think the term "GAMMA" should be omitted. I'm no expert but I'm not sure that sRGB is strictly a gamma function. The GL_EXT_texture_sRGB spec says "The sRGB color space roughly corresponds to 2.2 gamma correction." Also, the term GAMMA doesn't appear in any of th

Re: [Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

Looks good to me, Oliver. Reviewed-by: Brian Paul One question below... On 09/27/2012 02:56 AM, Oliver McFadden wrote: Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx/glxextensions.h |

[Mesa-dev] [PATCH] mesa: fix glCompressedSubTexture assertion/segfault

If the destination texture image doesn't exist we'd hit an assertion (or crash in a release build). The piglit/s3tc-errors test hits this. This has already been fixed in master by the error checking code consolidation. Note: This is a candidate for the 8.0 branch. --- src/mesa/main/teximage.c |

Re: [Mesa-dev] [PATCH] svga: Remove wierd code which forces non-sRGB formats.

On 09/26/2012 09:55 PM, John Kåre Alsaker wrote: On 9/25/12, Brian Paul wrote: On 09/24/2012 11:09 PM, John Kåre Alsaker wrote: On Mon, Sep 24, 2012 at 5:22 PM, Brian Paulmailto:bri...@vmware.com>> wrote: On 09/23/2012 05:44 AM, John Kåre Alsaker wrote: --- src/gal

Re: [Mesa-dev] Please test the automake-gallium branch

On 09/27/2012 12:19 AM, Kenneth Graunke wrote: On 09/26/2012 10:55 PM, Matt Turner wrote: On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke wrote: On 09/26/2012 04:09 PM, Matt Turner wrote: On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: Another issue is that the yacc-generated files are

[Mesa-dev] [PATCH v4 1/1] intel: add support for ANGLE_texture_compression_dxt.

Signed-off-by: Oliver McFadden --- v4: Off-by-one on a couple of 'if (ctx->Mesa_DXTn)' lines, which could cause a crash. src/glx/glxextensions.h |3 ++- src/mapi/glapi/gen/es_EXT.xml |6 ++ src/mesa/drivers/dri/intel/intel_extensions.c |1 +