[Mesa-dev] [PATCH] i965/vs: fix unit mismatch in base_offset.

2012-09-20 Thread Paul Berry
Callers of emit_scratch_{read,write}() pass a base_offset that is measured in bytes, but emit_scratch_{read,write}() was assuming it was measured in multiples of a complete register. As a result, a shader using a scratch read/write offset greater than zero (in practice, a shader containing more th

Re: [Mesa-dev] [PATCH] i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code

2012-09-20 Thread Paul Berry
On 20 September 2012 16:59, Kenneth Graunke wrote: > Given that it exists between a push/pop of instruction state, this call > can only affect the MOV or ADD instruction generated just below it. > Neither of those instructions are predicated, so it makes no sense to > ask for the inverse predicat

[Mesa-dev] [PATCH] i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code

2012-09-20 Thread Kenneth Graunke
Given that it exists between a push/pop of instruction state, this call can only affect the MOV or ADD instruction generated just below it. Neither of those instructions are predicated, so it makes no sense to ask for the inverse predicate. This fixes grumblings from the simulator debugger, which

[Mesa-dev] [PATCH] meta: Add on demand compilation of per target shader programs

2012-09-20 Thread Anuj Phogat
A call to glGenerateMipmap() follows the generation of a relevant shader program in setup_glsl_generate_mipmap(). To support all texture targets and to avoid compiling shaders everytime, per target shader programs are compiled on demand and saved for the next call. Fixes float-texture(mipmap.manu

Re: [Mesa-dev] [PATCH 2/2] i965/blorp: Add support for blits between SRGB and linear formats.

2012-09-20 Thread Kenneth Graunke
On 09/20/2012 02:05 PM, Paul Berry wrote: > > Ok, Ken and I just tried the test on an ATI system, and here's what we > found: > > - On his ATI system, you can't create sRGB buffers using > glRenderbufferStorage() or glRenderbufferStorageMultisample() (you get a > GL_INVALID_ENUM error, and then l

[Mesa-dev] [PATCH] mesa: Don't flatten IF statements by default.

2012-09-20 Thread Kenneth Graunke
MaxIfDepth of 0 means "flatten all the time", not "never flatten". This is only desirable on hardware that can't support control flow; software rasterization and most hardware drivers want this. This alters behavior for swrast as well as i915. Signed-off-by: Kenneth Graunke --- src/mesa/main/sh

Re: [Mesa-dev] [PATCH 2/2] i965/blorp: Add support for blits between SRGB and linear formats.

2012-09-20 Thread Paul Berry
On 18 September 2012 14:32, Paul Berry wrote: > On 17 September 2012 10:53, Paul Berry wrote: > >> On 17 September 2012 10:25, Ian Romanick wrote: >> >>> On 09/14/2012 02:56 AM, Paul Berry wrote: >>> On 11 September 2012 16:24, Kenneth Graunke >>> **> wrote: >

Re: [Mesa-dev] [PATCH] intel: Fix size of temporary etc1 buffer

2012-09-20 Thread Chad Versace
Adding Tapani to the CC list. Removing Oliver. On 09/20/2012 09:55 PM, Chad Versace wrote: > Fixes valgrind errors in piglit test > oes_compressed_etc1_rgb8_texture-miptree: an invalid write in > _mesa_store_compressed_store_texsubimage() at line 4406 and invalid reads > in texcompress_etc_tmp.h:e

[Mesa-dev] [PATCH] intel: Fix size of temporary etc1 buffer

2012-09-20 Thread Chad Versace
Fixes valgrind errors in piglit test oes_compressed_etc1_rgb8_texture-miptree: an invalid write in _mesa_store_compressed_store_texsubimage() at line 4406 and invalid reads in texcompress_etc_tmp.h:etc1_parse_block(). The calculation of the size of the temporary etc1 buffer allocated by intel_mipt

[Mesa-dev] [PATCH] intel: Improve teximage perf for Google Chrome paint rects (v3)

2012-09-20 Thread Chad Versace
This patch reduces the time spent in glTexImage and glTexSubImage by over 5x on Sandybridge for the workload described below. It adds a new fast path for glTexImage2D and glTexSubImage2D, intel_texsubimage_tiled_memcpy, which is optimized for Google Chrome's paint rectangles. The fast path is impl

Re: [Mesa-dev] [PATCH] intel: Improve teximage perf for Google Chrome paint rects

2012-09-20 Thread Chad Versace
On 09/14/2012 07:01 PM, Paul Berry wrote: > On 11 September 2012 12:04, Chad Versace wrote: >> + if (!image->mt || >> + image->mt->region->tiling != I915_TILING_X) { >> + /* The algorithm below is written only for X-tiled memory. >> + * >> + * Memcpy'ing to Y-tiled memory

Re: [Mesa-dev] [PATCH 00/13] misc docs clean-ups

2012-09-20 Thread Brian Paul
On 09/20/2012 12:51 PM, Andreas Boll wrote: 2012/9/20 Brian Paul: On 09/20/2012 10:33 AM, Andreas Boll wrote: Hi list, As requested by Brian [0] I've removed some old links. Furthermore I've cleaned up some other places. Please review. The patch series is also available at [1] I just had

Re: [Mesa-dev] [PATCH 00/13] misc docs clean-ups

2012-09-20 Thread Andreas Boll
2012/9/20 Brian Paul : > On 09/20/2012 10:33 AM, Andreas Boll wrote: >> >> Hi list, >> >> As requested by Brian [0] I've removed some old links. >> Furthermore I've cleaned up some other places. >> >> Please review. >> The patch series is also available at [1] > > > I just had two little comments.

Re: [Mesa-dev] [PATCH 00/13] misc docs clean-ups

2012-09-20 Thread Brian Paul
On 09/20/2012 10:33 AM, Andreas Boll wrote: Hi list, As requested by Brian [0] I've removed some old links. Furthermore I've cleaned up some other places. Please review. The patch series is also available at [1] I just had two little comments. Looks good otherwise. Thanks! Reviewed-by: Bri

Re: [Mesa-dev] [PATCH 13/13] docs: update some more FAQs

2012-09-20 Thread Brian Paul
On 09/20/2012 10:33 AM, Andreas Boll wrote: --- docs/faq.html | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/docs/faq.html b/docs/faq.html index 97b6491..3ee713b 100644 --- a/docs/faq.html +++ b/docs/faq.html @@ -16,7 +16,7 @@ Mesa F

Re: [Mesa-dev] [PATCH 06/13] docs: convert last traces of progs to mesa/demos repository

2012-09-20 Thread Brian Paul
On 09/20/2012 10:33 AM, Andreas Boll wrote: --- docs/osmesa.html |3 +-- docs/xlibdriver.html |8 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/osmesa.html b/docs/osmesa.html index 0ec67c4..8cc9714 100644 --- a/docs/osmesa.html +++ b/docs/osmesa.html

[Mesa-dev] [PATCH 13/13] docs: update some more FAQs

2012-09-20 Thread Andreas Boll
--- docs/faq.html | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/docs/faq.html b/docs/faq.html index 97b6491..3ee713b 100644 --- a/docs/faq.html +++ b/docs/faq.html @@ -16,7 +16,7 @@ Mesa Frequently Asked Questions -Last updated: 19 Septe

[Mesa-dev] [PATCH 12/13] docs: remove utility.html

2012-09-20 Thread Andreas Boll
This page is very old and some of the links are dead. --- docs/contents.html |1 - docs/utility.html | 43 --- 2 files changed, 0 insertions(+), 44 deletions(-) delete mode 100644 docs/utility.html diff --git a/docs/contents.html b/docs/contents.htm

[Mesa-dev] [PATCH 11/13] docs: remove science.html

2012-09-20 Thread Andreas Boll
This page is very old and some of the links are dead. --- docs/contents.html |1 - docs/science.html | 78 2 files changed, 0 insertions(+), 79 deletions(-) delete mode 100644 docs/science.html diff --git a/docs/contents.html b/docs/con

[Mesa-dev] [PATCH 10/13] docs: remove modelers.html

2012-09-20 Thread Andreas Boll
This page is very old and some of the links are dead. --- docs/contents.html |1 - docs/modelers.html | 72 2 files changed, 0 insertions(+), 73 deletions(-) delete mode 100644 docs/modelers.html diff --git a/docs/contents.html b/docs/co

[Mesa-dev] [PATCH 09/13] docs: remove libraries.html

2012-09-20 Thread Andreas Boll
This page is very old and some of the links are dead. --- docs/contents.html |1 - docs/libraries.html | 65 --- 2 files changed, 0 insertions(+), 66 deletions(-) delete mode 100644 docs/libraries.html diff --git a/docs/contents.html b/docs/

[Mesa-dev] [PATCH 08/13] docs: remove games.html

2012-09-20 Thread Andreas Boll
This page is very old and some of the links are dead. --- docs/contents.html |1 - docs/games.html| 72 2 files changed, 0 insertions(+), 73 deletions(-) delete mode 100644 docs/games.html diff --git a/docs/contents.html b/docs/conte

[Mesa-dev] [PATCH 07/13] docs/contents: add autoconf.html link

2012-09-20 Thread Andreas Boll
make it easier to find the docs/autoconf.html site --- docs/contents.html |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/docs/contents.html b/docs/contents.html index 94b538d..bdafea8 100644 --- a/docs/contents.html +++ b/docs/contents.html @@ -41,6 +41,10 @@ Downlo

[Mesa-dev] [PATCH 06/13] docs: convert last traces of progs to mesa/demos repository

2012-09-20 Thread Andreas Boll
--- docs/osmesa.html |3 +-- docs/xlibdriver.html |8 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/osmesa.html b/docs/osmesa.html index 0ec67c4..8cc9714 100644 --- a/docs/osmesa.html +++ b/docs/osmesa.html @@ -34,8 +34,7 @@ more information about the API

[Mesa-dev] [PATCH 05/13] docs: add IRC info

2012-09-20 Thread Andreas Boll
--- docs/lists.html |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/docs/lists.html b/docs/lists.html index 1c35037..0ac07fa 100644 --- a/docs/lists.html +++ b/docs/lists.html @@ -68,7 +68,12 @@ kernels, see the - +IRC + +join #dri-devel channel +on http://webc

[Mesa-dev] [PATCH 04/13] docs/egl: improve markup

2012-09-20 Thread Andreas Boll
replace unordered list with defined list --- docs/egl.html | 88 +--- 1 files changed, 52 insertions(+), 36 deletions(-) diff --git a/docs/egl.html b/docs/egl.html index a77c12f..240cec5 100644 --- a/docs/egl.html +++ b/docs/egl.html @@ -60,

[Mesa-dev] [PATCH 03/13] docs/autoconf: improve markup

2012-09-20 Thread Andreas Boll
replace unordered list with defined list --- docs/autoconf.html | 106 1 files changed, 65 insertions(+), 41 deletions(-) diff --git a/docs/autoconf.html b/docs/autoconf.html index d707e60..a07a3ee 100644 --- a/docs/autoconf.html +++ b/docs/

[Mesa-dev] [PATCH 02/13] docs/autoconf: remove obsolete demo options

2012-09-20 Thread Andreas Boll
removed with commit 56c3cce2a199f7f79a48d7633431e1e80fcd4ba2 two years ago --- docs/autoconf.html | 21 - 1 files changed, 0 insertions(+), 21 deletions(-) diff --git a/docs/autoconf.html b/docs/autoconf.html index 0210bd1..d707e60 100644 --- a/docs/autoconf.html +++ b/docs/

[Mesa-dev] [PATCH 01/13] docs: improve quality of gears.png

2012-09-20 Thread Andreas Boll
--- removed binary data patch for review docs/gears.png | Bin 1608 -> 3467 bytes 1 files changed, 0 insertions(+), 0 deletions(-) -- 1.7.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-

[Mesa-dev] [PATCH 00/13] misc docs clean-ups

2012-09-20 Thread Andreas Boll
Hi list, As requested by Brian [0] I've removed some old links. Furthermore I've cleaned up some other places. Please review. The patch series is also available at [1] Andreas. [0] http://lists.freedesktop.org/archives/mesa-dev/2012-September/027639.html [1] http://cgit.freedesktop.org/~ab/mesa

[Mesa-dev] [PATCH] egl-nok-swap-region: probe front not back buffer

2012-09-20 Thread Robert Bragg
The egl-nok-swap-buffer was mistakenly reading the back buffer to test the correctness of eglSwapRegionNOK but once the second glClear() to red has been issued the whole back buffer is red and so the test would always passed since it only probed points it expected to be red anyway. This patch now

[Mesa-dev] [PATCH] egl-util: Adds probe_front_pixel_rgb function

2012-09-20 Thread Robert Bragg
This adds an egl_probe_front_pixel_rgb function that is analogous to piglit_probe_pixel_rgba except it probes the front buffer instead of probing the back buffer. --- tests/egl/egl-util.c | 31 +++ tests/egl/egl-util.h |4 2 files changed, 35 insertions(+), 0

Re: [Mesa-dev] [PATCH 1/2] egl-util: Adds probe_front_pixel_rgb function

2012-09-20 Thread Robert Bragg
On Thu, Sep 20, 2012 at 3:34 PM, Brian Paul wrote: > On 09/20/2012 07:21 AM, Robert Bragg wrote: >> >> This adds an egl_probe_front_pixel_rgb function that is analogous to >> piglit_probe_pixel_rgba except it probes the front buffer instead of >> probing the back buffer. >> --- >> tests/egl/egl-

[Mesa-dev] [Bug 55117] [llvmpipe] piglit tex3d-maxsize regression

2012-09-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55117 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH] llvmpipe: fix overflow bug in total texture size computation

2012-09-20 Thread Jose Fonseca
Looks good to me. Thanks. Jose - Original Message - > v2: use uint64_t for the total_size variable, per Jose. > > Also add two earlier checks for exceeding the max texture size. > For example a 1K^3 RGBA volume would overflow the lpr->image_stride > variable. > > Use simple algebra to a

[Mesa-dev] [PATCH] llvmpipe: fix overflow bug in total texture size computation

2012-09-20 Thread Brian Paul
v2: use uint64_t for the total_size variable, per Jose. Also add two earlier checks for exceeding the max texture size. For example a 1K^3 RGBA volume would overflow the lpr->image_stride variable. Use simple algebra to avoid overflow in intermediate values. So instead of "x * y > z" use "x > z /

Re: [Mesa-dev] [PATCH 2/2] egl-nok-swap-region: probe front not back buffer

2012-09-20 Thread Brian Paul
On 09/20/2012 07:21 AM, Robert Bragg wrote: The egl-nok-swap-buffer was mistakenly reading the back buffer to test the correctness of eglSwapRegionNOK but once the second glClear() to red has been issued the whole back buffer is red and so the test would always passed since it only probed points

Re: [Mesa-dev] [PATCH 1/2] egl-util: Adds probe_front_pixel_rgb function

2012-09-20 Thread Brian Paul
On 09/20/2012 07:21 AM, Robert Bragg wrote: This adds an egl_probe_front_pixel_rgb function that is analogous to piglit_probe_pixel_rgba except it probes the front buffer instead of probing the back buffer. --- tests/egl/egl-util.c | 30 ++ tests/egl/egl-util.h |

Re: [Mesa-dev] [PATCH] llvmpipe: fix overflow bug in total texture size computation

2012-09-20 Thread Brian Paul
On 09/20/2012 05:15 AM, Jose Fonseca wrote: Good find. Stride could be bigger than 1024 yet not a 1024 multiple. I explored using a 1024 scale factor, and it works (it wasn't based on stride), but just using uint64_t is much simpler. I think it would be simpler to use uint64_t. Should cove

Re: [Mesa-dev] [PATCH] mesa: Don't override S3TC internalFormat if data is pre-compressed.

2012-09-20 Thread Ian Romanick
On 09/19/2012 09:01 PM, Kenneth Graunke wrote: Commit 42723d88d intended to override an S3TC internalFormat to a generic compressed format when the application requested online compression of uncompressed data. Unfortunately, it also broke pre-compressed textures when libtxc_dxtn isn't installed

Re: [Mesa-dev] [PATCH 2/2] egl-nok-swap-region: probe front not back buffer

2012-09-20 Thread Robert Bragg
Ah, I only just realized there is a separate list for piglit tests, sorry. Hopefully it's ok to review these here this time, but I'll remember to send piglit patches to the right list in the future. regards, - Robert On Thu, Sep 20, 2012 at 2:21 PM, Robert Bragg wrote: > The egl-nok-swap-buffer

[Mesa-dev] [PATCH 2/2] egl-nok-swap-region: probe front not back buffer

2012-09-20 Thread Robert Bragg
The egl-nok-swap-buffer was mistakenly reading the back buffer to test the correctness of eglSwapRegionNOK but once the second glClear() to red has been issued the whole back buffer is red and so the test would always passed since it only probed points it expected to be red anyway. This patch now

[Mesa-dev] [PATCH 1/2] egl-util: Adds probe_front_pixel_rgb function

2012-09-20 Thread Robert Bragg
This adds an egl_probe_front_pixel_rgb function that is analogous to piglit_probe_pixel_rgba except it probes the front buffer instead of probing the back buffer. --- tests/egl/egl-util.c | 30 ++ tests/egl/egl-util.h |4 2 files changed, 34 insertions(+), 0

Re: [Mesa-dev] [PATCH] llvmpipe: fix overflow bug in total texture size computation

2012-09-20 Thread Jose Fonseca
Good find. Stride could be bigger than 1024 yet not a 1024 multiple. I think it would be simpler to use uint64_t. Should cover all cases. Jose - Original Message - > > The particular failing case was a 1024^3 3D texture. > 1024*1024*1024*4 > (RGBA) = 4GB which overflows to zero in a 3