On 09/20/2012 02:05 PM, Paul Berry wrote: > > Ok, Ken and I just tried the test on an ATI system, and here's what we > found: > > - On his ATI system, you can't create sRGB buffers using > glRenderbufferStorage() or glRenderbufferStorageMultisample() (you get a > GL_INVALID_ENUM error, and then later the driver crashes). This appears > to be a driver bug. Fortunately However you *can* create sRGB textures > and attach them to framebuffers. So we modified the test to create the > single-sampled buffers using textures, create the linear MSAA buffer > using glRenderbufferStorageMultisample(), and skip the sRGB MSAA buffer. > - With these changes, the ATI system behaves the same as the nVidia system. > > That's enough to convince me. Ken, you can consider both of your patches: > > Reviewed-by: Paul Berry <stereotype...@gmail.com > <mailto:stereotype...@gmail.com>> > > I'll take responsibility for updating my test with pass/fail criteria > (I'll also update the test to test both textures and renderbuffers, > since Mesa blits use different code paths for those two possibilities). > And I'll make any remaining Mesa fixes that are necessary to get the > test to pass.
Thanks so much for your thorough investigation here, Paul. I've pushed these patches with a note that nVidia and AMD both have this behavior. I plan to cherry-pick them to 9.0 on Monday if there's no objections. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
