[Mesa-dev] [PATCH 4/4] vbo: optimize validation for glMultiDrawElements

2012-06-26 Thread Marek Olšák
Some parameters need to be checked only once. check_valid_to_render needs to be called only once. The validate function is based on the one for DrawElements. --- src/mesa/main/api_validate.c | 70 + src/mesa/main/api_validate.h |6 src/mesa/vbo

[Mesa-dev] [PATCH 1/4] mesa: rename MaxTransformFeedbackSeparateAttribs to MaxTransformFeedbackBuffers

2012-06-26 Thread Marek Olšák
This is a cleanup for ARB_transform_feedback3, where GL_MAX_TRANSFORM_FEEDBACK_BUFFERS is introduced for interleaved attribs and has the same meaning as GL_MAX_.._SEPARATE_ATTRIBS for separate attribs. Also, the maximum number of TFB buffers is reduced from 32 to 4, which makes this patch useful e

[Mesa-dev] [PATCH 3/4] vbo: first ASSERT_OUTSIDE_BEGIN_END then FLUSH, not the other way around

2012-06-26 Thread Marek Olšák
--- src/mesa/main/api_validate.c | 12 ++-- src/mesa/vbo/vbo_exec_array.c | 22 -- 2 files changed, 6 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index 02495a1..ec47f1d 100644 --- a/src/mesa/main/api_vali

[Mesa-dev] [PATCH 2/4] vbo: don't call twice _mesa_valid_to_render in DrawArraysInstancedBaseInstance

2012-06-26 Thread Marek Olšák
It's called in _mesa_validate_DrawArraysInstanced already. --- src/mesa/vbo/vbo_exec_array.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index ebf0085..e80a68b 100644 --- a/src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH 7/7] r600g: implement TIMESTAMP query

2012-06-26 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c |1 + src/gallium/drivers/r600/r600_query.c | 17 - 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 435aa77..c5d282a 100644 --- a/src/ga

[Mesa-dev] [PATCH 6/7] gallium: implement what's left for TIMESTAMP query

2012-06-26 Thread Marek Olšák
--- src/gallium/include/pipe/p_defines.h|3 ++- src/mesa/state_tracker/st_cb_queryobj.c |5 + src/mesa/state_tracker/st_extensions.c |7 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_de

[Mesa-dev] [PATCH 5/7] mesa: add ARB_timer_query to the extension list

2012-06-26 Thread Marek Olšák
--- src/mesa/main/extensions.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index e4fe733..6603f5d 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -139,6 +139,7 @@ static const struct extension extension_

[Mesa-dev] [PATCH 4/7] mesa: implement glGet(GL_TIMESTAMP)

2012-06-26 Thread Marek Olšák
--- src/mesa/main/get.c | 10 src/mesa/main/mtypes.h |1 + src/mesa/main/queryobj.c | 61 ++ src/mesa/main/queryobj.h |5 4 files changed, 77 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 677

[Mesa-dev] [PATCH 3/7] mesa: add QueryCounter display list support

2012-06-26 Thread Marek Olšák
--- src/mesa/main/dlist.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index a0d84cf..a827d13 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -469,6 +469,9 @@ typedef enum OPCODE_BEGIN_CONDITIONA

[Mesa-dev] [PATCH 2/7] mesa: implement TIMESTAMP query and glQueryCounter

2012-06-26 Thread Marek Olšák
--- src/mesa/main/queryobj.c | 78 ++ 1 file changed, 72 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index f0a9a79..cb50784 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -353

[Mesa-dev] [PATCH 1/7] glapi: add ARB_timer_query

2012-06-26 Thread Marek Olšák
--- src/mapi/glapi/gen/gl_API.xml | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index af05135..7ac3568 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@ -798

[Mesa-dev] [PATCH 0/7] GL_TIMESTAMP and GL_ARB_timer_query

2012-06-26 Thread Marek Olšák
Hi everyone, this series implements the GL_TIMESTAMP query, the last missing feature for GL_ARB_timer_query. I am not 100% sure about my approach to implementing glGet(GL_TIMESTAMP) and whether there is a better way. There are tests for this on the piglit mailing list and they pass. Please rev

Re: [Mesa-dev] [PATCH 07/13] mesa pack: handle packed integer formats with clamping

2012-06-26 Thread Jordan Justen
On Tue, Jun 26, 2012 at 2:35 PM, Brian Paul wrote: > On 06/25/2012 06:34 PM, Jordan Justen wrote: >> >> pack_int_cases_tmp.h is included in two places: >> _mesa_pack_rgba_span_from_ints with GLint rgba[][4] >>   and >> _mesa_pack_rgba_span_from_uints with GLuint rgba[][4] >> >> Signed-off-by: Jord

Re: [Mesa-dev] [PATCH] r600g: improve flushed depth texture handling v2

2012-06-26 Thread Alex Deucher
On Tue, Jun 26, 2012 at 7:34 PM, Vadim Girlin wrote: > Use r600_resource_texture::flished_depth_texture for GPU access, and > allocate it in the VRAM. For transfers we'll allocate untiled texture in the > GTT and store it in the r600_transfer::staging. > > Improves performance when flushed depth t

[Mesa-dev] [PATCH] r600g: improve flushed depth texture handling v2

2012-06-26 Thread Vadim Girlin
Use r600_resource_texture::flished_depth_texture for GPU access, and allocate it in the VRAM. For transfers we'll allocate untiled texture in the GTT and store it in the r600_transfer::staging. Improves performance when flushed depth texture is frequently used by the GPU (about 30% for Lightsmark)

Re: [Mesa-dev] [PATCH 02/13] mesa: use integers in glReadPixels for GL_RGBA with integer types

2012-06-26 Thread Jordan Justen
On Tue, Jun 26, 2012 at 2:34 PM, Brian Paul wrote: > On 06/25/2012 06:34 PM, Jordan Justen wrote: >> >> Previously if a format of GL_RGBA was used, then float data would >> be returned, even if the type was an integer type. >> >> Signed-off-by: Jordan Justen >> --- >>  src/mesa/main/readpix.c |  

Re: [Mesa-dev] [PATCH 13/13] i965: add ARB_texture_rgb10_a2ui support

2012-06-26 Thread Matt Turner
On Mon, Jun 25, 2012 at 8:34 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- Probably want to update docs/GL3.txt too. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: return 120 for PIPE_CAP_GLSL_FEATURE_LEVEL

2012-06-26 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Wed, Jun 27, 2012 at 12:53 AM, Brian Paul wrote: > --- >  src/gallium/drivers/llvmpipe/lp_screen.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c > b/src/gallium/drivers/

[Mesa-dev] [PATCH 2/2] svga: return 120 for PIPE_CAP_GLSL_FEATURE_LEVEL

2012-06-26 Thread Brian Paul
--- src/gallium/drivers/svga/svga_screen.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 09d7646..70a2530 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drive

[Mesa-dev] [PATCH 1/2] llvmpipe: return 120 for PIPE_CAP_GLSL_FEATURE_LEVEL

2012-06-26 Thread Brian Paul
--- src/gallium/drivers/llvmpipe/lp_screen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index e66737b..33fa241 100644 --- a/src/gallium/drivers/llvmpipe/lp_screen.c +++ b/src/gallium

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
On 06/26/2012 04:44 PM, Marek Olšák wrote: On Wed, Jun 27, 2012 at 12:22 AM, Olivier Galibert wrote: On Tue, Jun 26, 2012 at 02:46:01PM -0600, Brian Paul wrote: As with the previous commit for softpipe. v2: remove 'default' case to get compile-time warning --- src/gallium/drivers/llvmpipe/l

Re: [Mesa-dev] [PATCH 2/3] glsl: glcpp: Move handling of #line directives from lexer to parser.

2012-06-26 Thread Carl Worth
Kenneth Graunke writes: > Sorry for the extremely late review. (Lost this one in the inbox.) No problem at all. > Could yylineno and yylloc->source be set directly from the rules, rather > than using flags and setting them here? It seems like they could, but I > imagine you tried that and it d

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Marek Olšák
On Wed, Jun 27, 2012 at 12:22 AM, Olivier Galibert wrote: > On Tue, Jun 26, 2012 at 02:46:01PM -0600, Brian Paul wrote: >> As with the previous commit for softpipe. >> >> v2: remove 'default' case to get compile-time warning >> --- >>  src/gallium/drivers/llvmpipe/lp_screen.c |   52 >> ++

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Olivier Galibert
On Tue, Jun 26, 2012 at 02:46:01PM -0600, Brian Paul wrote: > As with the previous commit for softpipe. > > v2: remove 'default' case to get compile-time warning > --- > src/gallium/drivers/llvmpipe/lp_screen.c | 52 +++-- > 1 files changed, 48 insertions(+), 4 deletions

Re: [Mesa-dev] [PATCH v2 00/21] ARB_sampler_object and minor fixes

2012-06-26 Thread Brian Paul
On 06/12/2012 12:38 PM, Pauli Nieminen wrote: I updated patches based on review comments and run piglit for swrast. There is also new patch to fix sampler object binding to update shared state in share group. Too bad swrast fails randomly all tests that use front buffer because tests aren't wait

Re: [Mesa-dev] [PATCH 13/13] i965: add ARB_texture_rgb10_a2ui support

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |1 + src/mesa/drivers/dri/intel/intel_extensions.c|1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

Re: [Mesa-dev] [PATCH 12/13] mesa: allow CopyTexSubImage on integer formats

2012-06-26 Thread Brian Paul
One nit: the commit message should say "meta" not "mesa". Reviewed-by: Brian Paul On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/drivers/common/meta.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/dri

Re: [Mesa-dev] [PATCH 11/13] mesa formats: add MESA_FORMAT_ABGR2101010_UINT

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/format_pack.c | 28 + src/mesa/main/format_unpack.c | 35 + src/mesa/main/formats.c | 15 + src/mesa/main/formats.h |1 + src/mesa/

Re: [Mesa-dev] [PATCH 10/13] mesa texstore: handle signed/unsigned integer clamping

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/texstore.c | 95 -- 1 file changed, 75 insertions(+), 20 deletions(-) Reviewed-by: Brian Paul ___ mesa-dev m

Re: [Mesa-dev] [PATCH 09/13] GetTexImage: handle signed/unsigned integer clamping

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/texgetimage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 5d2f4da..06d4464 100644 --- a/src/mesa/m

Re: [Mesa-dev] [PATCH 07/13] mesa pack: handle packed integer formats with clamping

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: pack_int_cases_tmp.h is included in two places: _mesa_pack_rgba_span_from_ints with GLint rgba[][4] and _mesa_pack_rgba_span_from_uints with GLuint rgba[][4] Signed-off-by: Jordan Justen --- src/mesa/main/pack.c |6 + src/mesa/

Re: [Mesa-dev] [PATCH 06/13] mesa pack: handle uint and int clamping properly

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Rename _mesa_pack_rgba_span_int to _mesa_pack_rgba_span_from_uints. Add _mesa_pack_rgba_span_from_ints. These separate routines allow the integer clamping to be handled properly for signed versus unsigned integers. Reviewed-by: Brian Paul ___

Re: [Mesa-dev] [PATCH 05/13] mesa formats: allow non-integer formats to be used for integer packing

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: For example format=GL_RGBA with type=GL_UNSIGNED_BYTE will be treated the same as format=GL_RGBA_INTEGER_EXT with type=GL_UNSIGNED_BYTE. In what context would this happen? If this would be with a glReadPixels or glGetTexImage I'm not sure this is t

Re: [Mesa-dev] [PATCH 04/13] mesa formats: unpack ARGB8888/XRGB8888

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/mesa/main/format_unpack.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c index c42bac1..d1daae5 100644 ---

Re: [Mesa-dev] [PATCH 03/13] mesa: use _mesa_problem instead of assert for unsupported format/types

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: For unsupported formats& types, use _mesa_problem, rather than assert. Signed-off-by: Jordan Justen --- src/mesa/main/pack.c | 17 ++--- src/mesa/main/pack_tmp.h |9 - 2 files changed, 18 insertions(+), 8 deletions(-

Re: [Mesa-dev] [PATCH 02/13] mesa: use integers in glReadPixels for GL_RGBA with integer types

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: Previously if a format of GL_RGBA was used, then float data would be returned, even if the type was an integer type. Signed-off-by: Jordan Justen --- src/mesa/main/readpix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH 01/13] mesa formats: add integer type/format detection routines

2012-06-26 Thread Brian Paul
On 06/25/2012 06:34 PM, Jordan Justen wrote: _mesa_is_integer_format is moved to formats.c and renamed as _mesa_is_enum_format_integer. _mesa_is_format_unsigned, _mesa_is_type_integer, _mesa_is_type_unsigned, and _mesa_is_enum_format_or_type_integer are added. Signed-off-by: Jordan Justen ---

[Mesa-dev] [PATCH 9/9] softpipe: fix numFragsEmitted debug code

2012-06-26 Thread Brian Paul
--- src/gallium/drivers/softpipe/sp_setup.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_setup.c b/src/gallium/drivers/softpipe/sp_setup.c index 6b15c87..8cb4fc1 100644 --- a/src/gallium/drivers/softpipe/sp_setup.c +++ b/src/galliu

[Mesa-dev] [PATCH 8/9] gallium: minor whitespace, comment changes

2012-06-26 Thread Brian Paul
--- src/gallium/include/pipe/p_screen.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index b4a7f01..164e54d 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_sc

[Mesa-dev] [PATCH 7/9] mesa: update glext.h to version 81

2012-06-26 Thread Brian Paul
--- include/GL/glext.h | 411 ++-- 1 files changed, 368 insertions(+), 43 deletions(-) diff --git a/include/GL/glext.h b/include/GL/glext.h index 113241e..8fce0f6 100644 --- a/include/GL/glext.h +++ b/include/GL/glext.h @@ -6,7 +6,7 @@ extern "C" {

[Mesa-dev] [PATCH 6/9] mesa: update glxext.h to version 33

2012-06-26 Thread Brian Paul
--- include/GL/glxext.h | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/include/GL/glxext.h b/include/GL/glxext.h index 3c47dc3..e640ff7 100644 --- a/include/GL/glxext.h +++ b/include/GL/glxext.h @@ -6,7 +6,7 @@ extern "C" { #endif /* -** Copyright (c

[Mesa-dev] [PATCH 5/9] mesa: make _mesa_reference_array_object() an inline function

2012-06-26 Thread Brian Paul
As we do for texture objects, buffer objects, etc. --- src/mesa/main/arrayobj.c | 11 ++- src/mesa/main/arrayobj.h | 12 +++- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 4c50066..3439ab6 100644 --- a/

[Mesa-dev] [PATCH 4/9] mesa: look up enum name for glEnable/Disable errors

2012-06-26 Thread Brian Paul
--- src/mesa/main/enable.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index d0b4625..c811f2a 100644 --- a/src/mesa/main/enable.c +++ b/src/mesa/main/enable.c @@ -161,8 +161,8 @@ client_state(struct gl_context *

[Mesa-dev] [PATCH 2/9] mesa: rename ColorMaterialBitmask to _ColorMaterialBitmask

2012-06-26 Thread Brian Paul
Since it's a derived field. --- src/mesa/drivers/dri/nouveau/nv10_state_tnl.c |4 ++-- src/mesa/drivers/dri/nouveau/nv20_state_tnl.c |4 ++-- src/mesa/drivers/dri/r200/r200_state.c|4 ++-- src/mesa/drivers/dri/radeon/radeon_state.c|8 src/mesa/main/ffvertex_pro

[Mesa-dev] [PATCH 3/9] mesa: move TEXGEN defines closer to gl_texgen struct

2012-06-26 Thread Brian Paul
--- src/mesa/main/mtypes.h | 80 1 files changed, 40 insertions(+), 40 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f9cec24..d37c1f3 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -1181,46 +

[Mesa-dev] [PATCH 1/9] mesa: re-order, update comments on lighting-related structs

2012-06-26 Thread Brian Paul
--- src/mesa/main/mtypes.h | 50 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f18b81e..8572b5f 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -630,6 +63

[Mesa-dev] [PATCH 0/9] assorted patches

2012-06-26 Thread Brian Paul
These are just a bunch of minor patches I've had sitting in my trees for a while. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] softpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Jun 26, 2012 at 10:46 PM, Brian Paul wrote: > These all return zero.  Add a debug_printf() to catch the default case so > we don't accidently mishandle something important in the future. > > v2: remove 'default' case to get compile-time wa

[Mesa-dev] [PATCH 3/3] svga: handle missing PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
And fix incorrect error message for a bad shader type/number. --- src/gallium/drivers/svga/svga_screen.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 0d8b1d2..0

[Mesa-dev] [PATCH 2/3] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
As with the previous commit for softpipe. v2: remove 'default' case to get compile-time warning --- src/gallium/drivers/llvmpipe/lp_screen.c | 52 +++-- 1 files changed, 48 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/galliu

[Mesa-dev] [PATCH 1/3] softpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
These all return zero. Add a debug_printf() to catch the default case so we don't accidently mishandle something important in the future. v2: remove 'default' case to get compile-time warning --- src/gallium/drivers/softpipe/sp_screen.c | 34 +++-- 1 files changed, 31 i

Re: [Mesa-dev] [PATCH 1/2] softpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
On 06/26/2012 02:25 PM, Marek Olšák wrote: On Tue, Jun 26, 2012 at 10:11 PM, Brian Paul wrote: These all return zero. Add a debug_printf() to catch the default case so we don't accidently mishandle something important in the future. FWIW, it's better to remove the default statement and move

Re: [Mesa-dev] [PATCH 1/2] softpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Marek Olšák
On Tue, Jun 26, 2012 at 10:11 PM, Brian Paul wrote: > These all return zero.  Add a debug_printf() to catch the default case so > we don't accidently mishandle something important in the future. FWIW, it's better to remove the default statement and move the default code after the switch, so that

[Mesa-dev] [Bug 51428] No rule to make target 'install' for osmesa

2012-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51428 --- Comment #3 from Alexandre Demers 2012-06-26 13:23:14 PDT --- (In reply to comment #1) > See http://lists.freedesktop.org/archives/mesa-dev/2012-June/023206.html This patch is a no go when applied on latest git: configure.ac:2151: error: re

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > As with the previous commit for softpipe. > --- > src/gallium/drivers/llvmpipe/lp_screen.c | 43 > - > 1 files changed, 41 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/llvmpipe/lp_s

[Mesa-dev] [PATCH 2/2] llvmpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
As with the previous commit for softpipe. --- src/gallium/drivers/llvmpipe/lp_screen.c | 43 - 1 files changed, 41 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index 40037a5..72c9016 1

[Mesa-dev] [PATCH 1/2] softpipe: handle more PIPE_CAP_x queries

2012-06-26 Thread Brian Paul
These all return zero. Add a debug_printf() to catch the default case so we don't accidently mishandle something important in the future. --- src/gallium/drivers/softpipe/sp_screen.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/s

[Mesa-dev] [PATCH] glsl: be more careful about counting varying vars in the linker

2012-06-26 Thread Brian Paul
Previously, we were counting gl_FrontFacing, gl_FragCoord and gl_PointCoord against the limit of varying variables. This prevented some valid shaders from linking. The other potential solution to this is to have the driver advertise more varying vars or set the GLSLSkipStrictMaxVaryingLimitCheck

[Mesa-dev] [PATCH] docs/helpwanted: add some useful todo lists

2012-06-26 Thread Andreas Boll
--- docs/helpwanted.html | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index cfa057e..6d6058e 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -46,6 +46,19 @@ the latest Mesa code and run tests (such

Re: [Mesa-dev] [PATCH 1/3] r600g: avoid unnecessary shader exports v2

2012-06-26 Thread Andreas Boll
2012/6/26 : > From: Vadim Girlin > > In some cases TGSI shader has more color outputs than the number of CBs, > so it seems we need to limit the number of color exports. This requires > different shader variants depending on the nr_cbufs, but on the other hand > we are doing less exports, which a

Re: [Mesa-dev] [PATCH 1/3] r600g: avoid unnecessary shader exports v2

2012-06-26 Thread Alex Deucher
On Tue, Jun 26, 2012 at 12:21 PM, wrote: > From: Vadim Girlin > > In some cases TGSI shader has more color outputs than the number of CBs, > so it seems we need to limit the number of color exports. This requires > different shader variants depending on the nr_cbufs, but on the other hand > we a

[Mesa-dev] [PATCH 3/3] r600g: enable DUAL_EXPORT mode when possible on r6xx/r7xx

2012-06-26 Thread j . glisse
From: Jerome Glisse DUAL_EXPORT can be enabled on r6xx/r7xx when all CBs use 16-bit export and there is no depth/stencil export. Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/r600_pipe.h |1 + src/gallium/drivers/r600/r600_state.c| 45 -

[Mesa-dev] [PATCH 2/3] r600g: enable DUAL_EXPORT mode when possible

2012-06-26 Thread j . glisse
From: Vadim Girlin It seems DUAL_EXPORT on evergreen may be enabled when all CBs use 16-bit export mode (EXPORT_4C_16BPC), also there should be at least one CB, and the PS shouldn't export depth/stencil. Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/evergreen_state.c | 46 ++

[Mesa-dev] [PATCH 1/3] r600g: avoid unnecessary shader exports v2

2012-06-26 Thread j . glisse
From: Vadim Girlin In some cases TGSI shader has more color outputs than the number of CBs, so it seems we need to limit the number of color exports. This requires different shader variants depending on the nr_cbufs, but on the other hand we are doing less exports, which are very costly. v2: fix

[Mesa-dev] [PATCH 3/3] i965: adjust gen6+ timestamp pipe_control writes

2012-06-26 Thread Daniel Vetter
Similar treatment to the depth count pipe_control writes - Add the CS_STALL workaround, timestamp writes are non-zero post-sync ops, too. - Also ensure that we write the full 64bits by using the 5 dword long variant of pipe_control. --- src/mesa/drivers/dri/i965/brw_queryobj.c | 32 +

[Mesa-dev] [PATCH 2/3] i965: we want 64bit writes for depth count

2012-06-26 Thread Daniel Vetter
... and the hardware seems to take the lenght of the pipe control command to indicate whether the write is 64bit or 32bit. Which makes sense for immediate writes. I've discovered this by writing a pattern into the query object bo and noticing that the high 32bits are left intact, even on those pip

[Mesa-dev] [PATCH 1/3] i965: tackle the occlusion query pipe control mess

2012-06-26 Thread Daniel Vetter
- Separate out the depth stall from the depth count write, workarounds say that a depth stall needs to be preceeded with a non-zero post-sync op. - Implement the cs stall workaround like the kernel does. I've hoped that this would fix a occlusion query issue on snb, but alas, it doesn't seem t

[Mesa-dev] [PATCH 0/3] gen6+ pipe control fixes for queries

2012-06-26 Thread Daniel Vetter
Hi all, This is a bit fallout from trying to battle that curious pipe control depth count write failure: https://bugs.freedesktop.org/show_bug.cgi?id=48019 For whatever oddball reason, the depth count write simply never shows up sometimes. Preventing buffer re-use (with e.g. making the query bo

[Mesa-dev] [Bug 51428] No rule to make target 'install' for osmesa

2012-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51428 --- Comment #2 from Alexandre Demers 2012-06-26 07:26:37 PDT --- (In reply to comment #1) > See http://lists.freedesktop.org/archives/mesa-dev/2012-June/023206.html I'll test it later today. -- Configure bugmail: https://bugs.freedesktop.org/

Re: [Mesa-dev] [PATCH 0/2] [RFC] r600g: improve handling of the shader exports

2012-06-26 Thread Jerome Glisse
On Tue, Jun 26, 2012 at 5:45 AM, Vadim Girlin wrote: > On Fri, 2012-06-22 at 14:24 -0400, Jerome Glisse wrote: >> On Fri, Jun 22, 2012 at 10:02 AM, Vadim Girlin wrote: >> >  r600g: avoid unnecessary shader exports >> >  r600g: enable DUAL_EXPORT mode when possible >> > >> > First patch fixes the

[Mesa-dev] [Bug 51428] No rule to make target 'install' for osmesa

2012-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51428 --- Comment #1 from Laurent carlier 2012-06-26 05:34:37 PDT --- See http://lists.freedesktop.org/archives/mesa-dev/2012-June/023206.html -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

Re: [Mesa-dev] [PATCH 0/2] [RFC] r600g: improve handling of the shader exports

2012-06-26 Thread Vadim Girlin
On Fri, 2012-06-22 at 14:24 -0400, Jerome Glisse wrote: > On Fri, Jun 22, 2012 at 10:02 AM, Vadim Girlin wrote: > > r600g: avoid unnecessary shader exports > > r600g: enable DUAL_EXPORT mode when possible > > > > First patch fixes the lockups with DUAL_EXPORT mode for me, also AFAICS it > > fixe

Re: [Mesa-dev] dri broken on i915

2012-06-26 Thread Chris Wilson
On Tue, 26 Jun 2012 09:12:10 +0200, Knut Petersen wrote: > @ Chris: mieq* problems are back, see log. During connector probing. Unusual, I can blame Eugeni since he touched it last :) -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ me