Kenneth Graunke <kenn...@whitecape.org> writes: > Sorry for the extremely late review. (Lost this one in the inbox.)
No problem at all. > Could yylineno and yylloc->source be set directly from the rules, rather > than using flags and setting them here? It seems like they could, but I > imagine you tried that and it doesn't work. Correct. I did try that first. It was hard to get at the lex-specific data structure from the grammar rules. And then I was also concerned about the potentially of the timing of the adjustments being wrong if performed in grammar rules. It's easier to just know these line numbers are correctly being adjusted by doing it in the lexer. > Hm. I originally thought #line took effect regardless of any #if trees, ... > So I think this is right. Thanks. I hadn't even thought through that, but simply copied that block of code. I appreciate your eye for detail. > Could you please #include <stdbool.h> and use 'bool' instead of 'int' > for the has_* variables? Done. > For the series: > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Thanks for the review. All pushed now, (along with a couple of other patches you reviewed previously). -Carl -- carl.d.wo...@intel.com
pgpySIB1NCApv.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
