Re: [Mesa-dev] [PATCH] softpipe: Take all lods into account when texture sampling.

2012-06-19 Thread Olivier Galibert
On Tue, Jun 19, 2012 at 02:46:35PM -0700, Jose Fonseca wrote: > Could you give more background on why is this necessary? > > This will make software renderering slower, so I'd really like to avoid it on > llvmpipe if at all possible. Well, given the existence of textureLod and textureGrad every

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Kenneth Graunke
On 06/19/2012 11:27 AM, Paul Berry wrote: On 19 June 2012 10:29, Kenneth Graunke wrote: Whitespace errors here. I know Mesa isn't terribly consistent w.r.t. tabs or spaces, but in general these files use 3 space indent with 8 space tabs. Please use tabs to match the surrounding line

Re: [Mesa-dev] [PATCH] i965: Don't set brw_wm_prog_key::iz_lookup on Gen6+.

2012-06-19 Thread Eric Anholt
On Sat, 16 Jun 2012 16:42:00 -0700, Kenneth Graunke wrote: > Sandy Bridge and later don't use this field, so there's no point in > setting it. It can only cause harmful state-based recompiles. We can potentially remove some state flagging on gen6+ based on this, but it's a great start. Reviewe

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-19 Thread Eric Anholt
On Tue, 19 Jun 2012 08:10:25 -0600, Brian Paul wrote: > On 06/18/2012 07:35 PM, Eric Anholt wrote: > > Fixes piglit ARB_uniform_buffer_object/getintegeri_v. > > --- > > src/mesa/main/get.c | 24 > > 1 file changed, 24 insertions(+) > > > > diff --git a/src/mesa/main/g

[Mesa-dev] Building under Windows

2012-06-19 Thread Jesper Weissglas
I am trying to build with LLVM under windows. Using SCons and MinGW. After solving some basic problems with llvm-config and applying the patches for 8.0.3 most things are going OK. Until it is time to generate the libgallium.a library. The "ar" command to build this library is over 10kBytes lo

Re: [Mesa-dev] Mesa (master): st/mesa: move st_validate_state() call earlier in st_DrawPixels()

2012-06-19 Thread Brian Paul
On 06/19/2012 04:08 PM, Brian Paul wrote: Module: Mesa Branch: master Commit: 7f4786ad29ac4b0ebfcec8114921c1c8f6e3 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f4786ad29ac4b0ebfcec8114921c1c8f6e3 Author: Brian Paul Date: Tue Jun 19 09:40:32 2012 -0600 st/mesa: move st_va

Re: [Mesa-dev] [PATCH 1/4] mesa: Add support for GL_ARB_base_instance

2012-06-19 Thread Jerome Glisse
On Tue, Jun 19, 2012 at 4:46 PM, Jerome Glisse wrote: > On Mon, Jun 18, 2012 at 8:33 PM, Fredrik Höglund wrote: >> On Tuesday 19 June 2012, Brian Paul wrote: >>> On 06/18/2012 02:50 PM, Fredrik Höglund wrote: >>> > Reviewed-by: Brian Paul >>> > --- >>> > >>> > v2: Change baseinstance to base_inst

Re: [Mesa-dev] [PATCH 1/4] mesa: Add support for GL_ARB_base_instance

2012-06-19 Thread Jerome Glisse
On Mon, Jun 18, 2012 at 8:33 PM, Fredrik Höglund wrote: > On Tuesday 19 June 2012, Brian Paul wrote: >> On 06/18/2012 02:50 PM, Fredrik Höglund wrote: >> > Reviewed-by: Brian Paul >> > --- >> > >> > v2: Change baseinstance to base_instance in _mesa_prims >> >      and to baseInstance in the vbo_ex

Re: [Mesa-dev] [PATCH] r600g: Unify SURFACE_SYNC packet emission for 3D and compute

2012-06-19 Thread Marek Olšák
Ah ok. Nevermind then. Marek On Tue, Jun 19, 2012 at 8:06 PM, Tom Stellard wrote: > On Tue, Jun 19, 2012 at 07:57:50PM +0200, Marek Olšák wrote: >> Hi Tom, >> >> This adds new calls to r600_inval_xxx_cache, which justs sets the >> dirty flag in the atom "surface_sync_cmd" to true, but I couldn't

Re: [Mesa-dev] Ping: patches to apply

2012-06-19 Thread Brian Paul
On 06/19/2012 12:51 PM, Olivier Galibert wrote: Hi, They've been revieved, they've been changed when requested :-) Thanks. I'll push them soon. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/

Re: [Mesa-dev] [PATCH] r600g: Unify SURFACE_SYNC packet emission for 3D and compute

2012-06-19 Thread Jerome Glisse
On Tue, Jun 19, 2012 at 2:06 PM, Tom Stellard wrote: > On Tue, Jun 19, 2012 at 07:57:50PM +0200, Marek Olšák wrote: >> Hi Tom, >> >> This adds new calls to r600_inval_xxx_cache, which justs sets the >> dirty flag in the atom "surface_sync_cmd" to true, but I couldn't find >> where the compute code

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Kristian Høgsberg
On Tue, Jun 19, 2012 at 2:56 PM, Kristian Høgsberg wrote: > On Tue, Jun 19, 2012 at 11:27:17AM -0700, Paul Berry wrote: >> On 19 June 2012 10:29, Kenneth Graunke wrote: >> >> > On 06/19/2012 08:16 AM, Paul Berry wrote: >> > >> >>  From the GL 3.0 spec (p.116): >> >> >> >>     "Multisample rasteri

[Mesa-dev] [PATCH 3/4] llvmpipe: Simplify and fix system variables fetch.

2012-06-19 Thread Olivier Galibert
The system array values concept doesn't really because it expects the system values to be fixed per call, which is wrong for gl_VertexID and iffy for gl_SampleID. So this patch does two things: - kill the array, have emit_fetch_system_value directly pick the values it needs (only gl_InstanceID

[Mesa-dev] [PATCH 4/4] llvmpipe: Add vertex id support.

2012-06-19 Thread Olivier Galibert
Signed-off-by: Olivier Galibert Reviewed-by: Brian Paul --- src/gallium/auxiliary/draw/draw_llvm.c | 32 ++- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 13 +++-- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 11 +--- src/gallium/drivers/llvmp

[Mesa-dev] [PATCH 2/4] draw: fix flat shading and screen-space linear interpolation in clipper

2012-06-19 Thread Olivier Galibert
This includes: - picking up correctly which attributes are flatshaded and which are noperspective - copying the flatshaded attributes when needed, including the non-built-in ones - correctly interpolating the noperspective attributes in screen-space instead than in a 3d-correct fashion. Si

[Mesa-dev] [PATCH 1/4] softpipe: Offset is not to be applied to the layer parameter of array texture fetches.

2012-06-19 Thread Olivier Galibert
Signed-off-by: Olivier Galibert Reviewed-by: Brian Paul --- src/gallium/drivers/softpipe/sp_tex_sample.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_tex_sample.c b/src/gallium/drivers/softpipe/sp_tex_sample.c index d4c0175..f29a6c7

[Mesa-dev] Ping: patches to apply

2012-06-19 Thread Olivier Galibert
Hi, They've been revieved, they've been changed when requested :-) Best, OG. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Kristian Høgsberg
On Tue, Jun 19, 2012 at 11:27:17AM -0700, Paul Berry wrote: > On 19 June 2012 10:29, Kenneth Graunke wrote: > > > On 06/19/2012 08:16 AM, Paul Berry wrote: > > > >> From the GL 3.0 spec (p.116): > >> > >> "Multisample rasterization is enabled or disabled by calling > >> Enable or Disable

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Paul Berry
On 19 June 2012 10:29, Kenneth Graunke wrote: > On 06/19/2012 08:16 AM, Paul Berry wrote: > >> From the GL 3.0 spec (p.116): >> >> "Multisample rasterization is enabled or disabled by calling >> Enable or Disable with the symbolic constant MULTISAMPLE." >> >> Elsewhere in the spec, where

Re: [Mesa-dev] [PATCH] r600g: Unify SURFACE_SYNC packet emission for 3D and compute

2012-06-19 Thread Tom Stellard
On Tue, Jun 19, 2012 at 07:57:50PM +0200, Marek Olšák wrote: > Hi Tom, > > This adds new calls to r600_inval_xxx_cache, which justs sets the > dirty flag in the atom "surface_sync_cmd" to true, but I couldn't find > where the compute code calls r600_emit_atom. The proper way to emit > dirty atoms

Re: [Mesa-dev] [PATCH v2 09/21] mesa/samplerobj: Set state dirty in bind if state is shared

2012-06-19 Thread Eric Anholt
On Tue, 12 Jun 2012 21:38:49 +0300, Pauli Nieminen wrote: > State changes in share group must be updated when the object is rebound > to the binding point. That requires mesa to set texture state dirty when > binding sampler object in a share group. > > GL 4.2 specification appendix "Shared Obje

Re: [Mesa-dev] [PATCH] r600g: Unify SURFACE_SYNC packet emission for 3D and compute

2012-06-19 Thread Marek Olšák
Hi Tom, This adds new calls to r600_inval_xxx_cache, which justs sets the dirty flag in the atom "surface_sync_cmd" to true, but I couldn't find where the compute code calls r600_emit_atom. The proper way to emit dirty atoms is in r600_state_common.c:843-845. Marek On Tue, Jun 19, 2012 at 11:24

[Mesa-dev] [PATCH] radeon/llvm: fix CR/LF

2012-06-19 Thread Andreas Boll
--- src/gallium/drivers/radeon/AMDILSIDevice.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/radeon/AMDILSIDevice.h b/src/gallium/drivers/radeon/AMDILSIDevice.h index b272af7..bc7d4b8 100644 --- a/src/gallium/drivers/radeon/AMDILSIDevice.h +++ b/src

[Mesa-dev] [PATCH] mesa: remove obsolete confdiff.sh

2012-06-19 Thread Andreas Boll
this script is obsolete since 0cc216676c96efacb0e1eb82457e6a83920ae704 --- bin/confdiff.sh | 48 1 files changed, 0 insertions(+), 48 deletions(-) delete mode 100755 bin/confdiff.sh diff --git a/bin/confdiff.sh b/bin/confdiff.sh deleted file mod

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Kenneth Graunke
On 06/19/2012 08:16 AM, Paul Berry wrote: From the GL 3.0 spec (p.116): "Multisample rasterization is enabled or disabled by calling Enable or Disable with the symbolic constant MULTISAMPLE." Elsewhere in the spec, where multisample rasterization is described (sections 3.4.3, 3.5.4,

[Mesa-dev] [PATCH] r600g: Unify SURFACE_SYNC packet emission for 3D and compute

2012-06-19 Thread Tom Stellard
Drop the compute specific evergreen_set_buffer_sync() function and instead use the r600_surface_sync_command atom for emitting SURFACE_SYNC packets. --- src/gallium/drivers/r600/evergreen_compute.c | 18 ++- .../drivers/r600/evergreen_compute_internal.c | 111 +++ ...

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Eric Anholt
On Tue, 19 Jun 2012 08:16:22 -0700, Paul Berry wrote: > From the GL 3.0 spec (p.116): > > "Multisample rasterization is enabled or disabled by calling > Enable or Disable with the symbolic constant MULTISAMPLE." > > Elsewhere in the spec, where multisample rasterization is described > (s

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2012-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 50316] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.cos

2012-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50316 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Paul Berry
On 19 June 2012 08:16, Paul Berry wrote: > From the GL 3.0 spec (p.116): > >"Multisample rasterization is enabled or disabled by calling >Enable or Disable with the symbolic constant MULTISAMPLE." > > Elsewhere in the spec, where multisample rasterization is described > (sections 3.4.3, 3

[Mesa-dev] [PATCH] i965/msaa: Only do multisample rasterization if GL_MULTISAMPLE enabled.

2012-06-19 Thread Paul Berry
>From the GL 3.0 spec (p.116): "Multisample rasterization is enabled or disabled by calling Enable or Disable with the symbolic constant MULTISAMPLE." Elsewhere in the spec, where multisample rasterization is described (sections 3.4.3, 3.5.4, and 3.6.6), the following text is consistently

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-19 Thread Brian Paul
On 06/18/2012 07:35 PM, Eric Anholt wrote: Fixes piglit ARB_uniform_buffer_object/getintegeri_v. --- src/mesa/main/get.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 933bfe7..4798c02 100644 --- a/src/mesa/main/g

Re: [Mesa-dev] [PATCH 1/9] glapi: Add uniform buffer object API

2012-06-19 Thread Brian Paul
On 06/18/2012 07:35 PM, Eric Anholt wrote: From: Vincent Lejeune v2: Fix a typo spotted by Eric Anholt. v3: Fix missing "GL" on types, fix style, fix Studly_Caps extension name, drop commented code duplicated with GL3x.xml [anholt] --- src/mapi/glapi/gen/ARB_uniform_buffer_object.xml |

Re: [Mesa-dev] [PATCH 7/9] mesa: Add support for glBindBufferBase/Range on GL_UNIFORM_BUFFER.

2012-06-19 Thread Brian Paul
On 06/18/2012 07:35 PM, Eric Anholt wrote: Fixes piglits: GL_ARB_uniform_buffer_object/bindbuffer-general-point. GL_ARB_uniform_buffer_object/negative-bindbuffer-buffer GL_ARB_uniform_buffer_object/negative-bindbuffer-index GL_ARB_uniform_buffer_object/negative-bindbuffer-target GL_ARB_uniform_bu

Re: [Mesa-dev] [PATCH 4/9] mesa: Add indexed binding points for uniform buffer objects.

2012-06-19 Thread Brian Paul
On 06/18/2012 07:35 PM, Eric Anholt wrote: --- src/mesa/main/bufferobj.c | 29 + src/mesa/main/mtypes.h| 22 ++ 2 files changed, 51 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b646baa..ecfa7af

Re: [Mesa-dev] [PATCH 07/11 v3] gbm: add handle2(drm buffer region name)

2012-06-19 Thread Ander Conselvan de Oliveira
On 06/14/2012 01:32 PM, Zhao Halley wrote: --- src/gbm/backends/dri/gbm_dri.c |6 +- src/gbm/main/gbm.c | 14 ++ src/gbm/main/gbm.h |3 +++ src/gbm/main/gbmint.h |1 + 4 files changed, 23 insertions(+), 1 deletions(-) mode cha