For the 1-6 patches:
Reviewed-by: Marek Olšák
On Sat, Sep 10, 2011 at 12:39 AM, Ian Romanick wrote:
> The previous patch series cleaned up the way DRI drivers enable
> extensions. This series implements a couple more clean ups and
> refactors that were enabled by the first series.
>
>
On 09/09/2011 10:04 AM, Eric Anholt wrote:
> On Thu, 8 Sep 2011 15:49:21 -0700, Kenneth Graunke
> wrote:
>> @@ -861,7 +862,14 @@ fs_visitor::emit_texture_gen5(ir_texture *ir, fs_reg
>> dst, fs_reg coordinate,
>>inst = emit(FS_OPCODE_TXS, dst);
>>break;
>> case ir_txf:
>> -
On 09/09/2011 10:07 AM, Eric Anholt wrote:
> On Thu, 8 Sep 2011 15:49:23 -0700, Kenneth Graunke
> wrote:
>> + /* Initialize the rest of u/v/r with 0.0, for safety */
>> + for (int i = ir->coordinate->type->vector_elements; i < 3; i++) {
>> + emit(BRW_OPCODE_MOV, fs_reg(MRF, base_mr
On Fri, 09 Sep 2011 15:21:14 -0700, Kenneth Graunke
wrote:
> On 09/08/2011 11:32 PM, Eric Anholt wrote:
> > + * Does algebraic optimizations (0 * a = 0, 1 * a = a, a + 0 = a).
>
> I was going to ask "what about commutativity?"...after all, 0 * a but a
> + 0 seems kind of arbitrary...but then I i
On Fri, 9 Sep 2011 15:39:14 -0700, "Ian Romanick" wrote:
> The previous patch series cleaned up the way DRI drivers enable
> extensions. This series implements a couple more clean ups and
> refactors that were enabled by the first series.
1-6 are:
Reviewed-by: Eric Anholt
I don't understand
From: Brian Paul
These two functions were nearly the same with lots of duplicated code.
Now pass in a boolean 'elts' flag and use a few conditionals to implement
the linear vs. indexed cases.
---
src/gallium/auxiliary/draw/draw_llvm.c | 370 +---
1 files changed, 97
Am 10.09.2011 00:39, schrieb Ian Romanick:
> The previous patch series cleaned up the way DRI drivers enable
> extensions. This series implements a couple more clean ups and
> refactors that were enabled by the first series.
For 1-6 of the series:
Reviewed-by: Roland Scheidegger
One less useles
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2011 03:49 PM, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23
> --- 1 files changed, 20 insertions(+), 3
> deletions(-)
>
> diff --git a/src/mesa/drivers
From: Ian Romanick
All of the extensions actually supported by Mesa have been remapped by
remap.c for a long time. Emitting all of these data structures is
just clutter.
Drivers that need additional functions remapped, should add
'offset="assign"' to the function definition in the .xml file.
T
From: Ian Romanick
---
src/mesa/main/extensions.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index f6eb7ec..7599ea9 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main/extensions.c
@@ -72,8 +72,6 @@ st
From: Ian Romanick
Since GL_EXT_blend_logic_op is removed, _mesa_rgba_logicop_enabled(ctx)
just returns ctx->Color.ColorLogicOpEnabled. That seems kind of silly.
---
src/mesa/drivers/dri/i915/i830_state.c |2 +-
src/mesa/drivers/dri/i915/i915_state.c |2 +-
src/mesa/drivers/dr
From: Ian Romanick
Support is removed for four reasons:
1. The implementation was broken with respect to separate blend
equations. The GL_EXT_blend_equation_separate spec says:
"If EXT_blend_logic_op and EXT_blend_equation_separate are both
supported, the logic op blend equation should
From: Ian Romanick
Since GL_EXT_blend_logic_op is removed, _LogicOpEnabled and
ColorLogicOpEnabled always have the same value.
---
src/mesa/drivers/dri/i965/brw_cc.c |2 +-
src/mesa/drivers/dri/i965/brw_wm_surface_state.c |2 +-
src/mesa/drivers/dri/i965/gen6_cc.c
From: Ian Romanick
It was broken, and it isn't really useful anyway.
Cc: Brian Paul
Cc: Roland Scheidegger
Cc: Marek Olšák
---
src/mesa/state_tracker/st_atom_blend.c | 10 +-
src/mesa/state_tracker/st_extensions.c |1 -
2 files changed, 1 insertions(+), 10 deletions(-)
diff --
From: Ian Romanick
The last user of this function was driInitExtensions, and that function
was removed in a previous commit.
---
src/mesa/main/extensions.c | 14 --
src/mesa/main/extensions.h |5 -
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/src/mesa/mai
The previous patch series cleaned up the way DRI drivers enable
extensions. This series implements a couple more clean ups and
refactors that were enabled by the first series.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedes
On 09/08/2011 11:32 PM, Eric Anholt wrote:
> These were copy and pasted from the FS, and are never used.
> ---
> src/mesa/drivers/dri/i965/brw_vec4.h |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h
> b/src/mesa/drivers/dri/i965/
On 09/08/2011 11:32 PM, Eric Anholt wrote:
> + * Does algebraic optimizations (0 * a = 0, 1 * a = a, a + 0 = a).
I was going to ask "what about commutativity?"...after all, 0 * a but a
+ 0 seems kind of arbitrary...but then I implemented it and tried it on
shader-db:
Total instructions: 39967 ->
On 09/09/2011 03:05 PM, Ian Romanick wrote:
Module: Mesa
Branch: master
Commit: 5a175127f38aa02d2b8169b1b6d08a2d4be3d36f
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a175127f38aa02d2b8169b1b6d08a2d4be3d36f
Author: Ian Romanick
Date: Mon Aug 22 16:00:03 2011 -0700
dri: Remove all
On 09/08/2011 11:32 PM, Eric Anholt wrote:
> We generate silly code for array access, and it's easier to generally
> support the cleanup than to specifically avoid the bad code in each
> place we might generate it.
>
> Removes 4.6% of instructions from 41.6% of shaders in shader-db,
> particularly
static bool src_reg_is_zero(src_reg *reg) is very C.
A first improvement would be:
static bool src_reg_is_zero(const src_reg ®)
as this (1) still avoids copying the struct in, (2) actually guarantees
the register won't be modified, and (3) doesn't require you to explicitly
use the & operator to g
On Fri, 9 Sep 2011 13:21:57 +0800, Yuanhan Liu
wrote:
> On Thu, Sep 08, 2011 at 09:25:30PM -0700, Kenneth Graunke wrote:
> > On 09/08/2011 06:59 PM, Yuanhan Liu wrote:
> > > On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote:
> > >> On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu
> > >>
On Thu, 8 Sep 2011 15:49:23 -0700, Kenneth Graunke
wrote:
> + /* Initialize the rest of u/v/r with 0.0, for safety */
> + for (int i = ir->coordinate->type->vector_elements; i < 3; i++) {
> + emit(BRW_OPCODE_MOV, fs_reg(MRF, base_mrf + mlen + i * 2),
> fs_reg(0.0f));
> + }
>
On Thu, 8 Sep 2011 15:49:21 -0700, Kenneth Graunke
wrote:
> @@ -861,7 +862,14 @@ fs_visitor::emit_texture_gen5(ir_texture *ir, fs_reg
> dst, fs_reg coordinate,
>inst = emit(FS_OPCODE_TXS, dst);
>break;
> case ir_txf:
> - assert(!"GLSL 1.30 features unsupported");
> +
On 8 September 2011 23:32, Eric Anholt wrote:
> Fixes piglit vertex-program-two-side back.
> ---
> src/mesa/drivers/dri/i965/gen6_sf_state.c |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen6_sf_state.c
> b/src/mesa/drivers/dri/i9
On 8 September 2011 23:32, Eric Anholt wrote:
> Fixes piglit:
> vertex-program-two-side
> vertex-program-two-side primary
> vertex-program-two-side secondary
> ---
> src/mesa/drivers/dri/i965/brw_vs_constval.c |6 +++---
> src/mesa/drivers/dri/i965/gen6_sf_state.c |5 +++--
> src/mesa/
On 09/09/2011 12:07 AM, Eric Anholt wrote:
Fixes piglit nv_conditional_render-dlist.
---
src/mesa/main/dlist.c | 45 +
1 files changed, 45 insertions(+), 0 deletions(-)
For the series: Reviewed-by: Brian Paul
v2: adjust the assertion, add a comment
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 ++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 9394bea..4a5f6a2 100644
---
The depth should be in W.
v2: adjust the assertion, add a comment
---
src/mesa/program/ir_to_mesa.cpp | 17 ++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp
index 9813c4a..69a84de 100644
--- a/src
https://bugs.freedesktop.org/show_bug.cgi?id=40633
Benjamin Franzke changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
This is a cleanup of commit 02f1b50987c0d24da3dcc36dbb44821c20d0660c.
Update tex buffer using a dri_drawable hook from implemented in sw/drisw.c.
This saves us the duplication of dri_drawable.c.
CC: Stuart Abercrombie
CC: Stéphane Marchesin
---
.../state_trackers/dri/common/dri_drawable.c
This reverts commit 569bde1fa7d03fb7688d0d391b32e61e857ad44e.
CC: Stuart Abercrombie
CC: Stéphane Marchesin
---
src/gallium/state_trackers/dri/sw/dri_drawable.c | 270 +-
1 files changed, 1 insertions(+), 269 deletions(-)
mode change 100644 => 12 src/gallium/state_trac
This reverts commit 02f1b50987c0d24da3dcc36dbb44821c20d0660c.
CC: Stuart Abercrombie
CC: Stéphane Marchesin
---
src/gallium/state_trackers/dri/sw/dri_drawable.c | 50 +++---
1 files changed, 7 insertions(+), 43 deletions(-)
diff --git a/src/gallium/state_trackers/dri/sw/dri_d
https://bugs.freedesktop.org/show_bug.cgi?id=40729
Chia-I Wu changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
34 matches
Mail list logo
