On Fri, 9 Sep 2011 13:21:57 +0800, Yuanhan Liu <yuanhan....@linux.intel.com> wrote: > On Thu, Sep 08, 2011 at 09:25:30PM -0700, Kenneth Graunke wrote: > > On 09/08/2011 06:59 PM, Yuanhan Liu wrote: > > > On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: > > >> On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu > > >> <yuanhan....@linux.intel.com> wrote: > > >>> BTW, this patch fix the oglc pntrast fail on SNB(haven't tested it on > > >>> IVB yet). > > >> > > >> Could you include a piglit test for the failure? > > > > > > Actually, this is an issue of edgeflag. You will also find this patch > > > will fix the oglc edgeflag test fail. pntrast test case would also use > > > polygonmode with edgeflag to render a point. Thus it failed. > > > > > > I simply grep-ed the piglit repo, didn't find any references on > > > glEdgeFlag. Seems that current piglit doesn't include this test? > > > > You are right---piglit doesn't currently test glEdgeFlag. I think Eric > > was asking if you could please write a new test for piglit that > > demonstrates the failure. The rest of the community doesn't have access > > to closed source test suites like oglc, but everyone can run piglit. > > Having the test will help other developers avoid accidentally break > > glEdgeFlag support in the future. > > Got it. I may try to write one next week. > > Besides this, any ideas on how to setup the edge flag enable bit? Or, > does that patch make sense to you. > > If Ok, I will resend the patch later with little change to apply Eric's > suggestion.
The patch does look wrong according to the spec you quoted, which is part of why I want to see some testcases. That way we can figure out why testcases might pass if the patch isn't what it should be, and build better testcases.
pgpxNLZMxEPld.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
