Re: [Mesa-dev] [PATCH 01/11] mesa: Remove API facing bits of EXT_paletted_texture and EXT_shared_texture_palette

2011-08-31 Thread Brian Paul
On 08/31/2011 02:21 PM, Ian Romanick wrote: From: Ian Romanick This was also discussed at XDS 2010. However, actually making the change was delayed because several drivers still exposed these extensions to significant benefit (e.g., tdfx). Now that those drivers have been removed, this code ca

Re: [Mesa-dev] map-texture-image-v5 branch

2011-08-31 Thread Brian Paul
Eric, I've pushed some more patches to the map-texture-image-v5 branch. This should fix some (all, maybe?) of your regressions. There's still a few failures with some compressed formats, but I'm suspecting they're bugs in the block compression/decompression logic in a couple cases. They're

Re: [Mesa-dev] [PATCH 0/8] intel: fixes and features for Android

2011-08-31 Thread Chia-I Wu
On Thu, Sep 1, 2011 at 3:42 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/30/2011 10:46 PM, Chia-I Wu wrote: >> Hi, >> >> There are 3 changes in this series.  They are combined into a single >> series so that it is clear where they lead to.  I will split them

Re: [Mesa-dev] [PATCH 7/8] meta: add _mesa_meta_DrawTex()

2011-08-31 Thread Chia-I Wu
On Thu, Sep 1, 2011 at 4:04 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/30/2011 10:46 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> It can be used for dd->DrawTex. > > My main concern about this is that we have exactly zero tests for this > extension.  Befo

Re: [Mesa-dev] [PATCH 8/8] intel: enable GL_OES_draw_texture

2011-08-31 Thread Chia-I Wu
On Thu, Sep 1, 2011 at 4:06 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/30/2011 10:46 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> --- >>  src/mesa/drivers/dri/intel/intel_extensions_es.c |    1 + >>  src/mesa/drivers/dri/intel/intel_tex.c           |    1

Re: [Mesa-dev] [PATCH 1/3] i965: fix Android build

2011-08-31 Thread Chia-I Wu
On Thu, Sep 1, 2011 at 6:48 AM, Chad Versace wrote: > On 08/30/2011 10:27 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> Use $(TARGET_CC) instead of $(CC).  Correctly name and set LOCAL_CFLAGS. >> --- >>  src/mesa/drivers/dri/Android.mk      |    5 + >>  src/mesa/drivers/dri/i965/Android.mk |

Re: [Mesa-dev] [PATCH 2/3] i915: factor our source lists into Makefile.sources

2011-08-31 Thread Chia-I Wu
On Thu, Sep 1, 2011 at 9:00 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/30/2011 10:27 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> In preparation for porting i915 to Android, factor its source lists into >> a shared makefile. This prevents duplication of s

Re: [Mesa-dev] [PATCH 2/3] i915: factor our source lists into Makefile.sources

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2011 10:27 PM, Chia-I Wu wrote: > From: Chia-I Wu > > In preparation for porting i915 to Android, factor its source lists into > a shared makefile. This prevents duplication of source lists, and hence > prevents the Android from breaking as

Re: [Mesa-dev] [PATCH] mesa: Replace the EmitNoIfs compiler flag with a MaxIfLevel flag.

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2011 03:30 PM, Bryan Cain wrote: > This is a better, more fine-grained way of lowering if statements. Fixes the > game And Yet It Moves on nv50. Other than the one comment below, Reviewed-by: Ian Romanick > --- > src/mesa/drivers/dri/i91

Re: [Mesa-dev] [PATCH 1/3] i965: fix Android build

2011-08-31 Thread Chad Versace
On 08/30/2011 10:27 PM, Chia-I Wu wrote: > From: Chia-I Wu > > Use $(TARGET_CC) instead of $(CC). Correctly name and set LOCAL_CFLAGS. > --- > src/mesa/drivers/dri/Android.mk |5 + > src/mesa/drivers/dri/i965/Android.mk |7 +++ > 2 files changed, 8 insertions(+), 4 deletion

[Mesa-dev] [PATCH] mesa: Replace the EmitNoIfs compiler flag with a MaxIfLevel flag.

2011-08-31 Thread Bryan Cain
This is a better, more fine-grained way of lowering if statements. Fixes the game And Yet It Moves on nv50. --- src/mesa/drivers/dri/i915/i915_context.c |2 +- src/mesa/main/mtypes.h |6 +- src/mesa/program/ir_to_mesa.cpp|8 src/mesa/stat

[Mesa-dev] [PATCH 11/11] docs: skeleton file for 7.12 release notes

2011-08-31 Thread Ian Romanick
From: Ian Romanick Current just the items that have been removed from Mesa are mentioned in the release notes. --- docs/relnotes-7.12.html | 64 +++ docs/relnotes.html |1 + 2 files changed, 65 insertions(+), 0 deletions(-) create mode 1006

[Mesa-dev] [PATCH 10/11] mesa: Remove support for unpacking from client memory to color-index pixels

2011-08-31 Thread Ian Romanick
From: Ian Romanick Mesa hasn't supported color-index rendering for a long time. --- src/mesa/main/pack.c | 52 +++-- 1 files changed, 12 insertions(+), 40 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index 7de1d05..fd3f89d 1

[Mesa-dev] [PATCH 08/11] mesa: Remove GL_COLOR_INDEX from _mesa_{dest, source}_buffer_exists

2011-08-31 Thread Ian Romanick
From: Ian Romanick Mesa hasn't supported color-index rendering for a long time. --- src/mesa/main/framebuffer.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index 23fa1b2..42da176 100644 --- a/src/mesa/main/fr

[Mesa-dev] [PATCH 09/11] swrast: Use GL_STENCIL_INDEX for address calculations

2011-08-31 Thread Ian Romanick
From: Ian Romanick GL_COLOR_INDEX produced the same result (because GL_BITMAP is always used for stencil glDrawPixels), but it was confusing to read. I spent about 15 minutes wondering, "WTF?" --- src/mesa/swrast/s_drawpix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

[Mesa-dev] [PATCH 07/11] mesa: Remove GL_COLOR_INDEX from base format assertions

2011-08-31 Thread Ian Romanick
From: Ian Romanick _mesa_make_temp_float_image can't work on color-index textures, but there is no such thing as a color-index texture anymore. --- src/mesa/main/texstore.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore

[Mesa-dev] [PATCH 06/11] swrast: Remove GL_COLOR_INDEX from assertions

2011-08-31 Thread Ian Romanick
From: Ian Romanick These sampling functions don't work on color-index textures, but there is no such thing as a color-index texture anymore. --- src/mesa/swrast/s_texfilter.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swra

[Mesa-dev] [PATCH 05/11] mesa: Remove unused struct gl_color_table

2011-08-31 Thread Ian Romanick
From: Ian Romanick --- src/mesa/main/colortab.h |1 - src/mesa/main/mtypes.h | 19 --- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/colortab.h b/src/mesa/main/colortab.h index 3bc2066..b0d2b5d 100644 --- a/src/mesa/main/colortab.h +++ b/sr

[Mesa-dev] [PATCH 04/11] mesa: Remove unused functions _mesa_lookup_rgba_{float, ubyte}

2011-08-31 Thread Ian Romanick
From: Ian Romanick --- src/mesa/main/pixeltransfer.c | 261 - src/mesa/main/pixeltransfer.h |9 -- 2 files changed, 0 insertions(+), 270 deletions(-) diff --git a/src/mesa/main/pixeltransfer.c b/src/mesa/main/pixeltransfer.c index c183297..5e88143 10

[Mesa-dev] [PATCH 03/11] mesa: Remove all mention of GL_COLOR_INDEX*_EXT

2011-08-31 Thread Ian Romanick
From: Ian Romanick These enums were only valid with the paletted texture extensions. This allows a couple other trivial clean-ups. --- src/mesa/main/image.c | 27 --- src/mesa/main/image.h |3 --- src/mesa/main/texgetimage.c |8 ++-- 3 files chan

[Mesa-dev] [PATCH 02/11] mesa: Remove dd_function_table::CopyColorTable, ::CopyColorSubTable, and ::UpdateTexturePalette

2011-08-31 Thread Ian Romanick
From: Ian Romanick There's nothing left that can call any of these functions. This also removes the meta-ops code that implemented the first two. --- src/mesa/drivers/common/driverfuncs.c |5 --- src/mesa/drivers/common/meta.c| 55 - src/mesa/driver

[Mesa-dev] [PATCH 01/11] mesa: Remove API facing bits of EXT_paletted_texture and EXT_shared_texture_palette

2011-08-31 Thread Ian Romanick
From: Ian Romanick This was also discussed at XDS 2010. However, actually making the change was delayed because several drivers still exposed these extensions to significant benefit (e.g., tdfx). Now that those drivers have been removed, this code can be removed as well. v2: A lot of bits that

Re: [Mesa-dev] [PATCH 8/8] intel: enable GL_OES_draw_texture

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2011 10:46 PM, Chia-I Wu wrote: > From: Chia-I Wu > > --- > src/mesa/drivers/dri/intel/intel_extensions_es.c |1 + > src/mesa/drivers/dri/intel/intel_tex.c |1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 7/8] meta: add _mesa_meta_DrawTex()

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2011 10:46 PM, Chia-I Wu wrote: > From: Chia-I Wu > > It can be used for dd->DrawTex. My main concern about this is that we have exactly zero tests for this extension. Before this is enabled in Intel drivers, I want there to be at least so

Re: [Mesa-dev] [PATCH 0/8] intel: fixes and features for Android

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2011 10:46 PM, Chia-I Wu wrote: > Hi, > > There are 3 changes in this series. They are combined into a single > series so that it is clear where they lead to. I will split them up > if there is a v2. Tested with i915. > > Patch 1-2: enabl

Re: [Mesa-dev] [PATCH 1/3] swrast: initialize program native limits

2011-08-31 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2011 01:26 PM, Brian Paul wrote: > From: Brian Paul 1/3 and 2/3 are Reviewed-by: Ian Romanick > --- > src/mesa/swrast/s_context.c | 22 ++ > 1 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/src/me

[Mesa-dev] [PATCH] glsl : enable parsing of EXT_geometry_shader4 program.

2011-08-31 Thread vlj
This patch enables GLSL to parse geometry shader and generate corresponding ir tree (behaviour of glCompileShader). It adds ir_gs_function type to represent EmitVertex and EndPrimitive function. - This patch does not make linking of geometry shader possible. - This patch does not implement GS part

[Mesa-dev] [Bug 40437] libGL should give some indication when DRI2 fails

2011-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40437 --- Comment #2 from Michel Dänzer 2011-08-31 09:28:25 PDT --- Please provide your Signed-off-by: Ideally, submit the patches to the mesa-dev mailing list with git send-email. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?ta

Re: [Mesa-dev] [PATCH] mesa: handle zero-size buffers in MapBuffer and ranges in MapBufferRange (v3)

2011-08-31 Thread Brian Paul
On Tue, Aug 30, 2011 at 3:19 PM, Marek Olšák wrote: > --- >  src/mesa/main/bufferobj.c                    |   24 ++- >  src/mesa/state_tracker/st_cb_bufferobjects.c |   32 ++--- >  2 files changed, 31 insertions(+), 25 deletions(-) > LGTM. It may take a while

Re: [Mesa-dev] [PATCH 7/8] meta: add _mesa_meta_DrawTex()

2011-08-31 Thread Brian Paul
On Tue, Aug 30, 2011 at 11:46 PM, Chia-I Wu wrote: > From: Chia-I Wu > > It can be used for dd->DrawTex. > --- >  src/mesa/drivers/common/meta.c |  141 > >  src/mesa/drivers/common/meta.h |    3 + >  2 files changed, 144 insertions(+), 0 deletions(-) Rev

[Mesa-dev] [PATCH] mesa: fix broken store_texel() functions

2011-08-31 Thread Brian Paul
From: Brian Paul This fixes the swrast failures for piglit's fbo-generatemipmap-formats test. At some point down the road this code will go away so I haven't checked all the other store_texel() functions. --- src/mesa/main/colormac.h |6 src/mesa/main/texfetch_tmp.h | 55

Re: [Mesa-dev] [PATCH 3/3] state_trackers/dri/sw: Implement texture_from_pixmap.

2011-08-31 Thread Benjamin Franzke
It looks like this should be converted to a new dri_drawable hook (like allocate_textures), so the the drisw specific bits would be in sw/drisw.c (the hook in drm/dri2.c would just be a noop). This is the way the other stuff in st/dri is implemented and dri_drawable.c wouldnt need to be cloned. 20

Re: [Mesa-dev] [PATCH 3/3] state_trackers/dri/sw: Implement texture_from_pixmap.

2011-08-31 Thread Keith Whitwell
On Wed, 2011-08-31 at 04:55 -0700, Jose Fonseca wrote: > I haven't tested but the whole patch series looks good AFAICT. > > I'm really happy to see this work completed, as it was excluding the > llvmpipe/softpipe from a very big class of apps. Thanks for taking the > initiative! Likewise! Than

Re: [Mesa-dev] [PATCH 3/3] state_trackers/dri/sw: Implement texture_from_pixmap.

2011-08-31 Thread Jose Fonseca
I haven't tested but the whole patch series looks good AFAICT. I'm really happy to see this work completed, as it was excluding the llvmpipe/softpipe from a very big class of apps. Thanks for taking the initiative! Jose - Original Message - > Signed-off-by: Stuart Abercrombie > Signed

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-31 Thread Christian König
Am Dienstag, den 30.08.2011, 23:29 +0200 schrieb Maarten Lankhorst: > > I think the question we should ask isn't if one driver or another needs > > something, but more if one or another behaviour is specific to an > > interface or not. So when an interface theoretically allows a behaviour > > (even

[Mesa-dev] [Bug 38970] [bisected]piglit glx/glx-pixmap-multi failed

2011-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38970 --- Comment #12 from fangxun 2011-08-31 01:01:17 PDT --- (In reply to comment #11) > Xun, maybe you can have a test with the newest commit and xorg-server-1.10.3 > commit of xserver on server-1.10-branch. It also fails on xorg-server-1.10.3 comm