Re: LyX 1.4: Reproducable Crash [more math bug examples]

Martin Vermeer wrote: > On Wed, Feb 22, 2006 at 09:41:48PM +0200, Martin Vermeer wrote: >> The test for (*it)->getChar(). The idea with this is to make sure that >> if there is not a "character" in this location (but rather, something >> that is itself an inset), the cursor slice on the current le

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Georg Baum a écrit : The attached patch implements that and works for me as well. What needs to be done if this should go in is to check for side effects everywhere where editable() is used (fortunately only ~ 3 places), and better testing, but I think that this approach is prefereable to the get

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This is a hack that will bite later. getChar is supposed to Georg> return the contents of an inset if it can be represented as a Georg> single character, not some arbitrary character. I think I agree. Georg> What you really want to

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, 2006-02-23 at 10:05 +0100, Jean-Marc Lasgouttes wrote: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> This is a hack that will bite later. getChar is supposed to > Georg> return the contents of an inset if it can be represented as a > Georg> single character, not some

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: | | Georg> This is a hack that will bite later. getChar is supposed to | Georg> return the contents of an inset if it can be represented as a | Georg> single character, not some arbitrary ch

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Only MathNestInset needs this. All the others (including | MathHullInset) derive from that. Actually, you can just check for | asNestInset. | | The following works for me. BTW. Do we have a bugzilla bug number for this one? -- Lgb

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Jean-Marc Lasgouttes wrote: > Georg> The attached patch implements that and works for me as well. > Georg> What needs to be done if this should go in is to check for side > Georg> effects everywhere where editable() is used (fortunately only ~ > Georg> 3 places), and better testing, but I think th

Re: Linebreak between - and ,

Hartmut Haase wrote: > It seems to work, but I had to put  Gas"~, in ERT. Another possibility I > found out ist to use \mbox  Gas-, Gas"~, works for me. > Anyway, how is a simple LyX user with not LaTeX experience supposed to know > that? Reading l2kurz.dvi, the German introduction for LaTeX, or

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> Only MathNestInset needs this. All the others (including >> MathHullInset) derive from that. Actually, you can just check for >> asNestInset. Georg> Indeed. Sometimes one is just routine-blinded (is this Georg> understandable? In german

[PATCH] Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I think it is also logically more valid. Yes. Martin> BTW get rid of the Martin> if (it < end() && ... Martin> condition! It is redundant. Indeed. I did that. Please test. Personally I cannot crash it anymore, but

Re: [PATCH] Makes ParagraphList use RandomAccessList

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, Two files with this mail: Abdelrazak> RandomAccessList.h: renamed and cleaned up version of Abdelrazak> former it_vector.h ParagraphListRewrite.patch: updated Abdelrazak> with the above. Abdelrazak> I think th

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Only MathNestInset needs this. All the others (including >> MathHullInset) derive from that. Actually, you can just check for >> asNestInset. >> >> The following works for me. Martin> I think it is also logically more valid. FWIW,

Re: Minor change to README - changins 'cvs' to Subversion

> "christian" == christian ridderstrom <[EMAIL PROTECTED]> writes: christian> Hi Here's a very minor patch to the file README where I've christian> just changed the references to 'cvs' into 'Subversion'. I applied it. JMarc

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Lars Gullik Bjønnes wrote: > BTW. Do we have a bugzilla bug number for this one? The cursor positioning part of it is http://bugzilla.lyx.org/show_bug.cgi?id=1918 I can confirm that Jean-Marc's patch fixes most of this bug. The only remainig glitch I see in Joost's testcase is that in the formu

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, 2006-02-23 at 12:10 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Only MathNestInset needs this. All the others (including > >> MathHullInset) derive from that. Actually, you can just check for > >> asNestInset. > >> > >> The fol

Re: State of release notes for 1.4.0

> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> How are we doing here? Lars> Others things that should be mentioned that have not yet been Lars> brought forward? I propose to put the release notes in a separate file like RELEASE-NOTES. We should add there the things that ar

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Ah, and by the way I think you should put the whole stanza in Martin> an 'else' block, as I did in my patch. Gives better cursor Martin> positioning when clicking on the left of an object that has Martin> inset on its left (I cou

Re: [PATCH] Makes ParagraphList use RandomAccessList

Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Abdelrazak> Hello, Two files with this mail: | | Abdelrazak> RandomAccessList.h: renamed and cleaned up version of | Abdelrazak> former it_vector.h ParagraphListRewrite.patc

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, 2006-02-23 at 11:33 +0100, Jean-Marc Lasgouttes wrote: > Georg> Indeed. Sometimes one is just routine-blinded (is this > Georg> understandable? In german we call it "betriebsblind"). > > That's understandable, but I cannot find the right english (or french) > version... "Can't see the fo

Re: State of release notes for 1.4.0

Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> How are we doing here? | | Lars> Others things that should be mentioned that have not yet been | Lars> brought forward? | | I propose to put the release notes in a separa

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "John" == John C Spray <[EMAIL PROTECTED]> writes: John> On Thu, 2006-02-23 at 11:33 +0100, Jean-Marc Lasgouttes wrote: Georg> Indeed. Sometimes one is just routine-blinded (is this Georg> understandable? In german we call it "betriebsblind"). >> That's understandable, but I cannot find the

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > BTW. Do we have a bugzilla bug number for this one? | | The cursor positioning part of it is | http://bugzilla.lyx.org/show_bug.cgi?id=1918 I move the bug back to 1.4.0, and assigned it to J-M. -- Lgb

Re: [PATCH] Makes ParagraphList use RandomAccessList

Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, Two files with this mail: Abdelrazak> RandomAccessList.h: renamed and cleaned up version of Abdelrazak> former it_vector.h ParagraphListRewrite.patch: updated Abdelrazak> with the ab

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Juergen Spitzmueller a écrit : Lars Gullik Bjønnes wrote: BTW. Do we have a bugzilla bug number for this one? The cursor positioning part of it is http://bugzilla.lyx.org/show_bug.cgi?id=1918 I can confirm that Jean-Marc's patch fixes most of this bug. I confirm that also on windows. The

Re: [PATCH] Makes ParagraphList use RandomAccessList

Lars Gullik Bjønnes a écrit : Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Abdelrazak> Hello, Two files with this mail: | | Abdelrazak> RandomAccessList.h: renamed and cleaned up version of | Abdelrazak> former it_v

Re: State of release notes for 1.4.0

Jean-Marc Lasgouttes wrote: > - Font changes doesn't apply to tables inside the selection when I think this should read "don't", not "doesn't". Nothing else occurs to me apart from that. Georg

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, 2006-02-23 at 12:44 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Ah, and by the way I think you should put the whole stanza in > Martin> an 'else' block, as I did in my patch. Gives better cursor > Martin> positioning when cl

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Abdelrazak Younes wrote: > > The only remainig glitch I see in Joost's testcase is that in the formula > > > > q\leq\frac{(X^{2}+d)}{a+b+c} > > > > I cannot place the cursor right to the superscript with the mouse. But > > that can certainly wait. > > Another problem: the '+' sign in 'X^{2}+d' cann

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, 2006-02-23 at 13:57 +0100, Juergen Spitzmueller wrote: > Abdelrazak Younes wrote: > > > The only remainig glitch I see in Joost's testcase is that in the formula > > > > > > q\leq\frac{(X^{2}+d)}{a+b+c} > > > > > > I cannot place the cursor right to the superscript with the mouse. But > > >

Re: [PATCH] Makes ParagraphList use RandomAccessList

Abdelrazak Younes a écrit : An idea for testing: would i be possible to add temporarily to the at() method a test that the paragraph returned by the vector is the same as what would be obtained from the list (by std::advance, I guess)? This would help to make sure the vector and the list are alwa

Re: State of release notes for 1.4.0

> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I am fine with this. I committed the file, updated Makefile.am and added a pointer in ANNOUNCE. JMarc

Re: State of release notes for 1.4.0

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> - Font changes doesn't apply to tables inside the selection when Georg> I think this should read "don't", not "doesn't". Nothing else Georg> occurs to me apart from that. Thanks. JMarc

Re: LyX 1.4: Reproducable Crash [more math bug examples]

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> OK, here is the explanation (why not put it in a comment in Martin> the patch, if you can formulate a short one) Thanks for the explanation. I changed the logic of the code (no more go to the left and then to the right) and adde

Re: Fix for 2316 in bugzilla

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Tested and working. Not quite as trivial as 2316 though, so Martin> someone have a look at it. Concerning the part the removes the blue line under the ERT, I do not like it: 1/ this adds explicit test against an inset code (and

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Jean-Marc Lasgouttes wrote: > Please test. It works for me. Works like a charm. Jürgen

[PATCH] fix crash with case-changing LFUNs at end of paragraph

1. new document 2. M-c Right (or any other case changing lfun) 3. Crash. and of course 4. patch attached. The real fix is the last hunk (setCursor tries to go to a place that does not exist). The rest (which is trivial) fixes the logic of cursorRightOneWord so that it goes to the beginning to t

Feature request: automatic recognition of .cls and .layout in the document directory.

Dear developers, This may need a lot of work and may violate many people's belief that .cls and .layout should be in their respective directory ( as in the case of .cst file which has been the topic of long argument). However, it would be really convenient to keep *everything* related to a docume

Re: State of release notes for 1.4.0

Jean-Marc Lasgouttes wrote: > - Delete key does not move the cursor to the next character > http://bugzilla.lyx.org/show_bug.cgi?id=2185 The meaning here is unclear (though I'm still hazy as to what the problem is having read the bug report :p). Perhaps: - Delete key will not delete successive c

New Spotlight metadata importer for LyX/Mac

I've got a new version of the Spotlight metadata importer for LyX/ Mac, largely copied (with permission) from Norm Gall's LaTeX metadata importer (). The main improvement over my old code is that the new version will find not ju

Re: [PATCH] Makes ParagraphList use RandomAccessList

Abdelrazak Younes <[EMAIL PROTECTED]> writes: Just some little observations. Angus /// Copy constructor. RandomAccessList(RandomAccessList const & ext_list) { - for (const_iterator it = ext_list.begin(); -it != ext_list.end(); ++it) +

Re: State of release notes for 1.4.0

> "Daniel" == Daniel Watkins <[EMAIL PROTECTED]> writes: Daniel> Jean-Marc Lasgouttes wrote: >> - Delete key does not move the cursor to the next character >> http://bugzilla.lyx.org/show_bug.cgi?id=2185 Daniel> The meaning here is unclear (though I'm still hazy as to what Daniel> the problem

Another way to an assert

1. mark a footnote or another chunk beginning with an inset 2. C-M Assertion triggered in CursorSlice LCursor::anchor() const by failing check "anchor_.depth() >= depth()" in file cursor.C:416 Note that the footnote has to be at the very beginning of the selection. This is now bug 2321 http://b

Re: [PATCH] Makes ParagraphList use RandomAccessList

Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: Just some little observations. Angus /// Copy constructor. RandomAccessList(RandomAccessList const & ext_list) { - for (const_iterator it = ext_list.begin(); -it != ext_list.en

Re: State of release notes for 1.4.0

Jean-Marc Lasgouttes wrote: > I find it clear: > - create a document with some words in it > - turn on change tracking > - delete a character with Delete ==> the cursor does not move. OK, just making sure. I don't use change tracking myself (and never have), which was the cause of the misunderstan

Re: Another way to an assert

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> 1. mark a footnote or another chunk beginning with an inset Juergen> 2. C-M Juergen> Assertion triggered in CursorSlice LCursor::anchor() const by Juergen> failing check "anchor_.depth() >= depth()" in file Juergen> curs

Strange Subversion error

Hi I just tried to update my checked out copy of the source... what's this: black01:lyx-devel>svn update svn: Can't open 'm4/.svn/tmp/text-base/intmax.m4.svn-base.tmp': No such file or directory I'm guessing this shouldn't really happen, but I'll just delete it and keep going. /Christian PS

Re: Another way to an assert

Jean-Marc Lasgouttes wrote: > Am I right that this is the fix? Yes. Very fast! Jürgen

Re: Fix for 2316 in bugzilla

On Thu, Feb 23, 2006 at 03:47:18PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Tested and working. Not quite as trivial as 2316 though, so > Martin> someone have a look at it. > > Concerning the part the removes the blue line under

Re: Fix for 2316 in bugzilla

> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> I did not try the other part. Martin> But that's the actual bug fix! This part is just cosmetic (and Martin> I have no strong feelings on it, except that the blue line Martin> might be confusing for some users.) I know :) But I do n

Re: Fix for 2316 in bugzilla

On Thu, Feb 23, 2006 at 06:29:05PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> I did not try the other part. > > Martin> But that's the actual bug fix! This part is just cosmetic (and > Martin> I have no strong feelings on it, except th

Fwd: Re: Another way to an assert

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Am I right that this is the fix? Juergen> Yes. Very fast! :) Lars, can I apply that? What happens is that, while the selection is not empty, the ascii version of it is empty (footnotes ha

Re: New Spotlight metadata importer for LyX/Mac

On the contrary, I would have it included in the LyX subversion repository, under a mac-specific source code directory. Proper makefile adjustments can be made to have it build using xcodebuild when LyX itself is built (perhaps as part of a bundle stage when targetting Mac OS X). Incidentally, the

Minor patch for INSTALL, s/CVS/Subversion/

Hi, here's a minor patch for INSTALL which changes CVS references into Subverison references. Are these version requirements correct btw? If you have checked this out from Subversion, you need to have: * automake >= 1.9 * autoconf >= 2.52 * gettext >= 0.12 /Christian -- Christian

Problem with INSTALL.Win32 -

Hi, I think INSTALL.Win32 is seriously out of date and needs to be looked over by someonw who knows this stuff... Here's a patch where I'm *guessing* - it should *not* be applied as it is. I changed 'MinSYS' be changed into 'MSYS', is that correct? Does the procedure described in this file even

Can LyX 1.4.0 really be built on OS2???

Hi Can LyX 1.4.0 really be built on OS2? If not, perhaps that file should be changed to say that or simply removed. /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

The file NEWS is ok regarding CVS vs Subversion

Hi, the file NEWS is ok when it comes to replacing CVS with Subversion. It's caught by grep -li cvs * but that's just because it contains What's new in LyX version 1.1.6fix3? ... - the `history' and `revert' function

RELEASE-NOTES

I think the following two annoying items should be added to the RELEASE-NOTES (regressions wrt 1.3.7): - Bookmarks and links to LaTeX errors are broken after paragraph deletion/insertion http://bugzilla.lyx.org/show_bug.cgi?id=2284 http://bugzilla.lyx.org/show_bug.cgi?id=2242 - Instant prev

Re: Can LyX 1.4.0 really be built on OS2???

[EMAIL PROTECTED] wrote: Can LyX 1.4.0 really be built on OS2? If not, perhaps that file should be changed to say that or simply removed. No way! The file should be removed. Michael

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> OK, here is the explanation (why not put it in a comment in Martin> the patch, if you can formulate a short one) Thanks for the explanation. I changed the logic of the code (no more go to the left and th

Re: RELEASE-NOTES

> - Instant preview figures are sometimes displaced > http://bugzilla.lyx.org/show_bug.cgi?id=2167 I still think the patch for 2167 should be applied. The displaced preview figures will be an instant annoyance to users, especially when this feature (instant preview) is available in 1.3.x and the

Re: RELEASE-NOTES

Bo Peng wrote: - Instant preview figures are sometimes displaced http://bugzilla.lyx.org/show_bug.cgi?id=2167 I still think the patch for 2167 should be applied. The displaced preview figures will be an instant annoyance to users, especially when this feature (instant preview) is availab

Re: [PATCH] Makes ParagraphList use RandomAccessList

Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > /** > > - \todo This could be optimized a bit by rebuilding ItVector > > - instead of multiple deletion. > > + TODO: use std::remove_if and vector<>::erase, passing the > > You don't like '\todo'? Doxygen recognize it and generates

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Thu, Feb 23, 2006 at 03:44:14PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> OK, here is the explanation (why not put it in a comment in > Martin> the patch, if you can formulate a short one) > > Thanks for the explanation. I cha

Re: LyX 1.4: Reproducable Crash [more math bug examples]

Martin Vermeer wrote: if you change if (it != begin() into if (it != begin() && currx >= targetx I expect Joost will find it behaving slightly better in the situation he complained about. It won't fix everything though. - Martin I'll try this one. With the last patch of JM

Re: LyX 1.4: Reproducable Crash [more math bug examples]

On Fri, Feb 24, 2006 at 12:13:50AM +0100, Joost Verburg wrote: > Martin Vermeer wrote: > >if you change > > > > if (it != begin() > > > >into > > > > if (it != begin() && currx >= targetx > > > >I expect Joost will find it behaving slightly better in the situation he > >complained about. It

Re: Fix for 2316 in bugzilla

On Thu, 2006-02-23 at 19:39 +0200, Martin Vermeer wrote: > On Thu, Feb 23, 2006 at 06:29:05PM +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> I did not try the other part. > > > > Martin> But that's the actual bug fix! This part is ju

One more patch [was: Reproducible...]

On Fri, 2006-02-24 at 01:27 +0200, Martin Vermeer wrote: > On Fri, Feb 24, 2006 at 12:13:50AM +0100, Joost Verburg wrote: > > Martin Vermeer wrote: > > >if you change > > > > > > if (it != begin() > > > > > >into > > > > > > if (it != begin() && currx >= targetx > > > > > >I expect Joost will f