Re: [PATCH] BUG 3598. Was: wrong fix committed for bug 3598

2007-05-19 Thread Bo Peng
On 5/19/07, Uwe Stöhr <[EMAIL PROTECTED]> wrote: Bo Peng schrieb: > Please test the attached patch. I will wait for another OK to commit. This is OK now. I applied it since it is trivial. Bo

Re: [PATCH] BUG 3598. Was: wrong fix committed for bug 3598

2007-05-19 Thread Uwe Stöhr
Bo Peng schrieb: Please test the attached patch. I will wait for another OK to commit. This is OK now. thanks and regards Uwe

[PATCH] BUG 3598. Was: wrong fix committed for bug 3598

2007-05-18 Thread Bo Peng
Uwe, Please test the attached patch. I will wait for another OK to commit. Cheers, Bo Index: src/insets/InsetNote.cpp === --- src/insets/InsetNote.cpp (revision 18413) +++ src/insets/InsetNote.cpp (working copy) @@ -365,10 +365,8 @@

Re: wrong fix committed for bug 3598

2007-05-18 Thread Uwe Stöhr
Bo Peng schrieb: This was wrong because the bug is that LyX adds color commands to the preamble when using a framed note: \definecolor{shadecolor}{rgb}{1,0,0} So you mean a frame note does not need this \definecolor? Yes. If so, requiring color is wrong and please revert my changes when y

Re: wrong fix committed for bug 3598

2007-05-18 Thread Bo Peng
This was wrong because the bug is that LyX adds color commands to the preamble when using a framed note: \definecolor{shadecolor}{rgb}{1,0,0} So you mean a frame note does not need this \definecolor? If so, requiring color is wrong and please revert my changes when you fix it. Bo

wrong fix committed for bug 3598

2007-05-18 Thread Uwe Stöhr
Hello Bo, you were over eager with your bugfix for bug 3598. You said in http://bugzilla.lyx.org/show_bug.cgi?id=3598#c1 that the framed not required the color package and implemented this. This was wrong because the bug is that LyX adds color commands to the preamble when using a framed note: