Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | and now you must have a look again. Ok, this is final version. Please have a look and comment. Unless I get objections this will go in. ? counter-2.diff ? counter-3.diff ? counter.diff ? deptherror.diff ? deptherror.lyx ? kystskipper-a-1.lyx ? m

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | Have a look. > | Of itself this is obviously an improvement, but I wonder if you could | make use of BufferParams::user_defined_bullet? Not now. (as you can see from my comments, this has been thought of) | I know, I'

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Oct 08, 2003 at 01:58:13PM +0200, Lars Gullik Bjønnes wrote: >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Lars Gullik Bjønnes wrote: >> >> Ok, I have a patch... not the nicest one, but it seems to work, and >> >> I need others to thest i

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: >>> | Have a look. Of itself this is obviously an improvement, but I wonder if you could make use of BufferParams::user_defined_bullet? I know, I'm probably shifting your goal posts. + string itemlabel; + switch (pit->itemdepth) { +

Re: watch counters go wrong

2003-10-08 Thread Andre Poenitz
On Wed, Oct 08, 2003 at 01:58:13PM +0200, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > >> Ok, I have a patch... not the nicest one, but it seems to work, and > >> I need others to thest it. > > > | You seem to have lost the 'Bibliographi

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | Initialise itemdepth when constructing it. >> eh? > | Paragraph::Paragraph() | : y(0), pimpl_(new Paragraph::Pimpl(this)), itemdepth(0) | {} I am only removing things... (in this part of the code), expect a patch

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Since I am not able to compile 1.4.0cvs (hint!) That was a stern hint. (whimper...) Have you tried with STLport? (mr. innocent strikes again) |, I'll ask directly: | does the patch still allows to increase the depth of a paragraph | to nest it

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Initialise itemdepth when constructing it. > eh? Paragraph::Paragraph() : y(0), pimpl_(new Paragraph::Pimpl(this)), itemdepth(0) {} > | I think you should add a decent comment about itemdepth in the > | deader file. > > what dead file? s/d/h/ and no, that

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Initialise itemdepth when constructing it. eh? | Paragraph::Paragraph() | : y(0), pimpl_(new Paragraph::Pimpl(this)) | { | - enumdepth = 0; | itemdepth = 0; | params().clear(); | } > | I think you should add a decent co

Re: watch counters go wrong

2003-10-08 Thread Jean-Marc Lasgouttes
Since I am not able to compile 1.4.0cvs (hint!), I'll ask directly: does the patch still allows to increase the depth of a paragraph to nest it inside an environment? The goal is to obtain latex code like \begin{theorem} The following facts are equivalent \begin{itemize} \item Foo is Bar \item Ba

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > But I am the only one able to counter your counter with a counter > counter patch. Don't push your luck (or give up the day job ;-) >>> I guess ok. > | Augh. Thanks Lars. > > and now you must have a look again. Don't build in your source tree: Index: po/POTFILES

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> Hrmmpff! black-mail tactics! > | Hey, you started it. (Whine!) | I counter your counter with one of my own. But I am the only one able to counter your counter with a counter counter patch. >> I guess ok. | Augh. Thanks

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Hrmmpff! black-mail tactics! Hey, you started it. (Whine!) I counter your counter with one of my own. > I guess ok. Augh. Thanks Lars. -- Angus

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> I think I'll clean up the patch a bit and just check it in, easier >> to get people to test it then. I tried it with the UserGuide, and >> could not see any mistakes. > | So what about my lyxlib.C proposal ;-) Hrmmpff! blac

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > I think I'll clean up the patch a bit and just check it in, easier > to get people to test it then. I tried it with the UserGuide, and > could not see any mistakes. So what about my lyxlib.C proposal ;-) -- Angus

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> I think you are right, but I want to know if I got the enumdepth >> part right, and also the resetting of the enum counters. > | Why not ask on the users' list? Someone is bound to have a complex | example of this stuff. I

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > I think you are right, but I want to know if I got the enumdepth > part right, and also the resetting of the enum counters. Why not ask on the users' list? Someone is bound to have a complex example of this stuff. -- Angus

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> Ok, I have a patch... not the nicest one, but it seems to work, and >> I need others to thest it. > | You seem to have lost the 'Bibliographies can't have their depth | changed' bit entirely. Actually I think not. Now only

Re: watch counters go wrong

2003-10-08 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Ok, I have a patch... not the nicest one, but it seems to work, and > I need others to thest it. You seem to have lost the 'Bibliographies can't have their depth changed' bit entirely. Other than that the code is pretty understandable, although I'm not a fan of those

Re: watch counters go wrong

2003-10-08 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Tue, Oct 07, 2003 at 11:42:22PM +0200, Lars Gullik Bj?nnes wrote: > >> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >> >> | Have a look. >> >> This seems to fix the problem: >> (please verify) > | I think we have least two counter bugs worth testing

Re: watch counters go wrong

2003-10-07 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Tue, Oct 07, 2003 at 11:42:22PM +0200, Lars Gullik Bj?nnes wrote: > >> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >> >> | Have a look. >> >> This seems to fix the problem: >> (please verify) > | I think we have least two counter bugs worth testing

Re: watch counters go wrong

2003-10-07 Thread John Levon
On Tue, Oct 07, 2003 at 11:42:22PM +0200, Lars Gullik Bj?nnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | Have a look. > > This seems to fix the problem: > (please verify) I think we have least two counter bugs worth testing against on bugzilla john -- Khendon's Law: If th

Re: watch counters go wrong

2003-10-07 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Have a look. This seems to fix the problem: (please verify) ? deptherror.diff ? deptherror.lyx ? kystskipper-a-1.lyx Index: src/text2.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel

watch counters go wrong

2003-10-07 Thread Lars Gullik Bjønnes
Have a look. deptherror.lyx Description: Binary data -- Lgb