Angus Leeming <[EMAIL PROTECTED]> writes:

| Lars Gullik Bjønnes wrote:
>> Ok, I have a patch... not the nicest one, but it seems to work, and
>> I need others to thest it.
>
| You seem to have lost the 'Bibliographies can't have their depth 
| changed' bit entirely.

Actually I think not. Now only enumerate will ever have enumdepth set
to anything else than 0 (similar with itemize/itemdepth).

| Other than that the code is pretty 
| understandable, although I'm not a fan of those {...} guards.

they kind of grew on me.

>
| If you introduced a new Paragraph member function,
|         void Paragraph::incDepth(LYX_LABEL_TYPES type, int increment) {
|                 if (type == LABEL_ENUMERATE)
|                         enumdepth += increment;
|                 else if (type == LABEL_ITEMIZE)
|                         itemdepth += increment;
|         }
>
| then I think that those first two big blocks could be collapsed into a 
| single function taking the LYX_LABEL_TYPES type as an arg. Maybe I'm 
| wrong...

I think you are right, but I want to know if I got the enumdepth part
right, and also the resetting of the enum counters.

>> Please throw all itemize and enumerate stuff you can think of at
>> this one. If you can find a situation where we do something
>> different than LaTeX please produce a small test file and add it to
>> bugzilla case 1025 (and notify me of course).
>
| Answer the question about bibliographies...

enumdepth always 0 for all other paragraphs than enumerate.

-- 
        Lgb

Reply via email to