Andre Poenitz wrote:
>> And why is this information not in cursor.h?
>
> Is this a trick question?
Yes. Take it as a gentle complaint that the code is not documented enough
(see for example the iterator classes). I always try to add documentation
when I got some informartion from the list, but i
Andre Poenitz wrote:
> On Sun, May 08, 2005 at 10:57:04AM +0200, Georg Baum wrote:
>> I did also call noUpdate() instead of undispatched() in insetcommand.C.
>> Is that correct?
>
> 'undispatched' means: I, the doDispatch() method of InsetFoo, hereby
> declare that I am not able to handle that re
On Sun, May 08, 2005 at 10:57:04AM +0200, Georg Baum wrote:
> I did also call noUpdate() instead of undispatched() in insetcommand.C. Is
> that correct?
'undispatched' means: I, the doDispatch() method of InsetFoo, hereby
declare that I am not able to handle that request and trust my parent
will
Am Sonntag, 8. Mai 2005 11:26 schrieb Asger Ottar Alstrup:
> Maybe you could add some comments about what the protocol for
> update/noupdate calls is? Add it to the BufferView::update method, or
> wherever the main update call is.
There is already a comment in LCursor::dispatch. In fact I got my
Georg Baum wrote:
All update() calls in src/insets are unnecessary. They are all in
do_dispatch(), and LCursor->dispatch() makes sure that update is called.
It is the other way round: We need to call cur.noUpdate() if no update is
needed.
I did also call noUpdate() instead of undispatched() in in
Am Samstag, 7. Mai 2005 21:35 schrieb Andre Poenitz:
>
> Could anybody please make sure that 'his' code does not contain
> unnecessary update() calls?
>
> As a first approximation I'd classify any update() with exception
> of the one in lyxfunc.C as 'unnecessary'.
>
> Most notably the LFUN_INSET
Could anybody please make sure that 'his' code does not contain
unnecessary update() calls?
As a first approximation I'd classify any update() with exception
of the one in lyxfunc.C as 'unnecessary'.
Most notably the LFUN_INSET_MODIFY handling seems to have sneaked
something in...
Andre'
