All update() calls in src/insets are unnecessary. They are all in do_dispatch(), and LCursor->dispatch() makes sure that update is called.
It is the other way round: We need to call cur.noUpdate() if no update is needed.
I did also call noUpdate() instead of undispatched() in insetcommand.C. Is that correct?
Looks right to me.
Maybe you could add some comments about what the protocol for update/noupdate calls is? Add it to the BufferView::update method, or wherever the main update call is.
In general, I think the new code should be commented some more. Maybe you do not understand exactly how it is supposed to work, but it is still better to add a comment about how you understand it than not adding something. Then, the people that understand it can post patches to the comments.
Regards, Asger
