Re: setting tabular lines in multicolumn cells

2006-11-15 Thread Georg Baum
Edwin Leuven wrote: > Georg Baum wrote: >> I had a closer look, and IMHO it is only partly an improvement. You >> remove the functionality to set the borders of whole columns/rows. > > i think that it is possible to set borders of whole cols/rows. just > select them and set/unset them. And how i

Re: setting tabular lines in multicolumn cells

2006-11-15 Thread Edwin Leuven
Georg Baum wrote: I had a closer look, and IMHO it is only partly an improvement. You remove the functionality to set the borders of whole columns/rows. i think that it is possible to set borders of whole cols/rows. just select them and set/unset them. This is useful functionality that shou

Re: setting tabular lines in multicolumn cells

2006-11-15 Thread Georg Baum
Edwin Leuven wrote: > Michael Gerz wrote: >>> Edwin Leuven wrote: >>> >>> is there a reason to have both M_TOGGLE_LINE_TOP and TOGGLE_LINE_TOP ? >>> couldn't we just have one TOGGLE_LINE_TOP and set the proper flags >>> depending whether we are in a multicolumn cell or not? >> This is exactly what

Re: setting tabular lines in multicolumn cells

2006-11-14 Thread Edwin Leuven
Michael Gerz wrote: Edwin Leuven wrote: is there a reason to have both M_TOGGLE_LINE_TOP and TOGGLE_LINE_TOP ? couldn't we just have one TOGGLE_LINE_TOP and set the proper flags depending whether we are in a multicolumn cell or not? This is exactly what I proposed for 1.4 :-) the attach patc

Re: setting tabular lines in multicolumn cells

2006-11-14 Thread Georg Baum
Am Dienstag, 14. November 2006 20:04 schrieb Edwin Leuven: > Michael Gerz wrote: > > Edwin Leuven wrote: > > > >> is there a reason to have both M_TOGGLE_LINE_TOP and TOGGLE_LINE_TOP ? > >> > >> couldn't we just have one TOGGLE_LINE_TOP and set the proper flags > >> depending whether we are in a

Re: setting tabular lines in multicolumn cells

2006-11-14 Thread Edwin Leuven
Michael Gerz wrote: Edwin Leuven wrote: is there a reason to have both M_TOGGLE_LINE_TOP and TOGGLE_LINE_TOP ? couldn't we just have one TOGGLE_LINE_TOP and set the proper flags depending whether we are in a multicolumn cell or not? This is exactly what I proposed for 1.4 :-) what happene

Re: setting tabular lines in multicolumn cells

2006-11-14 Thread Michael Gerz
Edwin Leuven wrote: is there a reason to have both M_TOGGLE_LINE_TOP and TOGGLE_LINE_TOP ? couldn't we just have one TOGGLE_LINE_TOP and set the proper flags depending whether we are in a multicolumn cell or not? This is exactly what I proposed for 1.4 :-) Michael

setting tabular lines in multicolumn cells

2006-11-14 Thread Edwin Leuven
... using the toolbar doesn't work as expected (i think) the reason is that when setting the (top) line through the dialog passes through the controller: void ControlTabular::toggleTopLine() { if (tabular().isMultiColumn(getActiveCell())) set(LyXTabular::M_TOGGLE_LINE_T