Georg Baum wrote:
I had a closer look, and IMHO it is only partly an improvement. You
remove the functionality to set the borders of whole columns/rows.
i think that it is possible to set borders of whole cols/rows. just
select them and set/unset them.
This is useful functionality that should not be removed. For example
I could have a table with several columns, including multicolumn
cells, where some have top lines and decide that I rather do not want
any top row. I therefore want to be able to set or reset the top
lines of a whole row. For toggling I agree: It does only make sense
to toggle what is currently used, e.g. if at least one cell of a row
has an individual top/bottom line setting that setting should be
toggled. If the whole row has the same setting then the whole row
should be toggled. The same applies of course to left/right lines and
columns.
afaics my changes make the dialog and toolbar act in a consistent way
which i think is what people expect.
If you rework your patch to not remove this functionality then it
would be OK with me. It would be even better if it would be possible
to set/reset whole column/row lines in the dialog, but since the
dialog is horribly broken anwyway this can also wait.
can you give me an example what you are missing? i didn't follow the one
above. (i might be wrong but there is no table you cannot make after the
patch that you could make before.)
the only thing that is different with my patch is that when the cursor
is in a multicolumn cell toggling applies to that cell's borders.
it is not possible to toggle left/right (unless it is at the border of
the table or if there is an adjacent multicolumn cell). to toggle
left/right for the column either move to a non multicolumn cell or
select the column. note that it behaves like the dialog.
the unpatched toolbar otoh toggles the whole left/right colomn line
setting (except the multi col ones) when in a multicol cell.
more in general i think that it makes sense to have the toggling apply
to what is selected:
cursor in cell -> toggle cell
selection -> toggle selection
want to change the whole row/col? -> select row/col and toggle
it is not really clear to me in what situations we should allow
what. i found the following comment:
// pay attention to left/right lines: they are only allowed // to
set if we are in first/last cell of row or if the left/right //
cell is also a multicolumn.
why is that, and what would be the preferred policy here?
This is the multicolumn case (normal cells are handled above that
comment). It is not possible to set left/right lines inside of a
multicolumn cell, they can of course only be set at the
leftmost/rightmost cell of a multicolumn cell.
the strange thing is that this comment is in the frontend whereas what
you are saying should be handled by the core...
What do you mean? You can set the lines in the UI per cell. If all
lines in a row are set this results in a \hline, otherwise in one or
more \cline. What else has \cline and \hline to do with the user
interface?
how do you do that? i don't manage to have a horizontal line that spans
only a few columns unless i make the cell multicolumns cells...
thanks, ed.
