Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-27 Thread Tommaso Cucinotta
Il 27/05/2011 14:22, Richard Heck ha scritto: On 05/27/2011 06:11 AM, Tommaso Cucinotta wrote: Should it be added to this specific dialog, or to the Dialog class ? Perhaps add that to the Dialog class. Then it can be used elsewhere as needed. So I did (r38865). T.

Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-27 Thread Vincent van Ravesteijn
On 27-5-2011 12:11, Tommaso Cucinotta wrote: > Il 27/05/2011 10:17, Vincent van Ravesteijn ha scritto: >> I don't like this. In all dialogs, calling buffer() will give you the >> currentBufferView(). It is confusing if it is suddenly different here. > > because in each & every usage of the buffer(

Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-27 Thread Richard Heck
On 05/27/2011 06:11 AM, Tommaso Cucinotta wrote: > >> By the way, buffer() is not declared virtual in Dialog. > > ops, then you're right: let's introduce another method > documentBuffer() and use it. > Should it be added to this specific dialog, or to the Dialog class ? > Perhaps add that to the Di

Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-27 Thread Tommaso Cucinotta
Il 27/05/2011 10:17, Vincent van Ravesteijn ha scritto: I don't like this. In all dialogs, calling buffer() will give you the currentBufferView(). It is confusing if it is suddenly different here. because in each & every usage of the buffer() method in this dialog, I needed a different buffer (

Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-27 Thread Vincent van Ravesteijn
On 26-5-2011 19:33, tomm...@lyx.org wrote: > Author: tommaso > Date: Thu May 26 19:33:36 2011 > New Revision: 38847 > URL: http://www.lyx.org/trac/changeset/38847 > > Log: > Use the main document's buffer(), when scanning for citations from within the > citation dialog. > This allows to pick and

Re: r38847 - lyx-devel/trunk/src/frontends/qt4

2011-05-26 Thread Richard Heck
On 05/26/2011 01:33 PM, tomm...@lyx.org wrote: > Author: tommaso > Date: Thu May 26 19:33:36 2011 > New Revision: 38847 > URL: http://www.lyx.org/trac/changeset/38847 > > Log: > Use the main document's buffer(), when scanning for citations from within the > citation dialog. > This allows to pick a