Il 27/05/2011 10:17, Vincent van Ravesteijn ha scritto:
I don't like this. In all dialogs, calling buffer() will give you the
currentBufferView(). It is confusing if it is suddenly different here.
because in each & every usage of the buffer() method in this
dialog, I needed a different buffer (the document one, not the
current one). So I thought the most immediate change was
an override of the buffer() method, as opposed to introducing
a new method.
If this is an exception, then you might better want to get the document
buffer explicitly. What makes GuiCitation an exception?
Explained above: we don't care about citations inserted into the Find WA
(the user is not supposed to insert citations there, but he can if he really
wants, if he wants to search for a bibliographic entry itself :-) )
Why does GuiRef not have to refer to the documentBuffer as well.
because in GuiRef that's implicit: we don't use buffer(), but there's a
combo
box with the currently open documents, and the user can choose the buffer
from there, then it's retrieved by name via theBufferList().get(...);
The same combo might (should ?) be ported to the GuiCitation as well.
By the way, buffer() is not declared virtual in Dialog.
ops, then you're right: let's introduce another method documentBuffer()
and use it.
Should it be added to this specific dialog, or to the Dialog class ?
Unless, we want to add that combo box. Please, let me know.
T.
