Re: r38431 - lyx-devel/trunk/src

2011-04-21 Thread Richard Heck
On 04/19/2011 03:14 PM, Georg Baum wrote: Enrico Forestieri wrote: Are you sure it is pointless? runparams is a reference and even if it is constant, there are mutable members that could be changed. The copy you removed maybe tries to protect against that. If the mutable members really make a

Re: r38431 - lyx-devel/trunk/src

2011-04-19 Thread Georg Baum
Enrico Forestieri wrote: > Are you sure it is pointless? runparams is a reference and even if > it is constant, there are mutable members that could be changed. > The copy you removed maybe tries to protect against that. If the mutable members really make a difference then they should not be mut

Re: r38431 - lyx-devel/trunk/src

2011-04-18 Thread Richard Heck
On 04/18/2011 09:47 AM, Enrico Forestieri wrote: On Mon, Apr 18, 2011 at 03:49:23AM +0200, rgh...@lyx.org wrote: Author: rgheck Date: Mon Apr 18 03:49:23 2011 New Revision: 38431 URL: http://www.lyx.org/trac/changeset/38431 Log: Remove pointless variable. Are you sure it is pointless? runpara

Re: r38431 - lyx-devel/trunk/src

2011-04-18 Thread Enrico Forestieri
On Mon, Apr 18, 2011 at 03:49:23AM +0200, rgh...@lyx.org wrote: > Author: rgheck > Date: Mon Apr 18 03:49:23 2011 > New Revision: 38431 > URL: http://www.lyx.org/trac/changeset/38431 > > Log: > Remove pointless variable. Are you sure it is pointless? runparams is a reference and even if it is co